The proposal to merge
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
launchpad-mojo-specs:master has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/461805
--
Ines Almeida has proposed merging
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
launchpad-mojo-specs:master.
Commit message:
lp-fetch-service: add num_units to bundle
Requested reviews:
Canonical Launchpad Engineering (launchpad)
For more details, see:
The proposal to merge
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
launchpad-mojo-specs:master has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/461231
--
Ines Almeida has proposed merging
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
launchpad-mojo-specs:master.
Commit message:
Add barebones of lp-fetch-service mojo spec
While the charm and snap are not public, they require manually building, and
deploying from the
The proposal to merge
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
launchpad-mojo-specs:master has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/460966
--
Review: Approve
Looks good for me. I would like to have Guruprasad a second look on it.
--
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/460966
Your team Launchpad code reviewers is subscribed to branch
Diff comments:
> diff --git a/lp-fetch-service/bundle.yaml b/lp-fetch-service/bundle.yaml
> new file mode 100644
> index 000..286
> --- /dev/null
> +++ b/lp-fetch-service/bundle.yaml
> @@ -0,0 +1,22 @@
> +{%- if stage_name == "production" %}
> +{%- set devel = False %}
> +{%- elif
2nd attempt :)
Diff comments:
> diff --git a/lp-fetch-service/bundle.yaml b/lp-fetch-service/bundle.yaml
> new file mode 100644
> index 000..286
> --- /dev/null
> +++ b/lp-fetch-service/bundle.yaml
> @@ -0,0 +1,22 @@
> +{%- if stage_name == "production" %}
> +{%- set devel = False %}
>
see comments
--
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/460966
Your team Launchpad code reviewers is subscribed to branch
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service.
___
Mailing list:
Diff comments:
> diff --git a/lp-fetch-service/bundle.yaml b/lp-fetch-service/bundle.yaml
> new file mode 100644
> index 000..286
> --- /dev/null
> +++ b/lp-fetch-service/bundle.yaml
> @@ -0,0 +1,22 @@
> +{%- if stage_name == "production" %}
> +{%- set devel = False %}
> +{%- elif
Ines Almeida has proposed merging
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
launchpad-mojo-specs:master.
Commit message:
Add barebones of lp-fetch-service mojo spec
While the charm and snap are not public, they require manually building, and
deploying from the
The proposal to merge
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
launchpad-mojo-specs:master has been updated.
Description changed to:
This was tested deploying locally. Will try deploying in staging once this MP
is reviewed and approved.
The general structure was
12 matches
Mail list logo
