Diff comments:
> diff --git a/charm/launchpad-scripts-bzrsyncd/charmcraft.yaml
> b/charm/launchpad-scripts-bzrsyncd/charmcraft.yaml
> new file mode 100644
> index 000..9b28632
> --- /dev/null
> +++ b/charm/launchpad-scripts-bzrsyncd/charmcraft.yaml
> @@ -0,0 +1,63 @@
> +type: charm
>
Diff comments:
> diff --git a/charm/launchpad-scripts-bzrsyncd/charmcraft.yaml
> b/charm/launchpad-scripts-bzrsyncd/charmcraft.yaml
> new file mode 100644
> index 000..9b28632
> --- /dev/null
> +++ b/charm/launchpad-scripts-bzrsyncd/charmcraft.yaml
> @@ -0,0 +1,63 @@
> +type: charm
>
LGTM, only a few minor comments.
I don't feel comfortable being the sole reviewer though, so I'll leave the
approval for someone else :)
Diff comments:
> diff --git a/charm/launchpad-scripts-bzrsyncd/charmcraft.yaml
> b/charm/launchpad-scripts-bzrsyncd/charmcraft.yaml
> new file mode 100644
>
Guruprasad has proposed merging
~lgp171188/launchpad:charm-launchpad-scripts-bzrsyncd into launchpad:master.
Commit message:
charm: Implement the launchpad-scripts-bzrsyncd charm
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
4 matches
Mail list logo