On Tue, 21 Apr 2009 14:20:55 +1100
Alexander Klenin kle...@gmail.com wrote:
1) The name is good, if somewhat reminiscent of market-speak.
Buy our Lazarus -- now with Code Observer (tm) ;-)
2) The body of empty procedure is superfluously detected as empty
block.
empty procedures can
On Wed, 22 Apr 2009 01:54:57 +1100
Alexander Klenin kle...@gmail.com wrote:
On Tue, Apr 21, 2009 at 19:45, Mattias Gaertner
nc-gaert...@netcologne.de wrote:
4) I still think ' ' (space) should be added to the list of ignored
constants -- for those who prefer to turn single-char constant
1) The name is good, if somewhat reminiscent of market-speak.
Buy our Lazarus -- now with Code Observer (tm) ;-)
2) The body of empty procedure is superfluously detected as empty block.
3) Perhaps 'Create' and 'CreateFmt' should be added to the list of
functions ignoring constants?
raise
Alexander Klenin wrote:
3) Perhaps 'Create' and 'CreateFmt' should be added to the list of
functions ignoring constants?
raise Exception.Create('Error text') is a common construct.
No. Create and CreateFmt strings needs to be translatable even for
exceptions.
Best regards,
Paul Ishenin.
On Tue, Apr 21, 2009 at 14:49, Paul Ishenin i...@kmiac.ru wrote:
Alexander Klenin wrote:
3) Perhaps 'Create' and 'CreateFmt' should be added to the list of
functions ignoring constants?
raise Exception.Create('Error text') is a common construct.
No. Create and CreateFmt strings needs to be
Alexander Klenin wrote:
This is true, but unrelated.
First, naming a string constant does not make it translatable,
it should be made resourcestring (so perhaps it should be a separate
observation --
message is not translatable, where message is defined as string
constant containing at
