Re: [Lazarus] TCombobox major failure :(

2008-07-28 Thread Luiz Americo Pereira Camara
Mattias Gaertner wrote: > On Sun, 27 Jul 2008 10:22:03 -0300 > Luiz Americo Pereira Camara <[EMAIL PROTECTED]> wrote: > > >> BTW: the file gtkobject.inc seems unused. Initially i got confused >> after searching for the places where the info is freed. >> > > gtkobject.inc? > AFAIR it was rem

Re: [Lazarus] TCombobox major failure :(

2008-07-27 Thread Mattias Gaertner
On Sun, 27 Jul 2008 10:22:03 -0300 Luiz Americo Pereira Camara <[EMAIL PROTECTED]> wrote: [...] > Here it is. > > This patch does the following: > > - Avoid the creation of WidgetInfo to combox childs [gtk1] > - Pass WidgetInfo as the data to the changed event handler [gtk1] > - Update the Item

Re: [Lazarus] TCombobox major failure :(

2008-07-23 Thread Luiz Americo Pereira Camara
Mattias Gärtner wrote: > Zitat von Luiz Americo Pereira Camara <[EMAIL PROTECTED]>: > >> 7204 needs to test in OSX >> >> The next step is to ensure that only the widgetinfo of the main control >> is used, so is not needed to allocate the widgetinfo for the child widgets. >> > > Will you do

Re: [Lazarus] TCombobox major failure :(

2008-07-23 Thread Mattias Gärtner
Zitat von Luiz Americo Pereira Camara <[EMAIL PROTECTED]>: > Luiz Americo Pereira Camara wrote: > > Mattias Gaertner wrote: > > > > > >> I fixed that. Please review. 15831. > >> > >> > > > > Seems OK. I tested with a clean repository under win32. Later i will > > test the gtk side. > > > > I found

Re: [Lazarus] TCombobox major failure :(

2008-07-21 Thread Luiz Americo Pereira Camara
Mattias Gaertner wrote: > On Sat, 19 Jul 2008 23:05:43 -0300 > Luiz Americo Pereira Camara <[EMAIL PROTECTED]> wrote: > >> - ListBox.CreateHandle calls Assign that calls Clear, so there's no >> widgetinfo at this time. I added a check to widgetinfo. No big issue >> here, but i added some optio

Re: [Lazarus] TCombobox major failure :(

2008-07-21 Thread Marc Weustink
Mattias Gaertner wrote: > On Sat, 19 Jul 2008 23:05:43 -0300 > Luiz Americo Pereira Camara <[EMAIL PROTECTED]> wrote: > >> Mattias Gaertner wrote: Luiz Americo Pereira Camara wrote: Gtk2 is handled in an different callback function. Unlike gtk1 the LM_SELCHANGE messa

Re: [Lazarus] TCombobox major failure :(

2008-07-21 Thread Mattias Gaertner
On Sat, 19 Jul 2008 23:05:43 -0300 Luiz Americo Pereira Camara <[EMAIL PROTECTED]> wrote: > Mattias Gaertner wrote: > >> Luiz Americo Pereira Camara wrote: > >> > >> > >> Gtk2 is handled in an different callback function. Unlike gtk1 the > >> LM_SELCHANGE message is sent inside the 'changed'

Re: [Lazarus] TCombobox major failure :(

2008-07-17 Thread Luiz Americo Pereira Camara
Mattias Gaertner wrote: > On Wed, 16 Jul 2008 21:56:59 -0300 > Luiz Americo Pereira Camara <[EMAIL PROTECTED]> wrote: > > >> Luiz Americo Pereira Camara wrote: >> >>> Mattias Gaertner wrote: >>> >>> It seems, there are no objections. Will you do it?

Re: [Lazarus] TCombobox major failure :(

2008-07-17 Thread Graeme Geldenhuys
On Thu, Jul 17, 2008 at 8:20 AM, Mattias Gaertner <[EMAIL PROTECTED]> wrote: >> - Win32, gtk1, gtk2 does not fires OnChange after Text is changed >> through code. Qt does. It's possible to get this behavior in these >> widgetsets. What do you think? > > I think, that would be too Delphi incompatibl

Re: [Lazarus] TCombobox major failure :(

2008-07-16 Thread Mattias Gaertner
On Wed, 16 Jul 2008 21:56:59 -0300 Luiz Americo Pereira Camara <[EMAIL PROTECTED]> wrote: > Luiz Americo Pereira Camara wrote: > > Mattias Gaertner wrote: > > > >> It seems, there are no objections. Will you do it? > >> > >> > > > > Yes. > > > > I managed to get the discussed behavi

Re: [Lazarus] TCombobox major failure :(

2008-07-16 Thread Luiz Americo Pereira Camara
Luiz Americo Pereira Camara wrote: > Mattias Gaertner wrote: > >> It seems, there are no objections. Will you do it? >> >> > > Yes. > I managed to get the discussed behavior with Gtk1, Gtk2, Win32, but before submitting a patch i'd like to discuss more two issues found: - Win32, gt

Re: [Lazarus] TCombobox major failure :(

2008-07-15 Thread Vincent Snijders
Luiz Americo Pereira Camara schreef: > Mattias Gaertner wrote: >> It seems, there are no objections. Will you do it? >> > > Yes. > Is this bug report related to the thing you are trying to solve now? http://bugs.freepascal.org/view.php?id=9515 Vincent

Re: [Lazarus] TCombobox major failure :(

2008-07-15 Thread Luiz Americo Pereira Camara
Mattias Gaertner wrote: > It seems, there are no objections. Will you do it? > Yes. Luiz ___ Lazarus mailing list Lazarus@lazarus.freepascal.org http://www.lazarus.freepascal.org/mailman/listinfo/lazarus

Re: [Lazarus] TCombobox major failure :(

2008-07-15 Thread Mattias Gaertner
On Sat, 12 Jul 2008 15:28:10 -0300 Luiz Americo Pereira Camara <[EMAIL PROTECTED]> wrote: > Luiz Americo Pereira Camara wrote: > > Mattias Gaertner wrote: > > > >> My question is: > >> What about the other widgetsets? > >> > > Qt also sends LM_CHANGED + LM_SELCHANGE > > >> Can they easil

Re: [Lazarus] TCombobox major failure :(

2008-07-12 Thread Luiz Americo Pereira Camara
Luiz Americo Pereira Camara wrote: > Mattias Gaertner wrote: > >> My question is: >> What about the other widgetsets? >> Qt also sends LM_CHANGED + LM_SELCHANGE >> Can they easily distinguish between a popup selection change and >> other changes? >> If not, then we should redefine the LM_

Re: [Lazarus] TCombobox major failure :(

2008-07-12 Thread Luiz Americo Pereira Camara
Mattias Gaertner wrote: > I read the thread again and will try to summarize it. Please confirm or > correct me: > > When the user selects an item via the popup list, then an LM_SELCHANGE > event should be fired. Correct. Win32, Gtk1 and Gtk2 does this currently. > OTOH the text changes too, so t

Re: [Lazarus] TCombobox major failure :(

2008-07-12 Thread Mattias Gaertner
On Thu, 10 Jul 2008 00:13:59 -0300 Luiz Americo Pereira Camara <[EMAIL PROTECTED]> wrote: > Luiz Americo Pereira Camara wrote: > > Mattias Gärtner wrote: > > > >> I don't know if the OnChange is wrong or the OnSelect<>nil test is > >> wrong. gtk1 does not send LMSELCHANGE events, so there the c

Re: [Lazarus] TCombobox major failure :(

2008-07-09 Thread Luiz Americo Pereira Camara
Luiz Americo Pereira Camara wrote: > Mattias Gärtner wrote: > >> I don't know if the OnChange is wrong or the OnSelect<>nil test is wrong. >> gtk1 does not send LMSELCHANGE events, so there the case does not happen. >> >> Gtk1 still sends LM_SELCHANGE (that is mapped to OnChange at LCL lev

Re: [Lazarus] TCombobox major failure :(

2008-07-09 Thread Luiz Americo Pereira Camara
Mattias Gärtner wrote: > Zitat von Michael Van Canneyt <[EMAIL PROTECTED]>: > > >> On Wed, 9 Jul 2008, Mattias Gärtner wrote: >> >> >>> Zitat von Michael Van Canneyt <[EMAIL PROTECTED]>: >>> >>> >>> the change of the ItemIndex. >>> The LCL sends the second OnChange if OnSelect is ni

Re: [Lazarus] TCombobox major failure :(

2008-07-09 Thread Mattias Gaertner
On Wed, 09 Jul 2008 19:00:38 +0200 Ales Katona <[EMAIL PROTECTED]> wrote: > Note that while I was investigating gtk2 problem regarding > non-working "default" property when a combobox is inside a groupbox, > I found out that while the keydown event is emitted by the combobox, > the keyup is emitte

Re: [Lazarus] TCombobox major failure :(

2008-07-09 Thread Ales Katona
Note that while I was investigating gtk2 problem regarding non-working "default" property when a combobox is inside a groupbox, I found out that while the keydown event is emitted by the combobox, the keyup is emitted by the groupbox. Perhaps there's a connection with the double event reporting

Re: [Lazarus] TCombobox major failure :(

2008-07-09 Thread Michael Van Canneyt
On Wed, 9 Jul 2008, Mattias Gärtner wrote: > Zitat von Michael Van Canneyt <[EMAIL PROTECTED]>: > > > On Wed, 9 Jul 2008, Mattias Gärtner wrote: > > > > > Zitat von Michael Van Canneyt <[EMAIL PROTECTED]>: > > > > > > > Hi, > > > > > > > > In GTK 1, the TCombobox somehow looses the 'OnChange'

Re: [Lazarus] TCombobox major failure :(

2008-07-09 Thread Mattias Gärtner
Zitat von Michael Van Canneyt <[EMAIL PROTECTED]>: > On Wed, 9 Jul 2008, Mattias Gärtner wrote: > > > Zitat von Michael Van Canneyt <[EMAIL PROTECTED]>: > > > > > Hi, > > > > > > In GTK 1, the TCombobox somehow looses the 'OnChange' event after it was > > > fired > > > once, but only when the ite

Re: [Lazarus] TCombobox major failure :(

2008-07-09 Thread Michael Van Canneyt
On Wed, 9 Jul 2008, Mattias Gärtner wrote: > Zitat von Michael Van Canneyt <[EMAIL PROTECTED]>: > > > Hi, > > > > In GTK 1, the TCombobox somehow looses the 'OnChange' event after it was > > fired > > once, but only when the items list is sorted. > > > > Steps to reproduce: > > - Drop TCombobox

Re: [Lazarus] TCombobox major failure :(

2008-07-09 Thread Mattias Gärtner
Zitat von Michael Van Canneyt <[EMAIL PROTECTED]>: > Hi, > > In GTK 1, the TCombobox somehow looses the 'OnChange' event after it was > fired > once, but only when the items list is sorted. > > Steps to reproduce: > - Drop TCombobox on a new form > - Set items (one two three four five) > - Set Sor

[Lazarus] TCombobox major failure :(

2008-07-09 Thread Michael Van Canneyt
Hi, In GTK 1, the TCombobox somehow looses the 'OnChange' event after it was fired once, but only when the items list is sorted. Steps to reproduce: - Drop TCombobox on a new form - Set items (one two three four five) - Set Sorted=True - this is required !! - Set Style=csDropDownlist (don't know