Re: [Lazarus] [PATCH] Menu item "Rename identifier" shows as inactive if caret is placed at the end of an identifier

2017-11-13 Thread Juha Manninen via Lazarus
The issue is fixed in r56398 with a patch provided by Dmitry. Please test everybody. Juha -- ___ Lazarus mailing list Lazarus@lists.lazarus-ide.org https://lists.lazarus-ide.org/listinfo/lazarus

Re: [Lazarus] [PATCH] Menu item "Rename identifier" shows as inactive if caret is placed at the end of an identifier

2017-11-13 Thread Dmitry D. Chernov via Lazarus
Here's a video with the demonstration of the bug in Lazarus 1.6.4. https://yadi.sk/i/QkJEi53d3PfKiU 14.11.2017, 02:32, "Juha Manninen via Lazarus" : > On Mon, Nov 13, 2017 at 5:26 PM, Dmitry D. Chernov via Lazarus > wrote: >>  This is slightly related with recently fixed #32606: my patch fixes on

Re: [Lazarus] [PATCH] Menu item "Rename identifier" shows as inactive if caret is placed at the end of an identifier

2017-11-13 Thread Dmitry D. Chernov via Lazarus
Sorry, but it's just about convenience, because F2 is working now in this case (after patching #32606), unlike the corresponding menu item. 14.11.2017, 02:51, "Mattias Gaertner via Lazarus" : > On Tue, 14 Nov 2017 01:26:32 +1000 > "Dmitry D. Chernov via Lazarus" wrote: > >>  This is slightly re

Re: [Lazarus] [PATCH] Menu item "Rename identifier" shows as inactive if caret is placed at the end of an identifier

2017-11-13 Thread Mattias Gaertner via Lazarus
On Tue, 14 Nov 2017 01:26:32 +1000 "Dmitry D. Chernov via Lazarus" wrote: > This is slightly related with recently fixed #32606: my patch fixes only > wrong inactive state, patch for #32606 fixes determination of the identifier > under the carriage, as a whole. > > This bug is very annoying wh

Re: [Lazarus] [PATCH] Menu item "Rename identifier" shows as inactive if caret is placed at the end of an identifier

2017-11-13 Thread Juha Manninen via Lazarus
On Mon, Nov 13, 2017 at 5:26 PM, Dmitry D. Chernov via Lazarus wrote: > This is slightly related with recently fixed #32606: my patch fixes only > wrong inactive state, patch for #32606 fixes determination of the identifier > under the carriage, as a whole. > > This bug is very annoying when you

[Lazarus] [PATCH] Menu item "Rename identifier" shows as inactive if caret is placed at the end of an identifier

2017-11-13 Thread Dmitry D. Chernov via Lazarus
This is slightly related with recently fixed #32606: my patch fixes only wrong inactive state, patch for #32606 fixes determination of the identifier under the carriage, as a whole. This bug is very annoying when you selecting identifier to rename by double-clicking LMB on it. ___ Dmitry D. C