Re: [lazarus] TSpeedButton bugs patch

2007-07-22 Thread Paul Ishenin
Giuliano Colla пишет: Here's it again The attached patch fixes 2 issues for TSpeedButton: 1) With no Caption, the glyph is centered if Layout is Glyph Left or Glyph right, somewhere up or down with Glyph Top or Glyph Bottom. Reason: in speedbutton.inc, if Caption is empty, Result.CX is set twic

Re: [lazarus] TSpeedButton bugs patch

2007-07-20 Thread Giuliano Colla
Valdas Jankūnas ha scritto: [snip] Im are that "improver" :) http://www.freepascal.org/mantis/view.php?id=8538 My fault, apologize. Nothing to apologize of. Only those who don't contribute don't make errors. Giuliano _ To

Re: [lazarus] TSpeedButton bugs patch

2007-07-20 Thread Marc Weustink
Giuliano Colla wrote: Felipe Monteiro de Carvalho ha scritto: [...] I didn't commit the patch to lcl/include/buttonglyph.inc because I didn't understand it and I am not sure about it ... so I am leaving it for someone else. It's soon explained. The patch reverts this portion of code to the

Re: [lazarus] TSpeedButton bugs patch

2007-07-19 Thread Valdas Jankūnas
Giuliano Colla rašė: It's soon explained. The patch reverts this portion of code to the situation which has been working for a long time (see rev. 10808 - ver. 0.9.22 - which btw already had the speedbutton.inc bug). Someone, with the good proposition to improve it, added an unnecessary modific

Re: [lazarus] TSpeedButton bugs patch

2007-07-19 Thread Giuliano Colla
Felipe Monteiro de Carvalho ha scritto: [...] I didn't commit the patch to lcl/include/buttonglyph.inc because I didn't understand it and I am not sure about it ... so I am leaving it for someone else. It's soon explained. The patch reverts this portion of code to the situation which has bee

Re: [lazarus] TSpeedButton bugs patch

2007-07-19 Thread Felipe Monteiro de Carvalho
Hi, I commited the patch to lcl/include/speedbutton.inc as this is an obvious improvement I didn't commit the patch to lcl/include/buttonglyph.inc because I didn't understand it and I am not sure about it ... so I am leaving it for someone else. thanks, -- Felipe Monteiro de Carvalho _

Re: [lazarus] TSpeedButton bugs patch

2007-07-19 Thread Marc Weustink
Giuliano Colla wrote: Marc Weustink ha scritto: Giuliano Colla wrote: Here's it again The attached patch fixes 2 issues for TSpeedButton: 1) With no Caption, the glyph is centered if Layout is Glyph Left or Glyph right, somewhere up or down with Glyph Top or Glyph Bottom. Reason: in speedbu

Re: [lazarus] TSpeedButton bugs patch

2007-07-19 Thread Giuliano Colla
Marc Weustink ha scritto: Giuliano Colla wrote: Here's it again The attached patch fixes 2 issues for TSpeedButton: 1) With no Caption, the glyph is centered if Layout is Glyph Left or Glyph right, somewhere up or down with Glyph Top or Glyph Bottom. Reason: in speedbutton.inc, if Caption is

Re: [lazarus] TSpeedButton bugs patch

2007-07-18 Thread Marc Weustink
Giuliano Colla wrote: Here's it again The attached patch fixes 2 issues for TSpeedButton: 1) With no Caption, the glyph is centered if Layout is Glyph Left or Glyph right, somewhere up or down with Glyph Top or Glyph Bottom. Reason: in speedbutton.inc, if Caption is empty, Result.CX is set twic

[lazarus] TSpeedButton bugs patch

2007-07-18 Thread Giuliano Colla
Here's it again The attached patch fixes 2 issues for TSpeedButton: 1) With no Caption, the glyph is centered if Layout is Glyph Left or Glyph right, somewhere up or down with Glyph Top or Glyph Bottom. Reason: in speedbutton.inc, if Caption is empty, Result.CX is set twice to zero while Result.

[lazarus] TSpeedButton bugs patch

2007-07-12 Thread Giuliano Colla
The attached patch fixes 2 issues for TSpeedButton: 1) With no Caption, the glyph is centered if Layout is Glyph Left or Glyph right, somewhere up or down with Glyph Top or Glyph Bottom. Reason: in speedbutton.inc, if Caption is empty, Result.CX is set twice to zero while Result.CY is left und