Re: [LEDE-DEV] [LEDE-DEV, 3/3, v3] uqmi: Prevent 'POLICY MISMATCH' error.

2016-12-16 Thread John Crispin
Hi, still pending not had time to look into this. it'll take me a moment as i am not familiar with the code so i need to find a free moment to properly review this, sorry for the delay John On 16/12/2016 08:51, Nikolay Ledovskikh wrote: > So. What about patch? 'sync' call allows us not t

Re: [LEDE-DEV] [LEDE-DEV, 2/3, v2] Add support of using device symlinks.

2016-12-16 Thread John Crispin
On 16/12/2016 08:58, Nikolay Ledovskikh wrote: >> still pending not had time to look into this. it'll take me a moment as >> i am not familiar with the code so i need to find a free moment to >> properly review this, sorry for the delay >> >> John > > OK. I just offer to use 'readlink' o

Re: [LEDE-DEV] [LEDE-DEV, 2/3, v2] Add support of using device symlinks.

2016-12-16 Thread Nikolay Ledovskikh
> still pending not had time to look into this. it'll take me a moment as > i am not familiar with the code so i need to find a free moment to > properly review this, sorry for the delay > > John OK. I just offer to use 'readlink' onto 'device', so as a result we always get a real device i

Re: [LEDE-DEV] [LEDE-DEV, 2/3, v2] Add support of using device symlinks.

2016-12-16 Thread John Crispin
On 07/12/2016 18:13, Nickolay Ledovskikh wrote: > It's useful when using multiple usb devices that should be bound to > certain usb ports. Symlinks are created by hotplug handlers. > > Signed-off-by: Nickolay Ledovskikh > --- > package/network/utils/comgt/files/directip.sh| 1 + >

Re: [LEDE-DEV] [LEDE-DEV, 3/3, v2] uqmi: Prevent 'POLICY MISMATH' error.

2016-12-16 Thread John Crispin
On 07/12/2016 18:13, Nickolay Ledovskikh wrote: > Add uqmi 'sync' command call to release stalled cid when preparing to > setup new connection. As a result it prevents 'POLICY MISMATCH' errors. > > Signed-off-by: Nickolay Ledovskikh > --- > package/network/utils/uqmi/files/lib/netifd/proto/qmi

Re: [LEDE-DEV] [LEDE-DEV, 3/3, v2] uqmi: Prevent 'POLICY MISMATH' error.

2016-12-16 Thread Matti Laakso
On 07/12/2016 18:13, Nickolay Ledovskikh wrote: >/Add uqmi 'sync' command call to release stalled cid when preparing to />/setup new connection. As a result it prevents 'POLICY MISMATCH' errors. />//>/Signed-off-by: Nickolay Ledovskikh > />/---

Re: [LEDE-DEV] [LEDE-DEV, 3/3, v2] uqmi: Prevent 'POLICY MISMATH' error.

2016-12-16 Thread Nikolay Ledovskikh
Thanks for your comments. I'll update patches with your tips and send new versions. 2016-12-16 11:41 GMT+03:00 Matti Laakso : >> On 07/12/2016 18:13, Nickolay Ledovskikh wrote: >> >/Add uqmi 'sync' command call to release stalled cid when preparing to >> > />/setup new connection. As a result it p

Re: [LEDE-DEV] [LEDE-DEV, 3/3, v2] uqmi: Prevent 'POLICY MISMATH' error.

2016-12-16 Thread John Crispin
On 16/12/2016 10:10, Nikolay Ledovskikh wrote: > Thanks for your comments. I'll update patches with your tips and send > new versions. > and i'll handle them quicker this time :-) > 2016-12-16 11:41 GMT+03:00 Matti Laakso : >>> On 07/12/2016 18:13, Nickolay Ledovskikh wrote: /Add uqmi 'sy

Re: [LEDE-DEV] [PATCH] libubox: replace strtok with strsep

2016-12-16 Thread John Crispin
On 14/12/2016 06:43, Rosen Penev wrote: > strsep is re-entrant whereas strtok not necessarily so. > > Signed-off by: Rosen Penev > --- > ulog.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ulog.c b/ulog.c > index 296605d..985d366 100644 > --- a/ulog.c > +++ b/u

Re: [LEDE-DEV] [PATCH] libubox: replace strtok with strsep

2016-12-16 Thread Felix Fietkau
On 2016-12-16 10:58, John Crispin wrote: > > > On 14/12/2016 06:43, Rosen Penev wrote: >> strsep is re-entrant whereas strtok not necessarily so. >> >> Signed-off by: Rosen Penev >> --- >> ulog.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/ulog.c b/ulog.c >

[LEDE-DEV] [PATCH] kernel: bump to 4.4.39

2016-12-16 Thread Koen Vandeputte
Refresh patches for all targets running 4.4 Compile & run tested on: - cns3xxx - imx6 Signed-off-by: Koen Vandeputte --- include/kernel-version.mk | 4 ++-- .../patches-4.4/525-MIPS-ath79-enable-qca-usb-quirks.patch | 8 .../601-MIPS-ath79-add-more-re

Re: [LEDE-DEV] [PATCH] libubox: replace strtok with strsep

2016-12-16 Thread John Crispin
On 16/12/2016 11:10, Felix Fietkau wrote: > On 2016-12-16 10:58, John Crispin wrote: >> >> >> On 14/12/2016 06:43, Rosen Penev wrote: >>> strsep is re-entrant whereas strtok not necessarily so. >>> >>> Signed-off by: Rosen Penev >>> --- >>> ulog.c | 4 ++-- >>> 1 file changed, 2 insertions(+),

Re: [LEDE-DEV] [PATCH] kernel: bump to 4.4.39

2016-12-16 Thread Koen Vandeputte
Hi Stijn, In following of the discussion on properly updating the kernel some time ago, could you check this one please? (should you have some time) This patch is generated using the script and proper GIT config. Source used was this commit: a2798cff0f67349d7c1fe26f339439431188ec15 Thanks, K

Re: [LEDE-DEV] [PATCH] kernel: bump to 4.4.39

2016-12-16 Thread Rafał Miłecki
On 12/16/2016 11:12 AM, Koen Vandeputte wrote: @@ -4,11 +4,11 @@ LINUX_RELEASE?=1 LINUX_VERSION-3.18 = .43 LINUX_VERSION-4.1 = .34 -LINUX_VERSION-4.4 = .38 +LINUX_VERSION-4.4 = .39 LINUX_KERNEL_MD5SUM-3.18.43 = b1faeb4a2e1e70ffe061bdbb3452840a LINUX_KERNEL_MD5SUM-4.1.34 = fba99f0f4765ebf010

[LEDE-DEV] [PATCH v2] kernel: bump to 4.4.39

2016-12-16 Thread Koen Vandeputte
Refresh patches for all targets running 4.4 Compile & run tested on: - cns3xxx - imx6 Signed-off-by: Koen Vandeputte --- include/kernel-version.mk | 4 ++-- .../patches-4.4/525-MIPS-ath79-enable-qca-usb-quirks.patch | 8 .../601-MIPS-ath79-add-more-re

[LEDE-DEV] [LEDE-DEV v3] Add support of using device symlinks.

2016-12-16 Thread Nickolay Ledovskikh
It's useful when using multiple usb devices that should be bound to certain usb ports. Symlinks are created by hotplug handlers. Signed-off-by: Nickolay Ledovskikh --- package/network/utils/comgt/files/3g.sh | 2 ++ package/network/utils/comgt/files/directip.sh| 1 +

[LEDE-DEV] uqmi: Change returned value to QMI_CMD_REQUEST for 'sync' command.

2016-12-16 Thread Nickolay Ledovskikh
QMI_CMD_DONE is not working properly with 'sync' command. We must use QMI_CMD_REQUEST. Signed-off-by: Nickolay Ledovskikh --- commands.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/commands.c b/commands.c index ff9d3ac..f9545a9 100644 --- a/commands.c +++ b/commands.c @@

[LEDE-DEV] [LEDE-DEV, v3] uqmi: Prevent 'POLICY MISMATH' error.

2016-12-16 Thread Nickolay Ledovskikh
Add uqmi 'sync' command call to release stalled cid when preparing to setup new connection. As a result it prevents 'POLICY MISMATCH' errors. Signed-off-by: Nickolay Ledovskikh --- package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/packag

Re: [LEDE-DEV] [LEDE-DEV, v3] uqmi: Prevent 'POLICY MISMATH' error.

2016-12-16 Thread Nikolay Ledovskikh
2016-12-16 15:41 GMT+03:00 Nickolay Ledovskikh : > Add uqmi 'sync' command call to release stalled cid when preparing to > setup new connection. As a result it prevents 'POLICY MISMATCH' errors. There was an awful error in uqmi 'sync' command return value. So it should be applied first of all. The

Re: [LEDE-DEV] [PATCH] libubox: Fix cppcheck warnings

2016-12-16 Thread Felix Fietkau
On 2016-12-15 05:11, Rosen Penev wrote: > Two formats and a memory leak. > > Signed-off by: Rosen Penev > --- > ulog.c | 2 +- > usock.c | 2 +- > utils.c | 4 +++- > 3 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/ulog.c b/ulog.c > index 985d366..e7fb081 100644 > --- a/ulog.

[LEDE-DEV] [PATCH] Allow sending a fd along a ubus_request

2016-12-16 Thread amine.ahd
Signed-off-by: amine.ahd --- libubus-internal.h | 4 +++- libubus-obj.c | 24 libubus-req.c | 50 +++--- libubus.c | 2 +- libubus.h | 19 +++ ubusd_proto.c | 6 +- 6 files

Re: [LEDE-DEV] [PATCH v2] kernel: bump to 4.4.39

2016-12-16 Thread Stijn Segers
Hi Koen, I pulled your patch (not sure if you were talking about Stijn Tintel or me), I am getting whitespace errors: $ git apply --whitespace=fix ../patches/main/0001-Kernel-bump-to-4.4.39.patch ../patches/main/0001-Kernel-bump-to-4.4.39.patch:39: trailing whitespace. ../patches/main/0001

[LEDE-DEV] resolv.conf not localhost anymore?

2016-12-16 Thread Weedy
So I just ran into this updating master from 2ish weeks ago. root@OpenWrt:~# cat /tmp/resolv.conf # Interface wan nameserver 206.248.154.170 nameserver 206.248.154.22 root@OpenWrt:~# cat /tmp/resolv.conf.ppp nameserver 206.248.154.170 nameserver 206.248.154.22 root@OpenWrt:~# /usr/sbin/ntpd -n -d

Re: [LEDE-DEV] [PATCH v2] kernel: bump to 4.4.39

2016-12-16 Thread Felix Fietkau
On 2016-12-16 20:02, Stijn Segers wrote: > Hi Koen, > > I pulled your patch (not sure if you were talking about Stijn Tintel or > me), I am getting whitespace errors: > > $ git apply --whitespace=fix > ../patches/main/0001-Kernel-bump-to-4.4.39.patch > ../patches/main/0001-Kernel-bump-to-4.4.39

[LEDE-DEV] [PATCH RFC 2/2] openvpn: fix disabling DES support in mbedtls

2016-12-16 Thread Magnus Kroken
From: Felix Fietkau Signed-off-by: Felix Fietkau Signed-off-by: Magnus Kroken --- Felix added this to his staging tree along with my 2.4_rc1 patch, it needed updates after rc2 due to a style reformatting of the OpenVPN codebase. Not sure if I got the rebasing right, let me know of any problems.

[LEDE-DEV] [PATCH RFC 1/2] openvpn: update to 2.4_rc2

2016-12-16 Thread Magnus Kroken
OpenVPN 2.4 builds with mbedTLS 2.x, rename openvpn-polarssl variant to openvpn-mbedtls. Some feature highlights: * Data channel cipher negotiation * AEAD cipher support for data channel encryption (currently only AES-GCM) * ECDH key exchange for control channel * LZ4 compression support See http

[LEDE-DEV] [PATCH RFC v2 2/2] openvpn: fix disabling DES support in mbedtls

2016-12-16 Thread Magnus Kroken
From: Felix Fietkau Signed-off-by: Felix Fietkau Signed-off-by: Magnus Kroken --- v2: Fix whitespace issues, sorry for the noise. .../services/openvpn/patches/220-disable_des.patch | 81 ++ 1 file changed, 81 insertions(+) create mode 100644 package/network/services/open

[LEDE-DEV] [PATCH] ramips: WNDR3700v5 fix mtd partitions and radios

2016-12-16 Thread L. D. Pinney
Fix the mtd partition layout and enable both radios in the dts Signed-off-by: L. D. Pinney Tested-by Andrius ??tikonas --- diff --git a/target/linux/ramips/dts/WNDR3700V5.dts b/target/linux/ramips/dts/WNDR3700V5.dts index b9ca613..bb879a1 100644 --- a/target/linux/ramips/dts/WNDR3700V5.dts ++