Re: [LEDE-DEV] new RBM33G board

2017-12-25 Thread Daniel Golle
Hi Dan, On Mon, Dec 25, 2017 at 10:50:41AM -0700, dan wrote: > Guys, new product from mikrotik. RBM33G. Has a MT7621A CPU w/ 16MB > of flash, 256MB RAM, and pcie m.2. > > This thing has 2 mini pci2 slots and 3 gigabit ethernet port and looks > nearly perfect for a dual radio, quad channel mesh

Re: [LEDE-DEV] [PATCH] odhcp6c: Replace strerror(errno) with %m

2017-12-25 Thread Florian Fainelli
Le 12/25/17 à 15:05, Rosen Penev a écrit : > Reduction of 48 bytes in compiled size. No functional difference. > > -pedantic was removed as %m is a GNU extension. My 2 cents, I really think your patches are moving us in the wrong direction, even if all C libraries that are currently supported imp

[LEDE-DEV] [PATCH] odhcp6c: Replace strerror(errno) with %m

2017-12-25 Thread Rosen Penev
Reduction of 48 bytes in compiled size. No functional difference. -pedantic was removed as %m is a GNU extension. Signed-off-by: Rosen Penev --- CMakeLists.txt | 2 +- src/dhcpv6.c | 4 ++-- src/odhcp6c.c | 5 ++--- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/CMakeLists.tx

[LEDE-DEV] [PATCH] libopkg: Replace strerror(errno) with %m

2017-12-25 Thread Rosen Penev
Saves a few bytes. No functional difference. Signed-off-by: Rosen Penev --- libopkg/opkg_conf.c| 2 +- libopkg/opkg_message.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libopkg/opkg_conf.c b/libopkg/opkg_conf.c index 08855eb..e4de374 100644 --- a/libopkg/opkg_conf

[LEDE-DEV] [PATCH] umdnsd: Replace strerror(errno) with %m.

2017-12-25 Thread Rosen Penev
Saves 352 bytes under glibc. No functional difference. Signed-off-by: Rosen Penev --- interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/interface.c b/interface.c index 7f814d2..9c5b048 100644 --- a/interface.c +++ b/interface.c @@ -353,7 +353,7 @@ interface_

[LEDE-DEV] [PATCH] luci: treewide: Replace strerror(errno) with %m.

2017-12-25 Thread Rosen Penev
Saves a few bytes. No functional difference. Signed-off-by: Rosen Penev --- contrib/package/freifunk-watchdog/src/watchdog.c | 6 ++--- contrib/package/freifunk-watchdog/src/watchdog.h | 6 ++--- modules/luci-mod-admin-full/src/luci-bwc.c | 31 3 files changed, 1

[LEDE-DEV] [PATCH 2/2] firewall3: Fix errors reported by cppcheck.

2017-12-25 Thread Rosen Penev
Mainly sign conversion errors with printf function (%d vs. %u). Exact command line used was: cppcheck --enable=all --inconclusive --force . 2> err.txt && cat err.txt | grep -v never | grep -v reduced Only errors that I felt comfortable with were fixed. Signed-off-by: Rosen Penev --- defaults

[LEDE-DEV] [PATCH 1/2] firewall3: Replace strerror(errno) with %m

2017-12-25 Thread Rosen Penev
Size reductiom in resulting binaries. No functional difference. Signed-off-by: Rosen Penev --- defaults.c | 2 +- includes.c | 4 ++-- utils.c| 14 +++--- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/defaults.c b/defaults.c index 85a3750..f1be1dd 100644 --- a/de

[LEDE-DEV] [PATCH] procd: Fix minor null pointer dereference.

2017-12-25 Thread Rosen Penev
Null pointer check was placed after assigning values to c. Signed-off-by: Rosen Penev --- plug/hotplug.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plug/hotplug.c b/plug/hotplug.c index c52259e..80e6e4d 100644 --- a/plug/hotplug.c +++ b/plug/hotplug.c @@ -392,12 +3

[LEDE-DEV] [PATCH 1/3] procd: Replace strerror(errno) with %m.

2017-12-25 Thread Rosen Penev
Saves 1496 bytes from compiled size under glibc. No functional difference. Signed-off-by: Rosen Penev --- initd/zram.c| 8 jail/capabilities.c | 2 +- jail/fs.c | 2 +- jail/jail.c | 32 jail/seccomp.c | 4 ++-- plug/ho

[LEDE-DEV] [PATCH 3/3] procd: Add %m to several functions that return errno.

2017-12-25 Thread Rosen Penev
Might help with debugging. No size impact. Signed-off-by: Rosen Penev --- initd/early.c | 2 +- initd/init.c | 4 ++-- initd/preinit.c| 12 ++-- initd/zram.c | 8 inittab.c | 4 ++-- jail/fs.c | 2 +- plug/coldplug.c| 4 ++-- plug

[LEDE-DEV] [PATCH 2/3] procd: Remove redundant errno variable in several printf functions.

2017-12-25 Thread Rosen Penev
%m, aka strerror(errno) is already used. No need to repeat it. Saves 280 bytes. Signed-off-by: Rosen Penev --- service/instance.c | 24 utils/utils.c | 4 ++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/service/instance.c b/service/instance.c

[LEDE-DEV] [PATCH fstools] libblkid-tiny: add support for NTFS superblock

2017-12-25 Thread Rafał Miłecki
From: Rafał Miłecki Its copied from the util-linux project and its libblkid. Call to the blkid_probe_set_utf8label was commented out due to libblkid-tiny not supporting it yet. Signed-off-by: Rafał Miłecki --- CMakeLists.txt| 1 + libblkid-tiny/libblkid-tiny.c | 1 + libblk

[LEDE-DEV] Question of replacing mountd with blockd

2017-12-25 Thread Rafał Miłecki
Hi, looking at: commit 7e4b869c45138 ("fstools: add blockd") commit 6a772cb953c4c ("mountd: drop in favour of blockd") I'd expect blockd to provide the same functionality as mountd did. I don't think it's the case though. With mountd installed (e.g. in LEDE 17.01) plugging in USB storage device w

Re: [LEDE-DEV] [PATCH] bcm53xx: use iflag=skip_bytes for dd command during sysupgrade

2017-12-25 Thread Etienne Champetier
Hi Rafal, 2017-12-25 5:18 GMT-08:00 Rafał Miłecki : > On 2017-12-24 00:26, Etienne Champetier wrote: >> >> 2017-12-23 14:14 GMT-08:00 Rafał Miłecki : >>> >>> From: Rafał Miłecki >>> >>> Since BusyBox 1.25.0 dd command supports iflag=skip_bytes which allows >>> skipping requested amount of bytes w

[LEDE-DEV] new RBM33G board

2017-12-25 Thread dan
Guys, new product from mikrotik. RBM33G. Has a MT7621A CPU w/ 16MB of flash, 256MB RAM, and pcie m.2. This thing has 2 mini pci2 slots and 3 gigabit ethernet port and looks nearly perfect for a dual radio, quad channel mesh box. I see that there are some devices with this cpu already supported

[LEDE-DEV] [PATCH v1] kernel: bump 4.9 to 4.9.72

2017-12-25 Thread Kevin Darbyshire-Bryant
Refresh patches. Runtime tested: ar71xx - Archer C7 v2 Signed-off-by: Kevin Darbyshire-Bryant --- include/kernel-version.mk | 4 +-- ...ky-CPU-port-fixes-for-devices-not-using-p.patch | 4 +-- .../960-add-rasbperrypi-compatible.patch | 32 +++

Re: [LEDE-DEV] [PATCH 1/4] brcm2708: convert to metadata

2017-12-25 Thread Álvaro Fernández Rojas
Applied, thanks! El 17/12/2017 a las 15:18, Christian Lamparter escribió: This patch converts all the raspberrypi images to utilize the common metadata-based image verification. Note: the CM1 and CM3 currently use the same "rpi-cm" boardname. Signed-off-by: Christian Lamparter --- .../linu

Re: [LEDE-DEV] [PATCH] bcm53xx: use iflag=skip_bytes for dd command during sysupgrade

2017-12-25 Thread Rafał Miłecki
On 2017-12-24 00:26, Etienne Champetier wrote: 2017-12-23 14:14 GMT-08:00 Rafał Miłecki : From: Rafał Miłecki Since BusyBox 1.25.0 dd command supports iflag=skip_bytes which allows skipping requested amount of bytes without reducing blocksize. Thanks to this we can leave default blocksize an

Re: [LEDE-DEV] layerscape build bot problem

2017-12-25 Thread Y.b. Lu
Hi Hauke, Created the pull request. Please help to review. https://github.com/lede-project/source/pull/1604 Thank you very much. Best regards, Yangbo Lu > -Original Message- > From: Y.b. Lu > Sent: 2017年12月22日 18:05 > To: 'Hauke Mehrtens' > Cc: lede-dev@lists.infradead.org > Subject: R