[LEDE-DEV] [PATCH netifd] interface: Fix triggering of interface update event

2016-11-02 Thread Hans Dedecker
/data change; before interface update events were actually sent wihtout any parameter change. Signed-off-by: Hans Dedecker --- interface.c | 9 ++--- interface.h | 2 +- proto-shell.c | 7 +++ 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/interface.c b/interface.c index

[LEDE-DEV] [PATCH odhcpd 1/5] config: Support infinite as DHCP pool leasetime value

2016-11-17 Thread Hans Dedecker
considered infinite if valid_unil holds the value 0. Signed-off-by: Hans Dedecker --- This fixes broken IPv6 connectivity in case infinite is specified as a leasetime value for a dhcp pool as odhcpd was considering this as an invalid value and deleted the interface. This particular problem can

[LEDE-DEV] [PATCH odhcpd 3/5] ubus: Fix displayed valid paramater for both DHCPv4 and DHCPv6 lease

2016-11-17 Thread Hans Dedecker
Fix ubus valid parameter being displayed as a negative number; also display infinite lifetime as INT32_MAX Signed-off-by: Hans Dedecker --- src/ubus.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/ubus.c b/src/ubus.c index 14d0a5f..425abe4 100644 --- a/src

[LEDE-DEV] [PATCH odhcpd 2/5] dhcpv4: Keep DHCPv4 assignment lifetime value in sync with assigned leasetime

2016-11-17 Thread Hans Dedecker
Keep the valid_until assignment parameter in sync with the leasetime assigned to the DHCP client when handling DHCP request message. This guarantees the contents of the ubus dhcp ipv4leases valid parameter is in sync with the client leasetime Signed-off-by: Hans Dedecker --- src/dhcpv4.c | 11

[LEDE-DEV] [PATCH odhcpd 5/5] dhcpv4: Adding DHCP client leasetime request support

2016-11-17 Thread Hans Dedecker
Add support for DHCPv4 clients proposing a leasetime; proposed leasetime will be accepted if it does not exceed either the pool or configured lease leastime. Further rework the duplicated leasetime logic which was in place. Signed-off-by: Hans Dedecker --- src/dhcpv4.c | 34

[LEDE-DEV] [PATCH odhcpd 4/5] dhcpv6-ia: Display infinite lifetime as INT32_MAX in state file

2016-11-17 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- src/dhcpv6-ia.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/dhcpv6-ia.c b/src/dhcpv6-ia.c index 597bc74..852af97 100644 --- a/src/dhcpv6-ia.c +++ b/src/dhcpv6-ia.c @@ -247,7 +247,8 @@ void dhcpv6_write_statefile(void

Re: [LEDE-DEV] [PATCH odhcpd 1/5] config: Support infinite as DHCP pool leasetime value

2016-11-17 Thread Hans Dedecker
On Thu, Nov 17, 2016 at 11:13 PM, Karl Palsson wrote: > > Hans Dedecker wrote: >> Add support for infinite leasetime value; this can be done by >> specifying "infinite" as leasetime value which is similar to >> dnsmasq infinite leasetime support. Specifying &

Re: [LEDE-DEV] [PATCH odhcpd 3/5] ubus: Fix displayed valid paramater for both DHCPv4 and DHCPv6 lease

2016-11-17 Thread Hans Dedecker
On Thu, Nov 17, 2016 at 11:15 PM, Karl Palsson wrote: > > Hans Dedecker wrote: >> Fix ubus valid parameter being displayed as a negative number; >> also display infinite lifetime as INT32_MAX > > Really? Why not 0 or -1? You dont' specify an infinite lease as >

Re: [LEDE-DEV] netifd: proto_add_host_dependency()

2016-11-18 Thread Hans Dedecker
On Friday, 18 November 2016 12:33:25 CET Dan Lüdtke wrote: > Hi everyone, > > I have a weird situation where proto_add_host_dependency() does not like > IPv6 addresses. The WAN/WAN6 interface don't have global unicast addresses > assigned, but my protocol script calls > > proto_add_host_dependen

[LEDE-DEV] [PATCH] odhcpd: Display infinite valid lifetime as -1

2016-11-21 Thread Hans Dedecker
Display infinite valid lifetime as -1 both in ubus and statefile Signed-off-by: Hans Dedecker --- Follow-up patch as a result of the remark given in http://lists.infradead.org/pipermail/lede-dev/2016-November/004133.html src/dhcpv6-ia.c | 16 src/ubus.c | 4 ++-- 2 files

[LEDE-DEV] [PATCH netifd 1/2] ubus: Use device_find to find a device when displaying device info

2016-11-21 Thread Hans Dedecker
vlan device in the dependency list of the layer 3 device as it has been created as a dependency of the aliased device. Signed-off-by: Hans Dedecker --- ubus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ubus.c b/ubus.c index 4d43b57..8ba43c0 100644 --- a/ubus.c +++ b/u

[LEDE-DEV] [PATCH netifd 2/2] device: Use device_find for better readibility in device_create

2016-11-21 Thread Hans Dedecker
Use device_find in device_create so it's clear a device lookup is being done in the device list. Signed-off-by: Hans Dedecker --- device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/device.c b/device.c index 82596e4..3c57a02 100644 --- a/device.c +++ b/dev

[LEDE-DEV] [PATCH odhcpd 1/2] dhcpv6-ia: Fix assignment of static DHCPv6 leases

2016-12-01 Thread Hans Dedecker
Fix assignment of static DHCPv6 leases which was broken by commit 6c3bc0141dacc88992583d6f2cdc8a360df7422d. At the same time fix lifetime check of existing assignments having a finite lifetime Fixes FS#309 Signed-off-by: Hans Dedecker --- src/dhcpv6-ia.c | 4 +++- 1 file changed, 3 insertions

[LEDE-DEV] [PATCH odhcpd 2/2] dhcpv6-ia : Fix static DHCPv6 assignments becoming non static

2016-12-01 Thread Hans Dedecker
updating it. Signed-off-by: Hans Dedecker --- src/dhcpv6-ia.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/dhcpv6-ia.c b/src/dhcpv6-ia.c index f4bf044..20ef1f8 100644 --- a/src/dhcpv6-ia.c +++ b/src/dhcpv6-ia.c @@ -773,8 +773,10 @@ static size_t

[LEDE-DEV] [PATCH netifd] ubus: Display the IPv6 prefix assigned address

2016-12-09 Thread Hans Dedecker
Display the IPv6 address obtained from a prefix assignment as local-address element in the ubus ipv6-prefix-assignment list so it's explicitly clear which IPv6 address from the delegated prefix is assigned to the interface. Signed-off-by: Hans Dedecker --- ubus.c | 11 ++- 1

Re: [LEDE-DEV] resolv.conf not localhost anymore?

2016-12-19 Thread Hans Dedecker
On Mon, Dec 19, 2016 at 11:38 AM, Weedy wrote: > On 16 December 2016 at 15:21, Weedy wrote: >> So I just ran into this updating master from 2ish weeks ago. >> >> root@OpenWrt:~# cat /tmp/resolv.conf >> # Interface wan >> nameserver 206.248.154.170 >> nameserver 206.248.154.22 >> root@OpenWrt:~# c

Re: [LEDE-DEV] [PATCH netifd] proto: allow configuring deprecated static IPv6 addresses

2016-12-19 Thread Hans Dedecker
On Sun, Dec 11, 2016 at 3:03 AM, Matthias Schiffer wrote: > Add a new boolean attribute ip6preferred to the static protocol which can > be set to 0 to mark IPv6 addresses as deprecated (set the preferred > lifetime to 0). This is useful to configure addresses that may be used for > incoming, but n

Re: [LEDE-DEV] [PATCH netifd] proto: allow configuring deprecated static IPv6 addresses

2016-12-21 Thread Hans Dedecker
On Mon, Dec 19, 2016 at 10:10 PM, Matthias Schiffer wrote: > On 12/19/2016 10:02 PM, Hans Dedecker wrote: >> On Sun, Dec 11, 2016 at 3:03 AM, Matthias Schiffer >> wrote: >>> Add a new boolean attribute ip6preferred to the static protocol which can >>> be s

[LEDE-DEV] [PATCH netifd] system-linux: Don't set gre tunnel ttl by default to 64 (#FS312)

2016-12-23 Thread Hans Dedecker
As the ttl of a gre tunnel was set by default to 64 the gre tunnel failed to get active if don't fragment was disabled as setting nopmtudisc and ttl is incompatible. Fix this by setting the default ttl value after don't fragment and ttl config values have been parsed. Signed-off-by: Han

Re: [LEDE-DEV] dhcpv6-pd subnet allocation?

2017-01-03 Thread Hans Dedecker
On Mon, Jan 2, 2017 at 8:02 PM, Dave Taht wrote: > 1) In a topology like this: > > ISP > | > routerA > | > routerB > | > routerC > > what options now exist in lede for getting an ipv6 subnet to routerC > from routerA after being provided by the ISP? (the basic PD allocation > from ISP to A seem

Re: [LEDE-DEV] [RFC PATCH odhcpd] config: respect ignore uci option

2017-01-05 Thread Hans Dedecker
uot; >> >> - the options "ra", "ndp", "dhcpv4" and "dhcpv6" to take precedence over the >>default "ignore" state to allow selectively enabling services on ignored >>interfaces >> >> - the README to clar

[LEDE-DEV] [PATCH netifd] interface-ip: route proto config support (FS#170)

2017-01-17 Thread Hans Dedecker
a numerical value Signed-off-by: Hans Dedecker --- interface-ip.c | 21 + interface-ip.h | 5 +++-- system-dummy.c | 6 ++ system-linux.c | 52 +++- system.h | 1 + ubus.c | 3 +++ 6 files changed, 81

Re: [LEDE-DEV] [PATCH netifd] interface-ip: route proto config support (FS#170)

2017-01-17 Thread Hans Dedecker
On Tue, Jan 17, 2017 at 5:00 PM, Dave Täht wrote: > Thank you Hans, this made my day. > > On 1/17/17 6:34 AM, Toke Høiland-Jørgensen wrote: >> Hans Dedecker writes: >> >>> Route proto support is usefull when using route distribution >>> via a routing daemo

[LEDE-DEV] [PATCH v2 netifd] interface-ip: route proto config support (FS#170)

2017-01-19 Thread Hans Dedecker
. Signed-off-by: Hans Dedecker --- v2: Use /etc/iproute2/rt_tables as fallback to resolve rt_proto string interface-ip.c | 21 + interface-ip.h | 5 +++-- system-dummy.c | 6 ++ system-linux.c | 42 -- system.h | 1 + ubus.c

Re: [LEDE-DEV] Fw: [openwrt/luci] BUG: DHCP Leases "infinite" time shows as "expired" not as "unlimited" in IPv4 (#963)

2017-01-20 Thread Hans Dedecker
Hi Daniel odhcpd uses 0 to indicate a lease is expired while -1 is used to reperesent infinite leasetime since the support of infinite leasetime (http://lists.infradead.org/pipermail/lede-dev/2016-November/004133.html). I have my doubts can you make a distinction in dnsmasq between infinite leaset

[LEDE-DEV] [PATCH netifd] interface: add prefix assignment priority support

2017-01-31 Thread Hans Dedecker
first -Finally the alphabetical order of the interfaces in case of equal ip6weight Signed-off-by: Hans Dedecker --- interface-ip.c | 57 - interface-ip.h | 1 + interface.c| 6 ++ interface.h| 1 + ubus.c | 2 ++ 5

Re: [LEDE-DEV] impressed by progress on odhcpd and procd and elsewhere.

2017-02-11 Thread Hans Dedecker
On Friday, 10 February 2017 09:11:17 CET Dave Taht wrote: > Hans, jow, blogic, everybody... > > I have been pulling lede-head stuff and starting to build lede again > (for the first time in 3 years), but I'd given up on the ipv6 > issues[1]. > > After reviewing odhcpd/procd/etc latest git commits

Re: [LEDE-DEV] impressed by progress on odhcpd and procd and elsewhere.

2017-02-15 Thread Hans Dedecker
On Tue, Feb 14, 2017 at 11:35 PM, Philip Prindeville wrote: > >> On Feb 11, 2017, at 11:11 PM, Stijn Tintel wrote: >> >> On 10-02-17 18:11, Dave Taht wrote: >>> About the biggest request from the field seems to be supplying RA and >>> dhcpv6 dns on a more real IPv6 address than fe80 to make andro

[LEDE-DEV] [PATCH 1/2] libubus: reset ctx->sock.error when doing ubus reconnect

2017-02-18 Thread Hans Dedecker
When ubus connect fails ctx->sock.eof will be set but ctx->sock.error can be set as well. Reset ctx->sock.error as well when doing ubus reconnect Signed-off-by: Hans Dedecker --- libubus-io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libubus-io.c b/libubus-io.c index 7047ac5

[LEDE-DEV] [PATCH 2/2] cli: fix listen_timeout compile issue

2017-02-18 Thread Hans Dedecker
Variable listen_timeout is redefined as a function resulting into a compile issue. Define the function as ubus_cli_listen_timeout to fix the compile issue. Signed-off-by: Hans Dedecker --- cli.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cli.c b/cli.c index 1949a17

[LEDE-DEV] [PATCH ubus 2/2] cli: fix listen_timeout compile issue

2017-02-18 Thread Hans Dedecker
Variable listen_timeout is redefined as a function resulting into a compile issue. Define the function as ubus_cli_listen_timeout to fix the compile issue. Signed-off-by: Hans Dedecker --- cli.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cli.c b/cli.c index 1949a17

[LEDE-DEV] [PATCH ubus 1/2] libubus: reset ctx->sock.error when doing ubus reconnect

2017-02-18 Thread Hans Dedecker
When ubus connect fails ctx->sock.eof will be set but ctx->sock.error can be set as well. Reset ctx->sock.error as well when doing ubus reconnect Signed-off-by: Hans Dedecker --- libubus-io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libubus-io.c b/libubus-io.c index 7047ac5

Re: [LEDE-DEV] [PATCH netifd] system-linux: add VXLAN support

2017-02-24 Thread Hans Dedecker
On Thursday, 23 February 2017 22:23:32 CET Matthias Schiffer wrote: > VXLAN shares many attributes with the tunnel devices, so it is implemented > as a new tunnel type. The 'remote' attribute can be used for an unicast > peer or a multicast group. > > The IANA-assigned port 4789 is used by default

Re: [LEDE-DEV] [PATCH netifd] system-linux: add VXLAN support

2017-02-24 Thread Hans Dedecker
On Fri, Feb 24, 2017 at 6:12 PM, Matthias Schiffer wrote: > On 02/24/2017 05:53 PM, Hans Dedecker wrote: >> On Thursday, 23 February 2017 22:23:32 CET Matthias Schiffer wrote: >>> VXLAN shares many attributes with the tunnel devices, so it is implemented >>> as a n

Re: [LEDE-DEV] [PATCH netifd v3] system-linux: add VXLAN support

2017-03-05 Thread Hans Dedecker
t 4789 is used by default, instead of the non-standard > port Linux defaults to. > > Signed-off-by: Matthias Schiffer Acked-by: Hans Dedecker > --- > > v2: Updated to use a nested JSON object for the VXLAN-specific attributes - > although one could argue that MAC address,

[LEDE-DEV] [PATCH netifd 1/2] interface-ip: set address indicator flag when IPv6 address lifetime changes

2017-03-09 Thread Hans Dedecker
Trigger interface update event when IPv6 address lifetime changes by setting the address indicator flag to inform external subsystems about IPv6 address lifetime change. Signed-off-by: Hans Dedecker --- interface-ip.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a

[LEDE-DEV] [PATCH netifd 2/2] interface-ip: set prefix indicator flag when IPv6 prefix lifetime changes

2017-03-09 Thread Hans Dedecker
Trigger interface update event when IPv6 prefix lifetime changes by setting the prefix indicator flag to inform external subsystems (eg hnetd) about IPv6 prefix lifetime changes. Signed-off-by: Hans Dedecker --- interface-ip.c | 4 1 file changed, 4 insertions(+) diff --git a/interface

Re: [LEDE-DEV] [PATCH netifd 1/2] interface-ip: set address indicator flag when IPv6 address lifetime changes

2017-03-09 Thread Hans Dedecker
On Thu, Mar 9, 2017 at 10:20 PM, Matthias Schiffer wrote: > On 03/09/2017 05:32 PM, Hans Dedecker wrote: >> Trigger interface update event when IPv6 address lifetime changes by setting >> the address indicator flag to inform external subsystems about IPv6 address >> lifetime

Re: [LEDE-DEV] [PATCH netifd 1/2] interface-ip: set address indicator flag when IPv6 address lifetime changes

2017-03-10 Thread Hans Dedecker
On Fri, Mar 10, 2017 at 12:08 AM, Matthias Schiffer wrote: > On 03/09/2017 11:03 PM, Hans Dedecker wrote: >> On Thu, Mar 9, 2017 at 10:20 PM, Matthias Schiffer >> wrote: >>> On 03/09/2017 05:32 PM, Hans Dedecker wrote: >>>> Trigger interface update event w

Re: [LEDE-DEV] using 464XLAT in LEDE (or OpenWRT)

2017-03-11 Thread Hans Dedecker
Hi, On Wed, Mar 8, 2017 at 10:23 PM, JORDI PALET MARTINEZ wrote: > Hi Hans, > > I believe you’re the maintainer of 464XLAT. I want to do demonstrations of > OpenWRT/LEDE in scenarios where you run out of IPv4 addresses for the WAN > links. > > Sorry to write you directly, but I’ve been trying f

Re: [LEDE-DEV] using 464XLAT in LEDE (or OpenWRT)

2017-03-13 Thread Hans Dedecker
t at the moment .. You can revert netifd commit https://git.lede-project.org/?p=project/netifd.git;a=commit;h=39d9ceeb96162a83a3f5fa63e6aaa1ccb38caa62 and based on this netifd version do further 464xlat tests. Other bug reports/feature requests need to be opened in github openwrt routing as an issu

[LEDE-DEV] [PATCH netifd 1/2] system-linux: parse gre specific settings as nested json data object

2017-03-14 Thread Hans Dedecker
Parse gre specific settings ikey, okey, icsum, ocsum, iseqno and oseqno as nested json data object Signed-off-by: Hans Dedecker --- system-linux.c | 48 +--- system.c | 14 ++ system.h | 11 +++ 3 files changed, 54

[LEDE-DEV] [PATCH netifd 2/2] system-linux: parse vti specific settings as nested json data object

2017-03-14 Thread Hans Dedecker
Parse vti specific settings ikey and okey as nested json data object. At the same time remove the now obsolete TUNNEL_ATTR_INFO attribute. Signed-off-by: Hans Dedecker --- system-linux.c | 29 - system.c | 11 ++- system.h | 8 +++- 3 files

Re: [LEDE-DEV] [PATCH netifd 1/2] system-linux: parse gre specific settings as nested json data object

2017-03-15 Thread Hans Dedecker
On Tue, Mar 14, 2017 at 11:32 PM, Felix Fietkau wrote: > On 2017-03-14 21:36, Hans Dedecker wrote: >> Parse gre specific settings ikey, okey, icsum, ocsum, iseqno and oseqno >> as nested json data object >> >> Signed-off-by: Hans Dedecker > Are you sure this

Re: [LEDE-DEV] [PATCH 1/3][RFC] netifd: propagate error code on netifd_reload()

2017-03-26 Thread Hans Dedecker
On Mon, Mar 20, 2017 at 3:08 PM, Alexandru Ardelean wrote: > From: Alexandru Ardelean > > The context is that we generate some of the UCI config > for netifd via scripts/programs. > > Every once in a while, there's a goof when doing that > UCI generation, and netifd prints out the error at > stde

Re: [LEDE-DEV] [PATCH 1/3][RFC] netifd: propagate error code on netifd_reload()

2017-03-26 Thread Hans Dedecker
On Sun, Mar 26, 2017 at 6:21 PM, Alexandru Ardelean wrote: > On Sun, Mar 26, 2017 at 7:06 PM, Hans Dedecker wrote: >> On Mon, Mar 20, 2017 at 3:08 PM, Alexandru Ardelean >> wrote: >>> From: Alexandru Ardelean >>> >>> The context is that we generate

Re: [LEDE-DEV] [PATCH 1/3][RFC] netifd: propagate error code on netifd_reload()

2017-03-26 Thread Hans Dedecker
On Sun, Mar 26, 2017 at 6:45 PM, Alexandru Ardelean wrote: > On Sun, Mar 26, 2017 at 7:38 PM, Hans Dedecker wrote: >> On Sun, Mar 26, 2017 at 6:21 PM, Alexandru Ardelean >> wrote: >>> On Sun, Mar 26, 2017 at 7:06 PM, Hans Dedecker wrote: >>>> On Mon, Mar 20,

Re: [LEDE-DEV] [PATCH][V4] netifd: propagate error code on netifd_reload()

2017-03-27 Thread Hans Dedecker
but returns 0 (success) err-code. > > This change will fail the ubus call if UCI config > is invalid or missing for /etc/config/network. > > Signed-off-by: Alexandru Ardelean Acked-by: Hans Dedecker > --- > config.c | 10 -- > config.h | 2 +- > main.c | 4 ++

Re: [LEDE-DEV] [PATCH 2/3][RFC] base-files: add option to rc.common to disable default reload behavior

2017-03-28 Thread Hans Dedecker
On Mon, Mar 20, 2017 at 3:08 PM, Alexandru Ardelean wrote: > From: Alexandru Ardelean > > Traditionally if a reload script fails, it will fallback to restart. > > That seems to be the default behavior in case no reload > handler has been specified, and `reload` will return 1. > > That also has th

[LEDE-DEV] [PATCH netifd] interface-ip: fix device name for IPv6 link-local DNS server

2017-04-03 Thread Hans Dedecker
referenced layer 3 device. Signed-off-by: Hans Dedecker --- interface-ip.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/interface-ip.c b/interface-ip.c index dd4e01c..140ef34 100644 --- a/interface-ip.c +++ b/interface-ip.c @@ -1287,13 +1287,14

Re: [LEDE-DEV] [PATCH odpcpd] dhcpv6: allow creating new bindings on REBIND

2017-04-11 Thread Hans Dedecker
On Mon, Apr 10, 2017 at 11:08 AM, Lubomir Rintel wrote: > There might be unassigned IAs among the options the client sends when it > issues a REBIND. In fact, that's how the ISC dhclient reqests new IA_PDs > to be assigned. However, odhcpd would just return the IA_PDs back > without assigning a pr

Re: [LEDE-DEV] [PATCH netifd] ubus: add interface method to trigger renew event

2017-04-13 Thread Hans Dedecker
On Wed, Apr 12, 2017 at 7:53 PM, Matthias Schiffer wrote: > Not all topology or connectivity changes may be detected by netifd, > depending on the underlying technology (e.g. VPN software); this adds a way > to explicitly trigger a renew. > > Signed-off-by: Matthias Schiffer

Re: [LEDE-DEV] [PATCH netifd] Revert: set prefix indicator flag when IPv6 prefix lifetime, changes

2017-04-23 Thread Hans Dedecker
On Mon, Apr 24, 2017 at 4:24 AM, Eric Luehrsen wrote: > This reverts commit a03216660797173fbe67866f75564e3fec9c1e8d. The previous > change causes IFUP events to occur from 30 seconds to 30 minutes depending > on various conditions at the WAN6 (typ.) interface. If a DHCPv6 lease is > 24 hours and

Re: [LEDE-DEV] OpenWRT tree vs LEDE tree

2016-05-09 Thread Hans Dedecker
On Wed, May 4, 2016 at 1:16 PM, Jo-Philipp Wich wrote: > > Hi Michael, > > several people expressed the intention to continue pushing patches to > both trees. In any case we'll keep picking stuff from both lists for > LEDE for some time to come. > > Regards, > Jo-Philipp > > __

[LEDE-DEV] [PATCH 1/2] netifd: Remove hardcoded DHCP release option

2016-05-09 Thread Hans Dedecker
Remove the udhcpc -R release option as sending a DHCP release is configurable via the uci option release. Signed-off-by: Hans Dedecker --- package/network/config/netifd/files/lib/netifd/proto/dhcp.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/config

[LEDE-DEV] [PATCH 2/2] dropbear: Add --disable-utmpx again

2016-05-09 Thread Hans Dedecker
The option --disable-utmpx was deleted by accident in commit 7545c1d; add it again to the CONFIGURE_ARGS list Signed-off-by: Hans Dedecker --- package/network/services/dropbear/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/package/network/services/dropbear/Makefile b/package

[LEDE-DEV] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-19 Thread Hans Dedecker
the specified DHCP(v6) interfaces; if empty all interfaces are considered Signed-off-by: Hans Dedecker --- The patch is based on a previous discussion held on the OpenWRT-devel mailing list (https://lists.openwrt.org/pipermail/openwrt-devel/2016-January/039081.html) as per Felix's comments

Re: [LEDE-DEV] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-19 Thread Hans Dedecker
enabling DHCP ntp server config without explicit config ? Regarding the improvements do you want me to send a patch containing the diff with the already staged commit or do you prefer a v2 patch ? Hans > > ~ Jo > > On 05/19/2016 06:57 PM, Hans Dedecker wrote: >> The busybox ntpd ut

Re: [LEDE-DEV] [OpenWrt-Devel] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-20 Thread Hans Dedecker
On Fri, May 20, 2016 at 3:18 PM, David Lang wrote: > On Fri, 20 May 2016, Jo-Philipp Wich wrote: > >> Hi Hans, >> >>> I wanted to preserve the ntp server behavior and only change the >>> behavior when configured in order to keep backwards compatibility. You >>> favour enabling DHCP ntp server conf

Re: [LEDE-DEV] [OpenWrt-Devel] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-20 Thread Hans Dedecker
On Fri, May 20, 2016 at 3:59 PM, Conor O'Gorman wrote: > > > On 20/05/16 14:43, Hans Dedecker wrote: >> >> On Fri, May 20, 2016 at 3:18 PM, David Lang wrote: >>> >>> On Fri, 20 May 2016, Jo-Philipp Wich wrote: >>> >>>> Hi Hans,

[LEDE-DEV] [PATCH v2] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-23 Thread Hans Dedecker
the specified DHCP(v6) interfaces; if empty all interfaces are considered Signed-off-by: Hans Dedecker --- v1 -> v2: Make jsonfilter dependant on BUSYBOX_CONFIG_NTPD Pipe output of network dump into jsonfilter use_dhcp is by default enabled Install fine grai

Re: [LEDE-DEV] A question on procd interface_trigger vs raw_trifger

2016-05-23 Thread Hans Dedecker
On Mon, May 23, 2016 at 12:04 AM, Daniel Dickinson wrote: > Hi, > > I've noticed that network_trigger has gone away and is replaced by > interface_trigger, but have seen raw_trigger too, and am not clear on > when one would use which. If you want to install a trigger for a specific interface you c

[LEDE-DEV] [PATCH netifd 2/3] device: Fix dotted vlan interface staying down

2016-06-06 Thread Hans Dedecker
state config interface 'test' option proto 'static' option ipaddr '192.168.2.1' option netmask '255.255.255.0' config interface 'test2' option ifname '@test.1' option proto 'dhcp' Signed-off-by: Hans Ded

[LEDE-DEV] [PATCH netifd 1/3] device: Fix device find failure in avl list due to device name change

2016-06-06 Thread Hans Dedecker
As device name is used as key in avl list a device name change will break the avl find logic. Function device_set_ifname offers api to set the device name and re-inserts the avl node in the list when the avl key value is changed. Signed-off-by: Hans Dedecker --- alias.c | 9

[LEDE-DEV] [PATCH netifd 3/3] system-linux: Replace device_get by device_find where appropriate

2016-06-06 Thread Hans Dedecker
Replace device_get by device_find so it's clear a device needs to be found present in the device list. Signed-off-by: Hans Dedecker --- system-linux.c | 2 +- ubus.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/system-linux.c b/system-linux.c index 98

Re: [LEDE-DEV] [OpenWrt-Devel] [PATCH netifd 1/3] device: Fix device find failure in avl list due to device name change

2016-06-06 Thread Hans Dedecker
On Mon, Jun 6, 2016 at 12:38 PM, Eyal Birger wrote: > Hi Hans, > > On Mon, Jun 6, 2016 at 1:03 PM, Hans Dedecker wrote: >> As device name is used as key in avl list a device name change will break >> the avl find logic. >> Function device_set_ifname offers api to

[LEDE-DEV] [PATCH v2 netifd 3/3] system-linux: Replace device_get by device_find where appropriate

2016-06-06 Thread Hans Dedecker
Replace device_get by device_find so it's clear a device needs to be found present in the device list. Signed-off-by: Hans Dedecker --- v1 -> v2 : Remove extra white line in netifd_handle_set_state system-linux.c | 2 +- ubus.c | 2 +- 2 files changed, 2 insertions(+), 2 d

[LEDE-DEV] [PATCH v2 netifd 2/3] device: Fix dotted vlan interface staying down

2016-06-06 Thread Hans Dedecker
state config interface 'test' option proto 'static' option ipaddr '192.168.2.1' option netmask '255.255.255.0' config interface 'test2' option ifname '@test.1' option proto 'dhcp' Signed-off-by: Hans Dedecke

[LEDE-DEV] [PATCH v2 netifd 1/3] device: Fix device find failure in avl list due to device name change

2016-06-06 Thread Hans Dedecker
As device name is used as key in avl list a device name change will break the avl find logic. Function device_set_ifname offers api to set the device name and re-inserts the avl node in the list when the avl key value is changed. Signed-off-by: Hans Dedecker --- v1 -> v2 : Fix debug print

Re: [LEDE-DEV] [PATCH] uloop: use a waker for notifying sigchld and loop cancel events

2016-06-15 Thread Hans Dedecker
On Wed, Jun 15, 2016 at 11:58 AM, Felix Fietkau wrote: > On 2016-06-15 11:39, Conor O'Gorman wrote: >> On 09/06/16 03:20, Yousong Zhou wrote: >>> Fix a race condition when do_sigchld, uloop_cancelled were set just >>> before epoll_wait(timeout=-1), resulting the loop stuck in the syscall >>> witho

Re: [LEDE-DEV] [PATCH] uloop: use a waker for notifying sigchld and loop cancel events

2016-06-16 Thread Hans Dedecker
On Wed, Jun 15, 2016 at 4:54 PM, Mats Karrman wrote: > > On 2016-06-15 15:16, Felix Fietkau wrote: >> >> On 2016-06-15 15:13, Hans Dedecker wrote: >> On Wed, Jun 15, 2016 at >> 11:58 AM, Felix Fietkau >> > > wrote: >>> On 2016-06-15 11:39, Cono

[LEDE-DEV] [PATCH netifd] alias: Set alias link device status to disabled when device is removed

2016-06-29 Thread Hans Dedecker
Fixes missing link state event propagation for an aliased device in case a new device is added as the link state has the last known status of the old device possible resulting into no link state change detection. Signed-off-by: Hans Dedecker --- alias.c | 4 +++- 1 file changed, 3 insertions

[LEDE-DEV] [PATCH netifd 2/3] interface: Only teardown interfaces having no proto task when l3_dev link lost

2016-07-14 Thread Hans Dedecker
persist state trying to re-establish the link via a hold off mechanism which is not possible when the daemon is terminated by the proto shell teardown. Therefore restrict the teardown action for shell protocols having no proto task. Signed-off-by: Hans Dedecker --- interface.c | 3 ++- 1 file

[LEDE-DEV] [PATCH netifd 3/3] proto: Display proto flags when dumping the protocol handlers in ubus

2016-07-14 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- proto.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/proto.c b/proto.c index 45eeb4b..4cbf3f4 100644 --- a/proto.c +++ b/proto.c @@ -567,7 +567,13 @@ proto_dump_handlers(struct blob_buf *b) blobmsg_add_string(b, p

[LEDE-DEV] [PATCH netifd 1/3] proto-shell: Model config parameter "no-proto-task" as a proto flag

2016-07-14 Thread Hans Dedecker
Export the config parameter "no-proto-task" as a proto flag so it can be checked by other netifd modules Signed-off-by: Hans Dedecker --- proto-shell.c | 6 +++--- proto.h | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/proto-shell.c b/proto-shell.c ind

Re: [LEDE-DEV] [OpenWrt-Devel] [PATCH netifd 2/3] interface: Only teardown interfaces having no proto task when l3_dev link lost

2016-07-14 Thread Hans Dedecker
On Thu, Jul 14, 2016 at 12:01 PM, Yousong Zhou wrote: > On 14 July 2016 at 16:14, Hans Dedecker wrote: >> Commit c6858766 adds teardown support when l3_dev link is lost especially >> for shell protocols >> that have no proto task. However shell protocols which have a proto

Re: [LEDE-DEV] [OpenWrt-Devel] [PATCH netifd 2/3] interface: Only teardown interfaces having no proto task when l3_dev link lost

2016-07-14 Thread Hans Dedecker
On Thu, Jul 14, 2016 at 4:56 PM, Felix Fietkau wrote: > On 2016-07-14 16:53, Yousong Zhou wrote: >> On 14/07/2016, Felix Fietkau wrote: >>> On 2016-07-14 13:28, Hans Dedecker wrote: >>>> On Thu, Jul 14, 2016 at 12:01 PM, Yousong Zhou >>>> wrote: >

Re: [LEDE-DEV] [OpenWrt-Devel] [PATCH netifd 2/3] interface: Only teardown interfaces having no proto task when l3_dev link lost

2016-07-14 Thread Hans Dedecker
On Thu, Jul 14, 2016 at 11:20 PM, Felix Fietkau wrote: > On 2016-07-14 23:10, Hans Dedecker wrote: >> Felix, >> >> Currently the xl2tp protocol script registers itself as having >> no_proto_task which is used in proto_shell_task_finish to send a >> teardown wh

[LEDE-DEV] [PATCH 5/5 netifd] utils: Move IP address validation to parse_addr function

2016-08-11 Thread Hans Dedecker
function parse_addr so experimantal/multicast addresses cannot be added as a host IP address while multicast routes can be added again. Signed-off-by: Hans Dedecker --- proto.c | 20 +++- utils.c | 19 +-- 2 files changed, 16 insertions(+), 23 deletions(-) diff

[LEDE-DEV] [PATCH v2 2/5 netifd] proto-shell: Model config parameter "no-proto-task" as a proto flag

2016-08-11 Thread Hans Dedecker
Export the config parameter "no-proto-task" as a proto flag so it's available for other other netifd modules Signed-off-by: Hans Dedecker --- Changes in v2: -PROTO_FLAG_NO_TASK assigned value 0x80 proto-shell.c | 6 +++--- proto.h | 1 + 2 files changed, 4 i

[LEDE-DEV] [PATCH v2 1/5 netifd] proto-shell: Support teardown on layer 3 link loss

2016-08-11 Thread Hans Dedecker
persist state trying to re-establish the link via a hold-off mechanism if layer 3 link loss is detected. Therefore shell handlers can enable via TEARDOWN_ON_L3_LINK_DOWN a proto flag which will teardown the interface when layer 3 link loss is detected Signed-off-by: Hans Dedecker --- Changes in v2

[LEDE-DEV] [PATCH v2 3/5 netifd] proto: Display proto flags when dumping the protocol handlers in ubus

2016-08-11 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- Changes in v2: -Display flag PROTO_FLAG_TEARDOWN_ON_L3_LINK_DOWN proto.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/proto.c b/proto.c index 45eeb4b..3b973d9 100644 --- a/proto.c +++ b/proto.c @@ -567,7 +567,14 @@ proto_dump_handlers(struct

[LEDE-DEV] [PATCH 4/5 netifd] Prevent premature device free in interface_claim_device

2016-08-11 Thread Hans Dedecker
interface_set_device_config can trigger a device free (for example if the device is here only present in a bridge), which renders dev invalid and leads to segfault. Add a lock to prevent this and clean-up the code for readability. Signed-off-by: Gino Peeters Signed-off-by: Hans Dedecker

[LEDE-DEV] [PATCH] procd: uClibc O_PATH backwards compatibility fixes

2016-08-12 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- inittab.c | 4 utils/utils.c | 4 2 files changed, 8 insertions(+) diff --git a/inittab.c b/inittab.c index 6dde11a..ae2c431 100644 --- a/inittab.c +++ b/inittab.c @@ -31,6 +31,10 @@ #include "procd.h" #include "rcS.h" +#if

Re: [LEDE-DEV] [PATCH] procd: uClibc O_PATH backwards compatibility fixes

2016-08-12 Thread Hans Dedecker
Karl P > > > Hans Dedecker wrote: >> Signed-off-by: Hans Dedecker >> --- >> inittab.c | 4 >> utils/utils.c | 4 >> 2 files changed, 8 insertions(+) >> >> diff --git a/inittab.c b/inittab.c >> index 6dde11a..ae2c431 1006

Re: [LEDE-DEV] per-host leasetime odhcpd patch I sent some time back

2016-08-17 Thread Hans Dedecker
On Sun, Aug 14, 2016 at 1:20 AM, Daniel Dickinson wrote: > Hi, > > Just wondering if I missed any questions or comments about the odhcpd > per-host leasetime patch I sent some time ago? I don't recall seeing > anything and I wasn't following the list all that closely for a while > for personal re

[LEDE-DEV] RFC netifd: UCI parameter to sort name servers in resolv.conf.auto

2016-09-05 Thread Hans Dedecker
Hi Felix, Current implementation in netifd writes the dns servers into resolv.conf.auto file based on the order of the interfaces in the interface list which is alphabetical sorted. The resolver, in this case dnsmasq, reads the resolv.conf.auto file and queries the nameserver(s) in the order liste

Re: [LEDE-DEV] RFC netifd: UCI parameter to sort name servers in resolv.conf.auto

2016-09-05 Thread Hans Dedecker
On Mon, Sep 5, 2016 at 1:49 PM, Jo-Philipp Wich wrote: > Hi Hans, > > imho it would also make sense to take any existing metric setting into > account as well. At least I'd expect that if I have a wan1 with metric > 10 and a wan2 with metric 20 that the DNS server entries "inherit" the > same weig

[LEDE-DEV] [PATCH netifd 2/3] interface-ip: DNS name server sorting support in resolv.conf.auto

2016-09-13 Thread Hans Dedecker
over a main and backup interface -Assign priority to IPv6 name servers over IPv4 or vice versa Signed-off-by: Hans Dedecker --- interface-ip.c | 73 +++--- interface.c| 6 + interface.h| 1 + ubus.c | 1 + 4 files changed

[LEDE-DEV] [PATCH netifd 1/3] bridge: Allow setting multicast_fast_leave_option

2016-09-13 Thread Hans Dedecker
saturation on the lan if a new stream is joined as multiple multicast streams are received. Signed-off-by: Hans Dedecker --- device.c | 9 + device.h | 3 +++ system-linux.c | 9 + 3 files changed, 21 insertions(+) diff --git a/device.c b/device.c index fa3d00f

[LEDE-DEV] [PATCH netifd 3/3] interface-event: Don't dequeue hotplug event in case of interface reload event

2016-09-13 Thread Hans Dedecker
interfaces resulting into no hotplug down event for all interfaces. Therefore don't flush the interface hotplug queue in case an interface reload event is observed. Signed-off-by: Hans Dedecker --- interface-event.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/inte

Re: [LEDE-DEV] [PATCH netifd 3/3] interface-event: Don't dequeue hotplug event in case of interface reload event

2016-09-14 Thread Hans Dedecker
On Wed, Sep 14, 2016 at 1:15 PM, Felix Fietkau wrote: > On 2016-09-13 14:33, Hans Dedecker wrote: >> Dropping hotplug event in case of interface reload results into hotplug >> scripts >> not being being run for the interface and thus external actors not being >> i

[LEDE-DEV] [PATCH netifd 3/7] macvlan: Use macvlan as device type name

2016-09-23 Thread Hans Dedecker
Fixes creation of macvlan devices by UCI due to device handlers rework Signed-off-by: Hans Dedecker --- macvlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/macvlan.c b/macvlan.c index 01a48cd..021d394 100644 --- a/macvlan.c +++ b/macvlan.c @@ -254,7 +254,7

[LEDE-DEV] [PATCH netifd 2/7] bridge: Make bridge_device_type static

2016-09-23 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- bridge.c | 2 +- device.h | 1 - wireless.c | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/bridge.c b/bridge.c index 98e237b..8e6c9a6 100644 --- a/bridge.c +++ b/bridge.c @@ -80,7 +80,7 @@ static void bridge_dump_info(struct device

[LEDE-DEV] [PATCH netifd 4/7] tunnel: Use tunnel as device type name

2016-09-23 Thread Hans Dedecker
Fixes creation of tunnel devices by UCI due to device handlers rework Signed-off-by: Hans Dedecker --- tunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tunnel.c b/tunnel.c index 32f3613..3fa3e21 100644 --- a/tunnel.c +++ b/tunnel.c @@ -90,7 +90,7 @@ tunnel_free

[LEDE-DEV] [PATCH netifd 7/7] device: Drop device down event during device release if device gets active again

2016-09-23 Thread Hans Dedecker
when the underlying device is switched during a reload; the alias_set_device function can add a new dependency on the new active device which will put the aliased device in active mode again as the aliased device is already claimed by the interface using it. Signed-off-by: Hans Dedecker

[LEDE-DEV] [PATCH netifd 5/7] vlandev: Register 8021ad and 8021q s device types

2016-09-23 Thread Hans Dedecker
Fixes creation of vlan 8021ad/8021q devices by UCI due to device handlers rework Signed-off-by: Hans Dedecker --- vlandev.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/vlandev.c b/vlandev.c index becaed8..b065c27 100644 --- a/vlandev.c +++ b/vlandev.c

[LEDE-DEV] [PATCH netifd 1/7] device: Move the different device type registrations to the device type file

2016-09-23 Thread Hans Dedecker
While at it; make device_types static if only used in the device type file Signed-off-by: Hans Dedecker --- alias.c | 2 -- bridge.c | 5 + device.c | 15 +-- device.h | 2 -- macvlan.c | 7 ++- tunnel.c | 5 - vlandev.c | 7 ++- 7 files changed, 26

[LEDE-DEV] [PATCH netifd 6/7] vlandev: Rework 8021ad/8021q detection based on vlandevice type

2016-09-23 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- vlandev.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/vlandev.c b/vlandev.c index b065c27..7e46251 100644 --- a/vlandev.c +++ b/vlandev.c @@ -20,14 +20,12 @@ #include "system.h" enum { - VLANDEV

[LEDE-DEV] [RFC netifd] Bridge member name issue when using aliased interface

2016-10-18 Thread Hans Dedecker
Hi Felix, An aliased interface can be specified as bridge member which is usefull in case the underlying device is dynamically created. In case the device is not yet present an empty string will be displayed in the ubus bridge member section as the aliased device ifname has not yet been set; not d

  1   2   3   >