Re: [LEDE-DEV] [PATCH] procd: get rid of putenv usage.

2018-01-23 Thread Rosen Penev
I just realized the original code leaks memory. ld_preload was not freed. On Tue, Jan 23, 2018 at 12:30 PM, Rosen Penev wrote: > setenv is prefered according to POSIX. Also allows staticly allocated strings. > > Saves 200 bytes when stripped. 432 without. > > Signed-off-by: Rosen Penev > --- >

[LEDE-DEV] [PATCH] procd: get rid of putenv usage.

2018-01-23 Thread Rosen Penev
setenv is prefered according to POSIX. Also allows staticly allocated strings. Saves 200 bytes when stripped. 432 without. Signed-off-by: Rosen Penev --- service/instance.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/service/instance.c b/service/instance.c index 12c

Re: [LEDE-DEV] [PATCH] procd: get rid of putenv usage.

2018-01-23 Thread Rosen Penev
On Tue, Jan 23, 2018 at 12:09 AM, Alexandru Ardelean wrote: > On Tue, Jan 23, 2018 at 4:57 AM, Rosen Penev wrote: >> setenv is prefered according to POSIX. Also allows staticly allocated >> strings. >> >> Saves 200 bytes when stripped. 400 without. >> >> Signed-off-by: Rosen Penev >> --- >> se

Re: [LEDE-DEV] [PATCH] procd: get rid of putenv usage.

2018-01-23 Thread Alexandru Ardelean
On Tue, Jan 23, 2018 at 4:57 AM, Rosen Penev wrote: > setenv is prefered according to POSIX. Also allows staticly allocated strings. > > Saves 200 bytes when stripped. 400 without. > > Signed-off-by: Rosen Penev > --- > service/instance.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletion

[LEDE-DEV] [PATCH] procd: get rid of putenv usage.

2018-01-22 Thread Rosen Penev
setenv is prefered according to POSIX. Also allows staticly allocated strings. Saves 200 bytes when stripped. 400 without. Signed-off-by: Rosen Penev --- service/instance.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/service/instance.c b/service/instance.c index 12