On 3 May 2017 at 13:38, Felix Fietkau wrote:
> On 2017-05-03 12:15, Roman Yeryomin wrote:
Simply including a big
functions.sh doesn't say anything and IMO can only be a workaround,
when you don't know what you need. But even now this doesn't work
because there are separate file
On 2017-05-03 12:15, Roman Yeryomin wrote:
>>> Simply including a big
>>> functions.sh doesn't say anything and IMO can only be a workaround,
>>> when you don't know what you need. But even now this doesn't work
>>> because there are separate files in /lib/functions/
>> In this case we're talking a
On 2 May 2017 at 21:47, Felix Fietkau wrote:
> On 2017-05-02 20:31, Roman Yeryomin wrote:
>> On 2 May 2017 at 20:46, Felix Fietkau wrote:
>>> On 2017-05-02 19:32, Roman Yeryomin wrote:
I just want to save maintenance time. As you admit it's already a
clutter. I'm trying to introduce som
On 2017-05-02 20:31, Roman Yeryomin wrote:
> On 2 May 2017 at 20:46, Felix Fietkau wrote:
>> On 2017-05-02 19:32, Roman Yeryomin wrote:
>>> I just want to save maintenance time. As you admit it's already a
>>> clutter. I'm trying to introduce some order.
>>> Actually uci-defaults is another one wh
On 2 May 2017 at 20:46, Felix Fietkau wrote:
> On 2017-05-02 19:32, Roman Yeryomin wrote:
>> I just want to save maintenance time. As you admit it's already a
>> clutter. I'm trying to introduce some order.
>> Actually uci-defaults is another one which doesn't need 90% of
>> functions.sh (it only
On 2017-05-02 19:32, Roman Yeryomin wrote:
> I just want to save maintenance time. As you admit it's already a
> clutter. I'm trying to introduce some order.
> Actually uci-defaults is another one which doesn't need 90% of
> functions.sh (it only needs list_contains).
> I would propose breaking dow
On 2 May 2017 at 19:18, Felix Fietkau wrote:
> On 2017-05-02 17:53, Roman Yeryomin wrote:
>> On 2 May 2017 at 10:25, Felix Fietkau wrote:
>>> board_name already exists, and I've already converted e.g. the lantiq
>>> target to use it directly from functions.sh.
>>> board_model is not used, neither
On 2017-05-02 17:53, Roman Yeryomin wrote:
> On 2 May 2017 at 10:25, Felix Fietkau wrote:
>> board_name already exists, and I've already converted e.g. the lantiq
>> target to use it directly from functions.sh.
>> board_model is not used, neither is the model function from any of the
>> messy copy
On 2 May 2017 at 10:25, Felix Fietkau wrote:
> On 2017-05-02 00:50, Roman Yeryomin wrote:
>> On 30 April 2017 at 12:46, Felix Fietkau wrote:
>>> On 2017-04-28 22:51, Roman Yeryomin wrote:
On 28 April 2017 at 20:12, Felix Fietkau wrote:
> On 2017-04-28 14:56, Roman Yeryomin wrote:
>>
On 2017-05-02 00:50, Roman Yeryomin wrote:
> On 30 April 2017 at 12:46, Felix Fietkau wrote:
>> On 2017-04-28 22:51, Roman Yeryomin wrote:
>>> On 28 April 2017 at 20:12, Felix Fietkau wrote:
On 2017-04-28 14:56, Roman Yeryomin wrote:
> Signed-off-by: Roman Yeryomin
> ---
> pack
On 30 April 2017 at 12:46, Felix Fietkau wrote:
> On 2017-04-28 22:51, Roman Yeryomin wrote:
>> On 28 April 2017 at 20:12, Felix Fietkau wrote:
>>> On 2017-04-28 14:56, Roman Yeryomin wrote:
Signed-off-by: Roman Yeryomin
---
package/base-files/files/lib/functions/board.sh | 17 ++
On 30 April 2017 at 12:44, Felix Fietkau wrote:
> On 2017-04-30 11:23, Bastian Bittorf wrote:
>> * Felix Fietkau [30.04.2017 09:30]:
>>> > +board_name()
>>> > +{
>>> > + sysinfo board_name
>>> > +}
>>> > +
>>> > +board_model()
>>> > +{
>>> > + sysinfo model
>>> > +}
>>
>>> Do we really need boa
On 2017-04-28 22:51, Roman Yeryomin wrote:
> On 28 April 2017 at 20:12, Felix Fietkau wrote:
>> On 2017-04-28 14:56, Roman Yeryomin wrote:
>>> Signed-off-by: Roman Yeryomin
>>> ---
>>> package/base-files/files/lib/functions/board.sh | 17 +
>>> 1 file changed, 17 insertions(+)
>>
On 2017-04-30 11:23, Bastian Bittorf wrote:
> * Felix Fietkau [30.04.2017 09:30]:
>> > +board_name()
>> > +{
>> > + sysinfo board_name
>> > +}
>> > +
>> > +board_model()
>> > +{
>> > + sysinfo model
>> > +}
>
>> Do we really need board_model() at all? I think it's better to leave the
>> board_n
* Felix Fietkau [30.04.2017 09:30]:
> > +board_name()
> > +{
> > + sysinfo board_name
> > +}
> > +
> > +board_model()
> > +{
> > + sysinfo model
> > +}
> Do we really need board_model() at all? I think it's better to leave the
> board_name() function where it is instead of adding this extra i
On 28 April 2017 at 20:12, Felix Fietkau wrote:
> On 2017-04-28 14:56, Roman Yeryomin wrote:
>> Signed-off-by: Roman Yeryomin
>> ---
>> package/base-files/files/lib/functions/board.sh | 17 +
>> 1 file changed, 17 insertions(+)
>> create mode 100644 package/base-files/files/lib/
On 2017-04-28 14:56, Roman Yeryomin wrote:
> Signed-off-by: Roman Yeryomin
> ---
> package/base-files/files/lib/functions/board.sh | 17 +
> 1 file changed, 17 insertions(+)
> create mode 100644 package/base-files/files/lib/functions/board.sh
>
> diff --git a/package/base-files/
Signed-off-by: Roman Yeryomin
---
package/base-files/files/lib/functions/board.sh | 17 +
1 file changed, 17 insertions(+)
create mode 100644 package/base-files/files/lib/functions/board.sh
diff --git a/package/base-files/files/lib/functions/board.sh
b/package/base-files/files/
18 matches
Mail list logo
