[LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-12 Thread Dan Bugnar
From: Dan Bugnar Add logd link to uci library, to read the system config file and get the buffer size. Remove the -S option support and use just the option from the config file. Signed-off-by: Dan Bugnar --- CMakeLists.txt | 2 +- log/logd.c | 60 +

[LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-18 Thread Dan Bugnar
From: Dan Bugnar Add ubus method to set the buffer size. Signed-off-by: Dan Bugnar --- log/logd.c | 28 +++- log/syslog.c | 8 +--- log/syslog.h | 2 +- 3 files changed, 29 insertions(+), 9 deletions(-) diff --git a/log/logd.c b/log/logd.c index 27d3cac..93ca0e

Re: [LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-12 Thread Karl Palsson
Dan Bugnar wrote: > From: Dan Bugnar > > Add logd link to uci library, to read the system config file > and get the buffer size. Remove the -S option support and use > just the option from the config file. Why do you need this exactly? It's already being parsed from the config file by the ini

Re: [LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-12 Thread Karl Palsson
Alexandru Ardelean wrote: > On Thu, May 12, 2016 at 5:30 PM, Karl Palsson > wrote: > > > > > Dan Bugnar wrote: > > > From: Dan Bugnar > > > > > > Add logd link to uci library, to read the system config file > > > and get the buffer size. Remove the -S option support and use > > > just the opt

Re: [LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-12 Thread Alexandru Ardelean
On Thu, May 12, 2016 at 5:49 PM, Karl Palsson wrote: > > Alexandru Ardelean wrote: >> On Thu, May 12, 2016 at 5:30 PM, Karl Palsson >> wrote: >> >> > >> > Dan Bugnar wrote: >> > > From: Dan Bugnar >> > > >> > > Add logd link to uci library, to read the system config file >> > > and get the buf

Re: [LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-12 Thread Karl Palsson
Alexandru Ardelean wrote: > > Changing the log size dynamically at runtime is a use case that > we have. I'm sorry, but can you talk to me like I'm 5? What is this use case? I mean, I can understand it synthetically, like, "If I want to resize the log dynamically, I need to be able to reload t

Re: [LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-12 Thread Alexandru Ardelean
On Fri, May 13, 2016 at 12:14 AM, Karl Palsson wrote: > > Alexandru Ardelean wrote: >> >> Changing the log size dynamically at runtime is a use case that >> we have. > > I'm sorry, but can you talk to me like I'm 5? What is this use > case? I mean, I can understand it synthetically, like, "If I w

Re: [LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-13 Thread Hannu Nyman
On 13.5.2016 9:23, Alexandru Ardelean wrote: Coming back to the patches. Is it a problem with: 1) The UCI C changes ? 2) The dynamic log resize ? 3) The whole thing ? Depending on what the problem is, we can adapt the patchset. Or simply drop the whole thing if it's deemed un-needed by the commu

Re: [LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-13 Thread Conor O'Gorman
On 13/05/16 08:33, Hannu Nyman wrote: On 13.5.2016 9:23, Alexandru Ardelean wrote: Coming back to the patches. Is it a problem with: 1) The UCI C changes ? 2) The dynamic log resize ? 3) The whole thing ? Depending on what the problem is, we can adapt the patchset. Or simply drop the whole th

Re: [LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-13 Thread Conor O'Gorman
On 13/05/16 07:23, Alexandru Ardelean wrote: Short version is: we have a configuration management system on top of OpenWrt ; system boots with default settings (on every boot), and config management applies config changes (whether it's right after boot, or during system's normal operation). Mayb

Re: [LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-13 Thread Bastian Bittorf
* Conor O'Gorman [13.05.2016 11:52]: > On 13/05/16 07:23, Alexandru Ardelean wrote: > >Short version is: we have a configuration management system on top of > >OpenWrt ; system boots with default settings (on every boot), and > >config management applies config changes (whether it's right after >

Re: [LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-13 Thread Helmut Schaa
On Fri, May 13, 2016 at 12:03 PM, Bastian Bittorf wrote: > * Conor O'Gorman [13.05.2016 11:52]: >> On 13/05/16 07:23, Alexandru Ardelean wrote: >> >Short version is: we have a configuration management system on top of >> >OpenWrt ; system boots with default settings (on every boot), and >> >confi

Re: [LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-13 Thread David Lang
On Fri, 13 May 2016, Helmut Schaa wrote: On Fri, May 13, 2016 at 12:03 PM, Bastian Bittorf wrote: * Conor O'Gorman [13.05.2016 11:52]: On 13/05/16 07:23, Alexandru Ardelean wrote: Short version is: we have a configuration management system on top of OpenWrt ; system boots with default setti

Re: [LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-13 Thread Alexandru Ardelean
On Fri, May 13, 2016 at 8:55 PM, David Lang wrote: > On Fri, 13 May 2016, Helmut Schaa wrote: > >> On Fri, May 13, 2016 at 12:03 PM, Bastian Bittorf >> wrote: >>> >>> * Conor O'Gorman [13.05.2016 11:52]: On 13/05/16 07:23, Alexandru Ardelean wrote: > > Short version is: we have

Re: [LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-13 Thread Felix Fietkau
On 2016-05-12 14:09, Dan Bugnar wrote: > From: Dan Bugnar > > Add logd link to uci library, to read the system config file and get the > buffer size. > Remove the -S option support and use just the option from the config file. > > Signed-off-by: Dan Bugnar I'd prefer a change where logd provid

Re: [LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-13 Thread David Lang
On Fri, 13 May 2016, Alexandru Ardelean wrote: On Fri, May 13, 2016 at 8:55 PM, David Lang wrote: On Fri, 13 May 2016, Helmut Schaa wrote: I was thinking of a different use-case: Increasing the buffer size on the fly comes in handy during a debug session where you'd like to not interrupt logg

Re: [LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-14 Thread John Crispin
On 12/05/2016 14:09, Dan Bugnar wrote: > From: Dan Bugnar > > Add logd link to uci library, to read the system config file and get the > buffer size. > Remove the -S option support and use just the option from the config file. > > Signed-off-by: Dan Bugnar NAK, logd should not get a depende

Re: [LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-14 Thread John Crispin
On 13/05/2016 22:40, David Lang wrote: > On Fri, 13 May 2016, Alexandru Ardelean wrote: > >> On Fri, May 13, 2016 at 8:55 PM, David Lang wrote: >>> On Fri, 13 May 2016, Helmut Schaa wrote: I was thinking of a different use-case: Increasing the buffer size on the fly comes in handy dur

Re: [LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

2016-05-15 Thread Helmut Schaa
On Fri, May 13, 2016 at 7:55 PM, David Lang wrote: > On Fri, 13 May 2016, Helmut Schaa wrote: >> I was thinking of a different use-case: >> Increasing the buffer size on the fly comes in handy during a debug >> session >> where you'd like to not interrupt logging (and thus potentially lose some >>