Re: [LEDE-DEV] [PATCH 2/3] procd: Don't use syslog before its initialization

2017-03-11 Thread Michal Sojka
Hi David, I understand what you're saying and you are right that there can be a lot of problems (e.g. hangs) due logging. Some comments below. On Sat, Mar 11 2017, David Lang wrote: > On Sat, 11 Mar 2017, Michal Sojka wrote: > >> On Sat, Mar 11 2017, John Crispin wrote: >>> On 11/03/17 01:48, Mic

Re: [LEDE-DEV] [PATCH 2/3] procd: Don't use syslog before its initialization

2017-03-11 Thread Michal Sojka
On Sat, Mar 11 2017, Michal Sojka wrote: > On Sat, Mar 11 2017, John Crispin wrote: >> On 11/03/17 01:48, Michal Sojka wrote: >>> When procd starts a rcS script, it captures its stdout and stderr and >>> logs them to syslog. It could happen (and I don't know exactly why), >>> that a rcS scripts pro

Re: [LEDE-DEV] [PATCH 2/3] procd: Don't use syslog before its initialization

2017-03-11 Thread David Lang
On Sat, 11 Mar 2017, Michal Sojka wrote: On Sat, Mar 11 2017, John Crispin wrote: On 11/03/17 01:48, Michal Sojka wrote: When procd starts a rcS script, it captures its stdout and stderr and logs them to syslog. It could happen (and I don't know exactly why), that a rcS scripts produces some o

Re: [LEDE-DEV] [PATCH 2/3] procd: Don't use syslog before its initialization

2017-03-11 Thread Michal Sojka
On Sat, Mar 11 2017, John Crispin wrote: > On 11/03/17 01:48, Michal Sojka wrote: >> When procd starts a rcS script, it captures its stdout and stderr and >> logs them to syslog. It could happen (and I don't know exactly why), >> that a rcS scripts produces some output before openlog() is called in

Re: [LEDE-DEV] [PATCH 2/3] procd: Don't use syslog before its initialization

2017-03-10 Thread John Crispin
On 11/03/17 01:48, Michal Sojka wrote: When procd starts a rcS script, it captures its stdout and stderr and logs them to syslog. It could happen (and I don't know exactly why), that a rcS scripts produces some output before openlog() is called in procd. The result is that all subsequent logs f

[LEDE-DEV] [PATCH 2/3] procd: Don't use syslog before its initialization

2017-03-10 Thread Michal Sojka
When procd starts a rcS script, it captures its stdout and stderr and logs them to syslog. It could happen (and I don't know exactly why), that a rcS scripts produces some output before openlog() is called in procd. The result is that all subsequent logs from procd are logged with ident and PID of