Re: [LEDE-DEV] [PATCH odhcpd] dhcpv4: notify DHCP ack messages via ubus

2017-11-28 Thread Borja Salazar
Hi, I will send a V2 patch. Thanks On Tue, Nov 28, 2017 at 8:36 AM, Hans Dedecker wrote: > On Mon, Nov 27, 2017 at 11:12 AM, Borja Salazar wrote: >> Hi, >> >> Our company is currently developing a service for controlling routers >> via ubus methods from a server. We also would like to received a

Re: [LEDE-DEV] [PATCH odhcpd] dhcpv4: notify DHCP ack messages via ubus

2017-11-27 Thread Hans Dedecker
On Mon, Nov 27, 2017 at 11:12 AM, Borja Salazar wrote: > Hi, > > Our company is currently developing a service for controlling routers > via ubus methods from a server. We also would like to received and > handle different notification from the device, so we would like to > send as many events as

Re: [LEDE-DEV] [PATCH odhcpd] dhcpv4: notify DHCP ack messages via ubus

2017-11-27 Thread Borja Salazar
Hi, Our company is currently developing a service for controlling routers via ubus methods from a server. We also would like to received and handle different notification from the device, so we would like to send as many events as possible. Currently there is already a patch for dnsmasq that provi

Re: [LEDE-DEV] [PATCH odhcpd] dhcpv4: notify DHCP ack messages via ubus

2017-11-27 Thread Hans Dedecker
On Fri, Nov 24, 2017 at 11:56 AM, Borja Salazar wrote: > Signed-off-by: Borja Salazar Hi, Could you describe why you want an ubus event per sent DHCP ack message as potentially this could generate a lot of ubus traffic depending on the leasetime and number of connected clients. Depending on your

Re: [LEDE-DEV] [PATCH odhcpd] dhcpv4: notify DHCP ack messages via ubus

2017-11-24 Thread Kevin Darbyshire-Bryant
> On 24 Nov 2017, at 10:56, Borja Salazar wrote: > > Signed-off-by: Borja Salazar > --- > src/dhcpv4.c | 8 > src/odhcpd.h | 1 + > src/ubus.c | 19 +++ > 3 files changed, 28 insertions(+) I suspect people are going to want to see a patch description as well as a r

[LEDE-DEV] [PATCH odhcpd] dhcpv4: notify DHCP ack messages via ubus

2017-11-24 Thread Borja Salazar
Signed-off-by: Borja Salazar --- src/dhcpv4.c | 8 src/odhcpd.h | 1 + src/ubus.c | 19 +++ 3 files changed, 28 insertions(+) diff --git a/src/dhcpv4.c b/src/dhcpv4.c index 166582e..ad8d338 100644 --- a/src/dhcpv4.c +++ b/src/dhcpv4.c @@ -870,6 +870,14 @@ static void