Re: [Ledger-smb-devel] Code formatting discussion/proposal

2015-07-06 Thread Chris Travers
On Mon, Jul 6, 2015 at 8:54 AM, Chris Bennett wrote: > On Mon, Jul 06, 2015 at 12:04:59PM +0200, Erik Huelsmann wrote: > > Hi all, > > > > I'm going through our code quite randomly at the moment while > investigating > > the multi-currency changes. > > > > What stands out at me is that we have: >

[Ledger-smb-devel] I have subscribed

2015-07-06 Thread Samuel Nicholas
Hi Erik, I am ready to begin -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your bu

Re: [Ledger-smb-devel] Code formatting discussion/proposal

2015-07-06 Thread Chris Bennett
On Mon, Jul 06, 2015 at 12:04:59PM +0200, Erik Huelsmann wrote: > Hi all, > > I'm going through our code quite randomly at the moment while investigating > the multi-currency changes. > > What stands out at me is that we have: > > * different indenting methods (tabs vs spaces) > * different in

Re: [Ledger-smb-devel] Code formatting discussion/proposal

2015-07-06 Thread Michael Richardson
Erik Huelsmann wrote: > I'm sorry, but it's starting to disturb me (quite a bit). So, here's my > proposal: > * We remove all tabs from the code base in one huge commit (except for > Makefile) Yes, and nuke trailing whitespace too. > * From there on, we watch out not to add

Re: [Ledger-smb-devel] Code formatting discussion/proposal

2015-07-06 Thread Erik Huelsmann
Hi Chris, I've re-organized the page documenting our Perl coding requirements: http://ledgersmb.org/topic/perl-coding-guidelines Feel free to further edit as you see fit. Regards, Erik. On Mon, Jul 6, 2015 at 1:26 PM, Chris Travers wrote: > Two brief comments > > On Mon, Jul 6, 2015 at

Re: [Ledger-smb-devel] Code formatting discussion/proposal

2015-07-06 Thread Chris Travers
Two brief comments On Mon, Jul 6, 2015 at 3:04 AM, Erik Huelsmann wrote: > Hi all, > > I'm going through our code quite randomly at the moment while > investigating the multi-currency changes. > > What stands out at me is that we have: > > * different indenting methods (tabs vs spaces) > *

[Ledger-smb-devel] Code formatting discussion/proposal

2015-07-06 Thread Erik Huelsmann
Hi all, I'm going through our code quite randomly at the moment while investigating the multi-currency changes. What stands out at me is that we have: * different indenting methods (tabs vs spaces) * different intenting styles (2, 3, 4+ spaces) * different widths: 80 on most files, but I've