Re: Unicode cleanup: g.u and the new g.ue

2009-12-20 Thread Ville M. Vainio
On Sun, Dec 20, 2009 at 11:22 PM, Edward K. Ream > def u(s,encoding='utf-8'): >    '''Convert the string s to unicode if necessary.''' >    if g.isUnicode(s): >        return s Is'n this check redundant? unicode(s) => s, if is is unicode. I still think a much faster way would be to check for py

Re: Vote for bugs you urgently want fixed

2009-12-20 Thread Rob Sheppard
Edward K. Ream wrote, On 12/18/2009 9:14 AM: > Per a recent suggestion, please vote here if there is a bug at > > https://bugs.launchpad.net/leo-editor/+bugs > > that is causing you *severe* and *practical* discomfort. Please don't > list your priorities: they won't be useful, but if there is so

Re: Wave invites available

2009-12-20 Thread Matt Wilkie
I sent one out for you Raj I still have a few to spare. cheers, -- -matt -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To post to this group, send email to leo-edi...@googlegroups.com. To unsubscribe from this group, send email to leo-editor

Re: BUG: improper handling of encodings in trunk

2009-12-20 Thread Edward K. Ream
On Sun, Dec 20, 2009 at 4:29 PM, zpcspm wrote: > My point is that when a certain version is released as stable, that > revision is usually tagged in version control. So if later a big > change is initiated, then something gets broken in the trunk and is > noticed only after some further commits (

Re: BUG: improper handling of encodings in trunk

2009-12-20 Thread zpcspm
On Dec 20, 11:33 pm, "Edward K. Ream" wrote: > The new, slightly risky, code is on the trunk at rev 2529. Did 'bzr pull' and tested the trunk again with a simple outline by following the above steps. Everything is OK, so presumably r2529 didn't break anything that worked in r2528 and before the b

Re: BUG: improper handling of encodings in trunk

2009-12-20 Thread Edward K. Ream
On Dec 20, 2:56 pm, "Edward K. Ream" wrote: > At the risk of another breakage, I plan to simplify the code again. > I'll let everyone know before I push any code. The new, slightly risky, code is on the trunk at rev 2529. Please let me know if there are any kinds of unicode problems with this

Re: BUG: improper handling of encodings in trunk

2009-12-20 Thread zpcspm
On Dec 20, 11:14 pm, "Edward K. Ream" wrote: > On Sun, Dec 20, 2009 at 3:14 PM, zpcspm wrote: > > I wonder if making a major stable release of leo just > > before starting to merge python 3.x stuff into the trunk could be a > > better strategy. Since you already started it, feel free to continue

Unicode cleanup: g.u and the new g.ue

2009-12-20 Thread Edward K. Ream
I plan to simplify g.u and introduce a new g.ue method. This follows Ville's suggestion. In the new scheme, g.u calls str or unicode with *no* encoding, g.ue calls str or unicode with a *mandatory* encoding. Experience shows that it is not possible to dispense with g.ue entirely: there are places

Re: BUG: improper handling of encodings in trunk

2009-12-20 Thread Edward K. Ream
On Sun, Dec 20, 2009 at 3:14 PM, zpcspm wrote: > I wonder if making a major stable release of leo just > before starting to merge python 3.x stuff into the trunk could be a > better strategy. Since you already started it, feel free to continue > and consider this an option for the future. I don'

Re: BUG: improper handling of encodings in trunk

2009-12-20 Thread zpcspm
On Dec 20, 9:56 pm, "Edward K. Ream" wrote: > Have you tried Leo using Python 3.x? No. Actually, I've never used Python 3.x yet. Perhaps I'm too biased towards the missing backward compatibility with 2.x. > At the risk of another breakage, I plan to simplify the code again. Not a problem for me

Re: BUG: improper handling of encodings in trunk

2009-12-20 Thread Edward K. Ream
On Sun, Dec 20, 2009 at 2:40 PM, zpcspm wrote: > Thanks, it seems to be ok now. Excellent. Please let me know if you have any further problems. Have you tried Leo using Python 3.x? At the risk of another breakage, I plan to simplify the code again. I'll let everyone know before I push any cod

Re: BUG: improper handling of encodings in trunk

2009-12-20 Thread zpcspm
> > Rev 2528 of the trunk attempts to make the trunk equivalent (for > > Python 2.x) to the trunk before the big merge.  This affects qtGui.py, > > leoAtFile.py and leoFileCommands.py.  There actually weren't all that > > many changes ever made, so it should be possible to fix this > > eventually.

Re: BUG: improper handling of encodings in trunk

2009-12-20 Thread zpcspm
On Dec 20, 9:25 pm, "Edward K. Ream" wrote: > Are you using Python 2.x or Python 3.x? 2.6 as I wrote in the first post. > Rev 2528 of the trunk attempts to make the trunk equivalent (for > Python 2.x) to the trunk before the big merge.  This affects qtGui.py, > leoAtFile.py and leoFileCommands.py

Re: BUG: improper handling of encodings in trunk

2009-12-20 Thread Edward K. Ream
On Sun, Dec 20, 2009 at 2:15 PM, zpcspm wrote: > My outline has no Python files. It has no external files at all. The > issues happen inside bodies of regular nodes in the outline. Ok. That eliminates leoAtFile.py. > It is very simple to reproduce the issue with a trivial outline: [snip] Are

Re: BUG: improper handling of encodings in trunk

2009-12-20 Thread zpcspm
On Dec 20, 8:18 pm, "Edward K. Ream" wrote: > What is the first line of your .leo file?  My .leo files start with: > > Same here. Always was like that. Leo used to convert fine everything Russian (non-ascii) to utf-8 when writing to the outline xml file. Yesterday everything was well. I'm prett

Re: BUG: improper handling of encodings in trunk

2009-12-20 Thread Edward K. Ream
On Dec 20, 12:02 pm, zpcspm wrote: > The latest trunk (r2525) has issues with proper string encoding > handling. I do 'bzr pull' on a daily basis, so it must be caused by > something that was pushed during the last 24-36 hours. Do you use: @first # -*- coding: utf-8 -*- (or the Russian equiva

Re: Vote for bugs you urgently want fixed

2009-12-20 Thread zpcspm
My biggest annoyance is the invalid bug 409442, I have to use the tk GUI because of it. I've also complained about it in this thread: http://groups.google.com/group/leo-editor/browse_thread/thread/07cdbb9ce1d3dba4# -- You received this message because you are subscribed to the Google Groups "le

BUG: improper handling of encodings in trunk

2009-12-20 Thread zpcspm
The latest trunk (r2525) has issues with proper string encoding handling. I do 'bzr pull' on a daily basis, so it must be caused by something that was pushed during the last 24-36 hours. Presumably it's the big leo3k commit, but it looks too huge for me to investigate it deeper. I've noticed this

Re: Vote for bugs you urgently want fixed

2009-12-20 Thread Terry Brown
On Sun, 20 Dec 2009 06:19:41 -0800 (PST) TL wrote: > Bug 362950: during body text undo selection goes nuts and view moves +1 Cheers -Terry -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To post to this group, send email to leo-edi...@googlegr

Re: Vote for bugs you urgently want fixed

2009-12-20 Thread TL
The following "undo" functionality should be fixed: Bug 498692: Undo deleted node renames current node's headline Bug 498688: Undo back to last saved content still shows file as modified ("*" in title) Bug 362950: during body text undo selection goes nuts and view moves TL -- You received this

Re: Merge of leo-3k branch coming soon. Please hold commits

2009-12-20 Thread Kent Tenney
On Sun, Dec 20, 2009 at 7:35 AM, Edward K. Ream wrote: > On Sun, Dec 20, 2009 at 7:24 AM, Kent Tenney wrote: > >>  File "/home/ktenney/work/download/leo-editor/leo/core/leoPlugins.py", >> line 723, in __call__ >>    except TryNext(exc): >> NameError: global name 'exc' is not defined > > Thanks fo

Re: Merge of leo-3k branch coming soon. Please hold commits

2009-12-20 Thread Edward K. Ream
On Sun, Dec 20, 2009 at 5:04 AM, VR wrote: > BTW, what is the recommended way to report problems now? - Still > informal reports like this one - or - a bug-report via Launchpad? Please make the reports here, not on Launchpad. I'll fix all bugs reported on this thread immediately. Edward -- Y

Re: Merge of leo-3k branch coming soon. Please hold commits

2009-12-20 Thread Edward K. Ream
On Sun, Dec 20, 2009 at 5:04 AM, VR wrote: > Using rev 2521 the following unnecessary directory is created, when > 'building' the documentation locally: > created directory: C:\leo-editor\leo\doc\directives that are in > ancestors of node p. If p is any kind of @file node A strange directory na

Re: Merge of leo-3k branch coming soon. Please hold commits

2009-12-20 Thread Edward K. Ream
On Sun, Dec 20, 2009 at 7:24 AM, Kent Tenney wrote: >  File "/home/ktenney/work/download/leo-editor/leo/core/leoPlugins.py", > line 723, in __call__ >    except TryNext(exc): > NameError: global name 'exc' is not defined Thanks for this report. The fix is on the trunk at rev 2523. This was a r

Re: Merge of leo-3k branch coming soon. Please hold commits

2009-12-20 Thread Edward K. Ream
On Sun, Dec 20, 2009 at 4:48 AM, VR wrote: > On 19 Dez., 19:02, "Edward K. Ream" wrote: >> On Dec 19, 10:04 am, "Edward K. Ream" wrote: >> >> > I'd like to merge the leo-3k branch into the trunk today.  Please hold >> > commits to the trunk until further notice. >> >> Rev 2519 of the trunk now c

Re: Merge of leo-3k branch coming soon. Please hold commits

2009-12-20 Thread Edward K. Ream
On Sun, Dec 20, 2009 at 4:48 AM, VR wrote: > On 19 Dez., 19:02, "Edward K. Ream" wrote: >> On Dec 19, 10:04 am, "Edward K. Ream" wrote: >> >> > I'd like to merge the leo-3k branch into the trunk today.  Please hold >> > commits to the trunk until further notice. >> >> Rev 2519 of the trunk now c

Re: Merge of leo-3k branch coming soon. Please hold commits

2009-12-20 Thread Kent Tenney
On Sat, Dec 19, 2009 at 12:02 PM, Edward K. Ream wrote: > > On Dec 19, 10:04 am, "Edward K. Ream" wrote: >> I'd like to merge the leo-3k branch into the trunk today.  Please hold >> commits to the trunk until further notice. > > Rev 2519 of the trunk now contains the merged leo-3k branch. > > All

Re: Merge of leo-3k branch coming soon. Please hold commits

2009-12-20 Thread VR
On 19 Dez., 19:02, "Edward K. Ream" wrote: > On Dec 19, 10:04 am, "Edward K. Ream" wrote: > > > I'd like to merge the leo-3k branch into the trunk today.  Please hold > > commits to the trunk until further notice. > > Rev 2519 of the trunk now contains the merged leo-3k branch. > > All important

Re: Merge of leo-3k branch coming soon. Please hold commits

2009-12-20 Thread VR
On 19 Dez., 19:02, "Edward K. Ream" wrote: > On Dec 19, 10:04 am, "Edward K. Ream" wrote: > > > I'd like to merge the leo-3k branch into the trunk today.  Please hold > > commits to the trunk until further notice. > > Rev 2519 of the trunk now contains the merged leo-3k branch. > > All important