Re: Cleaning up the worst pep8 offenses

This passed off the port bow this evening: https://github.com/hayd/pep8radius. I like the approach, applying pep8 only in the vicinity of where one has recently been working. On Sun, Nov 19, 2017 at 6:31 PM, Edward K. Ream wrote: > > > On Sun, Nov 19, 2017 at 5:09 PM, Terry

Re: ENB: Discussion of the fix to #579 re key bindings

On Sun, Nov 19, 2017 at 10:30 AM, Terry Brown wrote: I wonder what impact more use of signals would have in terms of > coupling in Leo. ​So do I. For now, I think the existing settings code, complicated though it is, is good enough. But I welcome any and all real

Re: Cleaning up the worst pep8 offenses

On Sun, Nov 19, 2017 at 5:09 PM, Terry Brown wrote: > > > > I have just created #584: clean up the worst pep8 offenses > > . > ​​ > > > I occasionally fix PEP 8 things when I see them, missing spaces after > commas

Re: Cleaning up the worst pep8 offenses

On Sun, 19 Nov 2017 09:35:24 -0800 (PST) "Edward K. Ream" wrote: > I have just created #584 #584: clean up the worst pep8 offenses > . > > I welcome all comments. If you do have comments or suggestions, > please make

Re: 65db25e removes one hard binding to Ctrl-Shift-F in quicksearch plugin

On Sun, Nov 19, 2017 at 11:00 AM, Terry Brown wrote: Maybe this should be bound in leoSettings.leo - its demise caused a lot > of concern last time. > ​Done at c2ccc2. The checkin log:​ Added find-quick-selected = Ctrl-Shift-F to leoSettings.leo, in the node: Keyboard

Cleaning up the worst pep8 offenses

I have just created #584 #584: clean up the worst pep8 offenses . I welcome all comments. If you do have comments or suggestions, please make them *here*, not in the issue itself. Edward -- You received this message because you are

Re: 65db25e removes one hard binding to Ctrl-Shift-F in quicksearch plugin

On Sun, 19 Nov 2017 08:49:31 -0800 (PST) "Edward K. Ream" wrote: > Rev 65db25e removes this hard binding in quicksearch.py plugin: > > find-quick-selected = Ctrl-Shift-F > > My by-hand tests indicate that all aspects of #579 >

65db25e removes one hard binding to Ctrl-Shift-F in quicksearch plugin

Rev 65db25e removes this hard binding in quicksearch.py plugin: find-quick-selected = Ctrl-Shift-F My by-hand tests indicate that all aspects of #579 work as expected, so if you want this binding you should define it in

Re: ENB: Discussion of the fix to #579 re key bindings

On Sun, 19 Nov 2017 07:12:56 -0800 (PST) vitalije wrote: > I am guessing that a call to make bindings is not placed > where it naturally belongs and I am not referring to a > file/class/location but rather about its time location. I wonder what impact more use of signals

The new EKR label

I have just added an EKR label for Leo's issues . This is definitely not the same as the author:edreamleo filter. Instead, it denotes issues that I created on my own behalf and have high priority for me. It's a valuable personalized new view.

Re: Remove top-level docs folder?

On Sun, Nov 19, 2017 at 7:36 AM, Matt Wilkie wrote: > +1. GitHub docs say to use a special branch or repo for web pages anyway. > ​Thanks. I have created #583 for this. Edward -- You received this message because you

Re: ENB: Discussion of the fix to #579 re key bindings

On Sun, Nov 19, 2017 at 9:12 AM, vitalije wrote: It was you Edward, who were not fully satisfied with your new solution that > sometimes unnecessary repeats a call to makeAllBindings. > ​And now I am. Better, for the first time I know why I am satisfied and what the

Re: New g.gitDescribe() function

On Sun, Nov 19, 2017 at 7:33 AM, Matt Wilkie wrote: For what it's worth, this looks decent: https://bitbucket.org/ > th3l0nius/gitdiscribe/. Or at least I see how to use it immediately, > unlike setuptools_scm. (A bookmark for future use, should g.gitDescribe > need

Re: ENB: Discussion of the fix to #579 re key bindings

Without any wish to insist on any design principle, let me say this. (I still haven't look at the code and former warning still applies.) I fully agree that calling makeAllBindings from plugins manager, would be a bad idea. Yet, the call doesn't have to be placed inside plugins manager. I

Re: PyPi: package name

Ok, thank you for your opinions. I'll use {tag}.dev{distance} . matt -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To

Re: Remove top-level docs folder?

+1. GitHub docs say to use a special branch or repo for web pages anyway. -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com.

Re: New g.gitDescribe() function

> > ​How could g.gitDescribe possibly be objectionable? A PR is kinda > overkill, imo. It's a new function, so just push it to master.​ > Simply because I've never touched anything in core before and I don't know what bits do what. ;-) Thanks for the vote of confidence (and I realize that's

Re: ENB: Discussion of the fix to #579 re key bindings

On Sun, Nov 19, 2017 at 5:33 AM, Edward K. Ream wrote: Leo's design is sound, flexible and robust because: > > 1. Classes knows nothing about any other class. > > 2. There is a single *command method* for each Leo command, and that > method is responsible for *all*

Re: ENB: Discussion of the fix to #579 re key bindings

On Saturday, November 18, 2017 at 9:20:31 AM UTC-6, Edward K. Ream wrote: On Saturday, November 18, 2017 at 6:58:46 AM UTC-6, vitalije wrote: > > Your questions and suggestions are excellent, and show deep understanding > of the code. However, I think the present code, even with its flaws, is