Re: github team member changes

2020-05-08 Thread Edward K. Ream
On Fri, May 8, 2020 at 1:34 AM Matt Wilkie wrote: > Hello Leo Devs, > > I've been working with Github Support and Edward on sorting out why Thomas > is having troubles pushing code changes to the Leo-editor repository on > Github. We may be near to solving that, but that's not the purpose of this

Re: Qt-prototype report and some thoughts about executeScript command

2020-05-08 Thread Edward K. Ream
On Thursday, May 7, 2020 at 1:42:24 PM UTC-5, vitalije wrote: First of all I must say that testing with hypothesis is really great way to > discover hidden bugs. > I am going to start by studying hypothesis. It looks like a great idea. I'll defer further work on unit testing until I see what y

Re: Qt-prototype report and some thoughts about executeScript command

2020-05-08 Thread Edward K. Ream
On Thu, May 7, 2020 at 2:27 PM vitalije wrote: QTreeWidgetItem class has a clone method which runs quite fast. > Wow. I didn't know that. Sounds like a great fit for the new code. > Cloning entire tree using this method is not problem at all. The problem > is that if a script changes vnodes we

ENB: Qt-prototype is finished

2020-05-08 Thread vitalije
The revision 00bda92 contains improved test and a new command execute_script. As Brian suggested in another thread I have changed the strategy for performing hypothesis tests. Now test chooses a sequence

Re: ENB: Qt-prototype is finished

2020-05-08 Thread Thomas Passin
Very nicely done! I would favor adapting prototype constructs into Leo. Any other way would mean that the new branches would be need to catch up to the rest of Leo as it evolves. Continual catch-up has been a problem for some other projects (more complicated than Leo, no doubt). It's possibl

Re: Push to Leo Repo Failed with error:Protected branch update failed for refs/heads/devel.

2020-05-08 Thread Thomas Passin
On Friday, May 8, 2020 at 2:36:47 AM UTC-4, Matt Wilkie wrote: > > Thomas I made some more Leo Editor org and member changes. Please try > pushing again, with a new file that doesn't already exist in the repo. > > -matt > I created a new branch tbp-test in the Leo repo. I fetched it and checked

Re: Push to Leo Repo Failed with error:Protected branch update failed for refs/heads/devel.

2020-05-08 Thread Edward K. Ream
On Fri, May 8, 2020 at 8:49 AM Thomas Passin wrote: After cruising through some of the settings for repo on Github, I see that > there is a branch protection rule on the devel branch. It requires CI as a > status check before merging. I don't know how to work with that in terms > of pushing and

Re: Push to Leo Repo Failed with error:Protected branch update failed for refs/heads/devel.

2020-05-08 Thread Thomas Passin
On Friday, May 8, 2020 at 10:56:25 AM UTC-4, Edward K. Ream wrote: > > > > On Fri, May 8, 2020 at 8:49 AM Thomas Passin > wrote: > > After cruising through some of the settings for repo on Github, I see that >> there is a branch protection rule on the devel branch. It requires CI as a >> status

Re: ENB: Qt-prototype is finished

2020-05-08 Thread Brian Theado
Vitalije On Fri, May 8, 2020 at 7:51 AM vitalije wrote: > As Brian suggested in another thread I have changed the strategy for > performing hypothesis tests. Now test chooses a sequence of commands > excluding undo and redo commands. After each command if the outline has > changed, test will che

Re: ENB: Qt-prototype is finished

2020-05-08 Thread vitalije
Good catch that was a typo that I fixed but forgot to push. The revision 58e901e57d contains the fix. Vitalije -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo

Re: Push to Leo Repo Failed with error:Protected branch update failed for refs/heads/devel.

2020-05-08 Thread Thomas Passin
And finally, I succeeded in pushing the latest version of VR3 to Leo's devel branch. Thanks so much to Matt and everyone who helped get this straightened out. The main changes to VR3 were to correctly find executables like asciidoc3 that were not getting found on Windows. It turns out that a