Re: @button for displaying all parents of a clone to log pane

2019-10-12 Thread Edward K. Ream
On Sat, Oct 12, 2019 at 8:53 AM Brian Theado wrote: But vnode2allPositions is used in the leo-editor by the method > c.cloneFindParents. The vnode2allPositions method has this in its doc > string: > > "Not really all, just all for each of v's distinct immediate parents." > > > I'm guessing it doe

Re: @button for displaying all parents of a clone to log pane

2019-10-12 Thread SegundoBob
On Saturday, October 12, 2019 at 6:53:41 AM UTC-7, btheado wrote: > > > But vnode2allPositions is used in the leo-editor by the method > c.cloneFindParents. > I missed the restructuring of the Leo-Editor core code that created the separate commands directory. My copy of LeoPyRef.leo was out

Re: @button for displaying all parents of a clone to log pane

2019-10-12 Thread Brian Theado
SegundoBob, > You give a correct implementation of vnode2allPositions(). [...] > The implementation of vnode2allPositions() in leoCommand.py is seriously flawed [...] > But vnode2allPositions() is not used by Leo-Editor core But vnode2allPositions is used in the leo-editor by the method c.cloneFi

Re: @button for displaying all parents of a clone to log pane

2019-10-11 Thread SegundoBob
btheado , On Thursday, October 10, 2019 at 4:08:06 AM UTC-7, btheado wrote: > > I've been thinking about this a lot and I've come to the conclusion that > there should be a separate command that will display all the clone > po

Re: @button for displaying all parents of a clone to log pane

2019-10-10 Thread Edward K. Ream
On Thu, Oct 10, 2019 at 12:19 PM Brian Theado wrote: > > I confess that I find both commands confusing, but I'll leave them in. >> > > Thanks for the feedback. Do you mean you find the output confusing or how > to use it confusing or confusing why it would be useful? > All of the above. For me,

Re: @button for displaying all parents of a clone to log pane

2019-10-10 Thread Brian Theado
Edward, On Thu, Oct 10, 2019 at 12:36 PM Edward K. Ream wrote: [...] > Done at 5e0117d, if I understand you correctly. > Thanks! > I confess that I find both commands confusing, but I'll leave them in. > Thanks for the feedback. Do you mean you find the output confusing or how to use it conf

Re: @button for displaying all parents of a clone to log pane

2019-10-10 Thread Edward K. Ream
On Thu, Oct 10, 2019 at 6:08 AM Brian Theado wrote: > I've been thinking about this a lot and I've come to the conclusion that > there should be a separate command that will display all the clone > positions of a given node. Maybe the original could be renamed from > 'show-clones' to 'show-clone-

Re: @button for displaying all parents of a clone to log pane

2019-10-10 Thread Brian Theado
I've been thinking about this a lot and I've come to the conclusion that there should be a separate command that will display all the clone positions of a given node. Maybe the original could be renamed from 'show-clones' to 'show-clone-parents' and this one could be called 'show-clone-ancestors'

Re: @button for displaying all parents of a clone to log pane

2019-10-08 Thread Brian Theado
In my previous email I was pointing the finger at g.handleUnl doing something wrong for SegundoBob's use case. However, I played with that a little bit and it seems to handle links to clones with the same parent just fine. Now I'm suspecting c.vnode2allPositions is not appropriate for the use case.

Re: @button for displaying all parents of a clone to log pane

2019-10-08 Thread Edward K. Ream
On Mon, Oct 7, 2019 at 5:49 PM Segundo Bob wrote: Brian is right. Edward, I think your fix does not fix the problem. > Please let me know what code you want, and i'll put it in. Better yet, you could do it yourself. Edward -- You received this message because you are subscribed to the Googl

Re: @button for displaying all parents of a clone to log pane

2019-10-07 Thread Segundo Bob
On 10/7/19 3:23 PM, Brian Theado wrote: > You interpreted SegundoBob's request differently, than I did. I was > thinking he didn't mind that the duplicates are there (and maybe prefers > it?), just that he wanted the displayed links go to the separate > instances of the clones. > Brian is right.

Re: @button for displaying all parents of a clone to log pane

2019-10-07 Thread Brian Theado
Thanks, Edward for putting this code into the core as a command. You interpreted SegundoBob's request differently, than I did. I was thinking he didn't mind that the duplicates are there (and maybe prefers it?), just that he wanted the displayed links go to the separate instances of the clones. S

Re: @button for displaying all parents of a clone to log pane

2019-10-07 Thread Edward K. Ream
On Monday, October 7, 2019 at 3:42:17 PM UTC-5, btheado wrote: > > > The short answer is that this is standard, core Leo code I'm calling. The > long answer is that it will take some investigation. > Here is the fix, at rev cc6c47b in devel: @g.command('show-clones') def show_clones(event=None

Re: @button for displaying all parents of a clone to log pane

2019-10-07 Thread Brian Theado
SegundoBob, I don't ever have clones with the same parent in my workflow and I didn't think to test that case. It looks like the g.es_clickable_link method is making use of UNL rather than positions. It looks to me like the leo getUNL functionality handles multiple clones with the same parent. Ma

Re: @button for displaying all parents of a clone to log pane

2019-10-07 Thread SegundoBob
btheado, Thanks, but your code doesn't work if several positions have the same parent. In this case, multiple links for the positions are displayed, but they all go to only one of the positions. I did not figure out what determines which of the positions wins. SegundoBob -- You received th

Re: @button for displaying all parents of a clone to log pane

2019-10-07 Thread Edward K. Ream
On Monday, October 7, 2019 at 3:41:26 AM UTC-5, Edward K. Ream wrote: > Elegant. Thanks for sharing this with us. Rev cb630a3 in devel adds the show-clones command. The definition is in leo/commands/editCommands.py Edward -- You received this message because you are subscribed to the Google

Re: @button for displaying all parents of a clone to log pane

2019-10-07 Thread Edward K. Ream
On Sun, Oct 6, 2019 at 9:15 PM Brian Theado wrote: the [goto-next-clone] command...feels uncomfortable and slow to me. > ... > this small script button [displays] links to all the clones of the > current selected position. The headline of the parent and the clone is > displayed: > > @button show

@button for displaying all parents of a clone to log pane

2019-10-06 Thread Brian Theado
I'm aware of the clone-find-all-parents command, but usually I want to display the other parents of a given clone in order to find one of them in particular. I don't want the new nodes which clone-find-all-parents create, because I don't want the extra work later of deleting these extra nodes. I wa