Help with 'find-all' !!

i'm having some trouble with the 'find-all' command. Not sure if it's me who doesn't understand the expected behavior. Here's an outline with 3 nodes (*Sent as attachment*) with a single line of text in each to keep it simple. Do a find-all command for the word 'bla'. Inspect the results for

Re: Help with 'find-all' !!

I can confirm your results. On the second node body, only three of the five matches are reported. When I step through using F3 in the Find tab, it does find all five (one at a time). On Monday, January 23, 2023 at 10:49:28 PM UTC-5 Félix wrote: > i'm having some trouble with the 'find-all' co

Re: Help with 'find-all' !!

On Mon, Jan 23, 2023 at 9:49 PM Félix wrote: Do a find-all command for the word 'bla'. Inspect the results for the > second node's body: two matches are missing... But - i copy pasted the same > text in the third node, and all matches are found there! Why would it not > hit all instances of 'bla

Re: Help with 'find-all' !!

On Mon, Jan 23, 2023 at 9:49 PM Félix wrote: i'm having some trouble with the 'find-all' command. It's a bug :-) See #3096 . Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsu

Re: Help with 'find-all' !!

Since *Find* can find all the matches one at a time, I'm thinking the problem has something to do with the way that results are collected. On Tuesday, January 24, 2023 at 5:23:11 AM UTC-5 Edward K. Ream wrote: > On Mon, Jan 23, 2023 at 9:49 PM Félix wrote: > > i'm having some trouble with the '

Re: Help with 'find-all' !!

On Tue, Jan 24, 2023 at 7:21 AM Thomas Passin wrote: > Since *Find* can find all the matches one at a time, I'm thinking the > problem has something to do with the way that results are collected. > Right. The culprit is find._find_all_helper. It improperly tries to use logic more suitable for in

Re: Help with 'find-all' !!

On Tuesday, January 24, 2023 at 11:09:59 AM UTC-5 Edward K. Ream wrote: On Tue, Jan 24, 2023 at 7:21 AM Thomas Passin wrote: Since *Find* can find all the matches one at a time, I'm thinking the problem has something to do with the way that results are collected. Right. The culprit is find._find

Re: Help with 'find-all' !!

On Mon, Jan 23, 2023 at 9:49 PM Félix wrote: > i'm having some trouble with the 'find-all' command. I'm hoping you haven't transliterated much of the 'find-all' command. PR #3099 will eventually rewrite most of the logic. The PR will eliminate some dead code in the 'change-all' command. Right

Re: Help with 'find-all' !!

On Tuesday, January 24, 2023 at 6:46:54 PM UTC-5 Edward K. Ream wrote: . For example, find-all could return a list of dicts of the form: { 'gnx': , 'head': list of indices of matches in the v.h, 'body': list of indices of matches in the v.b, } Given this data, the find-all could easily c

Re: Help with 'find-all' !!

> I'm hoping you haven't transliterated much of the 'find-all' command. PR #3099 will eventually rewrite most of the logic. I transliterated every line of leoFind.py ! but no worries, i'll rewrite find-all with your fixes when you're done with PR #3099 - no problem! :) I was in the process of s