Re: Please test PR #3398 in the ekr-fix-test branch

2023-06-21 Thread Félix
i finally got around to do so after realizing i was still testing on devel and not on ekr-fix-branch lol ! :) On Tuesday, June 20, 2023 at 9:51:57 AM UTC-4 Edward K. Ream wrote: > On Tue, Jun 20, 2023 at 8:24 AM Robert-Felix wrote: > >> Oops, looks like i can't read! Sorry about that! >> > >

Re: Please test PR #3398 in the ekr-fix-test branch

2023-06-20 Thread Edward K. Ream
On Tue, Jun 20, 2023 at 8:24 AM Robert-Felix wrote: > Oops, looks like i can't read! Sorry about that! > So you didn't run the tests in the ekr-fix-test branch? Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this

Re: Please test PR #3398 in the ekr-fix-test branch

2023-06-20 Thread Robert-Felix
Oops, looks like i can't read! Sorry about that! On Tue, Jun 20, 2023, 7:24 a.m. Edward K. Ream wrote: > > > On Mon, Jun 19, 2023 at 10:30 PM Félix wrote: > >> about the tryStar test fail: >> I've stepped in the test running in a debugger >> > > This should not be necessary. The only thing to

Re: Please test PR #3398 in the ekr-fix-test branch

2023-06-20 Thread Edward K. Ream
On Mon, Jun 19, 2023 at 10:30 PM Félix wrote: > about the tryStar test fail: > I've stepped in the test running in a debugger > This should not be necessary. The only thing to check is whether the call to skipTest is executed :-) Edward -- You received this message because you are

Re: Please test PR #3398 in the ekr-fix-test branch

2023-06-20 Thread Edward K. Ream
On Mon, Jun 19, 2023 at 7:54 PM Félix wrote: > on my old windows laptop, with python 3.9.6, i still get one failed test. > Screenshot below: > Are you running this test in the ekr-fix-test branch? The lines: if py_version < (3, 11): self.skipTest('Python 3.11+ only') should skip the

Re: Please test PR #3398 in the ekr-fix-test branch

2023-06-19 Thread Félix
about the tryStar test fail: I've stepped in the test running in a debugger, and in leoAst, the ast.parse call fails (when stepping into it brings us into usr/lib/python3.10/ast.py's parse function) and it throws an error in it's call to 'compile' function.: *return compile(source,

Re: Please test PR #3398 in the ekr-fix-test branch

2023-06-19 Thread Félix
and on ubuntu with python 3.10 i also get that test_tryStar one, along with the test_recursive_import one that checks for an absolute path starting with "C:\" on linux systems (wich fails.) Since the minimize_headline contains this line: *os.path.isabs(self.root_directory)* should the unittest

Re: Please test PR #3398 in the ekr-fix-test branch

2023-06-19 Thread Félix
on my old windows laptop, with python 3.9.6, i still get one failed test. Screenshot below: [image: still-single-unit-test-fail-python396.png] On Monday, June 19, 2023 at 8:58:17 AM UTC-4 Edward K. Ream wrote: > > > On Mon, Jun 19, 2023 at 7:21 AM Thomas Passin wrote: > > Thanks for your

Re: Please test PR #3398 in the ekr-fix-test branch

2023-06-19 Thread Edward K. Ream
On Mon, Jun 19, 2023 at 7:21 AM Thomas Passin wrote: Thanks for your tests. I'm not worried about warnings. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email

Re: Please test PR #3398 in the ekr-fix-test branch

2023-06-19 Thread Thomas Passin
Various Linuces: 3.11 Manjaro: leo\unittests\test_importers.py ...s... [ 5%] warnings summary leo/plugins/leo_babel/tests/lib_test.py:118

Re: Please test PR #3398 in the ekr-fix-test branch

2023-06-19 Thread Thomas Passin
On Windows 10, py -3.xx pytest: python 3.11: leo\unittests\test_importers.py ...s... [ 5%] warnings summary leo\plugins\leo_babel\tests\lib_test.py:118

Please test PR #3398 in the ekr-fix-test branch

2023-06-19 Thread Edward K. Ream
Thanks to those who have tested the recent code. PR #3398 contains my proposed fixes for several failing unit tests. I have tested this with various versions of python on both Windows and Ubuntu. Please check out the ekr-fix-test branch and