Re: Should search commands when there is no more hits return to position where search first started

2017-07-13 Thread lewis
Just to clarify, I read the command too literally. I thought it would conduct the search, and when it had cycled through the entire document, it would report the search complete, and return the user to the origin. Lewis -- You received this message because you are subscribed to the Google Grou

Re: Should search commands when there is no more hits return to position where search first started

2017-07-13 Thread lewis
Aha, my apologies. It works for me now, with *all* my plugins disabled :) I will retest with various plugins enabled. Thanks Lewis -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it,

Re: Should search commands when there is no more hits return to position where search first started

2017-07-13 Thread vitalije
On Thursday, July 13, 2017 at 3:49:38 PM UTC+2, lewis wrote: > > Open CheatSheet.leo > alt-F3 (nothing happens, there are no messages to log pane, or console) > alt-x search-return-to-origin (nothing happens, there are no messages to > log pane, or console) > > Well it seems I haven't explain ve

Re: Should search commands when there is no more hits return to position where search first started

2017-07-13 Thread lewis
Open CheatSheet.leo alt-F3 (nothing happens, there are no messages to log pane, or console) alt-x search-return-to-origin (nothing happens, there are no messages to log pane, or console) Confirmed on 2 win10 machines running 3.6.1 and PyQt 5.9.1. I will review my plugins and report. Leo Log Wi

Re: Should search commands when there is no more hits return to position where search first started

2017-07-12 Thread vitalije
On Thursday, July 13, 2017 at 2:35:23 AM UTC+2, lewis wrote: > > The search-return-to-origin command isn't working for me. I have no > bindings in myLeoSettings.leo > > Leo Log Window > Leo 5.5, build 20170712142037, Wed Jul 12 14:20:37 CDT 2017 > Git repo info: branch = master, commit = 840c257

Re: Should search commands when there is no more hits return to position where search first started

2017-07-12 Thread Xavier G. Domingo
El 12/07/2017 a las 21:35, lewis escribió: The search-return-to-origin command isn't working for me. I have no bindings in myLeoSettings.leo Leo Log Window Leo 5.5, build 20170712142037, Wed Jul 12 14:20:37 CDT 2017 Git repo info: branch = master, commit = 840c257d1084 Python 3.6.1, PyQt versio

Re: Should search commands when there is no more hits return to position where search first started

2017-07-12 Thread Xavier G. Domingo
New command `search-return-to-origin` is by default bound to Alt-F3, and it will restore current position as well as outline shape (expanded/contracted state of all nodes) to the state they were when last search has started. Great idea! I'll try to test it soon. -- You received this message

Re: Should search commands when there is no more hits return to position where search first started

2017-07-12 Thread lewis
The search-return-to-origin command isn't working for me. I have no bindings in myLeoSettings.leo Leo Log Window Leo 5.5, build 20170712142037, Wed Jul 12 14:20:37 CDT 2017 Git repo info: branch = master, commit = 840c257d1084 Python 3.6.1, PyQt version 5.9.1 Windows 10 AMD64 (build 10.0.15063) S

Re: Should search commands when there is no more hits return to position where search first started

2017-07-12 Thread Edward K. Ream
On Wed, Jul 12, 2017 at 9:50 AM, vitalije wrote: > Done at 9ca8546 >> >> > New command `search-return-to-origin` is by default bound to Alt-F3, and > it will restore current position as well as outline shape > (expanded/contracted state of all nodes) to the state they were when last > search has

Re: Should search commands when there is no more hits return to position where search first started

2017-07-12 Thread vitalije
Done at 9ca8546 > > New command `search-return-to-origin` is by default bound to Alt-F3, and it will restore current position as well as outline shape (expanded/contracted state of all nodes) to the state they were when last search has started. I hope that this default binding is not going to

Re: Should search commands when there is no more hits return to position where search first started

2017-07-12 Thread Edward K. Ream
On Wed, Jul 12, 2017 at 7:38 AM, vitalije wrote: > There is also another possibility that seems to me that would be best > thing to do. Simply let us turn this new code in new command > search-return-to-origin. > > ​Excellent idea. Feel free to do it. Edward -- You received this message bec

Re: Should search commands when there is no more hits return to position where search first started

2017-07-12 Thread lewis
Aware of the limitations of search in Leo, I am in the habit of going to the beginning of the file and commencing the search. The logic of the search-return-to-origin idea makes sense. Regards Lewis On Wednesday, July 12, 2017 at 10:38:23 PM UTC+10, vitalije wrote: > > turn this new code in

Re: Should search commands when there is no more hits return to position where search first started

2017-07-12 Thread vitalije
There is also another possibility that seems to me that would be best thing to do. Simply let us turn this new code in new command search-return-to-origin. Search commands should retain behavior as it was and if someone wants to return to where search has started, it is easy to execute one comma

Re: Should search commands when there is no more hits return to position where search first started

2017-07-12 Thread vitalije
> > > But let's not add this setting someone wants (or thinks they want) the new > way. And I wouldn't mind getting rid of the new code. > > Edward > I suppose Edward meant to say: But let's not add this setting *unless* someone (really) wants the new way. -- You received this message beca

Re: Should search commands when there is no more hits return to position where search first started

2017-07-12 Thread Edward K. Ream
On Wednesday, July 12, 2017 at 7:05:34 AM UTC-5, Edward K. Ream wrote: When I get to the end of a search, wrapped or not, I expect to stay in the > node that last matched. This is the way Leo has always worked, and I > personally do not want to "privilege" the​ > ​original starting point. > ..

Re: Should search commands when there is no more hits return to position where search first started

2017-07-12 Thread Edward K. Ream
On Wed, Jul 12, 2017 at 6:55 AM, vitalije wrote: > Personally, I don't use Leo's search commands. I get used to search in Nav > tab (quicksearch). While trying to fix issue #457 > I stated my > expectation about how search commands should beha

Should search commands when there is no more hits return to position where search first started

2017-07-12 Thread vitalije
Personally, I don't use Leo's search commands. I get used to search in Nav tab (quicksearch). While trying to fix issue #457 I stated my expectation about how search commands should behave. When I wrote code to fix the issue I also wrote cod