Re: [libav-devel] [PATCH] lagarith: Add correct line prediction for RGB

2011-11-16 Thread Kostya Shishkov
On Wed, Nov 16, 2011 at 12:45:00AM -0700, Nathan Caldwell wrote: --- libavcodec/lagarith.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) looks OK (and yes, Lagarith has very peculiar design decisions) ___ libav-devel mailing

Re: [libav-devel] [PATCH 2/2] Add another special case to the Cinepak video decoder so that it can handle the following file:

2011-11-16 Thread Kostya Shishkov
On Tue, Nov 15, 2011 at 11:06:48PM -0800, m...@multimedia.cx wrote: From: Mike Melanson m...@multimedia.cx http://samples.mplayerhq.hu/V-codecs/CVID/bad_cinepak_frame_size.mov This fix works around another work around which handles a different type of odd Cinepak data. Thanks to Matthew

Re: [libav-devel] [PATCH 2/2] Add another special case to the Cinepak video decoder so that it can handle the following file:

2011-11-16 Thread Johan Andersson
On Tue, Nov 15, 2011 at 11:06:48PM -0800, m...@multimedia.cx wrote: From: Mike Melanson m...@multimedia.cx http://samples.mplayerhq.hu/V-codecs/CVID/bad_cinepak_frame_size.mov This fix works around another work around which handles a different type of odd Cinepak data. Thanks to Matthew

Re: [libav-devel] [PATCH 2/2] Add another special case to the Cinepak video decoder so that it can handle the following file:

2011-11-16 Thread Kostya Shishkov
On Wed, Nov 16, 2011 at 09:22:02AM +0100, Johan Andersson wrote: On Tue, Nov 15, 2011 at 11:06:48PM -0800, m...@multimedia.cx wrote: From: Mike Melanson m...@multimedia.cx http://samples.mplayerhq.hu/V-codecs/CVID/bad_cinepak_frame_size.mov This fix works around another work around

Re: [libav-devel] [PATCH 2/2] Add another special case to the Cinepak video decoder so that it can handle the following file:

2011-11-16 Thread Mike Melanson
On 11/16/2011 12:22 AM, Johan Andersson wrote: - * after the frame header. Else, assume 2 extra bytes. */ + * after the frame header. Else, assume 2 extra bytes. The container size + * size also cannot be a multiple of the encoded size. */ The container

Re: [libav-devel] [PATCH 2/2] Add another special case to the Cinepak video decoder so that it can handle the following file:

2011-11-16 Thread Mike Melanson
On 11/16/2011 12:25 AM, Kostya Shishkov wrote: On Wed, Nov 16, 2011 at 09:22:02AM +0100, Johan Andersson wrote: On Tue, Nov 15, 2011 at 11:06:48PM -0800, m...@multimedia.cx wrote: From: Mike Melansonm...@multimedia.cx http://samples.mplayerhq.hu/V-codecs/CVID/bad_cinepak_frame_size.mov This

Re: [libav-devel] [PATCH 2/2] Add another special case to the Cinepak video decoder so that it can handle the following file:

2011-11-16 Thread Kostya Shishkov
On Wed, Nov 16, 2011 at 12:25:33AM -0800, Mike Melanson wrote: On 11/16/2011 12:22 AM, Johan Andersson wrote: - * after the frame header. Else, assume 2 extra bytes. */ + * after the frame header. Else, assume 2 extra bytes. The container size + * size

Re: [libav-devel] [PATCH 2/2] Add another special case to the Cinepak video decoder so that it can handle the following file:

2011-11-16 Thread Martin Storsjö
On Wed, 16 Nov 2011, Kostya Shishkov wrote: On Tue, Nov 15, 2011 at 11:06:48PM -0800, m...@multimedia.cx wrote: From: Mike Melanson m...@multimedia.cx http://samples.mplayerhq.hu/V-codecs/CVID/bad_cinepak_frame_size.mov This fix works around another work around which handles a different type

[libav-devel] [PATCH] applehttp: Fix seeking in streams not starting at DTS=0

2011-11-16 Thread Martin Storsjö
From: Panagiotis H.M. Issaris takis.issa...@uhasselt.be The Apple HTTP Live Streaming demuxer's implementation of seeking searches for the MPEG TS segment which contains the requested timestamp. In its current implementation it assumes that the first segment will start from 0. But, MPEG TS

Re: [libav-devel] [PATCH 1/3] avutil: Add av_timegm as a public function

2011-11-16 Thread Anton Khirnov
On Tue, 8 Nov 2011 00:19:27 +0200, Martin Storsjö mar...@martin.st wrote: This is useful, since the normal timegm function isn't a standard function (requiring _BSD_SOURCE or _SVID_SOURCE on glibc to be visible, and not available on e.g. windows). The widely available function mktime uses

Re: [libav-devel] [PATCH 2/3] avformat: Interpret times in ff_iso8601_to_unix_time as UTC

2011-11-16 Thread Anton Khirnov
On Tue, 8 Nov 2011 00:19:28 +0200, Martin Storsjö mar...@martin.st wrote: This function is used in muxers for parsing the 'creation_time' metadata key, for converting it to a time value. This makes it match the behaviour of the exported 'creation_time' metadata from demuxers, where it is

Re: [libav-devel] [PATCH 3/3] avformat: Accept the ISO8601 separate format as input, too

2011-11-16 Thread Anton Khirnov
On Tue, 8 Nov 2011 00:19:29 +0200, Martin Storsjö mar...@martin.st wrote: This makes the function accept the format of creation_time as output by demuxers (e.g. the mov demuxer), fixing keeping the creation timestamp intact if transcoding. --- Ok. -- Anton Khirnov

[libav-devel] [PATCH] mpegaudiodec: Don't use a nonexistent log context for av_dlog

2011-11-16 Thread Martin Storsjö
This fixes builds with DEBUG defined, broken since 1158745a2d12966c58e83b66243a42f20190812e. --- libavcodec/mpegaudiodec.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpegaudiodec.c b/libavcodec/mpegaudiodec.c index f8193d6..bc01273 100644 ---

Re: [libav-devel] [PATCH] mpegaudiodec: Don't use a nonexistent log context for av_dlog

2011-11-16 Thread Luca Barbato
On 11/16/11 10:35 AM, Martin Storsjö wrote: This fixes builds with DEBUG defined, broken since 1158745a2d12966c58e83b66243a42f20190812e. --- Ok ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] mpegaudiodec: Don't use a nonexistent log context for av_dlog

2011-11-16 Thread Janne Grunau
On Wed, Nov 16, 2011 at 11:35:08AM +0200, Martin Storsjö wrote: This fixes builds with DEBUG defined, broken since 1158745a2d12966c58e83b66243a42f20190812e. --- libavcodec/mpegaudiodec.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) ok Janne

Re: [libav-devel] [PATCH 2/2] Add another special case to the Cinepak video decoder so that it can handle the following file:

2011-11-16 Thread Luca Barbato
On 11/16/11 9:25 AM, Mike Melanson wrote: On 11/16/2011 12:22 AM, Johan Andersson wrote: - * after the frame header. Else, assume 2 extra bytes. */ + * after the frame header. Else, assume 2 extra bytes. The container size + * size also cannot be a multiple of the encoded size. */ The

Re: [libav-devel] [PATCH 1/2] pthread: do not touch has_b_frames

2011-11-16 Thread Janne Grunau
On Wed, Nov 16, 2011 at 01:01:13AM -0500, Alexander Strange wrote: On Nov 10, 2011, at 4:02 PM, Janne Grunau wrote: this fixes fate-iv8-demux with two threads Seems worthwhile. I added this to avoid mplayer/vlc having to make code changes (their a/v sync is somewhat based on

Re: [libav-devel] [PATCH] avcodec: move some AVCodecContext fields to an internal struct.

2011-11-16 Thread Uoti Urpala
On Tue, 2011-11-15 at 18:13 -0500, Justin Ruggles wrote: A new field, AVCodecContext.internal is used to hold a new struct AVCodecInternal, which has private fields that are not codec-specific and are needed only by general libavcodec functions. diff --git a/libavcodec/pthread.c

[libav-devel] [PATCH] configure: Add vda libs to extralibs instead of ldflags

2011-11-16 Thread Martin Storsjö
All other external libraries are added to extralibs instead of ldflags. --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 6e4259f..23a483e 100755 --- a/configure +++ b/configure @@ -2994,7 +2994,7 @@ check_func XFixesGetCursorImage

Re: [libav-devel] [PATCH] configure: Add vda libs to extralibs instead of ldflags

2011-11-16 Thread Luca Barbato
On 11/16/11 12:48 PM, Martin Storsjö wrote: All other external libraries are added to extralibs instead of ldflags. Not sure which is better. I was even tempted to move them to cflags. lu ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] Split snow in snowenc snowdec

2011-11-16 Thread Luca Barbato
This patchset might be squashed, it more or less show how to split a large codebase in two smaller, after this set I'll try to add a reindent patch over it. Please help me polish it since I'd like to make it an example for the Code In refactoring tasks. snow: split encoder from decoder snow:

[libav-devel] [PATCH 02/10] snow: start moving tables and common code away

2011-11-16 Thread Luca Barbato
The common non inlined code goes in snow.c, the common inlined code in snow.h, tables will move in snowdata.h (included only by snow.c) --- libavcodec/snow.c | 27 +++ libavcodec/snow.h | 157 ++ libavcodec/snowdata.h | 106 libavcodec/snowdec.c | 439

[libav-devel] [PATCH 03/10] snow: move pred_block out

2011-11-16 Thread Luca Barbato
--- libavcodec/snow.c | 358 ++ libavcodec/snow.h | 32 - libavcodec/snowdata.h |7 + libavcodec/snowdec.c | 461 + libavcodec/snowenc.c | 394 +- 5

[libav-devel] [PATCH 04/10] snow: move out same_block

2011-11-16 Thread Luca Barbato
--- libavcodec/snow.h|8 libavcodec/snowdec.c |8 libavcodec/snowenc.c |8 3 files changed, 8 insertions(+), 16 deletions(-) diff --git a/libavcodec/snow.h b/libavcodec/snow.h index 831613d..c433579 100644 --- a/libavcodec/snow.h +++ b/libavcodec/snow.h

[libav-devel] [PATCH 05/10] snow: move add_yblock out

2011-11-16 Thread Luca Barbato
the function is a bit big --- libavcodec/snow.h| 139 +++--- libavcodec/snowdec.c | 123 libavcodec/snowenc.c | 123 3 files changed, 132 insertions(+), 253

[libav-devel] [PATCH 07/10] snow: move away common_init_after_header

2011-11-16 Thread Luca Barbato
--- libavcodec/snow.c| 55 ++ libavcodec/snow.h|2 +- libavcodec/snowdec.c | 55 +- libavcodec/snowenc.c | 55 +- 4 files changed, 58

[libav-devel] [PATCH 06/10] snow: move away predict_plane

2011-11-16 Thread Luca Barbato
--- libavcodec/snow.h| 57 + libavcodec/snowdec.c | 57 - libavcodec/snowenc.c | 113 -- 3 files changed, 57 insertions(+), 170 deletions(-) diff --git a/libavcodec/snow.h b/libavcodec/snow.h

[libav-devel] [PATCH 08/10] snow: remove tree_sse and QUANTIZE2 related code

2011-11-16 Thread Luca Barbato
The code should be removed from the encoder as well since currently it is unreachable. --- libavcodec/snowdec.c | 48 1 files changed, 0 insertions(+), 48 deletions(-) diff --git a/libavcodec/snowdec.c b/libavcodec/snowdec.c index

[libav-devel] [PATCH 09/10] snow: move remaining common code away

2011-11-16 Thread Luca Barbato
--- libavcodec/snow.c| 146 libavcodec/snow.h|7 ++- libavcodec/snowdec.c | 151 +- libavcodec/snowenc.c | 151 +- 4 files changed, 157

[libav-devel] [PATCH 10/10] snow: move away the remaining shared inline functions

2011-11-16 Thread Luca Barbato
--- libavcodec/snow.h | 234 ++ libavcodec/snowdata.h | 19 libavcodec/snowdec.c | 248 - libavcodec/snowenc.c | 248 - 4 files changed, 253

Re: [libav-devel] Split snow in snowenc snowdec

2011-11-16 Thread Kostya Shishkov
On Wed, Nov 16, 2011 at 04:25:59PM +0100, Luca Barbato wrote: This patchset might be squashed, it more or less show how to split a large codebase in two smaller, after this set I'll try to add a reindent patch over it. Please help me polish it since I'd like to make it an example for the Code

[libav-devel] [PATCH] Added liborc as a dependency of libschroedinger

2011-11-16 Thread Courtland Jones
The configure script could't find liborc without the below changes. Added ldflags of -lorc-0.4 so that configure could find it, added liborc to the deps lines so it would build with liborc. Without this, configure reported ERROR: schroedinger-1.0 not found, along with every symbol schroedinger

Re: [libav-devel] [PATCH] Added liborc as a dependency of libschroedinger

2011-11-16 Thread Sean McGovern
On Monday, November 14, 2011, Courtland Jones courtland.jo...@gmail.com wrote: The configure script could't find liborc without the below changes. Added ldflags of -lorc-0.4 so that configure could find it, added liborc to the deps lines so it would build with liborc. Without this, configure

[libav-devel] [PATCH] avcodec: move some AVCodecContext fields to an internal struct.

2011-11-16 Thread Justin Ruggles
A new field, AVCodecContext.internal is used to hold a new struct AVCodecInternal, which has private fields that are not codec-specific and are needed only by general libavcodec functions. Moved user_buffer, user_buffer_count, and is_copy. --- doc/APIchanges |8 +

Re: [libav-devel] [PATCH] avcodec: move some AVCodecContext fields to an internal struct.

2011-11-16 Thread Måns Rullgård
Justin Ruggles justin.rugg...@gmail.com writes: @@ -728,9 +729,11 @@ static int frame_thread_init(AVCodecContext *avctx) update_context_from_thread(avctx, copy, 1); } else { -copy-is_copy = 1; copy-priv_data =

Re: [libav-devel] [PATCH] Added liborc as a dependency of libschroedinger

2011-11-16 Thread Måns Rullgård
Sean McGovern gsean...@gmail.com writes: On Monday, November 14, 2011, Courtland Jones courtland.jo...@gmail.com wrote: The configure script could't find liborc without the below changes. Added ldflags of -lorc-0.4 so that configure could find it, added liborc to the deps lines so it would

Re: [libav-devel] [PATCH] avcodec: move some AVCodecContext fields to an internal struct.

2011-11-16 Thread Uoti Urpala
On Wed, 2011-11-16 at 11:31 -0500, Justin Ruggles wrote: +copy-internal = av_malloc(sizeof(AVCodecInternal)); A corresponding free() seems to be missing. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] avcodec: move some AVCodecContext fields to an internal struct.

2011-11-16 Thread Justin Ruggles
On 11/16/2011 04:42 PM, Uoti Urpala wrote: On Wed, 2011-11-16 at 11:31 -0500, Justin Ruggles wrote: +copy-internal = av_malloc(sizeof(AVCodecInternal)); A corresponding free() seems to be missing. yes, i just found that. i'm sending another patch shortly. and also a patch to

[libav-devel] [PATCH 1/2] avcodec: move some AVCodecContext fields to an internal struct.

2011-11-16 Thread Justin Ruggles
A new field, AVCodecContext.internal is used to hold a new struct AVCodecInternal, which has private fields that are not codec-specific and are needed only by general libavcodec functions. Moved user_buffer, user_buffer_count, and is_copy. --- doc/APIchanges |8 +

[libav-devel] [PATCH 2/2] pthread: add some malloc failure checks

2011-11-16 Thread Justin Ruggles
--- libavcodec/pthread.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/libavcodec/pthread.c b/libavcodec/pthread.c index 9fe9b8d..42b82a5 100644 --- a/libavcodec/pthread.c +++ b/libavcodec/pthread.c @@ -719,6 +719,11 @@ static int