Re: [libav-devel] [PATCH 10/10] avserver: fix build after the next bump.

2012-01-13 Thread Anton Khirnov
On Thu, 12 Jan 2012 09:57:32 +0100, Anton Khirnov wrote: > --- > avserver.c | 22 -- > 1 files changed, 12 insertions(+), 10 deletions(-) > Ping. I know it's ugly, but fixing this properly is a lot of effort. -- Anton Khirnov ___

Re: [libav-devel] [PATCH 0/5] encode_audio2, v4

2012-01-13 Thread Ronald S. Bultje
Hi, On Tue, Jan 10, 2012 at 3:09 PM, Justin Ruggles wrote: > 4th try at new audio encoding API. > > a few differences: > > I included Ronald's suggestion of got_packet_ptr instead of inspecting > various packet fields to decide whether the output packet is empty. > > I left out passing of the inp

Re: [libav-devel] [PATCH] libx264: Don't leave max_b_frames as -1 if the user didn't set it

2012-01-13 Thread Janne Grunau
On 2012-01-14 00:43:45 +0200, Martin Storsjö wrote: > On Fri, 13 Jan 2012, Janne Grunau wrote: > > >On 2012-01-13 23:51:59 +0200, Martin Storsjö wrote: > >>max_b_frames is initialized to -1 for libx264, to allow > >>distinguishing between an explicit user set 0 and a default not > >>touched 0 (see

Re: [libav-devel] [PATCH] FATE: convert output to rgba for the targa tests which currently output pal8

2012-01-13 Thread Ronald S. Bultje
Hi, On Fri, Jan 13, 2012 at 3:42 PM, Justin Ruggles wrote: > fixes the tests on big-endian systems > --- >  tests/fate/image.mak                  |    4 ++-- >  tests/ref/fate/targa-conformance-CCM8 |    2 +- >  tests/ref/fate/targa-conformance-UCM8 |    2 +- >  3 files changed, 4 insertions(+),

[libav-devel] [PATCH] FATE: convert output to rgba for the targa tests which currently output pal8

2012-01-13 Thread Justin Ruggles
fixes the tests on big-endian systems --- tests/fate/image.mak |4 ++-- tests/ref/fate/targa-conformance-CCM8 |2 +- tests/ref/fate/targa-conformance-UCM8 |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/fate/image.mak b/tests/fate/image.mak

Re: [libav-devel] [PATCH] fate: add missing reference files for targa tests in 9c2f9b0e2

2012-01-13 Thread Ronald S. Bultje
Hi, On Fri, Jan 13, 2012 at 2:55 PM, Janne Grunau wrote: > Fixes fate-targa-conformance-CCM8 and fate-targa-conformance-UCM8. > --- >  tests/ref/fate/targa-conformance-CCM8 |    1 + >  tests/ref/fate/targa-conformance-UCM8 |    1 + >  2 files changed, 2 insertions(+), 0 deletions(-) >  create mod

[libav-devel] [PATCH] fate: add missing reference files for targa tests in 9c2f9b0e2

2012-01-13 Thread Janne Grunau
Fixes fate-targa-conformance-CCM8 and fate-targa-conformance-UCM8. --- tests/ref/fate/targa-conformance-CCM8 |1 + tests/ref/fate/targa-conformance-UCM8 |1 + 2 files changed, 2 insertions(+), 0 deletions(-) create mode 100644 tests/ref/fate/targa-conformance-CCM8 create mode 100644 test

Re: [libav-devel] [PATCH 2/2] FATE: enable the 2 remaining targa conformance suite tests

2012-01-13 Thread Janne Grunau
On 2012-01-13 16:42:37 -0500, Justin Ruggles wrote: > --- > tests/fate/image.mak |6 -- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tests/fate/image.mak b/tests/fate/image.mak > index 153a4f3..8a5df86 100644 > --- a/tests/fate/image.mak > +++ b/tests/fate/image.mak

Re: [libav-devel] [PATCH] libx264: Don't leave max_b_frames as -1 if the user didn't set it

2012-01-13 Thread Martin Storsjö
On Fri, 13 Jan 2012, Janne Grunau wrote: On 2012-01-13 23:51:59 +0200, Martin Storsjö wrote: max_b_frames is initialized to -1 for libx264, to allow distinguishing between an explicit user set 0 and a default not touched 0 (see bb73cda2). it's generally initialized to -1 No, it's not. The -

Re: [libav-devel] [PATCH] libx264: Don't leave max_b_frames as -1 if the user didn't set it

2012-01-13 Thread Janne Grunau
On 2012-01-13 23:51:59 +0200, Martin Storsjö wrote: > max_b_frames is initialized to -1 for libx264, to allow > distinguishing between an explicit user set 0 and a default not > touched 0 (see bb73cda2). it's generally initialized to -1 > If max_b_frames is left as -1, this affects dts generatio

Re: [libav-devel] [PATCH 0/7] export audio packet duration in parsers

2012-01-13 Thread Justin Ruggles
On 01/12/2012 11:43 PM, Justin Ruggles wrote: > This avoids reusing avctx->frame_size for per-frame information. > > Justin Ruggles (7): ... > gsm parser: set duration ... > adx parser: set duration I'm dropping patch 5/7 and 7/7 since the packet duration is constant for these codecs. I'll

Re: [libav-devel] [PATCH] swscale: change yuv2yuvX code to use cpuflag().

2012-01-13 Thread Daniel Kang
On Fri, Jan 13, 2012 at 3:00 PM, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > --- > libswscale/x86/output.asm | 119 > ++--- > 1 files changed, 59 insertions(+), 60 deletions(-) Seems fine. ___ libav

Re: [libav-devel] [PATCH] libx264: Don't leave max_b_frames as -1 if the user didn't set it

2012-01-13 Thread Anton Khirnov
On Fri, 13 Jan 2012 23:51:59 +0200, Martin Storsjö wrote: > max_b_frames is initialized to -1 for libx264, to allow > distinguishing between an explicit user set 0 and a default not > touched 0 (see bb73cda2). > > If max_b_frames is left as -1, this affects dts generation (where > expressions li

Re: [libav-devel] [PATCH] FATE: fix targa tests on big-endian systems

2012-01-13 Thread Ronald S. Bultje
Hu, On Fri, Jan 13, 2012 at 1:16 PM, Justin Ruggles wrote: > --- > This should fix the failing tests. Could someone please check to make sure? > > Thanks, > Justin > >  tests/fate/image.mak |    8 >  1 files changed, 4 insertions(+), 4 deletions(-) Just commit, this is necessary anyway.

Re: [libav-devel] [libav-commits] FATE: add tests for targa

2012-01-13 Thread Ronald S. Bultje
Hi, 2012/1/13 Måns Rullgård : > Paul B Mahol writes: > >> On 1/13/12, Maans Rullgaard wrote: >>> Paul B Mahol writes: >>> On 1/13/12, Maans Rullgaard wrote: > "Justin Ruggles " writes: > >> +# fate-targa-conformance-CCM8:  CMD = framecrc -i >> $(SAMPLES)/targa-conformance

Re: [libav-devel] [PATCH 2/2] FATE: enable the 2 remaining targa conformance suite tests

2012-01-13 Thread Ronald S. Bultje
Hi, On Fri, Jan 13, 2012 at 1:42 PM, Justin Ruggles wrote: > --- >  tests/fate/image.mak |    6 -- >  1 files changed, 4 insertions(+), 2 deletions(-) OK. Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/li

Re: [libav-devel] [PATCH 1/2] targa: add support for rgb555 palette

2012-01-13 Thread Ronald S. Bultje
Hi, On Fri, Jan 13, 2012 at 1:46 PM, Justin Ruggles wrote: > On 01/13/2012 04:42 PM, Justin Ruggles wrote: >> Also set opacity for the palette with rgb24 entries > > oops. this is no longer true. amended the commit message locally. Good to push then. Ronald _

Re: [libav-devel] [PATCH] configure: provide libavfilter/version.h header to get_version()

2012-01-13 Thread Janne Grunau
On 2012-01-13 22:24:26 +0100, Anton Khirnov wrote: > From: Stefano Sabatini > > Fix libavfilter library version numbers generation, which was broken in > 3167dc9515810bbdd86d99d773bcf84657d2e72a. > > Signed-off-by: Anton Khirnov > --- > configure |2 +- > 1 files changed, 1 insertions(+),

[libav-devel] [PATCH] libx264: Don't leave max_b_frames as -1 if the user didn't set it

2012-01-13 Thread Martin Storsjö
max_b_frames is initialized to -1 for libx264, to allow distinguishing between an explicit user set 0 and a default not touched 0 (see bb73cda2). If max_b_frames is left as -1, this affects dts generation (where expressions like max_b_frames != 0 are used), so make sure it is left at the default 0

Re: [libav-devel] [PATCH 1/2] targa: add support for rgb555 palette

2012-01-13 Thread Justin Ruggles
On 01/13/2012 04:42 PM, Justin Ruggles wrote: > Also set opacity for the palette with rgb24 entries oops. this is no longer true. amended the commit message locally. -Justin ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/ma

[libav-devel] [PATCH 2/2] FATE: enable the 2 remaining targa conformance suite tests

2012-01-13 Thread Justin Ruggles
--- tests/fate/image.mak |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/fate/image.mak b/tests/fate/image.mak index 153a4f3..8a5df86 100644 --- a/tests/fate/image.mak +++ b/tests/fate/image.mak @@ -32,10 +32,12 @@ FATE_TESTS += fate-sunraster-24bit-rle fate-su

[libav-devel] [PATCH 1/2] targa: add support for rgb555 palette

2012-01-13 Thread Justin Ruggles
Also set opacity for the palette with rgb24 entries --- libavcodec/targa.c | 39 +-- 1 files changed, 29 insertions(+), 10 deletions(-) diff --git a/libavcodec/targa.c b/libavcodec/targa.c index b821d74..00da758 100644 --- a/libavcodec/targa.c +++ b/libavcode

Re: [libav-devel] [libav-commits] FATE: add tests for targa

2012-01-13 Thread Måns Rullgård
Paul B Mahol writes: > On 1/13/12, Maans Rullgaard wrote: >> Paul B Mahol writes: >> >>> On 1/13/12, Maans Rullgaard wrote: "Justin Ruggles " writes: > +# fate-targa-conformance-CCM8: CMD = framecrc -i > $(SAMPLES)/targa-conformance/CCM8.TGA > +# fate-targa-conformance-

Re: [libav-devel] [libav-commits] FATE: add tests for targa

2012-01-13 Thread Paul B Mahol
On 1/13/12, Maans Rullgaard wrote: > Paul B Mahol writes: > >> On 1/13/12, Maans Rullgaard wrote: >>> "Justin Ruggles " writes: >>> +# fate-targa-conformance-CCM8: CMD = framecrc -i $(SAMPLES)/targa-conformance/CCM8.TGA +# fate-targa-conformance-UCM8: CMD = framecrc -i $(S

Re: [libav-devel] [libav-commits] FATE: add tests for targa

2012-01-13 Thread Måns Rullgård
Paul B Mahol writes: > On 1/13/12, Maans Rullgaard wrote: >> "Justin Ruggles " writes: >> >>> +# fate-targa-conformance-CCM8: CMD = framecrc -i >>> $(SAMPLES)/targa-conformance/CCM8.TGA >>> +# fate-targa-conformance-UCM8: CMD = framecrc -i >>> $(SAMPLES)/targa-conformance/UCM8.TGA >> >> WTF a

Re: [libav-devel] [libav-commits] FATE: add tests for targa

2012-01-13 Thread Paul B Mahol
On 1/13/12, Maans Rullgaard wrote: > "Justin Ruggles " writes: > >> +# fate-targa-conformance-CCM8: CMD = framecrc -i >> $(SAMPLES)/targa-conformance/CCM8.TGA >> +# fate-targa-conformance-UCM8: CMD = framecrc -i >> $(SAMPLES)/targa-conformance/UCM8.TGA > > WTF are those lines doing there? What

Re: [libav-devel] [PATCH] SMJPEG muxer

2012-01-13 Thread Måns Rullgård
Paul B Mahol writes: > --- > Changelog|1 + > doc/general.texi |2 +- > libavformat/Makefile |3 +- > libavformat/allformats.c |2 +- > libavformat/smjpeg.c | 159 ++--- > libavformat/smjpeg.h | 37 +++

[libav-devel] [PATCH] configure: provide libavfilter/version.h header to get_version()

2012-01-13 Thread Anton Khirnov
From: Stefano Sabatini Fix libavfilter library version numbers generation, which was broken in 3167dc9515810bbdd86d99d773bcf84657d2e72a. Signed-off-by: Anton Khirnov --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 3146641..93b

Re: [libav-devel] [PATCH] SMJPEG muxer

2012-01-13 Thread Paul B Mahol
--- Changelog|1 + doc/general.texi |2 +- libavformat/Makefile |3 +- libavformat/allformats.c |2 +- libavformat/smjpeg.c | 159 ++--- libavformat/smjpeg.h | 37 ++ libavformat/smjpegdec.c | 177

Re: [libav-devel] [libav-commits] FATE: add tests for targa

2012-01-13 Thread Måns Rullgård
"Justin Ruggles " writes: > +# fate-targa-conformance-CCM8: CMD = framecrc -i > $(SAMPLES)/targa-conformance/CCM8.TGA > +# fate-targa-conformance-UCM8: CMD = framecrc -i > $(SAMPLES)/targa-conformance/UCM8.TGA WTF are those lines doing there? Whatever happened to actually reviewing patches

Re: [libav-devel] [libav-commits] FATE: add tests for targa

2012-01-13 Thread Måns Rullgård
"Justin Ruggles " writes: > +fate-targa-conformance-CBW8: CMD = framecrc -i > $(SAMPLES)/targa-conformance/CBW8.TGA These need a suitable -pix_fmt argument to give endian-independent output. -- Måns Rullgård m...@mansr.com ___ libav-devel mailing l

[libav-devel] [PATCH] FATE: fix targa tests on big-endian systems

2012-01-13 Thread Justin Ruggles
--- This should fix the failing tests. Could someone please check to make sure? Thanks, Justin tests/fate/image.mak |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/fate/image.mak b/tests/fate/image.mak index 153a4f3..7fdbdc4 100644 --- a/tests/fate/image.mak

Re: [libav-devel] mov, mxfdec return value refactoring

2012-01-13 Thread Daniel Huang
On Wed, Jan 11, 2012 at 3:34 AM, Diego Biurrun wrote: > On Wed, Jan 11, 2012 at 07:50:55AM +0100, Anton Khirnov wrote: > > On Tue, 10 Jan 2012 09:31:20 -0600, Daniel Huang > wrote: > > > From 8aad2648ce411409c8ce941c7d2cb68d7470e44a Mon Sep 17 00:00:00 2001 > > > From: Daniel Huang > > > Date:

[libav-devel] [PATCH] swscale: change yuv2yuvX code to use cpuflag().

2012-01-13 Thread Ronald S. Bultje
From: "Ronald S. Bultje" --- libswscale/x86/output.asm | 119 ++--- 1 files changed, 59 insertions(+), 60 deletions(-) diff --git a/libswscale/x86/output.asm b/libswscale/x86/output.asm index 0ec2038..ae2929c 100644 --- a/libswscale/x86/output.asm +++ b/

[libav-devel] libav.org repository

2012-01-13 Thread Clément Bœsch
Hi, The libav.git repository URL referenced on http://libav.org/download.html doesn't work. Kostya noticed git://git.libav.org/libav.org works as a workaround, but I think the download page should be fixed (or actually maybe the server config should?). Regards, -- Clément B. pgp6UIHjgSU86.pgp

Re: [libav-devel] [PATCH] SMJPEG muxer

2012-01-13 Thread Kostya Shishkov
On Fri, Jan 13, 2012 at 07:39:51PM +, Paul B Mahol wrote: > On 1/13/12, Kostya Shishkov wrote: > > Do they have common code? If not maybe it's better to put muxer into > > separate > > file. Tags are easy to duplicate. > > Something like this: > > smjpegdec.c > smjpegenc.c > > and tags in s

Re: [libav-devel] [PATCH] SMJPEG muxer

2012-01-13 Thread Paul B Mahol
On 1/13/12, Kostya Shishkov wrote: > Do they have common code? If not maybe it's better to put muxer into > separate > file. Tags are easy to duplicate. Something like this: smjpegdec.c smjpegenc.c and tags in smjpeg.[c/h] ? ___ libav-devel mailing li

Re: [libav-devel] [PATCH] ARM: 4-byte align start of all asm functions

2012-01-13 Thread Janne Grunau
On 2012-01-13 18:56:56 +, Måns Rullgård wrote: > Due to apprent bugs in the GNU assembler and/or linker, relocations > can be incorrectly processed if the alignment of a Thumb instruction > is changed in the output file compared to the input object. > > This fixes crashes in h264 decoding with

Re: [libav-devel] [PATCH] ARM: fix Thumb-mode simple_idct_arm

2012-01-13 Thread Janne Grunau
On 2012-01-13 19:03:18 +, Måns Rullgård wrote: > The alignment directive must obviously precede the label. > This was never noticed in ARM mode since the location is > already aligned there. > > Signed-off-by: Mans Rullgard > --- > libavcodec/arm/simple_idct_arm.S |2 +- > 1 files change

[libav-devel] [PATCH] ARM: fix Thumb-mode simple_idct_arm

2012-01-13 Thread Mans Rullgard
The alignment directive must obviously precede the label. This was never noticed in ARM mode since the location is already aligned there. Signed-off-by: Mans Rullgard --- libavcodec/arm/simple_idct_arm.S |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/arm/sim

[libav-devel] [PATCH] ARM: 4-byte align start of all asm functions

2012-01-13 Thread Mans Rullgard
Due to apprent bugs in the GNU assembler and/or linker, relocations can be incorrectly processed if the alignment of a Thumb instruction is changed in the output file compared to the input object. This fixes crashes in h264 decoding with Thumb enabled. No effect in ARM mode since everything is 4-b

[libav-devel] [PATCH] sgidec: Use bytestream2 functions to prevent buffer overreads.

2012-01-13 Thread Aneesh Dogra
The patch also adds several bytestream macros to deal with native endian. --- libavcodec/bytestream.h | 37 + libavcodec/sgidec.c | 103 +++ 2 files changed, 88 insertions(+), 52 deletions(-) diff --git a/libavcodec/bytestream.h b

Re: [libav-devel] [PATCH] swscale-test: Drop unused argc and argv arguments fro main().

2012-01-13 Thread Ronald S. Bultje
Hi, On Fri, Jan 13, 2012 at 8:01 AM, Diego Biurrun wrote: > --- >  libswscale/colorspace-test.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) Why? Somewhat related, I'd prefer if we used them. I wanted to work on that but forgot. E.g., we could think of using argv[1]/[2] to spec

[libav-devel] [PATCH] swscale-test: Drop unused argc and argv arguments fro main().

2012-01-13 Thread Diego Biurrun
--- libswscale/colorspace-test.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libswscale/colorspace-test.c b/libswscale/colorspace-test.c index 10cee8a..135924c 100644 --- a/libswscale/colorspace-test.c +++ b/libswscale/colorspace-test.c @@ -33,7 +33,7 @@ #define FU

Re: [libav-devel] [PATCH] cosmetics: Move static and inline attributes to more standard places.

2012-01-13 Thread Ronald S. Bultje
Hi, On Fri, Jan 13, 2012 at 7:48 AM, Diego Biurrun wrote: > Fixes several "‘static’ is not at beginning of declaration" warnings. > --- >  libavcodec/g722.c            |    2 +- >  libavcodec/h264_loopfilter.c |   51 +++-- >  libavfilter/vf_fade.c        |    2

[libav-devel] [PATCH] cosmetics: Move static and inline attributes to more standard places.

2012-01-13 Thread Diego Biurrun
Fixes several "‘static’ is not at beginning of declaration" warnings. --- libavcodec/g722.c|2 +- libavcodec/h264_loopfilter.c | 51 +++-- libavfilter/vf_fade.c|2 +- libswscale/utils.c |2 +- 4 files changed, 46 inser

Re: [libav-devel] [PATCH] rv34: Split intra/inter and rewrite i16x16 handling

2012-01-13 Thread Christophe Gisquet
2012/1/12 Christophe Gisquet : > 2012/1/12 Kostya Shishkov : >> Probably OK, I'll wait for other people to say something. Also is there a >> chance of doing benchmarks? > > Before: 4.134 / 4.618 / 2.668 / 1.123 / 3.120 > After: 3.916 / 4.399 / 2.558 / 1.092 / 2.995 > So around a 4% speed increase.

Re: [libav-devel] [PATCH] SMJPEG muxer

2012-01-13 Thread Kostya Shishkov
On Fri, Jan 13, 2012 at 03:34:04AM +, Paul B Mahol wrote: > --- > doc/general.texi |2 +- > libavformat/Makefile |1 + > libavformat/allformats.c |2 +- > libavformat/smjpeg.c | 101 - > 4 files changed, 101 insertions(+)

Re: [libav-devel] vorbis: fix FPE when multiple values of x in the floor1 list

2012-01-13 Thread Vladimir Pantelic
Ronald S. Bultje wrote: Hi, On Thu, Jan 12, 2012 at 12:51 PM, Stratulat Oana wrote: int adx = x1 - x0; int ady = FFABS(dy); int sy = dy< 0 ? -1 : 1; +if (adx == 0) +adx = 1; OK, I guess. The ugliness has to go somewhere. Maybe add a comment that it prevents