Re: [libav-devel] [PATCH] dxa: Use bytestream2 API to fix unsafe code

2012-01-16 Thread Laurentiu Cristian Ion
Hi, please review the patch and give me feedback, I applied all the suggestions and added bytestream2 in decode_13(), tested it and everything is working :) 2012/1/17 Laurentiu Ion > --- > libavcodec/dxa.c | 167 > + > 1 files changed, 91 ins

[libav-devel] [PATCH] dxa: Use bytestream2 API to fix unsafe code

2012-01-16 Thread Laurentiu Ion
--- libavcodec/dxa.c | 167 + 1 files changed, 91 insertions(+), 76 deletions(-) diff --git a/libavcodec/dxa.c b/libavcodec/dxa.c index 97b912a..83cf6ea 100644 --- a/libavcodec/dxa.c +++ b/libavcodec/dxa.c @@ -29,6 +29,7 @@ #include "libavut

Re: [libav-devel] Patch error_resilience:cosmetics

2012-01-16 Thread Diego Biurrun
On Mon, Jan 16, 2012 at 11:11:42PM +0200, Donald wrote: > [...] Looks mostly good. Send a fresh patch with the changes I request below. I will queue it tomorrow. I'm OK with you getting your GCI points for sending that updated patch. > --- a/libavcodec/error_resilience.c > +++ b/libavcodec/erro

Re: [libav-devel] [PATCH 1/4] mpegvideo: fix invalid memory access for small video dimensions

2012-01-16 Thread John Brooks
On Mon, Jan 9, 2012 at 1:58 AM, Kostya Shishkov wrote: > On 4 January 2012 07:27, John Brooks wrote: >> For small video dimensions, these calculations of the upper bound >> for pixel access may have a negative result. Using an unsigned >> comparison to bound a potentially negative value only work

Re: [libav-devel] rv40: x86 SIMD for biweight

2012-01-16 Thread Christophe Gisquet
2012/1/16 Christophe Gisquet : > Summary of changes since previous patch: > try to factorize a bit more > use movh/movhps > fix number of gprs used And the last point I had forgotten, replacing RET by REP_RET rv40dsp_yasm.asm Description: Binary data _

Re: [libav-devel] rv40: x86 SIMD for biweight

2012-01-16 Thread Christophe Gisquet
2012/1/12 Christophe Gisquet : > Unfortunately, the SSSE3 version is not as > effective as the previous values made it look, and I'm wondering if > the few cycles shaved are worth the object size. Checked the above: this occurred because I switched to another sequence which didn't use the fastpath

Re: [libav-devel] Patch error_resilience:cosmetics

2012-01-16 Thread Diego Biurrun
On Mon, Jan 16, 2012 at 11:11:42PM +0200, Donald wrote: > Patch attached here. > >From 0eea4ea1cd482941b4d8581e2b94a5729b928379 Mon Sep 17 00:00:00 2001 > From: Donald Ovcharov > Date: Sat, 17 Dec 2011 21:30:01 +0200 > Subject: [PATCH] error_resilience:cosmetics So which is your official email a

Re: [libav-devel] [PATCH] avconv: fix -frames for video encoders with delay.

2012-01-16 Thread Luca Barbato
On 1/16/12 10:51 AM, Anton Khirnov wrote: Frames must be counted when they are passed to the encoder, not when they come out. --- avconv.c | 20 +++- 1 files changed, 19 insertions(+), 1 deletions(-) Seems fine. lu ___ libav-de

[libav-devel] [PATCH] avconv: fix -frames for video encoders with delay.

2012-01-16 Thread Anton Khirnov
Frames must be counted when they are passed to the encoder, not when they come out. --- avconv.c | 20 +++- 1 files changed, 19 insertions(+), 1 deletions(-) diff --git a/avconv.c b/avconv.c index 2246851..e2cc4b0 100644 --- a/avconv.c +++ b/avconv.c @@ -875,6 +875,19 @@ static

Re: [libav-devel] [PATCH 1/1] rv34: 1-pass inter MB reconstruction

2012-01-16 Thread Kostya Shishkov
On Sun, Jan 15, 2012 at 07:26:46PM +0100, Janne Grunau wrote: > From: Christophe GISQUET > > Implement 1-pass inverse transform and reconstruction for inter blocks. > --- > libavcodec/arm/rv34dsp_init_neon.c |8 +- > libavcodec/arm/rv34dsp_neon.S | 59 ++ > libavcodec/rv34.c

Re: [libav-devel] [PATCH 1/7] avcodec: add duration field to AVCodecParserContext

2012-01-16 Thread Justin Ruggles
On 01/12/2012 11:43 PM, Justin Ruggles wrote: > This will allow parsers to export the duration of the current frame being > output, if known, instead of using AVCodecContext.frame_size. > --- > doc/APIchanges |3 +++ > libavcodec/avcodec.h |7 +++ > libavcodec/version.h |2 +

Re: [libav-devel] [PATCH 1/1] rv34: add NEON rv34_idct_add

2012-01-16 Thread Måns Rullgård
Janne Grunau writes: > Overall almost 4% faster, idct_add down from 350 to 85 cycles, idct_dc_add > down from 83 to 30 cycles. > > squash: rv34 idct rearrange partial register loads > --- > libavcodec/arm/rv34dsp_init_neon.c |6 > libavcodec/arm/rv34dsp_neon.S | 59 > +++

[libav-devel] [PATCH 1/1] rv34: add NEON rv34_idct_add

2012-01-16 Thread Janne Grunau
Overall almost 4% faster, idct_add down from 350 to 85 cycles, idct_dc_add down from 83 to 30 cycles. squash: rv34 idct rearrange partial register loads --- libavcodec/arm/rv34dsp_init_neon.c |6 libavcodec/arm/rv34dsp_neon.S | 59 ++-- 2 files chan

Re: [libav-devel] [PATCH 1/4] mpegaudiodec: switch error detection check to AV_EF_BUFFER

2012-01-16 Thread Justin Ruggles
On 01/16/2012 08:25 AM, Dustin Brody wrote: > --- > libavcodec/mpegaudiodec.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavcodec/mpegaudiodec.c b/libavcodec/mpegaudiodec.c > index 6a06afa..a83b162 100644 > --- a/libavcodec/mpegaudiodec.c > +++ b/libavcodec/

Re: [libav-devel] [PATCH 2/4] lavf: migrate deprecated FF_ER_* to AV_EF_*

2012-01-16 Thread Justin Ruggles
On 01/16/2012 08:25 AM, Dustin Brody wrote: > --- > libavformat/avformat.h |2 +- > libavformat/avidec.c |4 ++-- > libavformat/options.c |8 +--- > 3 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index fff911

Re: [libav-devel] [PATCH] dxa: Use bytestream2 API to fix unsafe code

2012-01-16 Thread Justin Ruggles
On 01/16/2012 01:56 AM, Laurentiu Ion wrote: > --- > libavcodec/dxa.c | 44 ++-- > 1 files changed, 26 insertions(+), 18 deletions(-) > > diff --git a/libavcodec/dxa.c b/libavcodec/dxa.c > index 97b912a..baeb067 100644 > --- a/libavcodec/dxa.c > +++ b/li

Re: [libav-devel] [PATCH 1/1] rv34: add NEON rv34_idct_add

2012-01-16 Thread Måns Rullgård
Janne Grunau writes: > +/* void rv34_idct_add_c(uint8_t *dst, int stride, DCTELEM *block) */ > +function ff_rv34_idct_add_neon, export=1 > +mov r3, r0 > +rv34_inv_transform r2 > +vmov.i16q12, #0 > +vrshrn.s32 d16, q1, #10 @ (z0 + z3)

[libav-devel] [PATCH 4/4] avconv: add master err_detect option controlling c_err_detect and f_err_detect

2012-01-16 Thread Dustin Brody
--- avconv.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/avconv.c b/avconv.c index 2246851..7d30b99 100644 --- a/avconv.c +++ b/avconv.c @@ -295,6 +295,7 @@ typedef struct OptionsContext { /* input options */ int64_t input_ts_offset; int rate_emu;

[libav-devel] [PATCH 2/4] lavf: migrate deprecated FF_ER_* to AV_EF_*

2012-01-16 Thread Dustin Brody
--- libavformat/avformat.h |2 +- libavformat/avidec.c |4 ++-- libavformat/options.c |8 +--- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index fff911a..155fc03 100644 --- a/libavformat/avformat.h +++ b/libavfor

[libav-devel] [PATCH 3/4] lavc: rename and add help documentation to error detection option

2012-01-16 Thread Dustin Brody
--- libavcodec/options.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/options.c b/libavcodec/options.c index 00d80e0..fd8a90b 100644 --- a/libavcodec/options.c +++ b/libavcodec/options.c @@ -208,11 +208,11 @@ static const AVOption options[]={ {"very

[libav-devel] [PATCH 1/4] mpegaudiodec: switch error detection check to AV_EF_BUFFER

2012-01-16 Thread Dustin Brody
--- libavcodec/mpegaudiodec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/mpegaudiodec.c b/libavcodec/mpegaudiodec.c index 6a06afa..a83b162 100644 --- a/libavcodec/mpegaudiodec.c +++ b/libavcodec/mpegaudiodec.c @@ -985,7 +985,7 @@ static int huffman_decode(

[libav-devel] [PATCH 1/1] rv34: add NEON rv34_idct_add

2012-01-16 Thread Janne Grunau
Overall almost 4% faster, idct_add down from 350 to 85 cycles, idct_dc_add down from 83 to 30 cycles. squash: rv34 idct rearrange partial register loads --- libavcodec/arm/rv34dsp_init_neon.c |6 libavcodec/arm/rv34dsp_neon.S | 59 ++-- 2 files chan

Re: [libav-devel] [PATCH 1/1] rv34: add NEON rv34_idct_add

2012-01-16 Thread Måns Rullgård
Janne Grunau writes: > Overall almost 4% faster, idct_add down from 340 to 92 cycles, idct_dc_add > down from 96 to 33 cycles. > --- > libavcodec/arm/rv34dsp_init_neon.c |6 > libavcodec/arm/rv34dsp_neon.S | 58 > ++-- > 2 files changed, 61 insert

Re: [libav-devel] Patch error_resilience:cosmetics

2012-01-16 Thread Luca Barbato
On 1/15/12 11:37 PM, Diego Biurrun wrote: On Sun, Jan 15, 2012 at 11:42:56PM +0200, Donald Ovcharov wrote: To: Diego First of all thank you for the spent time to clarify my task.I do appreciate it. I got rid of the abv mailer .I have problems with thunderbird connecting to my abv e-mail so I've

Re: [libav-devel] [PATCH 2/2] avformat: add SMJPEG muxer

2012-01-16 Thread Kostya Shishkov
On Sat, Jan 14, 2012 at 07:29:59PM +, Paul B Mahol wrote: > --- > Changelog|1 + > doc/general.texi |2 +- > libavformat/Makefile |1 + > libavformat/allformats.c |2 +- > libavformat/smjpegenc.c | 149 > +++

Re: [libav-devel] [PATCH 1/1] rv34: add NEON rv34_idct_add

2012-01-16 Thread Christophe Gisquet
Hi, 2012/1/16 Janne Grunau : > Overall almost 4% faster, idct_add down from 340 to 92 cycles, idct_dc_add > down from 96 to 33 cycles. Nice. I'm glad all those changes are now paying off. Although a bit off-topic, do you have figures comparing before the changes since dequant modifications (but a

[libav-devel] [PATCH 1/1] rv34: add NEON rv34_idct_add

2012-01-16 Thread Janne Grunau
Overall almost 4% faster, idct_add down from 340 to 92 cycles, idct_dc_add down from 96 to 33 cycles. --- libavcodec/arm/rv34dsp_init_neon.c |6 libavcodec/arm/rv34dsp_neon.S | 58 ++-- 2 files changed, 61 insertions(+), 3 deletions(-) diff --git a/