Re: [libav-devel] [PATCH] cosmetics: Rename ffsink to avsink.

2012-01-18 Thread Anton Khirnov
On Wed, 18 Jan 2012 23:18:39 +0100, Diego Biurrun wrote: > --- > avconv.c |6 +++--- > avplay.c |6 +++--- > cmdutils.c | 20 ++-- > cmdutils.h |4 ++-- > ffmpeg.c |6 +++--- > 5 files changed, 21 insertions(+), 21 deletions(-) > You can't do that. AV an

Re: [libav-devel] [PATCH 2/2] avplay: add support for using a user-specified decoder name.

2012-01-18 Thread Anton Khirnov
On Wed, 18 Jan 2012 17:19:43 -0500, Justin Ruggles wrote: > Allows for choosing an alternate decoder when available. > --- > avplay.c | 35 ++- > 1 files changed, 30 insertions(+), 5 deletions(-) > > diff --git a/avplay.c b/avplay.c > index 4d21234..ad27aef 10

Re: [libav-devel] [PATCH 1/2] avformat: Use AVCodecContext.codec for displaying the codec name

2012-01-18 Thread Anton Khirnov
On Wed, 18 Jan 2012 17:19:42 -0500, Justin Ruggles wrote: > --- > libavcodec/utils.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index ff3f065..3fa9a55 100644 > --- a/libavcodec/utils.c > +++ b/libavcodec/utils.c >

Re: [libav-devel] [PATCH 11/11] aacenc: Simplify windowing

2012-01-18 Thread Nathan Caldwell
On Wed, Jan 18, 2012 at 10:41 PM, Nathan Caldwell wrote: > --- >  libavcodec/aacenc.c |  103 > ++- >  1 files changed, 69 insertions(+), 34 deletions(-) Fix trailing whitespace. -- -Nathan Caldwell From 3bd9bfaafa815780a76fee93ba15835f857f4aa0 M

Re: [libav-devel] [PATCH 10/11] aacenc: Move saved overlap samples to the beginning of the same buffer as incoming samples.

2012-01-18 Thread Nathan Caldwell
2012/1/18 Benjamin Larsson : > OK Fix trailing whitespace in context. -- -Nathan Caldwell From ef8cfc29823468ea239f1c458c0efaa900d4967e Mon Sep 17 00:00:00 2001 From: Nathan Caldwell Date: Sat, 24 Dec 2011 15:24:16 -0700 Subject: [PATCH 10/11] aacenc: Move saved overlap samples to the beginnin

Re: [libav-devel] [PATCH 09/11] aacenc: Deinterleave input samples before processing.

2012-01-18 Thread Nathan Caldwell
On Wed, Jan 18, 2012 at 1:39 PM, Nathan Caldwell wrote: > --- >  libavcodec/aacenc.c   |  102 +--- >  libavcodec/aacenc.h   |    6 ++- >  libavcodec/aacpsy.c   |   11 ++--- >  libavcodec/psymodel.c |   16 +++- >  libavcodec/psymodel.h |    9 +--- >  

[libav-devel] [PATCH 06/11] aacenc: Request normalized float samples instead of converting s16 samples to float.

2012-01-18 Thread Nathan Caldwell
--- libavcodec/aacenc.c | 12 ++-- libavcodec/aacenc.h |2 +- libavcodec/aacpsy.c | 10 +- libavcodec/psymodel.c |7 +++ libavcodec/psymodel.h |7 +++ 5 files changed, 18 insertions(+), 20 deletions(-) diff --git a/libavcodec/aacenc.c b/libavcodec/aac

Re: [libav-devel] [PATCH 06/11] aacenc: Request normalized float samples instead of converting s16 samples to float.

2012-01-18 Thread Nathan Caldwell
On Wed, Jan 18, 2012 at 2:29 PM, Alex Converse wrote: > On Wed, Jan 18, 2012 at 12:39 AM, Nathan Caldwell wrote: >> --- >>  libavcodec/aacenc.c   |   12 ++-- >>  libavcodec/aacenc.h   |    2 +- >>  libavcodec/aacpsy.c   |   10 ++ >>  libavcodec/psymodel.c |    7 +++ >>  libavc

[libav-devel] [PATCH 11/11] aacenc: Simplify windowing

2012-01-18 Thread Nathan Caldwell
--- libavcodec/aacenc.c | 103 ++- 1 files changed, 69 insertions(+), 34 deletions(-) diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c index 8b9a2ed..6b4fa86 100644 --- a/libavcodec/aacenc.c +++ b/libavcodec/aacenc.c @@ -178,45 +178,80 @@ sta

Re: [libav-devel] [PATCH 11/11] aacenc: Simplify windowing

2012-01-18 Thread Nathan Caldwell
On Wed, Jan 18, 2012 at 2:39 PM, Alex Converse wrote: >> @@ -709,6 +737,11 @@ static av_cold int aac_encode_init(AVCodecContext >> *avctx) >>         goto fail; >>     s->psypp = ff_psy_preprocess_init(avctx); >>     s->coder = &ff_aac_coders[2]; >> + >> +    s->apply_window[EIGHT_SHORT_SEQUENCE]

Re: [libav-devel] [PATCH 07/11] aacenc: Move Q^3/4 calculation to it's own table

2012-01-18 Thread Nathan Caldwell
On Wed, Jan 18, 2012 at 4:09 PM, Nathan Caldwell wrote: > On Wed, Jan 18, 2012 at 2:41 PM, Alex Converse > wrote: >> On Wed, Jan 18, 2012 at 12:39 AM, Nathan Caldwell wrote: >>> --- >>>  libavcodec/aac_tablegen.c      |    3 +++ >>>  libavcodec/aac_tablegen.h      |    9 - >>>  libavcod

Re: [libav-devel] (no subject)

2012-01-18 Thread Derek Buitenhuis
On 18/01/2012 1:25 PM, Diego Biurrun wrote: This is entirely untested due to lack of non-x86 machines and even crosscompilers. Since Luca volunteered to test ppc, I'm sending this already and hoping for more volunteers:) Since it may be useful to more than one person: http://autobuilder.yocto

Re: [libav-devel] [PATCH 2/2] swscale: formatting cosmetics for Blackfin Assembly code

2012-01-18 Thread Måns Rullgård
Diego Biurrun writes: > --- > libswscale/bfin/internal_bfin.S | 968 +++--- > 1 files changed, 484 insertions(+), 484 deletions(-) What is the purpose of this? It is hardly any more readable after your changes, and I doubt you have any intention to work on that

Re: [libav-devel] [PATCH 2/2] fate: add some shorthands to run groups of tests

2012-01-18 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 06:23:02PM -0500, Justin Ruggles wrote: > > -FATE_TESTS += fate-fax-g3 > > +FATE_FAX += fate-fax-g3 > > fate-fax-g3: CMD = framecrc -i $(SAMPLES)/CCITT_fax/G31D.TIF > > > > -FATE_TESTS += fate-fax-g3s > > +FATE_FAX += fate-fax-g3s > > fate-fax-g3s: CMD = framecrc -i $(SA

Re: [libav-devel] [PATCH 2/2] fate: add some shorthands to run groups of tests

2012-01-18 Thread Justin Ruggles
> -FATE_TESTS += fate-fax-g3 > +FATE_FAX += fate-fax-g3 > fate-fax-g3: CMD = framecrc -i $(SAMPLES)/CCITT_fax/G31D.TIF > > -FATE_TESTS += fate-fax-g3s > +FATE_FAX += fate-fax-g3s > fate-fax-g3s: CMD = framecrc -i $(SAMPLES)/CCITT_fax/G31DS.TIF > > +FATE_TESTS += $(FATE_FAX) > +fate-fax: $(FAT

Re: [libav-devel] [PATCH 1/2] fate: Give some tests more sensible names.

2012-01-18 Thread Justin Ruggles
On 01/15/2012 04:17 PM, Diego Biurrun wrote: > --- > 39 files changed, 72 insertions(+), 72 deletions(-) > rename tests/ref/fate/{creative-adpcm => adpcm-creative} (100%) > rename tests/ref/fate/{creative-adpcm-8-2.6bit => adpcm-creative-8-2.6bit} > (100%) > rename tests/ref/fate/{creative-ad

Re: [libav-devel] [PATCH 07/11] aacenc: Move Q^3/4 calculation to it's own table

2012-01-18 Thread Nathan Caldwell
On Wed, Jan 18, 2012 at 2:41 PM, Alex Converse wrote: > On Wed, Jan 18, 2012 at 12:39 AM, Nathan Caldwell wrote: >> --- >>  libavcodec/aac_tablegen.c      |    3 +++ >>  libavcodec/aac_tablegen.h      |    9 - >>  libavcodec/aac_tablegen_decl.h |    6 ++ >>  libavcodec/aaccoder.c    

Re: [libav-devel] [PATCH 2/2] avplay: add support for using a user-specified decoder name.

2012-01-18 Thread Luca Barbato
On 18/01/12 14:19, Justin Ruggles wrote: Allows for choosing an alternate decoder when available. +{ "acodec", HAS_ARG | OPT_STRING,&acodec_name, "audio codec name", "" }, +{ "vcodec", HAS_ARG | OPT_STRING,&vcodec_name, "video codec name", "" }, Would be possible keep it consistent w

Re: [libav-devel] [PATCH] cosmetics: Rename ffsink to avsink.

2012-01-18 Thread Luca Barbato
On 18/01/12 14:18, Diego Biurrun wrote: --- avconv.c |6 +++--- avplay.c |6 +++--- cmdutils.c | 20 ++-- cmdutils.h |4 ++-- ffmpeg.c |6 +++--- 5 files changed, 21 insertions(+), 21 deletions(-) Ok -- Luca Barbato Gentoo/linux http://dev.gent

Re: [libav-devel] [PATCH 05/11] aacpsy: Replace an if with FFMAX in LAME windowing.

2012-01-18 Thread Nathan Caldwell
On Wed, Jan 18, 2012 at 2:27 PM, Alex Converse wrote: > On Wed, Jan 18, 2012 at 12:39 AM, Nathan Caldwell wrote: >> >> --- >>  libavcodec/aacpsy.c |    3 +-- >>  1 files changed, 1 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/aacpsy.c b/libavcodec/aacpsy.c >> index 04feea3..577d8fb

[libav-devel] [PATCH 2/2] swscale: formatting cosmetics for Blackfin Assembly code

2012-01-18 Thread Diego Biurrun
--- libswscale/bfin/internal_bfin.S | 968 +++--- 1 files changed, 484 insertions(+), 484 deletions(-) diff --git a/libswscale/bfin/internal_bfin.S b/libswscale/bfin/internal_bfin.S index 9f985e7..1f46cb5 100644 --- a/libswscale/bfin/internal_bfin.S +++ b/libswsca

[libav-devel] [PATCH 1/2] swscale: K&R formatting cosmetics for Blackfin C code

2012-01-18 Thread Diego Biurrun
--- libswscale/bfin/swscale_bfin.c | 48 +++-- libswscale/bfin/yuv2rgb_bfin.c | 91 2 files changed, 72 insertions(+), 67 deletions(-) diff --git a/libswscale/bfin/swscale_bfin.c b/libswscale/bfin/swscale_bfin.c index 0c5f004..f9eba1e 1

[libav-devel] [PATCH] doc: Mention that '-vf' is an alias for '-filter:v' in avplay documentation.

2012-01-18 Thread Diego Biurrun
--- doc/avplay.texi |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/avplay.texi b/doc/avplay.texi index 8fc3308..a597bef 100644 --- a/doc/avplay.texi +++ b/doc/avplay.texi @@ -61,7 +61,7 @@ Set window title (default is the input filename). Loops movie playback times

Re: [libav-devel] [PATCH] mpeg12: check for available bits to avoid an infinite loop

2012-01-18 Thread Ronald S. Bultje
Hi, 2012/1/18 Jindřich Makovička : > this patch adds a check for remaining bits in a get_vlc2() loop. > Sometimes, this reading loop can get to the end of the buffer, and > then get_vlc2() keeps returning 35, resulting in a lockup: > > mpeg_decode_slice (s=0x440d0c0, mb_y=32, buf=0x7fff97bb6df0, >

[libav-devel] [PATCH] fate: Employ modern and preferred avconv syntax.

2012-01-18 Thread Diego Biurrun
--- tests/codec-regression.sh | 124 ++-- tests/fate/demux.mak | 36 +++--- tests/fate/h264.mak |4 +- tests/fate/microsoft.mak |4 +- tests/fate/mp3.mak| 14 +++--- tests/fate/mpc.mak|4 +- tests/fate/vid

Re: [libav-devel] [PATCH] mpeg12: check for available bits to avoid an infinite loop

2012-01-18 Thread Justin Ruggles
On 01/18/2012 04:07 PM, Jindřich Makovička wrote: > Hi, > > this patch adds a check for remaining bits in a get_vlc2() loop. > Sometimes, this reading loop can get to the end of the buffer, and > then get_vlc2() keeps returning 35, resulting in a lockup: > > mpeg_decode_slice (s=0x440d0c0, mb_y=

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-18 Thread Ronald S. Bultje
Hi, On Wed, Jan 18, 2012 at 1:15 PM, Uoti Urpala wrote: > On Wed, 2012-01-18 at 06:35 -0800, Ronald S. Bultje wrote: >> On Wed, Jan 18, 2012 at 5:52 AM, Janne Grunau wrote: >> > On 2012-01-18 12:46:28 +, Måns Rullgård wrote: >> >> "Ronald S. Bultje" writes: >> >> > On Wed, Jan 18, 2012 at 2

[libav-devel] [PATCH 2/2] avplay: add support for using a user-specified decoder name.

2012-01-18 Thread Justin Ruggles
Allows for choosing an alternate decoder when available. --- avplay.c | 35 ++- 1 files changed, 30 insertions(+), 5 deletions(-) diff --git a/avplay.c b/avplay.c index 4d21234..ad27aef 100644 --- a/avplay.c +++ b/avplay.c @@ -259,6 +259,8 @@ static int exit_on_k

[libav-devel] [PATCH 1/2] avformat: Use AVCodecContext.codec for displaying the codec name

2012-01-18 Thread Justin Ruggles
--- libavcodec/utils.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index ff3f065..3fa9a55 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -1405,7 +1405,9 @@ void avcodec_string(char *buf, int buf_size, AVCodecCont

[libav-devel] [PATCH] cosmetics: Rename ffsink to avsink.

2012-01-18 Thread Diego Biurrun
--- avconv.c |6 +++--- avplay.c |6 +++--- cmdutils.c | 20 ++-- cmdutils.h |4 ++-- ffmpeg.c |6 +++--- 5 files changed, 21 insertions(+), 21 deletions(-) diff --git a/avconv.c b/avconv.c index 5766413..9861faf 100644 --- a/avconv.c +++ b/avconv.c @@ -550

Re: [libav-devel] [PATCH] cosmetics: Rename avsink to ffsink.

2012-01-18 Thread Luca Barbato
Isn't it the other way round? -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] mpegaudio: replace a memcpy by SIMD code

2012-01-18 Thread Christophe Gisquet
Hi, found this by chance, and I would think this is worthwhile. Loading in+512 into another register saves some instruction size, not negligible compared to the whole code block size. I haven't tried movnt stuff, as the amount of data is probably small. Best regards, Christophe 0003-mpegaudio-r

[libav-devel] [PATCH] cosmetics: Rename avsink to ffsink.

2012-01-18 Thread Diego Biurrun
--- It's not my fault! Mike trolled me! ;-p avconv.c |6 +++--- avplay.c |6 +++--- cmdutils.c | 20 ++-- cmdutils.h |4 ++-- ffmpeg.c |6 +++--- 5 files changed, 21 insertions(+), 21 deletions(-) diff --git a/avconv.c b/avconv.c index 5766413..9861faf 1

[libav-devel] [PATCH 1/1] lavf: force single-threaded decoding in avformat_find_stream_info

2012-01-18 Thread Janne Grunau
On 2012-01-18 21:38:18 +0100, Anton Khirnov wrote: > > On Wed, 18 Jan 2012 20:52:28 +0100, Janne Grunau > wrote: > > The H.264 decoder needs SPS and PPS for initialization during > > multi-threaded decoding. When probed single-threaded SPS and PPS are > > copied to extradata and are available for

Re: [libav-devel] [PATCH 00/11] Various AAC Encoder changes

2012-01-18 Thread Alex Converse
On Wed, Jan 18, 2012 at 12:39 AM, Nathan Caldwell wrote: > Here are some patches for the AAC encoder that I've stockpiled while working > on other areas of the encoder. > > The first patch in the series is a rework of an already approved (but never > committed) patch, so it will need re-reviewed.

Re: [libav-devel] [PATCH 07/11] aacenc: Move Q^3/4 calculation to it's own table

2012-01-18 Thread Alex Converse
On Wed, Jan 18, 2012 at 12:39 AM, Nathan Caldwell wrote: > --- >  libavcodec/aac_tablegen.c      |    3 +++ >  libavcodec/aac_tablegen.h      |    9 - >  libavcodec/aac_tablegen_decl.h |    6 ++ >  libavcodec/aaccoder.c          |    7 --- >  4 files changed, 21 insertions(+), 4 de

Re: [libav-devel] [PATCH 11/11] aacenc: Simplify windowing

2012-01-18 Thread Alex Converse
> @@ -709,6 +737,11 @@ static av_cold int aac_encode_init(AVCodecContext *avctx) >         goto fail; >     s->psypp = ff_psy_preprocess_init(avctx); >     s->coder = &ff_aac_coders[2]; > + > +    s->apply_window[EIGHT_SHORT_SEQUENCE] = apply_eight_short_window; > +    s->apply_window[LONG_START_SE

Re: [libav-devel] [PATCH 06/11] aacenc: Request normalized float samples instead of converting s16 samples to float.

2012-01-18 Thread Alex Converse
On Wed, Jan 18, 2012 at 12:39 AM, Nathan Caldwell wrote: > --- >  libavcodec/aacenc.c   |   12 ++-- >  libavcodec/aacenc.h   |    2 +- >  libavcodec/aacpsy.c   |   10 ++ >  libavcodec/psymodel.c |    7 +++ >  libavcodec/psymodel.h |    7 +++ >  5 files changed, 19 insertion

Re: [libav-devel] [PATCH 05/11] aacpsy: Replace an if with FFMAX in LAME windowing.

2012-01-18 Thread Alex Converse
On Wed, Jan 18, 2012 at 12:39 AM, Nathan Caldwell wrote: > > --- >  libavcodec/aacpsy.c |    3 +-- >  1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/aacpsy.c b/libavcodec/aacpsy.c > index 04feea3..577d8fb 100644 > --- a/libavcodec/aacpsy.c > +++ b/libavcodec/aacpsy.c

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-18 Thread Uoti Urpala
On Wed, 2012-01-18 at 06:35 -0800, Ronald S. Bultje wrote: > On Wed, Jan 18, 2012 at 5:52 AM, Janne Grunau wrote: > > On 2012-01-18 12:46:28 +, Måns Rullgård wrote: > >> "Ronald S. Bultje" writes: > >> > On Wed, Jan 18, 2012 at 2:46 AM, Janne Grunau > >> > wrote: > >> >> Users of libavcodec

Re: [libav-devel] [PATCH] cosmetics: K&R reformatting for several files avprobe.c cmdutils.h tests/audiogen.c tests/rotozoom.c tests/tiny_psnr.c tests/videogen.c

2012-01-18 Thread Diego Biurrun
On Mon, Jan 02, 2012 at 02:19:00PM +0530, Gaurav Narula wrote: > --- > avprobe.c | 59 +++ > cmdutils.h| 18 +-- > tests/audiogen.c | 32 ++-- > tests/base64.c|6 +- > tests/rotozoom.c | 80 +++--- > tests/ti

[libav-devel] [PATCH] mpeg12: check for available bits to avoid an infinite loop

2012-01-18 Thread Jindřich Makovička
Hi, this patch adds a check for remaining bits in a get_vlc2() loop. Sometimes, this reading loop can get to the end of the buffer, and then get_vlc2() keeps returning 35, resulting in a lockup: mpeg_decode_slice (s=0x440d0c0, mb_y=32, buf=0x7fff97bb6df0, buf_size=184) at libavcodec/mpeg12.c:1662

[libav-devel] [PATCH 09/11] aacenc: Deinterleave input samples before processing.

2012-01-18 Thread Nathan Caldwell
--- libavcodec/aacenc.c | 102 +--- libavcodec/aacenc.h |6 ++- libavcodec/aacpsy.c | 11 ++--- libavcodec/psymodel.c | 16 +++- libavcodec/psymodel.h |9 +--- 5 files changed, 81 insertions(+), 63 deletions(-) diff --git a/libavc

Re: [libav-devel] [PATCH 1/1] lavf: force single-threaded decoding in avformat_find_stream_info

2012-01-18 Thread Anton Khirnov
On Wed, 18 Jan 2012 20:52:28 +0100, Janne Grunau wrote: > The H.264 decoder needs SPS and PPS for initialization during > multi-threaded decoding. When probed single-threaded SPS and PPS are > copied to extradata and are available for proper initialization of > the decoder before the first frame

Re: [libav-devel] [PATCH 01/11] aacenc: aac_encode_init() cleanup

2012-01-18 Thread Nathan Caldwell
On Wed, Jan 18, 2012 at 8:09 AM, Diego Biurrun wrote: > On Wed, Jan 18, 2012 at 01:39:48AM -0700, Nathan Caldwell wrote: >> Macroify sanity checks and check return values of allocs and other functions. >> >> --- a/libavcodec/aacenc.c >> +++ b/libavcodec/aacenc.c >> @@ -46,6 +46,12 @@ >> >> +#defin

Re: [libav-devel] [PATCH 09/11] aacenc: Deinterleave input samples before processing.

2012-01-18 Thread Nathan Caldwell
On Wed, Jan 18, 2012 at 4:50 AM, Benjamin Larsson wrote: > On 01/18/2012 09:39 AM, Nathan Caldwell wrote: >> >> --- >>  libavcodec/aacenc.c   |  102 >> +--- >>  libavcodec/aacenc.h   |    6 ++- >>  libavcodec/aacpsy.c   |   11 ++--- >>  libavcodec/psymod

[libav-devel] [PATCH 1/1] lavf: force single-threaded decoding in avformat_find_stream_info

2012-01-18 Thread Janne Grunau
The H.264 decoder needs SPS and PPS for initialization during multi-threaded decoding. When probed single-threaded SPS and PPS are copied to extradata and are available for proper initialization of the decoder before the first frame is decoded. --- libavformat/utils.c | 21 ++---

[libav-devel] [PATCH] cosmetics: Remove some unnecessary block braces.

2012-01-18 Thread Diego Biurrun
--- libavcodec/motion_est.c | 36 +--- libavfilter/vf_hflip.c |2 -- libswscale/ppc/swscale_altivec.c | 10 -- 3 files changed, 17 insertions(+), 31 deletions(-) diff --git a/libavcodec/motion_est.c b/libavcodec/motion_est.c index

Re: [libav-devel] [PATCH] cosmetics: Remove some unnecessary block braces.

2012-01-18 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 06:25:15PM +, Måns Rullgård wrote: > Diego Biurrun writes: > > > --- > > libavcodec/motion_est.c |2 -- > > libavfilter/vf_hflip.c |2 -- > > libswscale/ppc/swscale_altivec.c | 10 -- > > 3 files changed, 0 insertions(+), 14 deleti

Re: [libav-devel] [PATCH 4/5] doc: Suggest modern and preferred command line syntax.

2012-01-18 Thread Luca Barbato
On 18/01/12 10:23, Diego Biurrun wrote: --- doc/avconv.texi |2 +- doc/encoders.texi|2 +- doc/faq.texi | 12 +--- doc/filters.texi | 10 +- doc/libavfilter.texi |2 +- 5 files changed, 13 insertions(+), 15 deletions(-) Did you try th

Re: [libav-devel] [PATCH 1/5] fate: Employ modern and preferred avconv syntax.

2012-01-18 Thread Justin Ruggles
On 01/18/2012 01:23 PM, Diego Biurrun wrote: > --- > tests/codec-regression.sh | 124 ++-- > tests/fate/demux.mak | 36 +++--- > tests/fate/h264.mak |4 +- > tests/fate/microsoft.mak |4 +- > tests/fate/mp3.mak| 14 +

Re: [libav-devel] [PATCH 1/2] lavf: fix and extend av_interleaved_write_frame() doxy.

2012-01-18 Thread Justin Ruggles
On 01/18/2012 12:43 PM, Anton Khirnov wrote: > > On Wed, 18 Jan 2012 12:11:36 -0500, Justin Ruggles > wrote: >> >> Mostly looks good. The function already frees the packet in most cases. >> >> Not sure about the current vs. new wording for @return. What is that "1 >> if end of stream wanted", a

Re: [libav-devel] [PATCH 3/4] swscale: K&R formatting cosmetics for Blackfin code

2012-01-18 Thread Måns Rullgård
Diego Biurrun writes: > --- > libswscale/bfin/internal_bfin.S | 968 +++--- Please do not mess with assembler code calling it K&R cosmetics. -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list libav-devel@lib

Re: [libav-devel] [PATCH 3/5] doc: Mention that '-vf' is an alias for '-filter:v' in avplay documentation.

2012-01-18 Thread Måns Rullgård
Diego Biurrun writes: > --- > doc/avplay.texi |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/doc/avplay.texi b/doc/avplay.texi > index 8fc3308..24303c3 100644 > --- a/doc/avplay.texi > +++ b/doc/avplay.texi > @@ -63,7 +63,7 @@ Loops movie playback times. 0 means

[libav-devel] [PATCH 2/4] swscale: K&R formatting cosmetics for SPARC code

2012-01-18 Thread Diego Biurrun
--- libswscale/sparc/yuv2rgb_vis.c | 251 1 files changed, 125 insertions(+), 126 deletions(-) diff --git a/libswscale/sparc/yuv2rgb_vis.c b/libswscale/sparc/yuv2rgb_vis.c index 2111ea8..bcd2081 100644 --- a/libswscale/sparc/yuv2rgb_vis.c +++ b/libswscale

[libav-devel] [PATCH 3/4] swscale: K&R formatting cosmetics for Blackfin code

2012-01-18 Thread Diego Biurrun
--- libswscale/bfin/internal_bfin.S | 968 +++--- libswscale/bfin/swscale_bfin.c | 48 +- libswscale/bfin/yuv2rgb_bfin.c | 91 ++-- 3 files changed, 556 insertions(+), 551 deletions(-) diff --git a/libswscale/bfin/internal_bfin.S b/libswscale/bfin/internal_b

[libav-devel] [PATCH 1/4] swscale: K&R formatting cosmetics for mlib code

2012-01-18 Thread Diego Biurrun
--- libswscale/mlib/yuv2rgb_mlib.c | 40 ++-- 1 files changed, 22 insertions(+), 18 deletions(-) diff --git a/libswscale/mlib/yuv2rgb_mlib.c b/libswscale/mlib/yuv2rgb_mlib.c index 526c975..f4cad55 100644 --- a/libswscale/mlib/yuv2rgb_mlib.c +++ b/libswscale/m

[libav-devel] (no subject)

2012-01-18 Thread Diego Biurrun
This is entirely untested due to lack of non-x86 machines and even crosscompilers. Since Luca volunteered to test ppc, I'm sending this already and hoping for more volunteers :) ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/

Re: [libav-devel] [PATCH] cosmetics: Remove some unnecessary block braces.

2012-01-18 Thread Måns Rullgård
Diego Biurrun writes: > --- > libavcodec/motion_est.c |2 -- > libavfilter/vf_hflip.c |2 -- > libswscale/ppc/swscale_altivec.c | 10 -- > 3 files changed, 0 insertions(+), 14 deletions(-) Looks OK. Would you mind also fixing the indentation of those blocks

[libav-devel] [PATCH 5/5] avconv: Document which command line options are preferred in (--help) output.

2012-01-18 Thread Diego Biurrun
--- avconv.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/avconv.c b/avconv.c index e2cc4b0..5766413 100644 --- a/avconv.c +++ b/avconv.c @@ -2313,7 +2313,7 @@ static int transcode_init(OutputFile *output_files, switch (codec-

[libav-devel] [PATCH 4/5] doc: Suggest modern and preferred command line syntax.

2012-01-18 Thread Diego Biurrun
--- doc/avconv.texi |2 +- doc/encoders.texi|2 +- doc/faq.texi | 12 +--- doc/filters.texi | 10 +- doc/libavfilter.texi |2 +- 5 files changed, 13 insertions(+), 15 deletions(-) diff --git a/doc/avconv.texi b/doc/avconv.texi index 0a83326..81

[libav-devel] [PATCH 2/5] avplay: Recommend modern, preferred syntax in error messages.

2012-01-18 Thread Diego Biurrun
--- avplay.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/avplay.c b/avplay.c index 4d21234..a90d066 100644 --- a/avplay.c +++ b/avplay.c @@ -1301,7 +1301,7 @@ static void alloc_picture(void *opaque) /* SDL allocates a buffer smaller than requested if the vide

[libav-devel] [PATCH 1/5] fate: Employ modern and preferred avconv syntax.

2012-01-18 Thread Diego Biurrun
--- tests/codec-regression.sh | 124 ++-- tests/fate/demux.mak | 36 +++--- tests/fate/h264.mak |4 +- tests/fate/microsoft.mak |4 +- tests/fate/mp3.mak| 14 +++--- tests/fate/mpc.mak|4 +- tests/fate/vid

[libav-devel] [PATCH 3/5] doc: Mention that '-vf' is an alias for '-filter:v' in avplay documentation.

2012-01-18 Thread Diego Biurrun
--- doc/avplay.texi |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/avplay.texi b/doc/avplay.texi index 8fc3308..24303c3 100644 --- a/doc/avplay.texi +++ b/doc/avplay.texi @@ -63,7 +63,7 @@ Loops movie playback times. 0 means forever. @var{filter_graph} is a descrip

[libav-devel] [PATCH] cosmetics: Remove some unnecessary block braces.

2012-01-18 Thread Diego Biurrun
--- libavcodec/motion_est.c |2 -- libavfilter/vf_hflip.c |2 -- libswscale/ppc/swscale_altivec.c | 10 -- 3 files changed, 0 insertions(+), 14 deletions(-) diff --git a/libavcodec/motion_est.c b/libavcodec/motion_est.c index c4512a9..be317b9 100644 --- a/liba

Re: [libav-devel] [PATCH 1/2] lavf: fix and extend av_interleaved_write_frame() doxy.

2012-01-18 Thread Anton Khirnov
On Wed, 18 Jan 2012 12:11:36 -0500, Justin Ruggles wrote: > > Mostly looks good. The function already frees the packet in most cases. > > Not sure about the current vs. new wording for @return. What is that "1 > if end of stream wanted", and is it true? If I read that function correctly, it n

Re: [libav-devel] Patch error_resilience:cosmetics

2012-01-18 Thread Diego Biurrun
On Tue, Jan 17, 2012 at 03:48:39AM +0200, Donald wrote: > The reply is over 100kb to send.Here is my patch. Pushed, thanks. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/2] lavf: fix and extend av_interleaved_write_frame() doxy.

2012-01-18 Thread Justin Ruggles
On 01/18/2012 02:14 AM, Anton Khirnov wrote: > Specify that lavf is responsible for freeing the data. > --- > libavformat/avformat.h | 15 --- > 1 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index fff911a..71aed

Re: [libav-devel] [PATCH 2/2] lavf: free packets for muxers implementing interleave_packet().

2012-01-18 Thread Justin Ruggles
On 01/18/2012 02:14 AM, Anton Khirnov wrote: > Fixes a memleak. > --- > libavformat/utils.c |9 ++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/libavformat/utils.c b/libavformat/utils.c > index 373f068..b1832ba 100644 > --- a/libavformat/utils.c > +++ b/libavfor

Re: [libav-devel] [PATCH] dxa: Use bytestream2 API to fix unsafe code

2012-01-18 Thread Diego Biurrun
This patch still contains stray changes, whoever pushes this, please fix or wait for an updated iteration. On Wed, Jan 18, 2012 at 05:58:07PM +0200, Laurentiu Cristian Ion wrote: > --- a/libavcodec/dxa.c > +++ b/libavcodec/dxa.c > @@ -85,17 +102,16 @@ static int decode_13(AVCodecContext *avctx, >

Re: [libav-devel] [PATCH] dxa: Use bytestream2 API to fix unsafe code

2012-01-18 Thread Laurentiu Cristian Ion
--- libavcodec/dxa.c | 181 +- 1 files changed, 97 insertions(+), 84 deletions(-) diff --git a/libavcodec/dxa.c b/libavcodec/dxa.c index 97b912a..1ad071e 100644 --- a/libavcodec/dxa.c +++ b/libavcodec/dxa.c @@ -29,6 +29,7 @@ #include "libavut

Re: [libav-devel] [PATCH] dxa: Use bytestream2 API to fix unsafe code

2012-01-18 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 05:01:49PM +0200, Laurentiu Cristian Ion wrote: > > --- a/libavcodec/dxa.c > +++ b/libavcodec/dxa.c > @@ -39,40 +40,56 @@ typedef struct DxaDecContext { > > -static int decode_13(AVCodecContext *avctx, DxaDecContext *c, uint8_t* > dst, uint8_t *src, uint8_t *ref) > -{ > -

Re: [libav-devel] [PATCH 07/11] aacenc: Move Q^3/4 calculation to it's own table

2012-01-18 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 01:39:54AM -0700, Nathan Caldwell wrote: > > --- a/libavcodec/aac_tablegen.c > +++ b/libavcodec/aac_tablegen.c > @@ -32,6 +32,9 @@ int main(void) > > WRITE_ARRAY("const", float, ff_aac_pow2sf_tab); > +#if CONFIG_AAC_ENCODER > +WRITE_ARRAY("const", float, ff_aac_p

Re: [libav-devel] [PATCH 07/11] aacenc: Move Q^3/4 calculation to it's own table

2012-01-18 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 12:40:36PM +0100, Benjamin Larsson wrote: > OK No, definitely not. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 01/11] aacenc: aac_encode_init() cleanup

2012-01-18 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 01:39:48AM -0700, Nathan Caldwell wrote: > Macroify sanity checks and check return values of allocs and other functions. > > --- a/libavcodec/aacenc.c > +++ b/libavcodec/aacenc.c > @@ -46,6 +46,12 @@ > > +#define ERROR_IF(cond, ...) \ > +if (cond) { \ > +av_lo

Re: [libav-devel] [PATCH] dxa: Use bytestream2 API to fix unsafe code

2012-01-18 Thread Laurentiu Cristian Ion
--- libavcodec/dxa.c | 226 +- 1 files changed, 120 insertions(+), 106 deletions(-) diff --git a/libavcodec/dxa.c b/libavcodec/dxa.c index 97b912a..105f90f 100644 --- a/libavcodec/dxa.c +++ b/libavcodec/dxa.c @@ -29,6 +29,7 @@ #include "libav

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-18 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 11:46:36AM +0100, Janne Grunau wrote: > Users of libavcodec could break if they do not threadsafe callbacks. > Avconv and avplay still use -threads auto if not specified. .. could break if they do threadunsafe callbacks. Diego __

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-18 Thread Ronald S. Bultje
Hi, On Wed, Jan 18, 2012 at 5:52 AM, Janne Grunau wrote: > On 2012-01-18 12:46:28 +, Måns Rullgård wrote: >> "Ronald S. Bultje" writes: >> >> > Hi, >> > >> > On Wed, Jan 18, 2012 at 2:46 AM, Janne Grunau >> > wrote: >> >> Users of libavcodec could break if they do not threadsafe callbacks.

Re: [libav-devel] [PATCH] dxa: Use bytestream2 API to fix unsafe code

2012-01-18 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 03:23:01PM +0200, Laurentiu Cristian Ion wrote: > --- a/libavcodec/dxa.c > +++ b/libavcodec/dxa.c > @@ -39,41 +40,57 @@ typedef struct DxaDecContext { > > -static int decode_13(AVCodecContext *avctx, DxaDecContext *c, uint8_t* > dst, uint8_t *src, uint8_t *ref) > -{ > -

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-18 Thread Janne Grunau
On 2012-01-18 12:46:28 +, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > > > Hi, > > > > On Wed, Jan 18, 2012 at 2:46 AM, Janne Grunau > > wrote: > >> Users of libavcodec could break if they do not threadsafe callbacks. > >> Avconv and avplay still use -threads auto if not specified. >

Re: [libav-devel] [PATCH] dxa: Use bytestream2 API to fix unsafe code

2012-01-18 Thread Laurentiu Cristian Ion
--- libavcodec/dxa.c | 257 -- 1 files changed, 135 insertions(+), 122 deletions(-) diff --git a/libavcodec/dxa.c b/libavcodec/dxa.c index 97b912a..73e0b47 100644 --- a/libavcodec/dxa.c +++ b/libavcodec/dxa.c @@ -29,6 +29,7 @@ #include "libav

Re: [libav-devel] [PATCH] Declare avformat_find_stream_info 'options' param with real type

2012-01-18 Thread Andrey Utkin
2012/1/18 Måns Rullgård : > The change makes no sense.  Perhaps what your sense of purity was really > looking for was AVDictionary *options[], which is of course equivalent > with the current declaration. Yes, i was terribly wrong. Thanks for explanation. -- Andrey Utkin ___

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-18 Thread Måns Rullgård
"Ronald S. Bultje" writes: > Hi, > > On Wed, Jan 18, 2012 at 2:46 AM, Janne Grunau wrote: >> Users of libavcodec could break if they do not threadsafe callbacks. >> Avconv and avplay still use -threads auto if not specified. > > What callbacks? get_buffer() and friends I presume, since there ar

Re: [libav-devel] [PATCH] Declare avformat_find_stream_info 'options' param with real type

2012-01-18 Thread Måns Rullgård
Andrey Utkin writes: > It is treated not as **AVDictionary, but as an array of such. > Show it in declaration. > --- > libavformat/avformat.h |2 +- > libavformat/utils.c| 10 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavformat/avformat.h b/libavf

Re: [libav-devel] [PATCH] Declare avformat_find_stream_info 'options' param with real type

2012-01-18 Thread Janne Grunau
On 2012-01-18 13:54:11 +0200, Andrey Utkin wrote: > It is treated not as **AVDictionary, but as an array of such. > Show it in declaration. > --- > libavformat/avformat.h |2 +- > libavformat/utils.c| 10 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/lib

Re: [libav-devel] [PATCH 01/11] aacenc: aac_encode_init() cleanup

2012-01-18 Thread Benjamin Larsson
Change is ok, but it might be possible to squash this with patch 2. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 02/11] aacenc: cosmetics: move init() and end() to the bottom of the file.

2012-01-18 Thread Benjamin Larsson
I think you can squash patch 1 and 2. Anyway the move is OK. /Benjamin ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] Declare avformat_find_stream_info 'options' param with real type

2012-01-18 Thread Andrey Utkin
It is treated not as **AVDictionary, but as an array of such. Show it in declaration. --- libavformat/avformat.h |2 +- libavformat/utils.c| 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index fff911a..23fb75

Re: [libav-devel] [PATCH 11/11] aacenc: Simplify windowing

2012-01-18 Thread Benjamin Larsson
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 10/11] aacenc: Move saved overlap samples to the beginning of the same buffer as incoming samples.

2012-01-18 Thread Benjamin Larsson
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 09/11] aacenc: Deinterleave input samples before processing.

2012-01-18 Thread Benjamin Larsson
On 01/18/2012 09:39 AM, Nathan Caldwell wrote: --- libavcodec/aacenc.c | 102 +--- libavcodec/aacenc.h |6 ++- libavcodec/aacpsy.c | 11 ++--- libavcodec/psymodel.c | 16 +++- libavcodec/psymodel.h |9 +--- 5 files changed,

Re: [libav-devel] [PATCH 08/11] aacenc: Store channel count in AACEncContext.

2012-01-18 Thread Benjamin Larsson
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 07/11] aacenc: Move Q^3/4 calculation to it's own table

2012-01-18 Thread Benjamin Larsson
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 06/11] aacenc: Request normalized float samples instead of converting s16 samples to float.

2012-01-18 Thread Benjamin Larsson
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 05/11] aacpsy: Replace an if with FFMAX in LAME windowing.

2012-01-18 Thread Benjamin Larsson
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 04/11] aacenc: cosmetics, replace 'rd' with 'bits' in codebook_trellis_rate to make it more clear what is being calculated.

2012-01-18 Thread Benjamin Larsson
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 03/11] aacpsy: cosmetics, change a FIXME to a NOTE about subshort comparisons

2012-01-18 Thread Benjamin Larsson
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/2] RELEASE_NOTES: mention some notable API changes in 0.8

2012-01-18 Thread Reinhard Tartler
On Di, Jan 17, 2012 at 13:40:20 (CET), Anton Khirnov wrote: > --- > doc/RELEASE_NOTES | 30 +- > 1 files changed, 25 insertions(+), 5 deletions(-) > > diff --git a/doc/RELEASE_NOTES b/doc/RELEASE_NOTES > index b5ced86..797f5a1 100644 > --- a/doc/RELEASE_NOTES > +++ b

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-18 Thread Ronald S. Bultje
Hi, On Wed, Jan 18, 2012 at 2:46 AM, Janne Grunau wrote: > Users of libavcodec could break if they do not threadsafe callbacks. > Avconv and avplay still use -threads auto if not specified. What callbacks? Ronald ___ libav-devel mailing list libav-dev

[libav-devel] [PATCH 2/2] lavf: return -1 from try_decode_frame if no data is returned during flushing

2012-01-18 Thread Janne Grunau
--- libavformat/utils.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 373f068..67f702e 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -2133,7 +2133,7 @@ static int has_decode_delay_been_guessed(AVStream *s

  1   2   >