Re: [libav-devel] [PATCH] wmall: output packet only if we have decoded some samples

2012-03-21 Thread Kostya Shishkov
On Wed, Mar 21, 2012 at 12:49:41PM -0700, Luca Barbato wrote: > On 21/03/12 11:32, Kostya Shishkov wrote: > > WMA Losslessが変な音声コーデックですけど > > パケットの出力データは色々なサイズになります。 > > それは空パケットを出力りしますなければならない、threshも樂しくになるかも。 > > パッチ OK できました、AntonのアドバイスからCODEC_CAP_DELAYを足しました ___

Re: [libav-devel] [PATCH] wmall: output packet only if we have decoded some samples

2012-03-21 Thread Konstantin Pavlov
On Wed, Mar 21, 2012 at 07:32:36PM +0100, Kostya Shishkov wrote: > WMA Losslessが変な音声コーデックですけど > パケットの出力データは色々なサイズになります。 > それは空パケットを出力りしますなければならない、threshも樂しくになるかも。 This patch fixes luckynight.wma playback in VLC, thanks! -- Konstantin Pavlov VideoLAN team _

Re: [libav-devel] [PATCH] wmalossless: error out if a subframe is not used by any channel.

2012-03-21 Thread Kostya Shishkov
On Wed, Mar 21, 2012 at 03:43:20PM -0700, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > Prevents infinite loop because min_channel_len never increments. > > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > CC: libav-sta...@libav.org > --- > libavcodec/wmalosslessdec.c | 13 ++

Re: [libav-devel] [PATCH] xwma: Validate channels and bits_per_coded_sample.

2012-03-21 Thread Kostya Shishkov
On Wed, Mar 21, 2012 at 01:34:28PM -0700, Alex Converse wrote: > This prevents a SIGFPE later on. > > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > CC: libav-sta...@libav.org > --- > libavformat/xwma.c | 11 +++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --

Re: [libav-devel] [PATCH 1/2] aac: Reset some start variables when turning SBR off

2012-03-21 Thread Alex Converse
On Mar 21, 2012 12:55 PM, "Alex Converse" wrote: > > This makes sure we the reset flag gets set when SBR gets turned back on > and sets control variables for unguided mode back to their defaults. > > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > CC: libav-sta...@libav.org > --- > libav

Re: [libav-devel] [PATCH] wmalossless: error out on invalid values for order.

2012-03-21 Thread Ronald S. Bultje
Hi, On Wed, Mar 21, 2012 at 8:07 PM, Mashiat Sarker Shakkhar wrote: > On 3/22/2012 1:41 AM, Ronald S. Bultje wrote: >> >> From: "Ronald S. Bultje" >> >> Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind >> CC: libav-sta...@libav.org >> --- >>  libavcodec/wmalosslessdec.c |   34 +

Re: [libav-devel] [PATCH 2/8] h264: use struct offsets in get_cabac_bypass_sign_x86().

2012-03-21 Thread Ronald S. Bultje
Hi, On Tue, Mar 20, 2012 at 2:42 AM, Martin Storsjö wrote: > On Tue, 20 Mar 2012, Gil Pedersen wrote: > >> On 20/03/2012, at 01.37, Luca Barbato wrote: >> >>> On 19/03/12 16:43, Måns Rullgård wrote: >>> From my point of view, OSX is fringe.  Besides, we have plain C code too. The s

Re: [libav-devel] [PATCH] wmalossless: error out on invalid values for order.

2012-03-21 Thread Mashiat Sarker Shakkhar
On 3/22/2012 1:41 AM, Ronald S. Bultje wrote: From: "Ronald S. Bultje" Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/wmalosslessdec.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) [...]

[libav-devel] [PATCH 4/4] avcodec: Add audioconvert functions to handle planar sample formats automatically

2012-03-21 Thread Justin Ruggles
Make libavcodec/audioconvert.h public by installing the header. Deprecate the old API. It allowed planar conversions, but required the user to handle the setting of pointers and strides. Furthermore, the required pointer/stride layout did not match the one used in AVFrame. Because these were never

[libav-devel] [PATCH 3/4] avcodec: remove avcodec_guess_channel_layout()

2012-03-21 Thread Justin Ruggles
It is not public because the header is not installed, and its functionality has been replaced by av_get_default_channel_layout(). --- libavcodec/audioconvert.c | 14 -- libavcodec/audioconvert.h |9 - 2 files changed, 0 insertions(+), 23 deletions(-) diff --git a/libavco

[libav-devel] [PATCH 2/4] avutil: Add av_get_default_channel_layout()

2012-03-21 Thread Justin Ruggles
Also, use the new function in the AC-3 encoder. --- doc/APIchanges |3 +++ libavcodec/ac3enc.c |2 +- libavutil/audioconvert.c | 15 +++ libavutil/audioconvert.h |5 + libavutil/avutil.h |2 +- 5 files changed, 25 insertions(+), 2 deletions(-)

[libav-devel] [PATCH 1/4] avutil: add av_get_alt_sample_fmt().

2012-03-21 Thread Justin Ruggles
From: Clément Bœsch Signed-off-by: Justin Ruggles --- doc/APIchanges|3 +++ libavutil/avutil.h|2 +- libavutil/samplefmt.c | 31 +-- libavutil/samplefmt.h |9 + 4 files changed, 34 insertions(+), 11 deletions(-) diff --git a/doc/API

Re: [libav-devel] [PATCH] wmavoice: fix stack overread.

2012-03-21 Thread Justin Ruggles
On 03/21/2012 06:47 PM, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > CC: libav-sta...@libav.org > --- > libavcodec/wmavoice.c |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/wmavoice.

[libav-devel] [PATCH] aacsbr: handle m_max values smaller than 4 and larger than 255.

2012-03-21 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Prevents a signflip in the counter, and a subsequent crash because of overreads/overwrites. Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/x86/sbrdsp.asm |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -

[libav-devel] [PATCH] asf: reset side data elements on packet copy.

2012-03-21 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Prevents crash (double free) when free()ing the original packet. Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavformat/asfdec.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/asfdec.c b/libavformat/asfdec

[libav-devel] [PATCH] wmavoice: fix stack overread.

2012-03-21 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/wmavoice.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c index 9553089..a222f09 100644 --- a/libav

Re: [libav-devel] [PATCH] vqa: check palette chunk size before reading data.

2012-03-21 Thread Justin Ruggles
On 03/21/2012 06:19 PM, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > Prevents overreads beyond buffer boundaries. > > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > CC: libav-sta...@libav.org > --- > libavcodec/vqavideo.c |2 +- > 1 file changed, 1 insertion(+), 1 delet

[libav-devel] [PATCH] wmalossless: error out if a subframe is not used by any channel.

2012-03-21 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Prevents infinite loop because min_channel_len never increments. Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/wmalosslessdec.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/libavc

[libav-devel] [PATCH] vqa: check palette chunk size before reading data.

2012-03-21 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Prevents overreads beyond buffer boundaries. Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/vqavideo.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vqavideo.c b/libavcodec/vqavideo.c

[libav-devel] [PATCH] wmalossless: reset sample pointer for each subframe.

2012-03-21 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Prevents overwrites when some subframes only encode some channels. Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/wmalosslessdec.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff

[libav-devel] [PATCH] wmalossless: reset sample pointer for each subframe.

2012-03-21 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Prevents overwrites when some subframes only encode some channels. Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/wmalosslessdec.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git

[libav-devel] [PATCH 3/3] avconv: fix the resampling safety factors for output audio buffer allocation

2012-03-21 Thread Justin Ruggles
This matches the output size required for audio_resample() --- avconv.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/avconv.c b/avconv.c index d3f9540..b83662c 100644 --- a/avconv.c +++ b/avconv.c @@ -1020,7 +1020,7 @@ static int alloc_audio_output_buf(AVCodecContext *

[libav-devel] [PATCH 1/3] avconv: make the async buffer global and free it in exit_program()

2012-03-21 Thread Justin Ruggles
--- avconv.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/avconv.c b/avconv.c index 9a3c75d..f1da50f 100644 --- a/avconv.c +++ b/avconv.c @@ -142,6 +142,8 @@ static int print_stats = 1; static uint8_t *audio_buf; static unsigned int allocated_audio

[libav-devel] [PATCH 2/3] avconv: move audio output buffer allocation to a separate function

2012-03-21 Thread Justin Ruggles
Allows for removing a goto and makes the code easier to follow. --- avconv.c | 52 1 files changed, 32 insertions(+), 20 deletions(-) diff --git a/avconv.c b/avconv.c index f1da50f..d3f9540 100644 --- a/avconv.c +++ b/avconv.c @@ -1011,11 +10

[libav-devel] [PATCH] xwma: Validate channels and bits_per_coded_sample.

2012-03-21 Thread Alex Converse
This prevents a SIGFPE later on. Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavformat/xwma.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/libavformat/xwma.c b/libavformat/xwma.c index 2c6ee11..7b34b96 100644 --- a

Re: [libav-devel] [PATCH 1/4] avcodec: remove fallbacks for AVCodec.encode() in avcodec_encode_audio2()

2012-03-21 Thread Kostya Shishkov
On Wed, Mar 21, 2012 at 03:55:32PM -0400, Justin Ruggles wrote: > We no longer have any audio encoders using AVCodec.encode(). > --- > libavcodec/utils.c | 70 +-- > 1 files changed, 2 insertions(+), 68 deletions(-) looks OK (and cosmetics patch f

[libav-devel] [PATCH 2/2] aacsbr: Add a debug check to sbr_mapping.

2012-03-21 Thread Alex Converse
There have been multiple bugs caused by inconsistencies here. Based on an idea from Michael Niedermayer. CC: libav-sta...@libav.org --- libavcodec/aacsbr.c | 22 -- 1 files changed, 16 insertions(+), 6 deletions(-) diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c ind

[libav-devel] [PATCH 1/2] aac: Reset some start variables when turning SBR off

2012-03-21 Thread Alex Converse
This makes sure we the reset flag gets set when SBR gets turned back on and sets control variables for unguided mode back to their defaults. Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/aacsbr.c | 31 +-- libavcodec

[libav-devel] [PATCH 4/4] avcodec: do not needlessly set packet size to 0 in avcodec_encode_audio2()

2012-03-21 Thread Justin Ruggles
It is already set to 0 by av_free_packet() --- libavcodec/utils.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index c8ce2a9..78be63e 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -865,7 +865,6 @@ int attribute_align

[libav-devel] [PATCH 3/4] avcodec: for audio encoding, reset output packet when it is not valid

2012-03-21 Thread Justin Ruggles
--- libavcodec/utils.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 6494499..c8ce2a9 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -903,8 +903,11 @@ int attribute_align_arg avcodec_encode_audio2(AVCodecCon

[libav-devel] [PATCH 2/4] avcodec: refactor avcodec_encode_audio2() to merge common branches

2012-03-21 Thread Justin Ruggles
--- libavcodec/utils.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index f66295a..6494499 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -880,8 +880,9 @@ int attribute_align_arg avcodec_encode_audio2(AVCodec

[libav-devel] [PATCH 1/4] avcodec: remove fallbacks for AVCodec.encode() in avcodec_encode_audio2()

2012-03-21 Thread Justin Ruggles
We no longer have any audio encoders using AVCodec.encode(). --- libavcodec/utils.c | 70 +-- 1 files changed, 2 insertions(+), 68 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index a638bbf..f66295a 100644 --- a/libavcodec/uti

Re: [libav-devel] [PATCH] wmalossless: error out on invalid values for order.

2012-03-21 Thread Kostya Shishkov
On Wed, Mar 21, 2012 at 12:41:15PM -0700, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > CC: libav-sta...@libav.org > --- > libavcodec/wmalosslessdec.c | 34 +- > 1 file changed, 25 insertions(+),

Re: [libav-devel] [PATCH] wmall: output packet only if we have decoded some samples

2012-03-21 Thread Luca Barbato
On 21/03/12 11:32, Kostya Shishkov wrote: > WMA Losslessが変な音声コーデックですけど > パケットの出力データは色々なサイズになります。 > それは空パケットを出力りしますなければならない、threshも樂しくになるかも。 パッチ OK lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list libav-dev

[libav-devel] [PATCH] wmalossless: error out on invalid values for order.

2012-03-21 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/wmalosslessdec.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalossles

[libav-devel] [PATCH 3/4] aiffdec: factor out handling of integer PCM for AIFF-C and plain AIFF

2012-03-21 Thread Justin Ruggles
--- libavformat/aiffdec.c | 21 - 1 files changed, 8 insertions(+), 13 deletions(-) diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c index a48d946..70ce017 100644 --- a/libavformat/aiffdec.c +++ b/libavformat/aiffdec.c @@ -110,17 +110,19 @@ static unsigned int get_

[libav-devel] [PATCH 4/4] aiffdec: set block_duration to 1 for PCM codecs that are supported in AIFF-C

2012-03-21 Thread Justin Ruggles
--- libavformat/aiffdec.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c index 70ce017..27d42ea 100644 --- a/libavformat/aiffdec.c +++ b/libavformat/aiffdec.c @@ -123,6 +123,13 @@ static unsigned int get_aiff_header(AVFo

[libav-devel] [PATCH 2/4] aiffdec: use av_get_audio_frame_duration() to set block_duration for AIFF-C

2012-03-21 Thread Justin Ruggles
--- libavformat/aiffdec.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c index bbac1ab..a48d946 100644 --- a/libavformat/aiffdec.c +++ b/libavformat/aiffdec.c @@ -123,28 +123,27 @@ static unsigned int get_aiff_header(A

[libav-devel] [PATCH 1/4] aiffdec: do not set bit rate if block duration is unknown

2012-03-21 Thread Justin Ruggles
--- libavformat/aiffdec.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c index 11bbcac..bbac1ab 100644 --- a/libavformat/aiffdec.c +++ b/libavformat/aiffdec.c @@ -157,8 +157,10 @@ static unsigned int get_aiff_header(AVFor

Re: [libav-devel] [PATCH] asf: don't call av_free_packet() on empty packets.

2012-03-21 Thread Ronald S. Bultje
Hi, On Wed, Mar 21, 2012 at 11:34 AM, Kostya Shishkov wrote: > On Wed, Mar 21, 2012 at 11:28:19AM -0700, Ronald S. Bultje wrote: >> From: "Ronald S. Bultje" >> >> Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind >> CC: libav-sta...@libav.org >> --- >>  libavformat/asfdec.c |    3 ++- >>  1

Re: [libav-devel] [PATCH 2/2] mov: Do not read past the end of the ctts_data table.

2012-03-21 Thread Kostya Shishkov
On Wed, Mar 21, 2012 at 11:27:06AM -0700, Alex Converse wrote: > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > CC: libav-sta...@libav.org > --- > libavformat/mov.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > ind

Re: [libav-devel] [PATCH 1/2] xwma: Validate channels and bits_per_coded_sample.

2012-03-21 Thread Kostya Shishkov
On Wed, Mar 21, 2012 at 11:27:05AM -0700, Alex Converse wrote: > This prevents a SIGFPE later on. > > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > CC: libav-sta...@libav.org > --- > libavformat/xwma.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/l

Re: [libav-devel] [PATCH] asf: don't call av_free_packet() on empty packets.

2012-03-21 Thread Kostya Shishkov
On Wed, Mar 21, 2012 at 11:28:19AM -0700, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > CC: libav-sta...@libav.org > --- > libavformat/asfdec.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavfo

[libav-devel] [PATCH] wmall: output packet only if we have decoded some samples

2012-03-21 Thread Kostya Shishkov
WMA Losslessが変な音声コーデックですけど パケットの出力データは色々なサイズになります。 それは空パケットを出力りしますなければならない、threshも樂しくになるかも。 --- libavcodec/wmalosslessdec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index 6bd8bfb..cab6913 100644 --- a/libavc

[libav-devel] [PATCH] asf: don't call av_free_packet() on empty packets.

2012-03-21 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavformat/asfdec.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c index 0789960..8527246 100644 --- a/libavformat

[libav-devel] [PATCH 2/2] mov: Do not read past the end of the ctts_data table.

2012-03-21 Thread Alex Converse
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavformat/mov.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 7b21423..75dec37 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -

[libav-devel] [PATCH 1/2] xwma: Validate channels and bits_per_coded_sample.

2012-03-21 Thread Alex Converse
This prevents a SIGFPE later on. Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavformat/xwma.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/libavformat/xwma.c b/libavformat/xwma.c index 2c6ee11..20845ef 100644 --- a/libavf

[libav-devel] [PATCH] asf: don't call av_free_packet() on empty packets.

2012-03-21 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavformat/asfdec.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c index 0789960..e598070 100644 --- a/libavformat

Re: [libav-devel] [PATCH] aiffdec: Fix SIGFPE on pcm_f32be

2012-03-21 Thread Justin Ruggles
On 03/21/2012 01:52 PM, Justin Ruggles wrote: > On 03/21/2012 08:17 AM, Tomas Härdin wrote: > >> Hi >> >> Running ffprobe/avprobe on >> http://titan.codemill.se/~tomhar/samples/sigfpe.aif results in SIGFPE at >> libavformat/aiffdec.c:162 since aiff->block_duration == 0. >> Attached patch sets blo

Re: [libav-devel] [PATCH] aiffdec: Fix SIGFPE on pcm_f32be

2012-03-21 Thread Sean McGovern
On Wednesday, March 21, 2012, Ronald S. Bultje wrote: > Hi, > > On Wed, Mar 21, 2012 at 5:17 AM, Tomas Härdin wrote: >> Hi >> >> Running ffprobe/avprobe on >> http://titan.codemill.se/~tomhar/samples/sigfpe.aif results in SIGFPE at >> libavformat/aiffdec.c:162 since aiff->block_duration == 0. >>

Re: [libav-devel] [PATCH 2/2] adxenc: use AVCodec.encode2()

2012-03-21 Thread Kostya Shishkov
On Wed, Mar 21, 2012 at 02:00:41PM -0400, Justin Ruggles wrote: > --- > libavcodec/adxenc.c | 36 > 1 files changed, 20 insertions(+), 16 deletions(-) > > diff --git a/libavcodec/adxenc.c b/libavcodec/adxenc.c > index 591c075..45db48a 100644 > --- a/libavcod

Re: [libav-devel] [PATCH 1/2] adxenc: Use the AVFrame in ADXContext for coded_frame

2012-03-21 Thread Kostya Shishkov
On Wed, Mar 21, 2012 at 02:00:40PM -0400, Justin Ruggles wrote: > --- > libavcodec/adxenc.c | 10 ++ > 1 files changed, 2 insertions(+), 8 deletions(-) looks OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman

[libav-devel] [PATCH 2/2] adxenc: use AVCodec.encode2()

2012-03-21 Thread Justin Ruggles
--- libavcodec/adxenc.c | 36 1 files changed, 20 insertions(+), 16 deletions(-) diff --git a/libavcodec/adxenc.c b/libavcodec/adxenc.c index 591c075..45db48a 100644 --- a/libavcodec/adxenc.c +++ b/libavcodec/adxenc.c @@ -22,6 +22,7 @@ #include "avcodec.h"

[libav-devel] [PATCH 1/2] adxenc: Use the AVFrame in ADXContext for coded_frame

2012-03-21 Thread Justin Ruggles
--- libavcodec/adxenc.c | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/libavcodec/adxenc.c b/libavcodec/adxenc.c index 20f2798..591c075 100644 --- a/libavcodec/adxenc.c +++ b/libavcodec/adxenc.c @@ -119,7 +119,8 @@ static av_cold int adx_encode_init(AVCodecContex

Re: [libav-devel] [PATCH] indeo4: fix out-of-bounds function call.

2012-03-21 Thread Kostya Shishkov
On Wed, Mar 21, 2012 at 10:39:10AM -0700, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > CC: libav-sta...@libav.org > --- > libavcodec/indeo4.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcod

Re: [libav-devel] [PATCH] aiffdec: Fix SIGFPE on pcm_f32be

2012-03-21 Thread Justin Ruggles
On 03/21/2012 08:17 AM, Tomas Härdin wrote: > Hi > > Running ffprobe/avprobe on > http://titan.codemill.se/~tomhar/samples/sigfpe.aif results in SIGFPE at > libavformat/aiffdec.c:162 since aiff->block_duration == 0. > Attached patch sets block_duration = 1 in the default case. Fixes the > problem

Re: [libav-devel] [PATCH] aiffdec: Fix SIGFPE on pcm_f32be

2012-03-21 Thread Ronald S. Bultje
Hi, On Wed, Mar 21, 2012 at 5:17 AM, Tomas Härdin wrote: > Hi > > Running ffprobe/avprobe on > http://titan.codemill.se/~tomhar/samples/sigfpe.aif results in SIGFPE at > libavformat/aiffdec.c:162 since aiff->block_duration == 0. > Attached patch sets block_duration = 1 in the default case. Fixes

[libav-devel] [PATCH] indeo4: fix out-of-bounds function call.

2012-03-21 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/indeo4.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/indeo4.c b/libavcodec/indeo4.c index 573718e..3e8a398 100644 --- a/libavcodec/ind

[libav-devel] [PATCH] aiffdec: Fix SIGFPE on pcm_f32be

2012-03-21 Thread Tomas Härdin
Hi Running ffprobe/avprobe on http://titan.codemill.se/~tomhar/samples/sigfpe.aif results in SIGFPE at libavformat/aiffdec.c:162 since aiff->block_duration == 0. Attached patch sets block_duration = 1 in the default case. Fixes the problem for both projects. /Tomas >From 4923a8eef9273ca993a8818a9

Re: [libav-devel] [PATCH 1/2] mov: Add missing terminator to mov_ch_layout_map_1ch.

2012-03-21 Thread Kostya Shishkov
On Wed, Mar 21, 2012 at 10:14:39AM -0700, Alex Converse wrote: > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > --- > libavformat/mov_chan.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c > index 5728ebd..a0f

[libav-devel] [PATCH 2/2] aac: Reset PS parameters on header decode failure.

2012-03-21 Thread Alex Converse
If the next header frame codes zero envelopes the previous frame's values will be used. Consequently the invalid values must be cleared. Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind --- libavcodec/aacps.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/libavc

[libav-devel] [PATCH 1/2] mov: Add missing terminator to mov_ch_layout_map_1ch.

2012-03-21 Thread Alex Converse
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind --- libavformat/mov_chan.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c index 5728ebd..a0fbecc 100644 --- a/libavformat/mov_chan.c +++ b/libavformat/mov_chan.c @@ -155

Re: [libav-devel] [PATCH] configure: die when x11grab headers not found.

2012-03-21 Thread Diego Biurrun
On Wed, Mar 21, 2012 at 08:01:37AM -0700, Josh Allmann wrote: > > --- a/configure > +++ b/configure > @@ -1487,7 +1487,6 @@ v4l2_indev_deps_any="linux_videodev2_h sys_videoio_h" > vfwcap_indev_extralibs="-lavicap32" > x11_grab_device_indev_deps="x11grab XShmCreateImage" > -x11_grab_device_indev_

Re: [libav-devel] [PATCH] oggparseogm: fix order of arguments of avpriv_set_pts_info().

2012-03-21 Thread Kostya Shishkov
On Wed, Mar 21, 2012 at 05:05:59PM +0100, Anton Khirnov wrote: > From: Michael Niedermayer > > Signed-off-by: Anton Khirnov > --- > libavformat/oggparseogm.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavformat/oggparseogm.c b/libavformat/oggparseogm.c > i

Re: [libav-devel] [PATCH] oggparseogm: fix order of arguments of avpriv_set_pts_info().

2012-03-21 Thread Justin Ruggles
On 03/21/2012 12:05 PM, Anton Khirnov wrote: > From: Michael Niedermayer > > Signed-off-by: Anton Khirnov > --- > libavformat/oggparseogm.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavformat/oggparseogm.c b/libavformat/oggparseogm.c > index f16eb13..d7f

[libav-devel] [PATCH] oggparseogm: fix order of arguments of avpriv_set_pts_info().

2012-03-21 Thread Anton Khirnov
From: Michael Niedermayer Signed-off-by: Anton Khirnov --- libavformat/oggparseogm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/oggparseogm.c b/libavformat/oggparseogm.c index f16eb13..d7fc426 100644 --- a/libavformat/oggparseogm.c +++ b/libavformat/og

[libav-devel] [PATCH] configure: die when x11grab headers not found.

2012-03-21 Thread Josh Allmann
--- configure | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/configure b/configure index eba9cfe..e494411 100755 --- a/configure +++ b/configure @@ -1487,7 +1487,6 @@ v4l2_indev_deps_any="linux_videodev2_h sys_videoio_h" vfwcap_indev_deps="capCreateCaptureWindow

Re: [libav-devel] [PATCH] configure: die when x11grab headers not found.

2012-03-21 Thread Måns Rullgård
Josh Allmann writes: > --- > configure |9 +++-- > 1 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/configure b/configure > index eba9cfe..af9569b 100755 > --- a/configure > +++ b/configure > @@ -3018,12 +3018,9 @@ enabled libcdio && > check_lib2 "cdio/cdda.h cdio/p

[libav-devel] [PATCH] configure: die when x11grab headers not found.

2012-03-21 Thread Josh Allmann
--- configure |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/configure b/configure index eba9cfe..af9569b 100755 --- a/configure +++ b/configure @@ -3018,12 +3018,9 @@ enabled libcdio && check_lib2 "cdio/cdda.h cdio/paranoia.h" cdio_cddap_open "-lcdio_paranoi

Re: [libav-devel] [PATCH] configure: die when x11grab headers not found.

2012-03-21 Thread Josh Allmann
On 21 March 2012 03:41, Diego Biurrun wrote: > On Wed, Mar 21, 2012 at 12:25:20AM -0700, Josh Allmann wrote: >> >> --- a/configure >> +++ b/configure >> @@ -3018,9 +3018,9 @@ enabled libcdio && >> >>  enabled x11grab                         && >> -check_header X11/Xlib.h                 && >> -che

Re: [libav-devel] [PATCH] configure: die when x11grab headers not found.

2012-03-21 Thread Luca Barbato
On 3/21/12 4:23 AM, Måns Rullgård wrote: Diego Biurrun writes: On Wed, Mar 21, 2012 at 12:25:20AM -0700, Josh Allmann wrote: --- a/configure +++ b/configure @@ -3018,9 +3018,9 @@ enabled libcdio&& enabled x11grab&& -check_header X11/Xlib.h&& -check_header X11/extensions/XShm.h&& -check_he

Re: [libav-devel] [PATCH] lavf: make av_interleave_packet_per_dts() private.

2012-03-21 Thread Jindřich Makovička
2012/3/21 Martin Storsjö : > Hi, > > > On Wed, 21 Mar 2012, Jindřich Makovička wrote: > >> 2012/3/21 Martin Storsjö : >>> >>> In general though, for HLS, if you use interleaving and flush the >>> interleaver buffers before cutting a new segment, the last packets of the >>> previous segment actually

Re: [libav-devel] [PATCH] configure: die when x11grab headers not found.

2012-03-21 Thread Måns Rullgård
Diego Biurrun writes: > On Wed, Mar 21, 2012 at 12:25:20AM -0700, Josh Allmann wrote: >> >> --- a/configure >> +++ b/configure >> @@ -3018,9 +3018,9 @@ enabled libcdio && >> >> enabled x11grab && >> -check_header X11/Xlib.h && >> -check_header X11/exten

Re: [libav-devel] [PATCH] lavf: make av_interleave_packet_per_dts() private.

2012-03-21 Thread Martin Storsjö
On Wed, 21 Mar 2012, Anton Khirnov wrote: On Wed, 21 Mar 2012 11:13:25 +0100, Jindřich Makovička wrote: On Thu, Mar 15, 2012 at 21:04, Anton Khirnov wrote: > > On Thu, 15 Mar 2012 07:22:07 -0700, Luca Barbato wrote: >> On 3/15/12 5:40 AM, Anton Khirnov wrote: >> > There is no reason for it

Re: [libav-devel] [PATCH] libvorbis: use AVCodec.encode2()

2012-03-21 Thread Martin Storsjö
On Tue, 20 Mar 2012, Justin Ruggles wrote: --- libavcodec/Makefile|3 +- libavcodec/libvorbis.c | 69 ++-- 2 files changed, 51 insertions(+), 21 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index cb97bb6..2327054 100644

Re: [libav-devel] [PATCH] lavf: make av_interleave_packet_per_dts() private.

2012-03-21 Thread Anton Khirnov
On Wed, 21 Mar 2012 11:13:25 +0100, Jindřich Makovička wrote: > On Thu, Mar 15, 2012 at 21:04, Anton Khirnov wrote: > > > > On Thu, 15 Mar 2012 07:22:07 -0700, Luca Barbato wrote: > >> On 3/15/12 5:40 AM, Anton Khirnov wrote: > >> > There is no reason for it to be public, it's only meant to be

Re: [libav-devel] [PATCH] wmaenc: use AVCodec.encode2()

2012-03-21 Thread Martin Storsjö
On Tue, 20 Mar 2012, Justin Ruggles wrote: Update FATE references due to encoder delay. --- libavcodec/wmaenc.c | 48 +++- 1 files changed, 31 insertions(+), 17 deletions(-) diff --git a/libavcodec/wmaenc.c b/libavcodec/wmaenc.c index b9c40d8..570ff4

Re: [libav-devel] [PATCH] lavf: make av_interleave_packet_per_dts() private.

2012-03-21 Thread Jindřich Makovička
2012/3/21 Jindřich Makovička : > On Thu, Mar 15, 2012 at 21:04, Anton Khirnov wrote: >> >> On Thu, 15 Mar 2012 07:22:07 -0700, Luca Barbato wrote: >>> On 3/15/12 5:40 AM, Anton Khirnov wrote: >>> > There is no reason for it to be public, it's only meant to be used >>> > internally. >>> >>> I'd be

Re: [libav-devel] [PATCH] g722enc: use AVCodec.encode2()

2012-03-21 Thread Martin Storsjö
On Tue, 20 Mar 2012, Justin Ruggles wrote: FATE reference updated due timestamp rounding because of resampling from 44100 Hz to 16000 Hz in avconv. --- libavcodec/g722enc.c | 44 +--- tests/ref/acodec/g722 |4 ++-- 2 files changed, 35 insertions(+), 1

Re: [libav-devel] [PATCH] configure: die when x11grab headers not found.

2012-03-21 Thread Diego Biurrun
On Wed, Mar 21, 2012 at 12:25:20AM -0700, Josh Allmann wrote: > > --- a/configure > +++ b/configure > @@ -3018,9 +3018,9 @@ enabled libcdio && > > enabled x11grab && > -check_header X11/Xlib.h && > -check_header X11/extensions/XShm.h && > -check_head

Re: [libav-devel] [PATCH] lavf: make av_interleave_packet_per_dts() private.

2012-03-21 Thread Jindřich Makovička
On Thu, Mar 15, 2012 at 21:04, Anton Khirnov wrote: > > On Thu, 15 Mar 2012 07:22:07 -0700, Luca Barbato wrote: >> On 3/15/12 5:40 AM, Anton Khirnov wrote: >> > There is no reason for it to be public, it's only meant to be used >> > internally. >> >> I'd be careful, I know that sometimes we sugge

Re: [libav-devel] [PATCH] pngenc: better upper bound for encoded frame size.

2012-03-21 Thread Kostya Shishkov
On Wed, Mar 21, 2012 at 09:50:35AM +0100, Anton Khirnov wrote: > Fixes encoding very large pictures. > > Thanks to Костя for providing the formula. > --- > libavcodec/pngenc.c | 30 +- > 1 files changed, 17 insertions(+), 13 deletions(-) For better understanding: co

[libav-devel] [PATCH] pngenc: better upper bound for encoded frame size.

2012-03-21 Thread Anton Khirnov
Fixes encoding very large pictures. Thanks to Костя for providing the formula. --- libavcodec/pngenc.c | 30 +- 1 files changed, 17 insertions(+), 13 deletions(-) diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c index bf7dd1a..d79c800 100644 --- a/libavcodec/p

Re: [libav-devel] [PATCH 1/3] APIchanges: fill in missing dates and hashes.

2012-03-21 Thread Kostya Shishkov
On Wed, Mar 21, 2012 at 09:05:35AM +0100, Anton Khirnov wrote: > --- > doc/APIchanges | 14 +++--- > 1 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index 6e7d4e7..7bcb738 100644 > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -12,2

[libav-devel] [PATCH 2/3] APIchanges: mark the place where 0.8 was cut.

2012-03-21 Thread Anton Khirnov
--- doc/APIchanges |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 7bcb738..5320465 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -31,6 +31,7 @@ API changes, most recent first: 2012-02-25 - c9bca80 - lavu 51.24.0 - erro

[libav-devel] [PATCH 3/3] APIchanges: mark the place where 0.7 was cut.

2012-03-21 Thread Anton Khirnov
--- doc/APIchanges |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 5320465..15eec40 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -214,15 +214,22 @@ API changes, most recent first: 2011-07-10 - a67c061 - lavf 53.3.0 A

[libav-devel] [PATCH 1/3] APIchanges: fill in missing dates and hashes.

2012-03-21 Thread Anton Khirnov
--- doc/APIchanges | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 6e7d4e7..7bcb738 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -12,20 +12,20 @@ libavutil: 2011-04-18 API changes, most recent first: -2012-03

[libav-devel] [PATCH] configure: die when x11grab headers not found.

2012-03-21 Thread Josh Allmann
--- configure |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index eba9cfe..87d2261 100755 --- a/configure +++ b/configure @@ -3018,9 +3018,9 @@ enabled libcdio && check_lib2 "cdio/cdda.h cdio/paranoia.h" cdio_cddap_open "-lcdio_paranoia -