Re: [libav-devel] [PATCH] configure: add POWER[5-7] support

2012-04-27 Thread Måns Rullgård
Sean McGovern gsean...@gmail.com writes: --- configure |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 1dc2e3e..2b0231e 100755 --- a/configure +++ b/configure @@ -2282,6 +2282,9 @@ elif enabled ppc; then

Re: [libav-devel] [PATCH] configure: add POWER7 support

2012-04-27 Thread Måns Rullgård
Sean McGovern gsean...@gmail.com writes: 2012/4/26 Måns Rullgård m...@mansr.com: Sean McGovern gsean...@gmail.com writes: 2012/4/25 Måns Rullgård m...@mansr.com: Sean McGovern gsean...@gmail.com writes: On Wednesday, April 25, 2012, Måns Rullgård m...@mansr.com wrote: Sean McGovern

[libav-devel] [PATCH 2/2] ppc: add const where needed in scalarproduct_int16_altivec()

2012-04-27 Thread Mans Rullgard
Signed-off-by: Mans Rullgard m...@mansr.com --- libavcodec/ppc/int_altivec.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/ppc/int_altivec.c b/libavcodec/ppc/int_altivec.c index bbf4e1d..3c8b852 100644 --- a/libavcodec/ppc/int_altivec.c +++

[libav-devel] [PATCH 1/2] ppc: remove shift parameter from scalarproduct_int16_altivec()

2012-04-27 Thread Mans Rullgard
The shift parameter was removed from this interface in 7e1ce6a. This updates the Altivec implementation to match. Signed-off-by: Mans Rullgard m...@mansr.com --- libavcodec/ppc/int_altivec.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git

Re: [libav-devel] [PATCH 1/2] ppc: remove shift parameter from scalarproduct_int16_altivec()

2012-04-27 Thread Kostya Shishkov
On Fri, Apr 27, 2012 at 10:44:01AM +0100, Mans Rullgard wrote: The shift parameter was removed from this interface in 7e1ce6a. This updates the Altivec implementation to match. Signed-off-by: Mans Rullgard m...@mansr.com --- libavcodec/ppc/int_altivec.c | 11 +-- 1 file changed,

Re: [libav-devel] [PATCH 1/2] libschroedingerdec: check malloc

2012-04-27 Thread Diego Biurrun
On Fri, Apr 27, 2012 at 04:23:03AM +0200, Diego Biurrun wrote: On Thu, Apr 26, 2012 at 09:14:07PM +0200, Jordi Ortiz wrote: --- libavcodec/libschroedingerdec.c |5 + 1 file changed, 5 insertions(+) LGTM, will queue tomorrow. Upon closer inspection, there is another unchecked

Re: [libav-devel] [PATCH 2/3] fate: spelling cosmetics

2012-04-27 Thread Diego Biurrun
On Thu, Apr 26, 2012 at 02:25:15PM +0100, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: --- a/tests/fate/wavpack.mak +++ b/tests/fate/wavpack.mak @@ -1,4 +1,4 @@ -# Lossless +# lossless Spelling? You're changing capitalised words to all lowercase for some reason. I

[libav-devel] POWER[3-7] support

2012-04-27 Thread Sean McGovern
I'm a bit upset that I'm being accused of cargo culting. The documentation for the RS/6000 PowerPC options for GCC imply that the setting and unsetting of each of these 'suboptions' varies per release version. I don't have a battery of compiler releases to test from, but I still think it's

[libav-devel] [PATCH] configure: add POWER[5-7] support

2012-04-27 Thread Sean McGovern
Also merge POWER3 and POWER4 configuration together with the additions. --- configure |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 1dc2e3e..ed1624e 100755 --- a/configure +++ b/configure @@ -2279,9 +2279,12 @@ elif enabled ppc; then

Re: [libav-devel] POWER[3-7] support

2012-04-27 Thread Diego Biurrun
On Fri, Apr 27, 2012 at 09:47:57AM -0400, Sean McGovern wrote: I'm a bit upset that I'm being accused of cargo culting. No accusation was meant here - it's just a common phrase used around here, like bikeshedding. We're all guilty of one or the other at some point. Diego

Re: [libav-devel] [PATCH 3/3] aacps: NEON optimisations

2012-04-27 Thread Vladimir Pantelic
Måns Rullgård wrote: Mans Rullgardm...@mansr.com writes: Signed-off-by: Mans Rullgardm...@mansr.com --- libavcodec/aacpsdsp.c |3 + libavcodec/aacpsdsp.h |1 + libavcodec/arm/Makefile|6 +- libavcodec/arm/aacpsdsp_init_arm.c | 53

Re: [libav-devel] [PATCH 1/2] libschroedingerdec: check malloc

2012-04-27 Thread Jordi Ortiz
El 27 de abril de 2012 17:17, libav-devel-requ...@libav.org escribió: Upon closer inspection, there is another unchecked memory allocation through avpicture_alloc() in that file, could you please fix that as well? Ok, but if we apply first the patch 2/2, also sent to the list, then it is not

Re: [libav-devel] [PATCH 1/2] libschroedingerdec: check malloc

2012-04-27 Thread Diego Biurrun
On Fri, Apr 27, 2012 at 06:20:47PM +0200, Jordi Ortiz wrote: El 27 de abril de 2012 17:17, libav-devel-requ...@libav.org escribió: Upon closer inspection, there is another unchecked memory allocation through avpicture_alloc() in that file, could you please fix that as well? Ok, but if

[libav-devel] [PATCH] segment: fix null pointer dereference

2012-04-27 Thread Mashiat Sarker Shakkhar
From: Paul B Mahol one...@gmail.com Signed-off-by: Paul B Mahol one...@gmail.com Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/segment.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index

Re: [libav-devel] [PATCH] mpegts: Make sure we don't return uninitialized packets

2012-04-27 Thread Martin Storsjö
On Thu, 26 Apr 2012, Luca Barbato wrote: On 26/04/12 11:45, Martin Storsjö wrote: On Sat, 21 Apr 2012, Martin Storsjö wrote: This fixes crashes, where the demuxer could return 0 even if the returned AVPacket isn't initialized at all. This could happen if running into EOF or running out of

Re: [libav-devel] [PATCH 3/3] aacps: NEON optimisations

2012-04-27 Thread Måns Rullgård
Vladimir Pantelic vlado...@gmail.com writes: Måns Rullgård wrote: Mans Rullgardm...@mansr.com writes: Signed-off-by: Mans Rullgardm...@mansr.com --- libavcodec/aacpsdsp.c |3 + libavcodec/aacpsdsp.h |1 + libavcodec/arm/Makefile|6

Re: [libav-devel] POWER[3-7] support

2012-04-27 Thread Luca Barbato
On 27/04/12 06:47, Sean McGovern wrote: I'm a bit upset that I'm being accused of cargo culting. You are not, we are since those options are there in first place ^^; Once notice we just have to make sure they are sound. Thanks for checking for us. lu -- Luca Barbato Gentoo/linux

[libav-devel] [PATCH] avio: make avio_close(NULL) a no-op

2012-04-27 Thread Luca Barbato
Its behaviour in line with ffurl_close(NULL). --- libavformat/aviobuf.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index 01a3647..0353a17 100644 --- a/libavformat/aviobuf.c +++ b/libavformat/aviobuf.c @@ -756,8

[libav-devel] [PATCH] segment: reorder seg_write_header allocation

2012-04-27 Thread Luca Barbato
As pointed by Paul B Mahol one...@gmail.com the previous code could lead to null pointer dereference. --- libavformat/segment.c | 14 ++ 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 1af412a..8274792 100644 ---

Re: [libav-devel] [PATCH] mov: Parse EC3SpecificBox (dec3 atom).

2012-04-27 Thread Justin Ruggles
On 04/25/2012 07:38 PM, Yusuke Nakamura wrote: Skip to parse fields for additional independent substreams and its associated dependent substreams since libavcodec's eac3 decoder doesn't support them yet. [...] +/* No need to parse fields for additional independent substreams and its +

Re: [libav-devel] [PATCH] avio: make avio_close(NULL) a no-op

2012-04-27 Thread Anton Khirnov
On Fri, 27 Apr 2012 12:41:05 -0700, Luca Barbato lu_z...@gentoo.org wrote: Its behaviour in line with ffurl_close(NULL). --- Ok. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH 1/3] h264: (trivial) remove unneeded macro argument in x86/cabac.h

2012-04-27 Thread Roland Scheidegger
--- libavcodec/x86/cabac.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/x86/cabac.h b/libavcodec/x86/cabac.h index a6ec228..c1fc0d1 100644 --- a/libavcodec/x86/cabac.h +++ b/libavcodec/x86/cabac.h @@ -27,7 +27,7 @@ #include config.h #if

[libav-devel] [PATCH 3/3] h264: new assembly version of get_cabac for x86_64 with PIC

2012-04-27 Thread Roland Scheidegger
This adds a hand-optimized assembly version for get_cabac much like the existing one, but it works if the table offsets are RIP-relative. Compared to the non-RIP-relative version this adds 2 lea instructions and it needs one extra register. There is a surprisingly large performance improvement

[libav-devel] [PATCH 2/3] h264: use one table instead of several for cabac functions

2012-04-27 Thread Roland Scheidegger
The reason is this is easier for PIC code (in particular on darwin...). Keep the old names as pointers (static in cabac_functions.h so gcc knows these are just immediate offsets) so the c code can nicely stay the same (alternatively could use offsets directly in the functions needing the tables).

Re: [libav-devel] [PATCH] segment: reorder seg_write_header allocation

2012-04-27 Thread Anton Khirnov
On Fri, 27 Apr 2012 12:41:16 -0700, Luca Barbato lu_z...@gentoo.org wrote: As pointed by Paul B Mahol one...@gmail.com the previous code could lead to null pointer dereference. --- Looks good. -- Anton Khirnov ___ libav-devel mailing list

Re: [libav-devel] [PATCH] configure: add POWER7 support

2012-04-27 Thread Sean McGovern
2012/4/27 Måns Rullgård m...@mansr.com: Sean McGovern gsean...@gmail.com writes: 2012/4/26 Måns Rullgård m...@mansr.com: Sean McGovern gsean...@gmail.com writes: 2012/4/25 Måns Rullgård m...@mansr.com: Sean McGovern gsean...@gmail.com writes: On Wednesday, April 25, 2012, Måns Rullgård