[libav-devel] [PATCH] yadif: Improve pts calculations.

2012-05-06 Thread Robert Nagy
Note, NOT tested. This should solve the problem where the pts for "next" is less than "cur" giving bogus pts values for "is_second", e.g. when seeking or looping. > From 0dec658687d959239da9fa90c78ca3f54e6ab47c Mon Sep 17 00:00:00 2001 > From: Robert Nagy > Date: Mon, 7 May 2012 07:27:46 +0200 >

[libav-devel] [PATCH] lavfi: uninline avfilter_copy_buffer_ref_props().

2012-05-06 Thread Anton Khirnov
A nontrivial public function such as this should most certainly NOT be inline. --- libavfilter/avfilter.c | 13 + libavfilter/avfilter.h | 13 + libavfilter/version.h |2 +- 3 files changed, 15 insertions(+), 13 deletions(-) diff --git a/libavfilter/avfilter.c b/l

Re: [libav-devel] [PATCH] zerocodec: check if the previous frame is missing

2012-05-06 Thread Derek Buitenhuis
On 06/05/2012 4:44 PM, Luca Barbato wrote: > From: Paul B Mahol > > ZeroCodec relies on the keyframe flag being set in the container, and > prev is the previously decoded frame. A keyframe flags incorrectly set > will lead to this condition. As per discussion on IRC, OK. - Derek ___

Re: [libav-devel] [PATCH 2/4] Move code shared between libdirac and?libschroedinger to libschroedinger.

2012-05-06 Thread Diego Biurrun
On Sun, May 06, 2012 at 06:31:37PM +, Jordi Ortiz wrote: > Diego Biurrun writes: > > > -void ff_dirac_schro_queue_init(DiracSchroQueue *queue) > > -{ > > -queue->p_head = queue->p_tail = NULL; > > -queue->size = 0; > align = > > -if (top) { > > -void *data = top->data; > >

[libav-devel] video september in paris (Re: [foms] VideoLAN Dev Days 2012

2012-05-06 Thread Holger Levsen
Hi Jean-Baptiste, I'm adding cc:s to the debconf-video and dvswitch-devel mailinglists, as those groups might be interested to join a video/multimedia meeting in Paris... (the DebConf/Debian videoteam stores its hardware in Paris..) so fullquote for their benefit: On Freitag, 4. Mai 2012, Jean

Re: [libav-devel] [PATCH] lavr: replace the SSE version of ff_conv_fltp_to_flt_6ch() with AVX

2012-05-06 Thread Justin Ruggles
On 05/03/2012 03:39 PM, Justin Ruggles wrote: > The SSE version is slower than the MMX version on Athlon64 and Sandy Bridge, > but the 3-arg AVX version is faster on Sandy Bridge. > --- > Athlon64 > C - 26322 > MMX - 7997 > SSE - 8662 > > Sandy Bridge > C - 13011 > MMX - 4262 > SSE - 4680

[libav-devel] [PATCH] zerocodec: check if the previous frame is missing

2012-05-06 Thread Luca Barbato
From: Paul B Mahol ZeroCodec relies on the keyframe flag being set in the container, and prev is the previously decoded frame. A keyframe flags incorrectly set will lead to this condition. Signed-off-by: Paul B Mahol Signed-off-by: Luca Barbato --- libavcodec/zerocodec.c |4 1 files

Re: [libav-devel] [PATCH] pthread: warn on high thread counts

2012-05-06 Thread Ronald S. Bultje
Hi, On Sun, May 6, 2012 at 9:13 AM, Diego Biurrun wrote: > On Mon, Mar 19, 2012 at 09:45:08AM -0700, Ronald S. Bultje wrote: >> On Mon, Mar 19, 2012 at 7:10 AM, Sean McGovern wrote: >> > On 3/19/12, Ronald S. Bultje wrote: >> >> On Sun, Mar 18, 2012 at 10:08 PM, Sean McGovern >> >> wrote: >>

[libav-devel] fps filter

2012-05-06 Thread Robert Nagy
Not finalized. Ported (by hand) some code I register as an fps filter inside a third party application. If anyone wants to implement a fps filter this is could maybe be something to start from. Note, does not take poll_frame into account. 0001-lavfi-Add-fps-filter.patch Description: Binary data

Re: [libav-devel] [PATCH 4/4] libschroedinger: Switch to function names more in line with Libav style.

2012-05-06 Thread Jordi Ortiz
Looks good to me ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/4] libschroedinger: Move a function to avoid a forward declaration.

2012-05-06 Thread Jordi Ortiz
Looks good to me ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/4] Move code shared between libdirac and libschroedinger to libschroedinger.

2012-05-06 Thread Jordi Ortiz
Diego Biurrun writes: > -void ff_dirac_schro_queue_init(DiracSchroQueue *queue) > -{ > -queue->p_head = queue->p_tail = NULL; > -queue->size = 0; align = > -if (top) { > -void *data = top->data; > -queue->p_head = queue->p_head->next; align = > +/** key frame flag

Re: [libav-devel] [PATCH 4/4] eatgv: check vector_bits

2012-05-06 Thread Kostya Shishkov
On Sun, May 06, 2012 at 12:43:04PM -0400, Derek Buitenhuis wrote: > On 06/05/2012 3:59 AM, Kostya Shishkov wrote: > > How about this? > > Looks good. applied ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/lib

Re: [libav-devel] [PATCH 4/4] eatgv: check vector_bits

2012-05-06 Thread Derek Buitenhuis
On 06/05/2012 3:59 AM, Kostya Shishkov wrote: > How about this? Looks good. - Derek ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] vf_yadif: fix missing error handling for avfilter_poll_frame()

2012-05-06 Thread Diego Biurrun
On Sun, May 06, 2012 at 06:18:49PM +0200, Diego Biurrun wrote: > From: Robert Nagy > > --- > libavfilter/vf_yadif.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) LGTM, queueing. Diego ___ libav-devel mailing list libav-devel@libav.o

[libav-devel] [PATCH] vf_yadif: fix missing error handling for avfilter_poll_frame()

2012-05-06 Thread Diego Biurrun
From: Robert Nagy --- libavfilter/vf_yadif.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/libavfilter/vf_yadif.c b/libavfilter/vf_yadif.c index 12b3783..790dda5 100644 --- a/libavfilter/vf_yadif.c +++ b/libavfilter/vf_yadif.c @@ -316,11 +316,15 @@ static int poll_f

Re: [libav-devel] [PATCH] pthread: warn on high thread counts

2012-05-06 Thread Diego Biurrun
On Mon, Mar 19, 2012 at 09:45:08AM -0700, Ronald S. Bultje wrote: > On Mon, Mar 19, 2012 at 7:10 AM, Sean McGovern wrote: > > On 3/19/12, Ronald S. Bultje wrote: > >> On Sun, Mar 18, 2012 at 10:08 PM, Sean McGovern wrote: > >>> --- > >>>  libavcodec/pthread.c |    4 > >>>  1 files changed,

Re: [libav-devel] [PATCH 06/12] dvdec: drop const qualifier from variable to eliminate a warning

2012-05-06 Thread Kostya Shishkov
On Thu, Apr 19, 2012 at 03:06:57PM +0200, Diego Biurrun wrote: > libavcodec/dvdec.c:344:12: warning: assignment discards ‘const’ qualifier > from pointer target type > --- > libavcodec/dvdec.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavcodec/dvdec.c b/lib

Re: [libav-devel] [PATCH] Mark a number of variables only used in av_dlog() calls as av_unused.

2012-05-06 Thread Kostya Shishkov
On Sun, Apr 22, 2012 at 05:06:30PM +0200, Diego Biurrun wrote: > This fixes a number of unused-but-set gcc warnings. > --- > libavcodec/wmalosslessdec.c |3 ++- > libavformat/mov.c |6 -- > libavformat/nsvdec.c|5 +++-- > 3 files changed, 9 insertions(+), 5 deleti

Re: [libav-devel] [PATCH] lavfi/formats: use sizeof(var) instead of sizeof(type).

2012-05-06 Thread Diego Biurrun
On Sun, May 06, 2012 at 10:32:15AM +0200, Anton Khirnov wrote: > > --- a/libavfilter/formats.c > +++ b/libavfilter/formats.c > @@ -67,7 +67,7 @@ AVFilterFormats *avfilter_merge_formats(AVFilterFormats *a, > AVFilterFormats *b) > > -ret->refs = > av_malloc(sizeof(AVFilterFormats**)*(a->refc

Re: [libav-devel] [PATCH 5/8] lavfi: always enable the scale filter and depend on sws.

2012-05-06 Thread Diego Biurrun
On Sun, May 06, 2012 at 10:24:19AM +0200, Anton Khirnov wrote: > > --- a/configure > +++ b/configure > @@ -1530,12 +1530,12 @@ frei0r_src_filter_deps="frei0r dlopen strtok_r" > > # libraries > avdevice_deps="avcodec avformat" > avformat_deps="avcodec" > +avfilter_deps="swscale" order > ---

Re: [libav-devel] [PATCH 3/8] lavfi: avfilter_merge_formats: handle case where inputs are same

2012-05-06 Thread Diego Biurrun
On Sun, May 06, 2012 at 10:24:17AM +0200, Anton Khirnov wrote: > --- a/libavfilter/formats.c > +++ b/libavfilter/formats.c > @@ -45,6 +45,8 @@ AVFilterFormats *avfilter_merge_formats(AVFilterFormats *a, > AVFilterFormats *b) > AVFilterFormats *ret; > unsigned i, j, k = 0, m_count; > >

Re: [libav-devel] [PATCH 1/8] lavc: add sample rate and channel layout to AVFrame.

2012-05-06 Thread Luca Barbato
On 06/05/12 01:24, Anton Khirnov wrote: > Rationale is the same as for video width/height etc. > --- > doc/APIchanges |3 +++ > libavcodec/avcodec.h | 16 > libavcodec/utils.c |4 > libavcodec/version.h |2 +- > 4 files changed, 24 insertions(+), 1 delet

Re: [libav-devel] [PATCH 6/8] lavfi: add a function for copying properties from AVFilterBufferRef->AVFrame

2012-05-06 Thread Luca Barbato
On 06/05/12 01:24, Anton Khirnov wrote: > Based on a commit by Stefano Sabatini > --- > libavfilter/avfilter.c | 30 ++ > libavfilter/avfilter.h |8 > 2 files changed, 38 insertions(+) > Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_ze

Re: [libav-devel] [PATCH 8/8] lavfi: remove avfilter_default_config_input_link() declaration

2012-05-06 Thread Luca Barbato
On 06/05/12 01:24, Anton Khirnov wrote: > From: Stefano Sabatini > > The function is not implemented (and possibly useless). > --- > libavfilter/avfilter.h |3 --- > 1 file changed, 3 deletions(-) OK. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero _

Re: [libav-devel] [PATCH] lavfi: support audio in avfilter_copy_frame_props().

2012-05-06 Thread Luca Barbato
On 06/05/12 01:35, Anton Khirnov wrote: > --- > libavfilter/avfilter.c | 27 +-- > 1 file changed, 17 insertions(+), 10 deletions(-) > Seems ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel

Re: [libav-devel] [PATCH 2/8] avconv: remove stray useless comment.

2012-05-06 Thread Luca Barbato
On 06/05/12 01:24, Anton Khirnov wrote: > --- > avconv.c |1 - > 1 file changed, 1 deletion(-) Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/li

Re: [libav-devel] [PATCH 5/8] lavfi: always enable the scale filter and depend on sws.

2012-05-06 Thread Luca Barbato
On 06/05/12 01:24, Anton Khirnov wrote: > The scale filter is used for internal colorspace conversions, so it must > always be present. > --- Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list libav-devel@li

Re: [libav-devel] [PATCH 4/8] vf_split: support user-specifiable number of outputs.

2012-05-06 Thread Luca Barbato
On 06/05/12 01:24, Anton Khirnov wrote: > --- > doc/filters.texi | 13 + > libavfilter/vf_split.c | 68 > +++- > 2 files changed, 68 insertions(+), 13 deletions(-) > Great =) thank you. lu -- Luca Barbato Gentoo/linux http://dev.

Re: [libav-devel] [PATCH] dfa: use more meaningful return codes

2012-05-06 Thread Luca Barbato
On 06/05/12 00:54, Kostya Shishkov wrote: > --- > libavcodec/dfa.c | 54 > +++--- > 1 files changed, 27 insertions(+), 27 deletions(-) > Thank you, patch ok. lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___

Re: [libav-devel] [PATCH 1/2] mips: intreadwrite: remove unnecessary inline asm

2012-05-06 Thread Måns Rullgård
Derek Buitenhuis writes: > On 05/05/2012 8:25 PM, Måns Rullgård wrote: >> Actually, some non-gcc compilers do try to support gcc inline asm, >> sometimes even with partial success. I checked clang, and it does the >> right thing (insofar it works at all for 64-bit) without any extra help. > > In

[libav-devel] [PATCH] lavfi: support audio in avfilter_copy_frame_props().

2012-05-06 Thread Anton Khirnov
--- libavfilter/avfilter.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index e89c476..78acda2 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -684,19 +684,26 @@ int avfilter_

[libav-devel] [PATCH] lavfi/formats: use sizeof(var) instead of sizeof(type).

2012-05-06 Thread Anton Khirnov
--- libavfilter/formats.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavfilter/formats.c b/libavfilter/formats.c index 53458e6..bd87427 100644 --- a/libavfilter/formats.c +++ b/libavfilter/formats.c @@ -47,7 +47,7 @@ AVFilterFormats *avfilter_merge_formats

[libav-devel] [PATCH 7/8] lavfi: support audio in avfilter_copy_frame_props().

2012-05-06 Thread Anton Khirnov
--- libavfilter/avfilter.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index e89c476..8f30b0c 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -690,13 +690,23 @@ int avfilter_copy

[libav-devel] [PATCH 6/8] lavfi: add a function for copying properties from AVFilterBufferRef->AVFrame

2012-05-06 Thread Anton Khirnov
Based on a commit by Stefano Sabatini --- libavfilter/avfilter.c | 30 ++ libavfilter/avfilter.h |8 2 files changed, 38 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index d426591..e89c476 100644 --- a/libavfilter/avfilter.

[libav-devel] [PATCH 8/8] lavfi: remove avfilter_default_config_input_link() declaration

2012-05-06 Thread Anton Khirnov
From: Stefano Sabatini The function is not implemented (and possibly useless). --- libavfilter/avfilter.h |3 --- 1 file changed, 3 deletions(-) diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h index 2b1bb55..f7c3cf1 100644 --- a/libavfilter/avfilter.h +++ b/libavfilter/avfilter

[libav-devel] [PATCH 1/8] lavc: add sample rate and channel layout to AVFrame.

2012-05-06 Thread Anton Khirnov
Rationale is the same as for video width/height etc. --- doc/APIchanges |3 +++ libavcodec/avcodec.h | 16 libavcodec/utils.c |4 libavcodec/version.h |2 +- 4 files changed, 24 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges i

[libav-devel] [PATCH 3/8] lavfi: avfilter_merge_formats: handle case where inputs are same

2012-05-06 Thread Anton Khirnov
From: Mina Nagy Zaki This fixes a double-free crash if lists are the same due to the two merge_ref() calls at the end of the (useless) merging that happens. Signed-off-by: Anton Khirnov --- libavfilter/formats.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/formats.c b/l

[libav-devel] [PATCH 5/8] lavfi: always enable the scale filter and depend on sws.

2012-05-06 Thread Anton Khirnov
The scale filter is used for internal colorspace conversions, so it must always be present. --- configure|2 +- libavfilter/Makefile |7 +++ libavfilter/allfilters.c |8 ++-- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/configure b/configu

[libav-devel] [PATCH 4/8] vf_split: support user-specifiable number of outputs.

2012-05-06 Thread Anton Khirnov
--- doc/filters.texi | 13 + libavfilter/vf_split.c | 68 +++- 2 files changed, 68 insertions(+), 13 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index b012dc7..c5a56f4 100644 --- a/doc/filters.texi +++ b/doc/filters.t

[libav-devel] [PATCH 2/8] avconv: remove stray useless comment.

2012-05-06 Thread Anton Khirnov
--- avconv.c |1 - 1 file changed, 1 deletion(-) diff --git a/avconv.c b/avconv.c index f702d9d..73f3bc3 100644 --- a/avconv.c +++ b/avconv.c @@ -598,7 +598,6 @@ static int configure_video_filters(FilterGraph *fg) InputStream *ist = fg->inputs[0]->ist; OutputStream *ost = fg->outpu

Re: [libav-devel] [PATCH 3/4] eatgv: check motion vectors

2012-05-06 Thread Kostya Shishkov
On Sat, May 05, 2012 at 11:21:54AM -0700, Luca Barbato wrote: > On 05/05/12 06:09, Kostya Shishkov wrote: > > --- > > libavcodec/eatgv.c | 14 -- > > 1 files changed, 8 insertions(+), 6 deletions(-) > > Ok. Found out that I've wronly used m[xy] + 4 >= {width,height} instead of m[xy

Re: [libav-devel] [PATCH 4/4] eatgv: check vector_bits

2012-05-06 Thread Kostya Shishkov
On Sat, May 05, 2012 at 07:45:11PM -0400, Derek Buitenhuis wrote: > On 05/05/2012 12:45 PM, Kostya Shishkov wrote: > >>> +av_log(s->avctx, AV_LOG_ERROR, "vector_bits %d invalid\n", > >>> vector_bits); > >> > > >> > Could certainly use a better messages, but LGTM in general. > > Feel free

[libav-devel] [PATCH] dfa: use more meaningful return codes

2012-05-06 Thread Kostya Shishkov
--- libavcodec/dfa.c | 54 +++--- 1 files changed, 27 insertions(+), 27 deletions(-) diff --git a/libavcodec/dfa.c b/libavcodec/dfa.c index 4fe6519..7b6c5d5 100644 --- a/libavcodec/dfa.c +++ b/libavcodec/dfa.c @@ -49,7 +49,7 @@ static int decode_c

Re: [libav-devel] [PATCH 1/4] dfa: add some checks to ensure that decoder won't write past frame end

2012-05-06 Thread Kostya Shishkov
On Sat, May 05, 2012 at 11:21:33AM -0700, Luca Barbato wrote: > On 05/05/12 06:08, Kostya Shishkov wrote: > > --- > > libavcodec/dfa.c |8 +++- > > 1 files changed, 7 insertions(+), 1 deletions(-) > > > > While you are it could you please use AVERROR? > > Beside that patch ok. Changed