Re: [libav-devel] [PATCH] Support decoding unaligned rgb24 lagarith.

2012-05-07 Thread Kostya Shishkov
On Mon, May 07, 2012 at 10:39:44PM -0600, Nathan Caldwell wrote: > On Mon, May 7, 2012 at 10:34 PM, Kostya Shishkov > wrote: > > On Mon, May 07, 2012 at 10:25:53PM -0600, Nathan Caldwell wrote: > >> From: Carl Eugen Hoyos > >> > >> Fixes ticket #1214. > >> --- > >> > >> I am not sure this is corr

Re: [libav-devel] [PATCH] Support decoding unaligned rgb24 lagarith.

2012-05-07 Thread Nathan Caldwell
On Mon, May 7, 2012 at 10:34 PM, Kostya Shishkov wrote: > On Mon, May 07, 2012 at 10:25:53PM -0600, Nathan Caldwell wrote: >> From: Carl Eugen Hoyos >> >> Fixes ticket #1214. >> --- >> >> I am not sure this is correct, I do not have any unaligned RGB samples >> to test with. > > At least we have

Re: [libav-devel] [PATCH] lagarith: add YUY2 decoding support

2012-05-07 Thread Nathan Caldwell
On Mon, May 7, 2012 at 10:29 PM, Kostya Shishkov wrote: > On Mon, May 07, 2012 at 09:34:48PM -0600, Nathan Caldwell wrote: >> On Mon, May 7, 2012 at 11:47 AM, Kostya Shishkov >> wrote: >> > Unlike other variants, for YUY2 we need to use different prediction: >> > * on line 0 for luma we should le

Re: [libav-devel] [PATCH] Support decoding unaligned rgb24 lagarith.

2012-05-07 Thread Kostya Shishkov
On Mon, May 07, 2012 at 10:25:53PM -0600, Nathan Caldwell wrote: > From: Carl Eugen Hoyos > > Fixes ticket #1214. > --- > > I am not sure this is correct, I do not have any unaligned RGB samples > to test with. > > libavcodec/lagarith.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletio

Re: [libav-devel] [PATCH] lagarith: add YUY2 decoding support

2012-05-07 Thread Kostya Shishkov
On Mon, May 07, 2012 at 09:34:48PM -0600, Nathan Caldwell wrote: > On Mon, May 7, 2012 at 11:47 AM, Kostya Shishkov > wrote: > > Unlike other variants, for YUY2 we need to use different prediction: > > * on line 0 for luma we should left predict starting from the second pixel > > * on line 1 we sh

[libav-devel] [PATCH] Support decoding unaligned rgb24 lagarith.

2012-05-07 Thread Nathan Caldwell
From: Carl Eugen Hoyos Fixes ticket #1214. --- I am not sure this is correct, I do not have any unaligned RGB samples to test with. libavcodec/lagarith.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavcodec/lagarith.c b/libavcodec/lagarith.c index b27e755..41df

Re: [libav-devel] [PATCH] lagarith: add YUY2 decoding support

2012-05-07 Thread Nathan Caldwell
On Mon, May 7, 2012 at 11:47 AM, Kostya Shishkov wrote: > Unlike other variants, for YUY2 we need to use different prediction: > * on line 0 for luma we should left predict starting from the second pixel > * on line 1 we should left predict first 4 pixels for luma and 2 for chroma > * median predi

Re: [libav-devel] [PATCH] fate: Make oneline comparison ignore CR

2012-05-07 Thread Luca Barbato
On 07/05/12 18:36, Derek Buitenhuis wrote: > On 07/05/2012 8:26 PM, Ronald S. Bultje wrote: >> Although true, I don't think anyone wants to set up a real Windows >> test system. Either we don't test at all, or we test under wine. > > This seems like a horrible stance. A metric butt-load of users >

Re: [libav-devel] [PATCH] fate: Make oneline comparison ignore CR

2012-05-07 Thread Derek Buitenhuis
On 07/05/2012 8:26 PM, Ronald S. Bultje wrote: > Although true, I don't think anyone wants to set up a real Windows > test system. Either we don't test at all, or we test under wine. This seems like a horrible stance. A metric butt-load of users are on Windows, and neglecting to properly cover tha

Re: [libav-devel] [PATCH] fate: Make oneline comparison ignore CR

2012-05-07 Thread Ronald S. Bultje
Hi, On Mon, May 7, 2012 at 5:04 PM, Måns Rullgård wrote: > Alex Converse writes: > >> On Mon, May 7, 2012 at 4:32 PM, Måns Rullgård wrote: >>> Alex Converse writes: >>> ---  tests/fate-run.sh |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test

Re: [libav-devel] [PATCH] fate: Make oneline comparison ignore CR

2012-05-07 Thread Måns Rullgård
Luca Barbato writes: > On 07/05/12 17:04, Måns Rullgård wrote: >> Alex Converse writes: >> >>> On Mon, May 7, 2012 at 4:32 PM, Måns Rullgård wrote: Alex Converse writes: > --- > tests/fate-run.sh |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >

Re: [libav-devel] [PATCH] fate: Make oneline comparison ignore CR

2012-05-07 Thread Måns Rullgård
Luca Barbato writes: > On 07/05/12 16:52, Alex Converse wrote: >> The code doesn't run on a MinGW shell, fate-run.sh runs on dash on >> Linux, avprobe runs under wine. > > Looks like we have a good corner case. Using something different from > dash helps in any way? The shell is not the problem

Re: [libav-devel] [PATCH 2/2] lavc: check that extended_data is properly set in avcodec_encode_audio2().

2012-05-07 Thread Luca Barbato
On 07/05/12 08:05, Anton Khirnov wrote: > --- > libavcodec/utils.c | 17 + > 1 file changed, 17 insertions(+) > Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list libav-devel@libav.org ht

[libav-devel] mp3: "Header missing" error on last packet w/o seek.

2012-05-07 Thread Dale Curtis
All, We're running into a strange issue with an mp3 where it throws a "header missing" error if played straight through, but plays through fine w/ a seek to 1. E.g., using D_0.mp3 from: http://www.danedington.co.uk/superThings/HTML5Guitar/D_0.mp3 $ ffplay -autoexit D_0.mp3 ... [mp3 @ 0x25ee0c0]

Re: [libav-devel] [PATCH 11/22] lavfi: move audio-related functions to a separate file.

2012-05-07 Thread Luca Barbato
On 07/05/12 10:34, Anton Khirnov wrote: > This is easier to follow than having them randomly scattered in > avfilter.c and defaults.c. > --- > libavfilter/Makefile |1 + > libavfilter/audio.c| 208 > > libavfilter/avfilter.c | 126 +

Re: [libav-devel] [PATCH 10/22] lavfi: remove some audio-related function from public API.

2012-05-07 Thread Luca Barbato
On 07/05/12 10:34, Anton Khirnov wrote: > Those functions are only useful inside filter. It is better to not > support user filters until the API is more stable. > > This breaks audio filtering API and ABI in theory, but since it's > unusable right now this shouldn't be a problem. > --- > libavfi

Re: [libav-devel] [PATCH 09/22] lavfi: change AVFilterBufferRefAudioProps.sample_rate from uint32_t to int

2012-05-07 Thread Luca Barbato
On 07/05/12 10:34, Anton Khirnov wrote: > There's no reason for it to be explicitly 32 bits. It's declared as a > plain int in all other places in Libav. > > This breaks audio filtering API and ABI in theory, but since it's > unusable right now this shouldn't be a problem. > --- > libavfilter/avf

Re: [libav-devel] [PATCH 02/22] samplefmt: add a function for copying audio samples.

2012-05-07 Thread Luca Barbato
On 07/05/12 10:33, Anton Khirnov wrote: > --- > libavutil/samplefmt.c | 12 > libavutil/samplefmt.h | 12 > 2 files changed, 24 insertions(+) Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-d

Re: [libav-devel] [PATCH] fate: Make oneline comparison ignore CR

2012-05-07 Thread Luca Barbato
On 07/05/12 17:04, Måns Rullgård wrote: > Alex Converse writes: > >> On Mon, May 7, 2012 at 4:32 PM, Måns Rullgård wrote: >>> Alex Converse writes: >>> --- tests/fate-run.sh |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/fate-run.sh b/te

Re: [libav-devel] [PATCH] fate: Make oneline comparison ignore CR

2012-05-07 Thread Luca Barbato
On 07/05/12 16:52, Alex Converse wrote: > The code doesn't run on a MinGW shell, fate-run.sh runs on dash on > Linux, avprobe runs under wine. Looks like we have a good corner case. Using something different from dash helps in any way? lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_

Re: [libav-devel] [PATCH] fate: Make oneline comparison ignore CR

2012-05-07 Thread Måns Rullgård
Alex Converse writes: > On Mon, May 7, 2012 at 4:32 PM, Måns Rullgård wrote: >> Alex Converse writes: >> >>> --- >>>  tests/fate-run.sh |    2 +- >>>  1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/tests/fate-run.sh b/tests/fate-run.sh >>> index a45e9a9..2522a21 100755 >>

Re: [libav-devel] [PATCH] fate: Make oneline comparison ignore CR

2012-05-07 Thread Alex Converse
On Mon, May 7, 2012 at 4:32 PM, Måns Rullgård wrote: > Alex Converse writes: > >> --- >>  tests/fate-run.sh |    2 +- >>  1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/tests/fate-run.sh b/tests/fate-run.sh >> index a45e9a9..2522a21 100755 >> --- a/tests/fate-run.sh >> +++ b/

Re: [libav-devel] [PATCH] Fix make checkheaders

2012-05-07 Thread Måns Rullgård
Alex Converse writes: > --- > libavcodec/options_table.h |5 + > libavformat/options_table.h |4 > 2 files changed, 9 insertions(+), 0 deletions(-) Does it really make sense to include these files in that test? -- Måns Rullgård m...@mansr.com

Re: [libav-devel] [PATCH] fate: Make oneline comparison ignore CR

2012-05-07 Thread Måns Rullgård
Alex Converse writes: > --- > tests/fate-run.sh |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tests/fate-run.sh b/tests/fate-run.sh > index a45e9a9..2522a21 100755 > --- a/tests/fate-run.sh > +++ b/tests/fate-run.sh > @@ -61,7 +61,7 @@ stddev(){ > } > > oneline

[libav-devel] [PATCH] Fix make checkheaders

2012-05-07 Thread Alex Converse
--- libavcodec/options_table.h |5 + libavformat/options_table.h |4 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h index 1e2560c..1c438ff 100644 --- a/libavcodec/options_table.h +++ b/libavcodec/options_tabl

[libav-devel] [PATCH] fate: Make oneline comparison ignore CR

2012-05-07 Thread Alex Converse
--- tests/fate-run.sh |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index a45e9a9..2522a21 100755 --- a/tests/fate-run.sh +++ b/tests/fate-run.sh @@ -61,7 +61,7 @@ stddev(){ } oneline(){ -val=$(cat "$2") +val=$(cat "$2"

Re: [libav-devel] [libav-commits] fate: Add avprobe as a make dependency

2012-05-07 Thread Alex Converse
On Mon, May 7, 2012 at 3:28 PM, Diego Biurrun wrote: > On Mon, May 07, 2012 at 01:24:38PM -0700, Alex Converse wrote: >> On Mon, May 7, 2012 at 1:18 PM, Luca Barbato wrote: >> > On 07/05/12 12:54, Alex Converse wrote: >> >> On Mon, May 7, 2012 at 12:30 PM, Måns Rullgård wrote: >> >>> "Alex Conve

Re: [libav-devel] [libav-commits] fate: Add avprobe as a make dependency

2012-05-07 Thread Måns Rullgård
Diego Biurrun writes: > On Mon, May 07, 2012 at 01:24:38PM -0700, Alex Converse wrote: >> On Mon, May 7, 2012 at 1:18 PM, Luca Barbato wrote: >> > On 07/05/12 12:54, Alex Converse wrote: >> >> On Mon, May 7, 2012 at 12:30 PM, Måns Rullgård wrote: >> >>> "Alex Converse " writes: >> >>

Re: [libav-devel] [libav-commits] fate: Add avprobe as a make dependency

2012-05-07 Thread Diego Biurrun
On Mon, May 07, 2012 at 01:24:38PM -0700, Alex Converse wrote: > On Mon, May 7, 2012 at 1:18 PM, Luca Barbato wrote: > > On 07/05/12 12:54, Alex Converse wrote: > >> On Mon, May 7, 2012 at 12:30 PM, Måns Rullgård wrote: > >>> "Alex Converse " writes: > > --- a/tests/Makefile > +++

Re: [libav-devel] [PATCH 01/22] lavfi: add a function for copying properties from AVFilterBufferRef->AVFrame

2012-05-07 Thread Luca Barbato
On 07/05/12 10:33, Anton Khirnov wrote: > Based on a commit by Stefano Sabatini > --- > libavfilter/avfilter.c | 30 ++ > libavfilter/avfilter.h |8 > 2 files changed, 38 insertions(+) > Looks fine. -- Luca Barbato Gentoo/linux http://dev.gentoo.or

Re: [libav-devel] [PATCH] avprobe: don't print format entry name when only one was requested

2012-05-07 Thread Diego Biurrun
On Mon, May 07, 2012 at 10:02:39PM +0200, Anton Khirnov wrote: > This is easier to parse with automated tools. > --- > avprobe.c |6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) While generally desirable, this requires matching changes in FATE. > --- a/avprobe.c > +++ b/avprobe.c

Re: [libav-devel] [PATCH 1/2] Dirac: Dirac Native Decoder Base. No asm optimizations

2012-05-07 Thread Diego Biurrun
On Mon, May 07, 2012 at 10:15:17PM +0200, Jordi Ortiz wrote: > From: Jordi Ortiz > > Bitexact with libschroedinger with the exception of: > Deep-estimation > mx_precision 1 and 2 > transform 0 > --- > libavcodec/Makefile |2 + > libavcodec/allcodecs.c |1 + > libavcodec/dirac_arit

Re: [libav-devel] [PATCH 2/2] Dirac: add Comments and references to the standard

2012-05-07 Thread Diego Biurrun
On Mon, May 07, 2012 at 10:15:18PM +0200, Jordi Ortiz wrote: > > --- > libavcodec/dirac.c | 123 > +--- > 1 file changed, 78 insertions(+), 45 deletions(-) This does more than the log message suggests. > --- a/libavcodec/dirac.c > +++ b/libavcod

Re: [libav-devel] [Debconf-video] video september in paris (Re: [foms] VideoLAN Dev Days 2012

2012-05-07 Thread Peter 'p2' De Schrijver
On 2012-05-05 14:51:09 (-0600), Holger Levsen wrote: > Hi Jean-Baptiste, > > I'm adding cc:s to the debconf-video and dvswitch-devel mailinglists, as > those > groups might be interested to join a video/multimedia meeting in Paris... > (the > DebConf/Debian videoteam stores its hardware in Pa

Re: [libav-devel] [PATCH] libmp3lame: set supported channel layouts.

2012-05-07 Thread Justin Ruggles
Hi, On 05/07/2012 04:02 PM, Anton Khirnov wrote: > --- > libavcodec/libmp3lame.c |8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/libmp3lame.c b/libavcodec/libmp3lame.c > index c7abb99..8f25438 100644 > --- a/libavcodec/libmp3lame.c > +++ b/libavcode

Re: [libav-devel] [libav-commits] fate: Add avprobe as a make dependency

2012-05-07 Thread Måns Rullgård
Alex Converse writes: > On Mon, May 7, 2012 at 1:02 PM, Måns Rullgård wrote: >> Alex Converse writes: >> >>> On Mon, May 7, 2012 at 12:30 PM, Måns Rullgård wrote: "Alex Converse " writes: > Module: libav > Branch: master > Commit: 6345209a7d1ac2013704c42e3610a91f889f39ff

Re: [libav-devel] [PATCH] avprobe: don't print format entry name when only one was requested

2012-05-07 Thread Måns Rullgård
Anton Khirnov writes: > This is easier to parse with automated tools. > --- > avprobe.c |6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) This needs an update to the fate tests using it. -- Måns Rullgård m...@mansr.com ___ libav-devel

Re: [libav-devel] [libav-commits] fate: Add avprobe as a make dependency

2012-05-07 Thread Alex Converse
On Mon, May 7, 2012 at 1:18 PM, Luca Barbato wrote: > On 07/05/12 12:54, Alex Converse wrote: >> On Mon, May 7, 2012 at 12:30 PM, Måns Rullgård wrote: >>> "Alex Converse " writes: >>> Module: libav Branch: master Commit: 6345209a7d1ac2013704c42e3610a91f889f39ff Author:  

Re: [libav-devel] [libav-commits] fate: Add avprobe as a make dependency

2012-05-07 Thread Alex Converse
On Mon, May 7, 2012 at 1:02 PM, Måns Rullgård wrote: > Alex Converse writes: > >> On Mon, May 7, 2012 at 12:30 PM, Måns Rullgård wrote: >>> "Alex Converse " writes: >>> Module: libav Branch: master Commit: 6345209a7d1ac2013704c42e3610a91f889f39ff Author:    Alex Convers

Re: [libav-devel] [libav-commits] fate: Add avprobe as a make dependency

2012-05-07 Thread Luca Barbato
On 07/05/12 12:54, Alex Converse wrote: > On Mon, May 7, 2012 at 12:30 PM, Måns Rullgård wrote: >> "Alex Converse " writes: >> >>> Module: libav >>> Branch: master >>> Commit: 6345209a7d1ac2013704c42e3610a91f889f39ff >>> >>> Author:Alex Converse >>> Committer: Alex Converse >>> Date: M

[libav-devel] [PATCH 2/2] Dirac: add Comments and references to the standard

2012-05-07 Thread Jordi Ortiz
From: Jordi Ortiz --- libavcodec/dirac.c | 123 +--- 1 file changed, 78 insertions(+), 45 deletions(-) diff --git a/libavcodec/dirac.c b/libavcodec/dirac.c index bf56088..4811662 100644 --- a/libavcodec/dirac.c +++ b/libavcodec/dirac.c @@ -22,7 +

[libav-devel] [PATCH] avprobe: don't print format entry name when only one was requested

2012-05-07 Thread Anton Khirnov
This is easier to parse with automated tools. --- avprobe.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/avprobe.c b/avprobe.c index 8d2ec24..f44c929 100644 --- a/avprobe.c +++ b/avprobe.c @@ -34,6 +34,7 @@ const int program_birth_year = 2007; static int do_show_f

[libav-devel] [PATCH] libmp3lame: set supported channel layouts.

2012-05-07 Thread Anton Khirnov
--- libavcodec/libmp3lame.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/libmp3lame.c b/libavcodec/libmp3lame.c index c7abb99..8f25438 100644 --- a/libavcodec/libmp3lame.c +++ b/libavcodec/libmp3lame.c @@ -26,6 +26,7 @@ #include +#include "libavut

Re: [libav-devel] [libav-commits] fate: Add avprobe as a make dependency

2012-05-07 Thread Måns Rullgård
Alex Converse writes: > On Mon, May 7, 2012 at 12:30 PM, Måns Rullgård wrote: >> "Alex Converse " writes: >> >>> Module: libav >>> Branch: master >>> Commit: 6345209a7d1ac2013704c42e3610a91f889f39ff >>> >>> Author:    Alex Converse >>> Committer: Alex Converse >>> Date:      Mon May  7 11:00:

Re: [libav-devel] [libav-commits] fate: Add avprobe as a make dependency

2012-05-07 Thread Alex Converse
On Mon, May 7, 2012 at 12:30 PM, Måns Rullgård wrote: > "Alex Converse " writes: > >> Module: libav >> Branch: master >> Commit: 6345209a7d1ac2013704c42e3610a91f889f39ff >> >> Author:    Alex Converse >> Committer: Alex Converse >> Date:      Mon May  7 11:00:54 2012 -0700 >> >> fate: Add avpro

Re: [libav-devel] [libav-commits] fate: Add avprobe as a make dependency

2012-05-07 Thread Måns Rullgård
"Alex Converse " writes: > Module: libav > Branch: master > Commit: 6345209a7d1ac2013704c42e3610a91f889f39ff > > Author:Alex Converse > Committer: Alex Converse > Date: Mon May 7 11:00:54 2012 -0700 > > fate: Add avprobe as a make dependency > > --- > > tests/Makefile |2 +- > 1

Re: [libav-devel] [PATCH] doc: Replace a stray reference to the old '-intra' flag.

2012-05-07 Thread Anton Khirnov
On Mon, 7 May 2012 12:11:33 -0700, Alex Converse wrote: > --- > doc/avconv.texi |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Ok. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailma

Re: [libav-devel] [PATCH 1/2] fate: Add avprobe as a make dependency

2012-05-07 Thread Måns Rullgård
Alex Converse writes: > --- > tests/Makefile |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tests/Makefile b/tests/Makefile > index 56a8bb7..c440f04 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -119,7 +119,7 @@ FATE_UTILS = base64 tiny_psnr > > fate:

[libav-devel] [PATCH] doc: Replace a stray reference to the old '-intra' flag.

2012-05-07 Thread Alex Converse
--- doc/avconv.texi |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/avconv.texi b/doc/avconv.texi index bf72c4c..cc46e95 100644 --- a/doc/avconv.texi +++ b/doc/avconv.texi @@ -712,7 +712,7 @@ frame rate or decrease the frame size. @item If your computer is not fast

Re: [libav-devel] [PATCH 12/22] lavfi: add lavr-based audio resampling filter.

2012-05-07 Thread Anton Khirnov
On Mon, 07 May 2012 14:52:01 -0400, Justin Ruggles wrote: > On 05/07/2012 01:34 PM, Anton Khirnov wrote: > > +av_log(ctx, AV_LOG_VERBOSE, > > + "fmt:%s cl:%s -> fmt:%s cl:%s\n", > > + av_get_sample_fmt_name(inlink ->format), buf1, > > + av_get_sample_fmt_name(ou

Re: [libav-devel] [PATCH 2/5] dv: Split profile handling code into a separate file.

2012-05-07 Thread Diego Biurrun
On Wed, Apr 18, 2012 at 07:00:34PM +0200, Diego Biurrun wrote: > > --- /dev/null > +++ b/libavcodec/dv_profile.h > @@ -0,0 +1,72 @@ > + > +#ifndef AVCODEC_PROFILE_H > +#define AVCODEC_PROFILE_H > + > +#endif /* AVCODEC_PROFILE_H */ This should be AVCODEC_DV_PROFILE_H. OKed by Anton on IRC with t

Re: [libav-devel] [PATCH 12/22] lavfi: add lavr-based audio resampling filter.

2012-05-07 Thread Justin Ruggles
On 05/07/2012 01:34 PM, Anton Khirnov wrote: > +av_log(ctx, AV_LOG_VERBOSE, > + "fmt:%s cl:%s -> fmt:%s cl:%s\n", > + av_get_sample_fmt_name(inlink ->format), buf1, > + av_get_sample_fmt_name(outlink->format), buf2); shouldn't we also print sample rate here? -Jus

Re: [libav-devel] [PATCH 2/2] fate: Change the probe-format refs to match the final text format committed.

2012-05-07 Thread Anton Khirnov
On Mon, 7 May 2012 11:03:01 -0700, Alex Converse wrote: > --- > tests/fate/probe.mak |8 > 1 files changed, 4 insertions(+), 4 deletions(-) > Both patches LGTM. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org http

Re: [libav-devel] [RFC] lockmgr callback inclusion into libs sources

2012-05-07 Thread Luca Barbato
On 07/05/12 08:09, Andrey Utkin wrote: > 2012/5/7 Luca Barbato : >> I like the idea. shall we call it av_default_lockmgr? > > I think we may have av_default_lockmgr_{posix,winapi} etc. that hold > separate implementations, and conditionally-set av_default_lockmgr > function that calls them, or jus

[libav-devel] [PATCH 2/2] fate: Change the probe-format refs to match the final text format committed.

2012-05-07 Thread Alex Converse
--- tests/fate/probe.mak |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/fate/probe.mak b/tests/fate/probe.mak index 8a1fd9a..39068f2 100644 --- a/tests/fate/probe.mak +++ b/tests/fate/probe.mak @@ -1,14 +1,14 @@ FATE_PROBE_FORMAT += fate-probe-format-roundup

[libav-devel] [PATCH 1/2] fate: Add avprobe as a make dependency

2012-05-07 Thread Alex Converse
--- tests/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index 56a8bb7..c440f04 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -119,7 +119,7 @@ FATE_UTILS = base64 tiny_psnr fate: $(FATE) -$(FATE): avconv$(EXESUF) $(FATE

Re: [libav-devel] [PATCH] lagarith: add YUY2 decoding support

2012-05-07 Thread Luca Barbato
On 07/05/12 10:47, Kostya Shishkov wrote: > Unlike other variants, for YUY2 we need to use different prediction: > * on line 0 for luma we should left predict starting from the second pixel > * on line 1 we should left predict first 4 pixels for luma and 2 for chroma > * median prediction employed

[libav-devel] [PATCH] lagarith: add YUY2 decoding support

2012-05-07 Thread Kostya Shishkov
Unlike other variants, for YUY2 we need to use different prediction: * on line 0 for luma we should left predict starting from the second pixel * on line 1 we should left predict first 4 pixels for luma and 2 for chroma * median prediction employed here is taken directly from HuffYUV --- libavcode

[libav-devel] [PATCH 21/22] lavfi: add aformat filter

2012-05-07 Thread Anton Khirnov
Based on a patch by Mina Nagy Zaki --- doc/filters.texi | 15 + libavfilter/Makefile |1 + libavfilter/af_aformat.c | 148 ++ libavfilter/allfilters.c |1 + 4 files changed, 165 insertions(+) create mode 100644 libavfilter/af

[libav-devel] [PATCH 20/22] lavfi: add an audio buffer sink.

2012-05-07 Thread Anton Khirnov
--- libavfilter/allfilters.c |4 ++ libavfilter/buffersink.c | 102 -- libavfilter/buffersink.h | 21 +- 3 files changed, 122 insertions(+), 5 deletions(-) diff --git a/libavfilter/allfilters.c b/libavfilter/allfilters.c index 99cbf82..dc

[libav-devel] [PATCH 18/22] buffersrc: add av_buffersrc_write_frame().

2012-05-07 Thread Anton Khirnov
It's the same as av_vsrc_buffer_add_frame(), except it doesn't take pts or pixel_aspect parameters. Those are read from AVFrame. Deprecate av_vsrc_buffer_add_frame(). --- avconv.c|3 +-- libavfilter/buffersrc.c | 20 ++-- libavfilter/buffersrc.h | 11 ++

[libav-devel] [PATCH 22/22] avconv: add support for audio filters.

2012-05-07 Thread Anton Khirnov
--- avconv.c | 636 ++--- tests/ref/fate/amv| 20 +- tests/ref/fate/smjpeg | 16 +- tests/ref/fate/truemotion1-15 |2 +- 4 files changed, 354 insertions(+), 320 deletions(-) diff --git a/avconv.c b/avconv.c inde

[libav-devel] [PATCH 13/22] lavfi: autoinsert resample filter when necessary.

2012-05-07 Thread Anton Khirnov
--- libavfilter/avfiltergraph.c | 51 +-- 1 file changed, 35 insertions(+), 16 deletions(-) diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c index 04d9027..2ac1bc3 100644 --- a/libavfilter/avfiltergraph.c +++ b/libavfilter/avfiltergr

[libav-devel] [PATCH 14/22] lavfi: add types and functions for channel layout/samplerate negotiation

2012-05-07 Thread Anton Khirnov
--- libavfilter/avfilter.h | 16 +++ libavfilter/formats.c | 280 +++- libavfilter/formats.h | 78 ++ 3 files changed, 299 insertions(+), 75 deletions(-) create mode 100644 libavfilter/formats.h diff --git a/libavfilter/avfilter.h b/

[libav-devel] [PATCH 05/22] lavfi: add avfilter_get_audio_buffer_ref_from_arrays().

2012-05-07 Thread Anton Khirnov
From: Stefano Sabatini Signed-off-by: Anton Khirnov --- libavfilter/avfilter.c | 67 libavfilter/avfilter.h | 16 2 files changed, 83 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 5973e6b..a146

[libav-devel] [PATCH 07/22] lavfi: use avfilter_get_audio_buffer_ref_from_arrays() in avfilter_default_get_audio_buffer

2012-05-07 Thread Anton Khirnov
From: Stefano Sabatini --- libavfilter/defaults.c | 82 +++- 1 file changed, 18 insertions(+), 64 deletions(-) diff --git a/libavfilter/defaults.c b/libavfilter/defaults.c index fcb29e3..7c75ab9 100644 --- a/libavfilter/defaults.c +++ b/libavfilter/

[libav-devel] [PATCH 11/22] lavfi: move audio-related functions to a separate file.

2012-05-07 Thread Anton Khirnov
This is easier to follow than having them randomly scattered in avfilter.c and defaults.c. --- libavfilter/Makefile |1 + libavfilter/audio.c| 208 libavfilter/avfilter.c | 126 + libavfilter/defaults.c | 64

[libav-devel] [PATCH 10/22] lavfi: remove some audio-related function from public API.

2012-05-07 Thread Anton Khirnov
Those functions are only useful inside filter. It is better to not support user filters until the API is more stable. This breaks audio filtering API and ABI in theory, but since it's unusable right now this shouldn't be a problem. --- libavfilter/af_anull.c |5 ++-- libavfilter/audio.h|

[libav-devel] [PATCH 12/22] lavfi: add lavr-based audio resampling filter.

2012-05-07 Thread Anton Khirnov
--- configure |2 +- libavfilter/Makefile |5 +- libavfilter/af_resample.c | 188 + libavfilter/allfilters.c |4 + 4 files changed, 196 insertions(+), 3 deletions(-) create mode 100644 libavfilter/af_resample.c diff -

[libav-devel] [PATCH 19/22] lavfi: add an audio buffer source.

2012-05-07 Thread Anton Khirnov
--- libavfilter/allfilters.c |4 + libavfilter/buffersrc.c | 211 +- 2 files changed, 195 insertions(+), 20 deletions(-) diff --git a/libavfilter/allfilters.c b/libavfilter/allfilters.c index eb713cd..99cbf82 100644 --- a/libavfilter/allfilters.c

[libav-devel] [PATCH 15/22] lavfi: add channel layout/sample rate negotiation.

2012-05-07 Thread Anton Khirnov
--- libavfilter/af_resample.c | 11 libavfilter/avfilter.c | 21 -- libavfilter/avfiltergraph.c | 151 --- libavfilter/defaults.c | 72 + 4 files changed, 187 insertions(+), 68 deletions(-) diff --git a/libavf

[libav-devel] [PATCH 06/22] lavfi: cleanup avfilter_get_audio_buffer() and pals.

2012-05-07 Thread Anton Khirnov
From: Stefano Sabatini Remove AVFilterBufferRefAudioProps.size, and use nb_samples in its place everywhere. This is required as the size in the audio buffer may be aligned, so it may not contain a well defined number of samples. Also remove the useless planar parameter, which can be deduced from

[libav-devel] [PATCH 16/22] lavfi: rename vsrc_buffer.c to buffersrc.c

2012-05-07 Thread Anton Khirnov
Most of the code will be shared for both audio and video version. --- libavfilter/Makefile |2 +- libavfilter/buffersrc.c | 215 + libavfilter/vsrc_buffer.c | 215 - 3 files changed, 216 insertions

[libav-devel] [PATCH 17/22] buffersrc: fix invalid read in uninit if the fifo hasn't been allocated

2012-05-07 Thread Anton Khirnov
--- libavfilter/buffersrc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index 1ace368..c7284c1 100644 --- a/libavfilter/buffersrc.c +++ b/libavfilter/buffersrc.c @@ -137,7 +137,7 @@ static av_cold int init(AVFilterContext

[libav-devel] [PATCH 09/22] lavfi: change AVFilterBufferRefAudioProps.sample_rate from uint32_t to int

2012-05-07 Thread Anton Khirnov
There's no reason for it to be explicitly 32 bits. It's declared as a plain int in all other places in Libav. This breaks audio filtering API and ABI in theory, but since it's unusable right now this shouldn't be a problem. --- libavfilter/avfilter.h |2 +- 1 file changed, 1 insertion(+), 1 d

[libav-devel] [PATCH 08/22] lavfi: simplify signature for avfilter_get_audio_buffer() and friends

2012-05-07 Thread Anton Khirnov
From: Stefano Sabatini The additional parameters are just complicating the function interface. Assume that a requested samples buffer will *always* have the format specified in the requested link. This breaks audio filtering API and ABI in theory, but since it's unusable right now this shouldn'

[libav-devel] [PATCH 03/22] lavfi: add vsink_buffer, and use it in avtools

2012-05-07 Thread Anton Khirnov
Also add the public interface libavfilter/buffersink.h. --- avconv.c | 104 ++ avplay.c | 29 cmdutils.c | 68 --- cmdutils.h | 15 -- configure

[libav-devel] [PATCH 02/22] samplefmt: add a function for copying audio samples.

2012-05-07 Thread Anton Khirnov
--- libavutil/samplefmt.c | 12 libavutil/samplefmt.h | 12 2 files changed, 24 insertions(+) diff --git a/libavutil/samplefmt.c b/libavutil/samplefmt.c index 0a2ffa0..fb6a78f 100644 --- a/libavutil/samplefmt.c +++ b/libavutil/samplefmt.c @@ -185,3 +185,15 @@ int av_

[libav-devel] [PATCH 01/22] lavfi: add a function for copying properties from AVFilterBufferRef->AVFrame

2012-05-07 Thread Anton Khirnov
Based on a commit by Stefano Sabatini --- libavfilter/avfilter.c | 30 ++ libavfilter/avfilter.h |8 2 files changed, 38 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index d1c82ce..f12ca3a 100644 --- a/libavfilter/avfilter.

[libav-devel] [PATCH 04/22] lavfi: add extended_data to AVFilterBuffer.

2012-05-07 Thread Anton Khirnov
This is similar to what has previously been done in AVFrame to allow dealing with more than 8 channels. --- libavfilter/avfilter.c | 33 + libavfilter/avfilter.h | 32 libavfilter/defaults.c |2 ++ 3 files changed, 67 inserti

[libav-devel] [RFC] Audio filters

2012-05-07 Thread Anton Khirnov
Hi, here is the my current work on audio filters. It's still not complete, but I'm throwing it out here to get some comments. FATE passes, the stuff that's missing is: - polishing and docs - turn async stuff from avconv into a filter - more testing - more filters (we have only source, sink and res

Re: [libav-devel] [PATCH 1/3] fate: Add oneline comparison method

2012-05-07 Thread Diego Biurrun
On Mon, May 07, 2012 at 10:18:49AM -0700, Alex Converse wrote: > On Thu, May 3, 2012 at 5:55 PM, Alex Converse wrote: > > --- a/tests/fate-run.sh > > +++ b/tests/fate-run.sh > > > > Tested with success and failure > > ping? You fixed all the issues Mans mentioned, if this is tested and works, pu

Re: [libav-devel] [PATCH 1/3] mp3/ac3 probe: search for PES headers to prevent probing MPEG-PS as MP3.

2012-05-07 Thread Ronald S. Bultje
Hi, On Thu, May 3, 2012 at 6:16 PM, Ronald S. Bultje wrote: > Hi, > > On Thu, May 3, 2012 at 11:00 AM, Ronald S. Bultje wrote: >> From: "Ronald S. Bultje" >> >> --- >>  libavformat/ac3dec.c |   30 +- >>  libavformat/mp3dec.c |   30 +- >>  

Re: [libav-devel] [PATCH 1/3] fate: Add oneline comparison method

2012-05-07 Thread Alex Converse
On Thu, May 3, 2012 at 5:55 PM, Alex Converse wrote: > From: Mans Rullgard > > Signed-off-by: Alex Converse > --- >  tests/fate-run.sh |    9 - >  1 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/tests/fate-run.sh b/tests/fate-run.sh > index f7a7aba..8097eec 100755 > ---

Re: [libav-devel] [PATCH] lavr: replace the SSE version of ff_conv_fltp_to_flt_6ch() with AVX

2012-05-07 Thread Vitor Sessak
On 05/07/2012 04:29 PM, Justin Ruggles wrote: On 05/07/2012 08:18 AM, Vitor Sessak wrote: On 05/03/2012 09:39 PM, Justin Ruggles wrote: The SSE version is slower than the MMX version on Athlon64 and Sandy Bridge, but the 3-arg AVX version is faster on Sandy Bridge. --- Athlon64 C - 26322 MM

Re: [libav-devel] [PATCH 2/4] avcodec: refactor avcodec_encode_audio2() to merge common branches

2012-05-07 Thread Anton Khirnov
On Wed, 21 Mar 2012 15:55:33 -0400, Justin Ruggles wrote: > --- > libavcodec/utils.c |9 - > 1 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index f66295a..6494499 100644 > --- a/libavcodec/utils.c > +++ b/libavcodec/utils

[libav-devel] [PATCH 1/2] lavc: pad last audio frame with silence when needed.

2012-05-07 Thread Anton Khirnov
--- avconv.c |8 -- doc/APIchanges|5 libavcodec/avcodec.h | 10 +++- libavcodec/internal.h |6 + libavcodec/utils.c| 68 + libavcodec/version.h |2 +- 6 files changed, 83 insertions(+),

[libav-devel] [PATCH 2/2] lavc: check that extended_data is properly set in avcodec_encode_audio2().

2012-05-07 Thread Anton Khirnov
--- libavcodec/utils.c | 17 + 1 file changed, 17 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 4d1b1c2..74df9ec 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -911,6 +911,7 @@ int attribute_align_arg avcodec_encode_audio2(AVCodecContext

Re: [libav-devel] [RFC] lockmgr callback inclusion into libs sources

2012-05-07 Thread Andrey Utkin
2012/5/7 Luca Barbato : > I like the idea. shall we call it av_default_lockmgr? I think we may have av_default_lockmgr_{posix,winapi} etc. that hold separate implementations, and conditionally-set av_default_lockmgr function that calls them, or just points to them. -- Andrey Utkin __

Re: [libav-devel] [RFC] lockmgr callback inclusion into libs sources

2012-05-07 Thread Luca Barbato
On 07/05/12 07:20, Andrey Utkin wrote: > I'd like to offer inclusion of suitable lockmgr callback functions > into libraries code. > (To make it clear for non-familiar people: i mean the function we > register with lavc av_lockmgr_register() when we work multithreadingly > with {de,en}coders. > Cur

Re: [libav-devel] [PATCH 10/12] mov: Remove write-only variable in mov_read_chan().

2012-05-07 Thread Justin Ruggles
On 04/19/2012 09:07 AM, Diego Biurrun wrote: > libavformat/mov.c:597:25: warning: variable ‘cflags’ set but not used > --- > libavformat/mov.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index e1468ce..eb92703 100644 > -

Re: [libav-devel] [PATCH 05/12] av_samples_fill_array: Mark unmodified function argument as const.

2012-05-07 Thread Justin Ruggles
On 04/19/2012 09:06 AM, Diego Biurrun wrote: > libavcodec/utils.c:274: warning: passing argument 3 of > ‘av_samples_fill_arrays’ discards qualifiers from pointer target type > ./libavutil/samplefmt.h:151: note: expected ‘uint8_t *’ but argument is of > type ‘const uint8_t *’ > --- > libavutil/sa

Re: [libav-devel] [PATCH] lavr: replace the SSE version of ff_conv_fltp_to_flt_6ch() with AVX

2012-05-07 Thread Justin Ruggles
On 05/07/2012 08:18 AM, Vitor Sessak wrote: > On 05/03/2012 09:39 PM, Justin Ruggles wrote: >> The SSE version is slower than the MMX version on Athlon64 and Sandy >> Bridge, >> but the 3-arg AVX version is faster on Sandy Bridge. >> --- >> Athlon64 >>C - 26322 >> MMX - 7997 >> SSE - 8662 >>

Re: [libav-devel] [PATCH] flvenc: use AVFormatContext, not AVCodecContext for logging.

2012-05-07 Thread Justin Ruggles
On 05/07/2012 10:11 AM, Anton Khirnov wrote: > Encoder tag being used for muxer messages is confusing. > --- > libavformat/flvenc.c | 21 +++-- > 1 file changed, 11 insertions(+), 10 deletions(-) LGTM. -Justin ___ libav-devel mailing

[libav-devel] [RFC] lockmgr callback inclusion into libs sources

2012-05-07 Thread Andrey Utkin
I'd like to offer inclusion of suitable lockmgr callback functions into libraries code. (To make it clear for non-familiar people: i mean the function we register with lavc av_lockmgr_register() when we work multithreadingly with {de,en}coders. Currently every app maker who needs it must copy&paste

[libav-devel] [PATCH] flvenc: use AVFormatContext, not AVCodecContext for logging.

2012-05-07 Thread Anton Khirnov
Encoder tag being used for muxer messages is confusing. --- libavformat/flvenc.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index 42ecde1..19169ad 100644 --- a/libavformat/flvenc.c +++ b/libavformat/flve

Re: [libav-devel] [PATCH] lavc: pad last audio frame with silence when needed.

2012-05-07 Thread Justin Ruggles
On 05/07/2012 08:22 AM, Anton Khirnov wrote: > --- > avconv.c |8 -- > doc/APIchanges|5 > libavcodec/avcodec.h | 10 +++- > libavcodec/internal.h |6 + > libavcodec/utils.c| 68 > + > libav

Re: [libav-devel] [PATCH 1/2] h264: K&R formatting cosmetics for header files (part I/II)

2012-05-07 Thread Kostya Shishkov
On Mon, May 07, 2012 at 02:14:33PM +0200, Diego Biurrun wrote: > --- > libavcodec/h264.h | 499 +--- > libavcodec/h264data.h | 369 ++-- > libavcodec/h264pred.h | 81 + > 3 files changed, 491 insertions(+),

Re: [libav-devel] [PATCH 1/2] h264: K&R formatting cosmetics for header files (part I/II)

2012-05-07 Thread Diego Biurrun
On Mon, May 07, 2012 at 02:32:05PM +0200, Clément Bœsch wrote: > On Mon, May 07, 2012 at 02:14:33PM +0200, Diego Biurrun wrote: > > --- > > libavcodec/h264.h | 499 > > +--- > [...] > > void ff_h264_reset_sei(H264Context *h); > > > > - > > /* >

Re: [libav-devel] [PATCH] lavc: pad last audio frame with silence when needed.

2012-05-07 Thread Anton Khirnov
On Mon, 7 May 2012 14:22:12 +0200, Anton Khirnov wrote: > @@ -882,6 +932,17 @@ int attribute_align_arg > avcodec_encode_audio2(AVCodecContext *avctx, > if (nb_samples > avctx->frame_size) > return AVERROR(EINVAL); > } else if (!(avctx->codec->capabilities

  1   2   >