[libav-devel] [PATCH 04/30] samplefmt: add a function for copying audio samples.

--- libavutil/samplefmt.c | 19 +++ libavutil/samplefmt.h | 15 +++ 2 files changed, 34 insertions(+) diff --git a/libavutil/samplefmt.c b/libavutil/samplefmt.c index 711afac..5b01a81 100644 --- a/libavutil/samplefmt.c +++ b/libavutil/samplefmt.c @@ -185,3 +185,22

[libav-devel] [PATCH] Audio filters II

Hi, this should be pretty close to finished. The highlight of this set compared to the last one is that I've stuffed async into its own filter and removed its evilness from avconv. As a very nice side effect, adding audio filters support makes avconv 191 lines _shorter_ and all those evil fifos an

[libav-devel] [PATCH 01/30] libmp3lame: set supported channel layouts.

--- libavcodec/libmp3lame.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/libmp3lame.c b/libavcodec/libmp3lame.c index c7abb99..8f25438 100644 --- a/libavcodec/libmp3lame.c +++ b/libavcodec/libmp3lame.c @@ -26,6 +26,7 @@ #include +#include "libavut

[libav-devel] [PATCH 03/30] lavr: do not try to copy to uninitialized output audio data.

This would happen at least when lavr is used as a fifo with no conversion. --- libavresample/utils.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavresample/utils.c b/libavresample/utils.c index e533760..6d4509d 100644 --- a/libavresample/utils.c +++ b/libavresample/

[libav-devel] [PATCH 02/30] lavr: make avresample_read() with NULL output discard samples.

--- libavresample/avresample.h |3 ++- libavresample/utils.c |2 ++ libavresample/version.h|2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libavresample/avresample.h b/libavresample/avresample.h index 7350805..65d4d2d 100644 --- a/libavresample/avresample

[libav-devel] [PATCH 07/30] lavc: check that extended_data is properly set in avcodec_encode_audio2().

--- libavcodec/utils.c | 17 + 1 file changed, 17 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 5eda596..077768b 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -910,6 +910,7 @@ int attribute_align_arg avcodec_encode_audio2(AVCodecContext

[libav-devel] [PATCH 08/30] lavfi: add extended_data to AVFilterBuffer.

This is similar to what has previously been done in AVFrame to allow dealing with more than 8 channels. --- libavfilter/avfilter.c | 33 + libavfilter/avfilter.h | 32 libavfilter/defaults.c |2 ++ 3 files changed, 67 inserti

[libav-devel] [PATCH 09/30] lavfi: add avfilter_get_audio_buffer_ref_from_arrays().

From: Stefano Sabatini Signed-off-by: Anton Khirnov --- libavfilter/avfilter.c | 67 libavfilter/avfilter.h | 16 2 files changed, 83 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 5973e6b..a146

[libav-devel] [PATCH 12/30] lavfi: simplify signature for avfilter_get_audio_buffer() and friends

From: Stefano Sabatini The additional parameters are just complicating the function interface. Assume that a requested samples buffer will *always* have the format specified in the requested link. This breaks audio filtering API and ABI in theory, but since it's unusable right now this shouldn'

[libav-devel] [PATCH 06/30] lavc: pad last audio frame with silence when needed.

--- avconv.c |8 -- doc/APIchanges|6 + libavcodec/avcodec.h | 10 +++- libavcodec/internal.h |6 + libavcodec/utils.c| 66 + libavcodec/version.h |2 +- 6 files changed, 82 insertions(+)

[libav-devel] [PATCH 05/30] samplefmt: add a memset()-like function for samples.

--- libavutil/samplefmt.c | 17 + libavutil/samplefmt.h | 13 + 2 files changed, 30 insertions(+) diff --git a/libavutil/samplefmt.c b/libavutil/samplefmt.c index 5b01a81..3e6f79a 100644 --- a/libavutil/samplefmt.c +++ b/libavutil/samplefmt.c @@ -204,3 +204,20 @@ i

[libav-devel] [PATCH 10/30] lavfi: cleanup avfilter_get_audio_buffer() and pals.

From: Stefano Sabatini Remove AVFilterBufferRefAudioProps.size, and use nb_samples in its place everywhere. This is required as the size in the audio buffer may be aligned, so it may not contain a well defined number of samples. Also remove the useless planar parameter, which can be deduced from

[libav-devel] [PATCH 16/30] lavfi: move audio-related functions to a separate file.

This is easier to follow than having them randomly scattered in avfilter.c and defaults.c. --- libavfilter/Makefile |1 + libavfilter/audio.c| 208 libavfilter/avfilter.c | 126 + libavfilter/defaults.c | 64

[libav-devel] [PATCH 14/30] lavfi: change AVFilterLink.sample_rate from int64_t to int.

There is no real reason for it to be 64bit, it's just a plain int in the rest of Libav. This breaks audio filtering API and ABI in theory, but since it's unusable right now this shouldn't be a problem. Does not break ABI for the rest of lavfi assuming 32bit ints. --- libavfilter/avfilter.h |

[libav-devel] [PATCH 13/30] lavfi: change AVFilterBufferRefAudioProps.sample_rate from uint32_t to int

There's no reason for it to be explicitly 32 bits. It's declared as a plain int in all other places in Libav. This breaks audio filtering API and ABI in theory, but since it's unusable right now this shouldn't be a problem. --- libavfilter/avfilter.h |2 +- 1 file changed, 1 insertion(+), 1 d

[libav-devel] [PATCH 23/30] buffersrc: fix invalid read in uninit if the fifo hasn't been allocated

--- libavfilter/buffersrc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index 1ace368..c7284c1 100644 --- a/libavfilter/buffersrc.c +++ b/libavfilter/buffersrc.c @@ -137,7 +137,7 @@ static av_cold int init(AVFilterContext

[libav-devel] [PATCH 30/30] avconv: automatically insert asyncts when -async is used.

Deprecate -async. --- avconv.c| 27 +++ doc/avconv.texi |1 + 2 files changed, 28 insertions(+) diff --git a/avconv.c b/avconv.c index 5cd233a..9ae7ec4 100644 --- a/avconv.c +++ b/avconv.c @@ -703,6 +703,33 @@ static int configure_audio_filters(FilterGraph *f

[libav-devel] [PATCH 26/30] lavfi: add an audio buffer sink.

--- doc/filters.texi |7 libavfilter/allfilters.c |4 ++ libavfilter/buffersink.c | 102 -- libavfilter/buffersink.h | 21 +- 4 files changed, 129 insertions(+), 5 deletions(-) diff --git a/doc/filters.texi b/doc/filters.

[libav-devel] [PATCH 11/30] lavfi: use avfilter_get_audio_buffer_ref_from_arrays() in avfilter_default_get_audio_buffer

From: Stefano Sabatini --- libavfilter/defaults.c | 82 +++- 1 file changed, 18 insertions(+), 64 deletions(-) diff --git a/libavfilter/defaults.c b/libavfilter/defaults.c index fcb29e3..7c75ab9 100644 --- a/libavfilter/defaults.c +++ b/libavfilter/

[libav-devel] [PATCH 15/30] lavfi: remove some audio-related function from public API.

Those functions are only useful inside filter. It is better to not support user filters until the API is more stable. This breaks audio filtering API and ABI in theory, but since it's unusable right now this shouldn't be a problem. --- libavfilter/af_anull.c |5 ++-- libavfilter/audio.h|

[libav-devel] [PATCH 19/30] lavfi: add types and functions for channel layout/samplerate negotiation

--- libavfilter/avfilter.h | 16 +++ libavfilter/formats.c | 280 +++- libavfilter/formats.h | 78 ++ 3 files changed, 299 insertions(+), 75 deletions(-) create mode 100644 libavfilter/formats.h diff --git a/libavfilter/avfilter.h b/

[libav-devel] [PATCH 20/30] lavfi: add channel layout/sample rate negotiation.

--- libavfilter/af_resample.c | 11 ++ libavfilter/avfilter.c | 21 +++- libavfilter/avfiltergraph.c | 255 +-- libavfilter/defaults.c | 72 +++- 4 files changed, 292 insertions(+), 67 deletions(-) diff --git a/libavfilter/af_resa

[libav-devel] [PATCH 25/30] lavfi: add an audio buffer source.

--- doc/filters.texi | 27 ++ libavfilter/allfilters.c |4 + libavfilter/buffersrc.c | 211 +- 3 files changed, 222 insertions(+), 20 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 8eff84a..f3fb985 100644 --- a/d

[libav-devel] [PATCH 17/30] lavfi: add lavr-based audio resampling filter.

--- configure |2 +- doc/filters.texi |6 ++ libavfilter/Makefile |5 +- libavfilter/af_resample.c | 220 + libavfilter/allfilters.c |4 + 5 files changed, 234 insertions(+), 3 deletions(-) create mode 100

[libav-devel] [PATCH 29/30] avconv: add support for audio filters.

The FATE changes are all off-by-one due to different rounding being used (lrintf vs av_rescale_q). --- avconv.c | 803 - doc/avconv.texi |5 + tests/ref/fate/amv| 20 +- tests/ref/fate/smjpeg | 16 +- 4 files changed,

[libav-devel] [PATCH 27/30] lavfi: add aformat filter

Based on a patch by Mina Nagy Zaki --- doc/filters.texi | 26 libavfilter/Makefile |1 + libavfilter/af_aformat.c | 148 ++ libavfilter/allfilters.c |1 + 4 files changed, 176 insertions(+) create mode 100644 libavfilter

[libav-devel] [PATCH 24/30] buffersrc: add av_buffersrc_write_frame().

It's the same as av_vsrc_buffer_add_frame(), except it doesn't take pts or pixel_aspect parameters. Those are read from AVFrame. Deprecate av_vsrc_buffer_add_frame(). --- avconv.c|3 +-- libavfilter/buffersrc.c | 20 ++-- libavfilter/buffersrc.h | 11 ++

[libav-devel] [PATCH 21/30] avfiltergraph: reindent

--- libavfilter/avfiltergraph.c | 110 +-- 1 file changed, 55 insertions(+), 55 deletions(-) diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c index 8326ad0..e9d7fcf 100644 --- a/libavfilter/avfiltergraph.c +++ b/libavfilter/avfiltergr

[libav-devel] [PATCH 28/30] lavfi: add asyncts filter.

--- doc/filters.texi | 19 libavfilter/Makefile |1 + libavfilter/af_asyncts.c | 239 ++ libavfilter/allfilters.c |1 + 4 files changed, 260 insertions(+) create mode 100644 libavfilter/af_asyncts.c diff --git a/doc/filters.

[libav-devel] [PATCH 22/30] lavfi: rename vsrc_buffer.c to buffersrc.c

Most of the code will be shared for both audio and video version. --- libavfilter/Makefile |2 +- libavfilter/buffersrc.c | 215 + libavfilter/vsrc_buffer.c | 215 - 3 files changed, 216 insertions

[libav-devel] [PATCH 18/30] lavfi: autoinsert resample filter when necessary.

--- libavfilter/avfiltergraph.c | 51 +-- 1 file changed, 35 insertions(+), 16 deletions(-) diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c index 04d9027..2ac1bc3 100644 --- a/libavfilter/avfiltergraph.c +++ b/libavfilter/avfiltergr

Re: [libav-devel] [PATCH] rtmp: Implement check bandwidth notification.

On Wed, 9 May 2012, Samuel Pitoiset wrote: According to the behaviour of librtmp, it is recommended to send this message to the server after receiving the 'onBWDone' callback in order to do bandwidth checking and improve compatibility with some servers. --- libavformat/rtmpproto.c | 21 +++

Re: [libav-devel] [PATCH 3/3] rtmp: Support 'rtmp_swfurl', an option which specifies the URL of the SWF player.

On Wed, 9 May 2012, Samuel Pitoiset wrote: --- libavformat/rtmpproto.c |8 1 file changed, 8 insertions(+) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index e1c4beb..427655c 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -86,6 +86,7 @@ typed

Re: [libav-devel] [PATCH] rtmp: Implement check bandwidth notification.

On Wed, May 9, 2012 at 2:53 AM, Luca Barbato wrote: > On 08/05/12 15:58, Samuel Pitoiset wrote: > > +} else if (!memcmp(pkt->data, "\002\000\010onBWDone", 11)) { > > You might make a macro or a function to do this kind of matches since > they will be used a lot later, (And will be used pr

Re: [libav-devel] [PATCH] rtmp: Implement check bandwidth notification.

On Wed, May 9, 2012 at 11:41 AM, Martin Storsjö wrote: > On Wed, 9 May 2012, Samuel Pitoiset wrote: > > According to the behaviour of librtmp, it is recommended to send this >> message to the server after receiving the 'onBWDone' callback in order >> to do bandwidth checking and improve compatib

Re: [libav-devel] [PATCH 3/3] rtmp: Support 'rtmp_swfurl', an option which specifies the URL of the SWF player.

On Wed, May 9, 2012 at 11:41 AM, Martin Storsjö wrote: > On Wed, 9 May 2012, Samuel Pitoiset wrote: > > --- >> libavformat/rtmpproto.c |8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c >> index e1c4beb..427655c 100644 >> --- a

Re: [libav-devel] [PATCH 1/2] Solaris: add _XOPEN_SOURCE=600 to preprocessor flags.

On Wed, May 09, 2012 at 02:13:15AM -0400, Sean McGovern wrote: > This is needed to expose some networking APIs. > --- > configure |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) LGTM, queueing. Diego ___ libav-devel mailing list libav-dev

Re: [libav-devel] [PATCH 2/2] sctp: be consistent with socket option level

On Wed, May 09, 2012 at 02:13:16AM -0400, Sean McGovern wrote: > Use IPPROTO_SCTP instead of SOL_SCTP which is not defined on some platforms. > --- > libavformat/sctp.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) LGTM, will test on Linux and queue. Diego ___

[libav-devel] Windows builds

Hi, All ! Is it possible to have builds of releases (like 0.8.1) on http://win32.libav.org ? Otherwise, there is no place of stable libav binaries for windows at all. And, may be possible to have static binaries for linux also, because distributes usually contains out-of-date binaries of libav.

Re: [libav-devel] [PATCH 05/30] samplefmt: add a memset()-like function for samples.

On Wed, May 09, 2012 at 09:13:23AM +0200, Anton Khirnov wrote: > > --- a/libavutil/samplefmt.h > +++ b/libavutil/samplefmt.h > @@ -209,4 +209,17 @@ int av_samples_copy(uint8_t **dst, uint8_t **src, int > dst_offset, int src_offset > > +/** > + * Fill an audio buffer with a constant value. > + *

Re: [libav-devel] [PATCH 09/30] lavfi: add avfilter_get_audio_buffer_ref_from_arrays().

On Wed, May 09, 2012 at 09:13:27AM +0200, Anton Khirnov wrote: > From: Stefano Sabatini > > Signed-off-by: Anton Khirnov > --- > libavfilter/avfilter.c | 67 > > libavfilter/avfilter.h | 16 > 2 files changed, 83 insertions(+) >

Re: [libav-devel] [PATCH 15/30] lavfi: remove some audio-related function from public API.

On Wed, May 09, 2012 at 09:13:33AM +0200, Anton Khirnov wrote: > Those functions are only useful inside filter. It is better to not filterS Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 22/30] lavfi: rename vsrc_buffer.c to buffersrc.c

On Wed, May 09, 2012 at 09:13:40AM +0200, Anton Khirnov wrote: > Most of the code will be shared for both audio and video version. > --- > libavfilter/Makefile |2 +- > libavfilter/buffersrc.c | 215 > + > libavfilter/vsrc_buffer.c | 215 >

Re: [libav-devel] [PATCH] fate: add convenient shorthand for vp6 tests

On Wed, May 09, 2012 at 04:12:23AM +0200, Diego Biurrun wrote: > --- > tests/fate/vpx.mak |7 +-- > 1 files changed, 5 insertions(+), 2 deletions(-) Disregard this one, a more comprehensive one is coming up. Diego ___ libav-devel mailing list l

[libav-devel] [PATCH] fate: employ better names and add a convenient shorthand for vp6 tests

--- tests/fate/vpx.mak | 22 +++--- tests/ref/fate/{ea-vp60 => vp60} |0 tests/ref/fate/{ea-vp61 => vp61} |0 3 files changed, 11 insertions(+), 11 deletions(-) rename tests/ref/fate/{ea-vp60 => vp60} (100%) rename tests/ref/fate/{ea-vp61 => vp61} (100%)

Re: [libav-devel] [PATCH 2/2] sctp: be consistent with socket option level

Sean McGovern writes: > Use IPPROTO_SCTP instead of SOL_SCTP which is not defined on some platforms. > --- > libavformat/sctp.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavformat/sctp.c b/libavformat/sctp.c > index 3823e03..817b004 100644 > --- a/libavform

Re: [libav-devel] [PATCH] configure: add --enable/disable-random option

On 2012-05-09 04:32:09 +0100, Måns Rullgård wrote: > This allows creating random configurations which is useful for > testing purposes. > > Signed-off-by: Mans Rullgard > --- > Disregard the previous mail. It has some debug stuff left behind. > --- > configure | 20 > 1 f

Re: [libav-devel] [PATCH] fate: employ better names and add a convenient shorthand for vp6 tests

Diego Biurrun writes: > --- > tests/fate/vpx.mak | 22 +++--- > tests/ref/fate/{ea-vp60 => vp60} |0 > tests/ref/fate/{ea-vp61 => vp61} |0 > 3 files changed, 11 insertions(+), 11 deletions(-) > rename tests/ref/fate/{ea-vp60 => vp60} (100%) > rename tes

Re: [libav-devel] [PATCH] fate: employ better names and add a convenient shorthand for vp6 tests

On Wed, May 09, 2012 at 02:34:48PM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > --- a/tests/fate/vpx.mak > > +++ b/tests/fate/vpx.mak > > @@ -19,12 +10,21 @@ fate-vp3: $(FATE_VP3) > > FATE_AVCONV += fate-vp5 > > fate-vp5: CMD = framecrc -i $(SAMPLES)/vp5/potter512-400-partial.avi -an

Re: [libav-devel] [PATCH] fate: employ better names and add a convenient shorthand for vp6 tests

On Wed, May 09, 2012 at 03:41:27PM +0200, Diego Biurrun wrote: > On Wed, May 09, 2012 at 02:34:48PM +0100, Måns Rullgård wrote: > > Diego Biurrun writes: > > > --- a/tests/fate/vpx.mak > > > +++ b/tests/fate/vpx.mak > > > @@ -19,12 +10,21 @@ fate-vp3: $(FATE_VP3) > > > FATE_AVCONV += fate-vp5 > >

[libav-devel] [PATCH] lavr: replace the SSE version of ff_conv_fltp_to_flt_6ch() with SSE4 and AVX

The current SSE version is slower than the MMX version on Athlon64 and Sandy Bridge, but the SSE4 and AVX versions are faster on Sandy Bridge. --- libavresample/x86/audio_convert.asm| 30 -- libavresample/x86/audio_convert_init.c | 13 + libavutil/x8

Re: [libav-devel] [PATCH 01/30] libmp3lame: set supported channel layouts.

On 05/09/2012 03:13 AM, Anton Khirnov wrote: > --- > libavcodec/libmp3lame.c |8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) LGTM if applied with this patch set. -Justin ___ libav-devel mailing list libav-devel@libav.org https://list

Re: [libav-devel] [PATCH 05/30] samplefmt: add a memset()-like function for samples.

On 05/09/2012 03:13 AM, Anton Khirnov wrote: > --- > libavutil/samplefmt.c | 17 + > libavutil/samplefmt.h | 13 + > 2 files changed, 30 insertions(+) [...] > +/** > + * Fill an audio buffer with a constant value. > + * > + * @param audio_data array of pointers to d

Re: [libav-devel] [PATCH 02/30] lavr: make avresample_read() with NULL output discard samples.

On 05/09/2012 03:13 AM, Anton Khirnov wrote: > --- > libavresample/avresample.h |3 ++- > libavresample/utils.c |2 ++ > libavresample/version.h|2 +- > 3 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/libavresample/avresample.h b/libavresample/avresample.h >

Re: [libav-devel] [PATCH 03/30] lavr: do not try to copy to uninitialized output audio data.

On 05/09/2012 03:13 AM, Anton Khirnov wrote: > This would happen at least when lavr is used as a fifo with no > conversion. > --- > libavresample/utils.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavresample/utils.c b/libavresample/utils.c > index e533760..6d

Re: [libav-devel] [PATCH 04/30] samplefmt: add a function for copying audio samples.

On 05/09/2012 03:13 AM, Anton Khirnov wrote: > +int av_samples_copy(uint8_t **dst, uint8_t **src, int dst_offset, int > src_offset, > +int nb_samples, int nb_channels, > +enum AVSampleFormat sample_fmt) Should src be uint8_t *const *src? -Justin _

Re: [libav-devel] [PATCH 06/30] lavc: pad last audio frame with silence when needed.

On 05/09/2012 03:13 AM, Anton Khirnov wrote: > +frame = padded_frame; > +avctx->internal->last_audio_frame = 1; weird spacing otherwise patch LGTM -Justin ___ libav-devel mailing list libav-devel@libav.org https://

Re: [libav-devel] [PATCH 07/30] lavc: check that extended_data is properly set in avcodec_encode_audio2().

On 05/09/2012 03:13 AM, Anton Khirnov wrote: > --- > libavcodec/utils.c | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index 5eda596..077768b 100644 > --- a/libavcodec/utils.c > +++ b/libavcodec/utils.c > @@ -910,6 +910,7 @@

Re: [libav-devel] [PATCH 05/30] samplefmt: add a memset()-like function for samples.

On Wed, 09 May 2012 10:09:29 -0400, Justin Ruggles wrote: > On 05/09/2012 03:13 AM, Anton Khirnov wrote: > > --- > > libavutil/samplefmt.c | 17 + > > libavutil/samplefmt.h | 13 + > > 2 files changed, 30 insertions(+) > [...] > > +/** > > + * Fill an audio buffe

Re: [libav-devel] [PATCH 12/12] jpeglsdec: Remove write-only variable in ff_jpegls_decode_lse().

On Mon, May 07, 2012 at 12:36:00PM +0200, Kostya Shishkov wrote: > On Mon, May 07, 2012 at 12:23:18PM +0200, Diego Biurrun wrote: > > On Thu, Apr 19, 2012 at 03:07:03PM +0200, Diego Biurrun wrote: > > > libavcodec/jpeglsdec.c:54:9: warning: variable ‘len’ set but not used > > > --- > > > libavcode

Re: [libav-devel] [PATCH 12/12] jpeglsdec: Remove write-only variable in ff_jpegls_decode_lse().

On Wed, May 09, 2012 at 04:33:35PM +0200, Diego Biurrun wrote: > On Mon, May 07, 2012 at 12:36:00PM +0200, Kostya Shishkov wrote: > > On Mon, May 07, 2012 at 12:23:18PM +0200, Diego Biurrun wrote: > > > On Thu, Apr 19, 2012 at 03:07:03PM +0200, Diego Biurrun wrote: > > > > libavcodec/jpeglsdec.c:54

Re: [libav-devel] [PATCH 08/30] lavfi: add extended_data to AVFilterBuffer.

On 05/09/2012 03:13 AM, Anton Khirnov wrote: > This is similar to what has previously been done in AVFrame to allow > dealing with more than 8 channels. > --- > libavfilter/avfilter.c | 33 + > libavfilter/avfilter.h | 32 > liba

[libav-devel] [PATCH] samplefmt: add a function for copying audio samples.

--- libavutil/samplefmt.c | 19 +++ libavutil/samplefmt.h | 15 +++ 2 files changed, 34 insertions(+) diff --git a/libavutil/samplefmt.c b/libavutil/samplefmt.c index 711afac..1caddf9 100644 --- a/libavutil/samplefmt.c +++ b/libavutil/samplefmt.c @@ -185,3 +185,22

Re: [libav-devel] [PATCH 09/30] lavfi: add avfilter_get_audio_buffer_ref_from_arrays().

On 05/09/2012 03:13 AM, Anton Khirnov wrote: > From: Stefano Sabatini > > Signed-off-by: Anton Khirnov > --- > libavfilter/avfilter.c | 67 > > libavfilter/avfilter.h | 16 > 2 files changed, 83 insertions(+) LGTM -Justin ___

Re: [libav-devel] [PATCH 1/3] fate: Give more consistent names to some RealVideo/RealAudio tests.

On Thu, Apr 26, 2012 at 03:05:55PM +0200, Diego Biurrun wrote: > --- > tests/fate/real.mak |8 > tests/ref/fate/{real-14_4 => ra-144} |0 > tests/ref/fate/{real-rv40 => rv40} |0 > 3 files changed, 4 insertions(+), 4 deletions(-) > rename tests/ref/fate/{re

[libav-devel] [PATCH] fate: cosmetics: lowercase some comments

--- tests/fate/wavpack.mak | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/fate/wavpack.mak b/tests/fate/wavpack.mak index 2b64d76..d70f713 100644 --- a/tests/fate/wavpack.mak +++ b/tests/fate/wavpack.mak @@ -1,4 +1,4 @@ -# Lossless +# lossless FATE_WAVPA

Re: [libav-devel] [PATCH] samplefmt: add a function for copying audio samples.

On Wed, 9 May 2012 16:39:41 +0200, Anton Khirnov wrote: > --- > libavutil/samplefmt.c | 19 +++ > libavutil/samplefmt.h | 15 +++ > 2 files changed, 34 insertions(+) > Meh, I'll remove the first const after all, it generates warnings. -- Anton Khirnov ___

Re: [libav-devel] [PATCH] samplefmt: add a function for copying audio samples.

On 05/09/2012 10:39 AM, Anton Khirnov wrote: > --- > libavutil/samplefmt.c | 19 +++ > libavutil/samplefmt.h | 15 +++ > 2 files changed, 34 insertions(+) > > diff --git a/libavutil/samplefmt.c b/libavutil/samplefmt.c > index 711afac..1caddf9 100644 > --- a/libavut

Re: [libav-devel] [PATCH 12/12] jpeglsdec: Remove write-only variable in ff_jpegls_decode_lse().

On Wed, May 09, 2012 at 04:37:43PM +0200, Kostya Shishkov wrote: > On Wed, May 09, 2012 at 04:33:35PM +0200, Diego Biurrun wrote: > > On Mon, May 07, 2012 at 12:36:00PM +0200, Kostya Shishkov wrote: > > > On Mon, May 07, 2012 at 12:23:18PM +0200, Diego Biurrun wrote: > > > > On Thu, Apr 19, 2012 at

[libav-devel] [PATCH] cmdutils: Add fallback case to switch in check_stream_specifier().

This fixes the warning: cmdutils.c:897: warning: ‘type’ may be used uninitialized in this function --- cmdutils.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/cmdutils.c b/cmdutils.c index 3cd11ca..2ff5676 100644 --- a/cmdutils.c +++ b/cmdutils.c @@ -34,6 +34,7 @@ #in

Re: [libav-devel] [PATCH] fate: cosmetics: lowercase some comments

Diego Biurrun writes: > --- > tests/fate/wavpack.mak | 10 +- > 1 files changed, 5 insertions(+), 5 deletions(-) If you feel so strongly about it, OK. -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list libav-devel@libav.org https

[libav-devel] [PATCH] samplefmt: add a function for filling a buffer with silence.

--- libavutil/samplefmt.c | 19 +++ libavutil/samplefmt.h | 12 2 files changed, 31 insertions(+) diff --git a/libavutil/samplefmt.c b/libavutil/samplefmt.c index 8d7eaeb..9833a1a 100644 --- a/libavutil/samplefmt.c +++ b/libavutil/samplefmt.c @@ -204,3 +204,22 @@

Re: [libav-devel] [PATCH] libxvid: Separate libxvid encoder from libxvid rate control code.

On 04/10/2012 07:14 PM, Diego Biurrun wrote: > This allows compiling the Xvid rate control code without the encoder. > --- > libavcodec/Makefile |3 ++- > libavcodec/libxvid_rc.c | 41 + > libavcodec/libxvidff.c | 43

Re: [libav-devel] [PATCH] libxvid: Separate libxvid encoder from libxvid rate control code.

On Wed, Apr 11, 2012 at 01:14:32AM +0200, Diego Biurrun wrote: > This allows compiling the Xvid rate control code without the encoder. > --- > libavcodec/Makefile |3 ++- > libavcodec/libxvid_rc.c | 41 + > libavcodec/libxvidff.c | 43 --

Re: [libav-devel] [PATCH 05/30] samplefmt: add a memset()-like function for samples.

On Wed, May 9, 2012 at 3:23 PM, Anton Khirnov wrote: > > On Wed, 09 May 2012 10:09:29 -0400, Justin Ruggles > wrote: >> On 05/09/2012 03:13 AM, Anton Khirnov wrote: >> > --- >> >  libavutil/samplefmt.c |   17 + >> >  libavutil/samplefmt.h |   13 + >> >  2 files change

[libav-devel] [PATCH 1/6] vcr1: K&R formatting cosmetics, fix typos, drop some dead code

--- libavcodec/vcr1.c | 138 ++-- 1 files changed, 69 insertions(+), 69 deletions(-) diff --git a/libavcodec/vcr1.c b/libavcodec/vcr1.c index 23b0647..b6f49f9 100644 --- a/libavcodec/vcr1.c +++ b/libavcodec/vcr1.c @@ -21,92 +21,88 @@ /** * @fi

[libav-devel] [PATCH 2/6] vcr1: group encoder code together to save #ifdefs

--- libavcodec/vcr1.c | 90 +--- 1 files changed, 43 insertions(+), 47 deletions(-) diff --git a/libavcodec/vcr1.c b/libavcodec/vcr1.c index b6f49f9..3373101 100644 --- a/libavcodec/vcr1.c +++ b/libavcodec/vcr1.c @@ -27,10 +27,6 @@ #include "avco

[libav-devel] [PATCH 3/6] vcr1: drop pointless write-only AVCodecContext member from VCR1Context

--- libavcodec/vcr1.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/libavcodec/vcr1.c b/libavcodec/vcr1.c index 3373101..c80961a 100644 --- a/libavcodec/vcr1.c +++ b/libavcodec/vcr1.c @@ -28,7 +28,6 @@ #include "dsputil.h" typedef struct VCR1Context { -AVCodecCo

[libav-devel] [PATCH 5/6] vcr1: drop pointless empty encode_init() wrapper function

--- libavcodec/vcr1.c |9 + 1 files changed, 1 insertions(+), 8 deletions(-) diff --git a/libavcodec/vcr1.c b/libavcodec/vcr1.c index 73edfa7..b395691 100644 --- a/libavcodec/vcr1.c +++ b/libavcodec/vcr1.c @@ -172,19 +172,12 @@ static int encode_frame(AVCodecContext *avctx, unsigned

[libav-devel] [PATCH 4/6] vcr1: cosmetics: drop some parentheses, prettyprint, comment an #endif

--- libavcodec/vcr1.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/libavcodec/vcr1.c b/libavcodec/vcr1.c index c80961a..73edfa7 100644 --- a/libavcodec/vcr1.c +++ b/libavcodec/vcr1.c @@ -99,14 +99,14 @@ static int decode_frame(AVCodecCon

[libav-devel] [PATCH 6/6] vcr1enc: Replace obsolete get_bit_count() by put_bits_count().

--- libavcodec/vcr1.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/vcr1.c b/libavcodec/vcr1.c index b395691..b2bc240 100644 --- a/libavcodec/vcr1.c +++ b/libavcodec/vcr1.c @@ -151,6 +151,9 @@ AVCodec ff_vcr1_decoder = { #define CONFIG_VCR1_ENCODER 0

Re: [libav-devel] [PATCH] samplefmt: add a function for filling a buffer with silence.

On 05/09/2012 10:59 AM, Anton Khirnov wrote: > +int bps = av_get_bytes_per_sample(sample_fmt); > +int data_size = bps * nb_samples * (planar ? 1 : nb_channels); > +int fill_char = (sample_fmt == AV_SAMPLE_FMT_U8 || > + sample_fmt == AV_SAMPLE_FMT_U8P) ? 0x80 :

[libav-devel] [PATCH] lavfi: change AVFilterLink.sample_rate from int64_t to int on next bump

There is no real reason for it to be 64bit, it's just a plain int in the rest of Libav. --- The first version didn't work --- libavfilter/avfilter.h |6 +- libavfilter/version.h |3 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/libavfilter/avfilter.h b/libavfilter/

Re: [libav-devel] [PATCH] lavfi: change AVFilterLink.sample_rate from int64_t to int on next bump

Anton Khirnov writes: > There is no real reason for it to be 64bit, it's just a plain int in the > rest of Libav. > --- > The first version didn't work > --- > libavfilter/avfilter.h |6 +- > libavfilter/version.h |3 +++ > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --

[libav-devel] [PATCH] libxvid: Give more suitable names to libxvid-related files.

--- libavcodec/Makefile |2 +- libavcodec/libxvid.c | 788 + libavcodec/libxvid.h | 32 ++ libavcodec/libxvid_internal.h | 32 -- libavcodec/libxvid_rc.c |2 +- libavcodec/libxvidff.c| 788 -

Re: [libav-devel] [PATCH 12/12] jpeglsdec: Remove write-only variable in ff_jpegls_decode_lse().

On Wed, May 09, 2012 at 04:52:57PM +0200, Diego Biurrun wrote: > On Wed, May 09, 2012 at 04:37:43PM +0200, Kostya Shishkov wrote: > > On Wed, May 09, 2012 at 04:33:35PM +0200, Diego Biurrun wrote: > > > On Mon, May 07, 2012 at 12:36:00PM +0200, Kostya Shishkov wrote: > > > > On Mon, May 07, 2012 at

Re: [libav-devel] [PATCH 1/6] vcr1: K&R formatting cosmetics, fix typos, drop some dead code

On Wed, May 09, 2012 at 05:10:34PM +0200, Diego Biurrun wrote: > --- > libavcodec/vcr1.c | 138 ++-- > 1 files changed, 69 insertions(+), 69 deletions(-) LGTM ___ libav-devel mailing list libav-devel@liba

Re: [libav-devel] [PATCH 2/6] vcr1: group encoder code together to save #ifdefs

On Wed, May 09, 2012 at 05:10:35PM +0200, Diego Biurrun wrote: > --- > libavcodec/vcr1.c | 90 +--- > 1 files changed, 43 insertions(+), 47 deletions(-) looks OK ___ libav-devel mailing list libav-devel@

Re: [libav-devel] [PATCH 3/6] vcr1: drop pointless write-only AVCodecContext member from VCR1Context

On Wed, May 09, 2012 at 05:10:36PM +0200, Diego Biurrun wrote: > --- > libavcodec/vcr1.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vcr1.c b/libavcodec/vcr1.c > index 3373101..c80961a 100644 > --- a/libavcodec/vcr1.c > +++ b/libavcodec/vcr1.c > @@ -2

Re: [libav-devel] [PATCH 4/6] vcr1: cosmetics: drop some parentheses, prettyprint, comment an #endif

On Wed, May 09, 2012 at 05:10:37PM +0200, Diego Biurrun wrote: > --- > libavcodec/vcr1.c | 32 > 1 files changed, 16 insertions(+), 16 deletions(-) > > diff --git a/libavcodec/vcr1.c b/libavcodec/vcr1.c > index c80961a..73edfa7 100644 > --- a/libavcodec/vcr1.c >

Re: [libav-devel] [PATCH 5/6] vcr1: drop pointless empty encode_init() wrapper function

On Wed, May 09, 2012 at 05:10:38PM +0200, Diego Biurrun wrote: > --- > libavcodec/vcr1.c |9 + > 1 files changed, 1 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/vcr1.c b/libavcodec/vcr1.c > index 73edfa7..b395691 100644 > --- a/libavcodec/vcr1.c > +++ b/libavcodec/vcr1.c

Re: [libav-devel] [PATCH 6/6] vcr1enc: Replace obsolete get_bit_count() by put_bits_count().

On Wed, May 09, 2012 at 05:10:39PM +0200, Diego Biurrun wrote: > --- > libavcodec/vcr1.c |7 +-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vcr1.c b/libavcodec/vcr1.c > index b395691..b2bc240 100644 > --- a/libavcodec/vcr1.c > +++ b/libavcodec/vcr1.c >

Re: [libav-devel] [PATCH] libxvid: Give more suitable names to libxvid-related files.

On 05/09/2012 11:36 AM, Diego Biurrun wrote: > --- > libavcodec/Makefile |2 +- > libavcodec/libxvid.c | 788 > + > libavcodec/libxvid.h | 32 ++ > libavcodec/libxvid_internal.h | 32 -- > libavcodec/libxvid_rc.c |

Re: [libav-devel] [PATCH 4/6] vcr1: cosmetics: drop some parentheses, prettyprint, comment an #endif

On Wed, May 09, 2012 at 05:41:48PM +0200, Kostya Shishkov wrote: > On Wed, May 09, 2012 at 05:10:37PM +0200, Diego Biurrun wrote: > > --- > > libavcodec/vcr1.c | 32 > > 1 files changed, 16 insertions(+), 16 deletions(-) > > > > diff --git a/libavcodec/vcr1.c b/

[libav-devel] [PATCH] cmdutils: Add fallback case to switch in check_stream_specifier().

This fixes the warning: cmdutils.c:897: warning: ‘type’ may be used uninitialized in this function --- cmdutils.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/cmdutils.c b/cmdutils.c index 3cd11ca..bd07d2a 100644 --- a/cmdutils.c +++ b/cmdutils.c @@ -34,6 +34,7 @@ #in

[libav-devel] [PATCH] mov: make one comment slightly more specific

--- libavformat/mov.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index ad1340a..29f01c3 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -994,7 +994,7 @@ static int mov_read_glbl(MOVContext *c, AVIOContext *pb, MOVAtom

Re: [libav-devel] [PATCH] mov: make one comment slightly more specific

On Wed, 09 May 2012 18:13:08 +0200, Diego Biurrun wrote: > --- > libavformat/mov.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > SureWhyNot. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.o

Re: [libav-devel] [PATCH 10/30] lavfi: cleanup avfilter_get_audio_buffer() and pals.

On 05/09/2012 03:13 AM, Anton Khirnov wrote: > From: Stefano Sabatini > > Remove AVFilterBufferRefAudioProps.size, and use nb_samples in its place > everywhere. > This is required as the size in the audio buffer may be aligned, so it > may not contain a well defined number of samples. > > Also r

Re: [libav-devel] [PATCH 11/30] lavfi: use avfilter_get_audio_buffer_ref_from_arrays() in avfilter_default_get_audio_buffer

On 05/09/2012 03:13 AM, Anton Khirnov wrote: > From: Stefano Sabatini > > --- > libavfilter/defaults.c | 82 > +++- > 1 file changed, 18 insertions(+), 64 deletions(-) LGTM. very nice! -Justin ___ libav-

Re: [libav-devel] [PATCH 12/30] lavfi: simplify signature for avfilter_get_audio_buffer() and friends

On 05/09/2012 03:13 AM, Anton Khirnov wrote: > From: Stefano Sabatini > > The additional parameters are just complicating the function interface. > > Assume that a requested samples buffer will *always* have the format > specified in the requested link. > > This breaks audio filtering API and A

  1   2   >