[libav-devel] [PATCH] flvdec: Treat all nellymoser versions as the same codec

2012-07-04 Thread Martin Storsjö
This avoids creating new AVStreams for them when switching between different variants of them. --- libavformat/flvdec.c |4 1 file changed, 4 deletions(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index 093cd0a..5b232cb 100644 --- a/libavformat/flvdec.c +++ b/libavformat/f

Re: [libav-devel] [PATCH 4/4] rtsp: listen mode

2012-07-04 Thread Luca Barbato
On 07/04/2012 10:13 PM, Jordi Ortiz wrote: > --- > libavformat/rtsp.c | 30 ++- > libavformat/rtsp.h | 12 ++ > libavformat/rtspcodes.h | 14 ++ > libavformat/rtspdec.c | 549 > --- > 4 files changed, 566 insertions(+), 39 deletions(-

Re: [libav-devel] [PATCH] configure: add functions for testing code fragments

2012-07-04 Thread Diego Biurrun
On Wed, Jul 04, 2012 at 11:06:25PM +0100, Mans Rullgard wrote: > This simplifies testing arbitrary code fragments within a function > body. Very nice work, LGTM. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/li

Re: [libav-devel] [PATCH] lavfi: reclassify showfiltfmts as a TESTPROG

2012-07-04 Thread Diego Biurrun
On Wed, Jul 04, 2012 at 05:18:55PM +0100, Mans Rullgard wrote: > This tool uses lavfi internal symbols not accessible in shared > libraries. TESTPROGS are linked statically to allow them use of > library internals not normally exported. > --- > Now with updated .gitignore. > --- OK Diego ___

[libav-devel] [PATCH] configure: add functions for testing code fragments

2012-07-04 Thread Mans Rullgard
This simplifies testing arbitrary code fragments within a function body. Signed-off-by: Mans Rullgard --- configure | 39 ++- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/configure b/configure index 3c788df1..e2fb1cf 100755 --- a/configure

Re: [libav-devel] [PATCH] lavu: use intrinsic for emms on systems lacking inline asm support.

2012-07-04 Thread Måns Rullgård
"Ronald S. Bultje" writes: > On Wed, Jul 4, 2012 at 2:04 PM, Ronald S. Bultje wrote: >> Hi, >> >> On Wed, Jul 4, 2012 at 12:36 PM, Måns Rullgård wrote: >>> "Ronald S. Bultje" writes: >>> Hi, On Wed, Jul 4, 2012 at 10:15 AM, Måns Rullgård wrote: > "Ronald S. Bultje" writes:

Re: [libav-devel] [PATCH] lavu: use intrinsic for emms on systems lacking inline asm support.

2012-07-04 Thread Ronald S. Bultje
On Wed, Jul 4, 2012 at 2:04 PM, Ronald S. Bultje wrote: > Hi, > > On Wed, Jul 4, 2012 at 12:36 PM, Måns Rullgård wrote: >> "Ronald S. Bultje" writes: >> >>> Hi, >>> >>> On Wed, Jul 4, 2012 at 10:15 AM, Måns Rullgård wrote: "Ronald S. Bultje" writes: > From: "Ronald S. Bultje" >>

Re: [libav-devel] [PATCH] dct/fft-test: use a replacement getopt() if the system has none present.

2012-07-04 Thread Måns Rullgård
"Ronald S. Bultje" writes: > Hi, > > On Tue, Jul 3, 2012 at 8:14 PM, Ronald S. Bultje wrote: >> From: "Ronald S. Bultje" >> >> This allows compiling and running these tests on systems lacking a built- >> in version of getopt(), such as MSVC. >> --- >> configure |2 ++ >> libavc

Re: [libav-devel] [PATCH] dct/fft-test: use a replacement getopt() if the system has none present.

2012-07-04 Thread Ronald S. Bultje
Hi, On Tue, Jul 3, 2012 at 8:14 PM, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > This allows compiling and running these tests on systems lacking a built- > in version of getopt(), such as MSVC. > --- > configure |2 ++ > libavcodec/dct-test.c |7 + > libavcode

Re: [libav-devel] [PATCH] lavu: use intrinsic for emms on systems lacking inline asm support.

2012-07-04 Thread Ronald S. Bultje
Hi, On Wed, Jul 4, 2012 at 12:36 PM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >> Hi, >> >> On Wed, Jul 4, 2012 at 10:15 AM, Måns Rullgård wrote: >>> "Ronald S. Bultje" writes: >>> From: "Ronald S. Bultje" --- configure|9 + libavuti

Re: [libav-devel] [PATCH] vp8: Add ifdef guards around the sse2 loopfilter in the sse2slow branch too

2012-07-04 Thread Ronald S. Bultje
Hi, On Wed, Jul 4, 2012 at 12:28 PM, Martin Storsjö wrote: > This was missed in the the previous commit in 70a1c800. > --- > libavcodec/x86/vp8dsp-init.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/x86/vp8dsp-init.c b/libavcodec/x86/vp8dsp-init.c > index a0e8f9b..589

Re: [libav-devel] [PATCH] mxfdec: replace x>>av_log2(sizeof(..)) by x/sizeof(..).

2012-07-04 Thread Ronald S. Bultje
Hi, On Wed, Jul 4, 2012 at 5:08 AM, Tomas Härdin wrote: > On Wed, 2012-07-04 at 12:14 +0100, Måns Rullgård wrote: >> Kostya Shishkov writes: >> >> > On Wed, Jul 04, 2012 at 11:09:57AM +0100, Måns Rullgård wrote: >> >> "Ronald S. Bultje" writes: >> >> >> >> > From: "Ronald S. Bultje" >> >> > >>

[libav-devel] [PATCH 4/4] rtsp: listen mode

2012-07-04 Thread Jordi Ortiz
--- libavformat/rtsp.c | 30 ++- libavformat/rtsp.h | 12 ++ libavformat/rtspcodes.h | 14 ++ libavformat/rtspdec.c | 549 --- 4 files changed, 566 insertions(+), 39 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c in

[libav-devel] [PATCH 3/4] rtsp listen mode: make rtsp_open_transport_ctx visible out of rtsp.c (remove static)

2012-07-04 Thread Jordi Ortiz
--- libavformat/rtsp.c |6 +++--- libavformat/rtsp.h |5 + 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 551884b..d4206a1 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -595,7 +595,7 @@ void ff_rtsp_close_strea

[libav-devel] [PATCH 2/4] rtsp: move rtsp_read_close

2012-07-04 Thread Jordi Ortiz
--- libavformat/rtspdec.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 063e825..6226f41 100644 --- a/libavformat/rtspdec.c +++ b/libavformat/rtspdec.c @@ -31,6 +31,20 @@ #include "rdt.h" #

[libav-devel] [PATCH 1/4] rtsp: add mode=receive/record header parse code

2012-07-04 Thread Jordi Ortiz
--- libavformat/rtsp.c |8 libavformat/rtsp.h |3 +++ 2 files changed, 11 insertions(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 76b5df8..551884b 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -749,6 +749,14 @@ static void rtsp_parse_transport(RTSPM

Re: [libav-devel] [PATCH] flvdec: optionally trust the metadata

2012-07-04 Thread Diego Elio Pettenò
Il 04/07/2012 21:56, Luca Barbato ha scritto: > In certain conditions video or audio frames might appear way later in the > stream. LGTM. -- Diego Elio Pettenò — Flameeyes flamee...@flameeyes.eu — http://blog.flameeyes.eu/ ___ libav-devel mailing lis

[libav-devel] [PATCH] flvdec: optionally trust the metadata

2012-07-04 Thread Luca Barbato
In certain conditions video or audio frames might appear way later in the stream. --- libavformat/flvdec.c | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index 093cd0a..602cb9e 100644 --- a/li

Re: [libav-devel] [PATCH] lavu: use intrinsic for emms on systems lacking inline asm support.

2012-07-04 Thread Måns Rullgård
"Ronald S. Bultje" writes: > Hi, > > On Wed, Jul 4, 2012 at 10:15 AM, Måns Rullgård wrote: >> "Ronald S. Bultje" writes: >> >>> From: "Ronald S. Bultje" >>> >>> --- >>> configure|9 + >>> libavutil/internal.h |6 +- >>> 2 files changed, 14 insertions(+), 1 dele

Re: [libav-devel] [PATCH] mxfdec: replace x>>av_log2(sizeof(..)) by x/sizeof(..).

2012-07-04 Thread Luca Barbato
On 07/04/2012 02:08 PM, Tomas Härdin wrote: > Why not simply add av_calloc() to lavu and use it? These kind of > allocations are all over the place - it'd make them prettier. I've > suggested this before in [1]. You could even have it static inline. You wouldn't have to check nonetheless? lu --

[libav-devel] [PATCH] vp8: Add ifdef guards around the sse2 loopfilter in the sse2slow branch too

2012-07-04 Thread Martin Storsjö
This was missed in the the previous commit in 70a1c800. --- libavcodec/x86/vp8dsp-init.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/x86/vp8dsp-init.c b/libavcodec/x86/vp8dsp-init.c index a0e8f9b..589804f 100644 --- a/libavcodec/x86/vp8dsp-init.c +++ b/libavcodec/x86/vp8dsp

Re: [libav-devel] [PATCH] Add XTEA encryption support in libavutil

2012-07-04 Thread Martin Storsjö
On Wed, 4 Jul 2012, Samuel Pitoiset wrote: On Wed, Jul 4, 2012 at 3:15 PM, Måns Rullgård wrote: Samuel Pitoiset writes: [...] +void av_xtea_crypt(AVXTEA *ctx, uint8_t *dst, const uint8_t *src, int count, + uint8_t *iv, int decrypt) +{ +int i; + +while (count > 0)

Re: [libav-devel] [PATCH] Add XTEA encryption support in libavutil

2012-07-04 Thread Samuel Pitoiset
On Wed, Jul 4, 2012 at 3:15 PM, Måns Rullgård wrote: > Samuel Pitoiset writes: > > > [...] > >> +void av_xtea_crypt(AVXTEA *ctx, uint8_t *dst, const uint8_t *src, int count, >> + uint8_t *iv, int decrypt) >> +{ >> +int i; >> + >> +while (count > 0) { > > [...] > >> +

Re: [libav-devel] [PATCH] Add Blowfish encryption support in libavutil

2012-07-04 Thread Samuel Pitoiset
On Wed, Jul 4, 2012 at 3:10 PM, Luca Barbato wrote: > On 07/03/2012 03:45 PM, Samuel Pitoiset wrote: >> +while (count > 0) { >> +if (decrypt) { > > Same as for the XTEA, invert the order. first branch then loop. Okay, I'll submit a new patch. -- Best regards, Samuel Pitoiset.

Re: [libav-devel] [PATCH] avconv: Set audio filter time base to the sample rate

2012-07-04 Thread Anton Khirnov
On Wed, 4 Jul 2012 21:46:04 +0300, Martin Storsjö wrote: > If the output frame size is smaller than the input sample rate, > and the input stream time base corresponds exactly to the input > frame size (getting input packet timestamps like 0, 1, 2, 3, 4 etc), > the output timestamps from the fil

[libav-devel] [PATCH] avconv: Set audio filter time base to the sample rate

2012-07-04 Thread Martin Storsjö
If the output frame size is smaller than the input sample rate, and the input stream time base corresponds exactly to the input frame size (getting input packet timestamps like 0, 1, 2, 3, 4 etc), the output timestamps from the filter will be like 0, 1, 2, 3, 4, 4, 5 ..., leadning to non-monotone t

[libav-devel] [PATCH 2/2] rtmp: add rtmp_listen support

2012-07-04 Thread Jordi Ortiz
This code allows receiving a stream from a client with the PUBLISH command. --- libavformat/rtmpproto.c | 470 --- 1 file changed, 449 insertions(+), 21 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 5342be8..e901b7e

[libav-devel] [PATCH 1/2] rtmp: add ff_amf_read_* functions

2012-07-04 Thread Jordi Ortiz
--- libavformat/rtmppkt.c | 38 ++ libavformat/rtmppkt.h | 37 + 2 files changed, 75 insertions(+) diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c index 4ce238d..3251b71 100644 --- a/libavformat/rtmppkt.c +++ b

Re: [libav-devel] [PATCH] x86/cpu: implement support for cpuid through intrinsics.

2012-07-04 Thread Ronald S. Bultje
Hi, On Wed, Jul 4, 2012 at 10:35 AM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >> From: "Ronald S. Bultje" >> >> --- >> configure |9 + >> libavutil/x86/cpu.c | 14 ++ >> 2 files changed, 23 insertions(+) >> >> diff --git a/configure b/configure >>

Re: [libav-devel] [PATCH] x86/cpu: implement support for xgetbv through intrinsics.

2012-07-04 Thread Ronald S. Bultje
Hi, On Wed, Jul 4, 2012 at 10:31 AM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >> From: "Ronald S. Bultje" >> >> --- >> configure |9 + >> libavutil/x86/cpu.c | 11 +++ >> 2 files changed, 20 insertions(+) >> >> diff --git a/configure b/configure >> in

Re: [libav-devel] [PATCH] lavu: use intrinsic for emms on systems lacking inline asm support.

2012-07-04 Thread Ronald S. Bultje
Hi, On Wed, Jul 4, 2012 at 10:15 AM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >> From: "Ronald S. Bultje" >> >> --- >> configure|9 + >> libavutil/internal.h |6 +- >> 2 files changed, 14 insertions(+), 1 deletion(-) >> >> diff --git a/configure b/con

[libav-devel] [PATCH] lavu: use intrinsic for emms on systems lacking inline asm support.

2012-07-04 Thread Ronald S. Bultje
From: "Ronald S. Bultje" --- configure|9 + libavutil/internal.h |7 +-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 351d8a0..4fc20a2 100755 --- a/configure +++ b/configure @@ -1118,7 +1118,9 @@ HAVE_LIST=" MapV

Re: [libav-devel] [PATCH] x86/cpu: implement support for cpuid through intrinsics.

2012-07-04 Thread Måns Rullgård
"Ronald S. Bultje" writes: > From: "Ronald S. Bultje" > > --- > configure |9 + > libavutil/x86/cpu.c | 14 ++ > 2 files changed, 23 insertions(+) > > diff --git a/configure b/configure > index 35d4406..976b59d 100755 > --- a/configure > +++ b/configure > @@

Re: [libav-devel] [PATCH] x86/cpu: implement support for xgetbv through intrinsics.

2012-07-04 Thread Måns Rullgård
"Ronald S. Bultje" writes: > From: "Ronald S. Bultje" > > --- > configure |9 + > libavutil/x86/cpu.c | 11 +++ > 2 files changed, 20 insertions(+) > > diff --git a/configure b/configure > index 4fc20a2..35d4406 100755 > --- a/configure > +++ b/configure > @@ -10

[libav-devel] [PATCH] x86/cpu: implement support for cpuid through intrinsics.

2012-07-04 Thread Ronald S. Bultje
From: "Ronald S. Bultje" --- configure |9 + libavutil/x86/cpu.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/configure b/configure index 35d4406..976b59d 100755 --- a/configure +++ b/configure @@ -1062,6 +1062,7 @@ HAVE_LIST=" cbrtf clos

[libav-devel] [PATCH] x86/cpu: implement support for xgetbv through intrinsics.

2012-07-04 Thread Ronald S. Bultje
From: "Ronald S. Bultje" --- configure |9 + libavutil/x86/cpu.c | 11 +++ 2 files changed, 20 insertions(+) diff --git a/configure b/configure index 4fc20a2..35d4406 100755 --- a/configure +++ b/configure @@ -1092,6 +1092,7 @@ HAVE_LIST=" gettimeofday

Re: [libav-devel] [PATCH] lavu: use intrinsic for emms on systems lacking inline asm support.

2012-07-04 Thread Måns Rullgård
"Ronald S. Bultje" writes: > From: "Ronald S. Bultje" > > --- > configure|9 + > libavutil/internal.h |6 +- > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 351d8a0..4fc20a2 100755 > --- a/configure > +++ b/config

[libav-devel] [PATCH] lavu: use intrinsic for emms on systems lacking inline asm support.

2012-07-04 Thread Ronald S. Bultje
From: "Ronald S. Bultje" --- configure|9 + libavutil/internal.h |6 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 351d8a0..4fc20a2 100755 --- a/configure +++ b/configure @@ -1118,7 +1118,9 @@ HAVE_LIST=" MapVie

Re: [libav-devel] [PATCH] mxfdec: replace x>>av_log2(sizeof(..)) by x/sizeof(..).

2012-07-04 Thread Tomas Härdin
On Wed, 2012-07-04 at 12:14 +0100, Måns Rullgård wrote: > Kostya Shishkov writes: > > > On Wed, Jul 04, 2012 at 11:09:57AM +0100, Måns Rullgård wrote: > >> "Ronald S. Bultje" writes: > >> > >> > From: "Ronald S. Bultje" > >> > > >> > --- > >> > libavformat/mxfdec.c |8 > >> > 1 f

Re: [libav-devel] [RFC PATCH] avconv: Set audio filter time base to the sample rate

2012-07-04 Thread Anton Khirnov
On Sat, 30 Jun 2012 11:30:18 +0300, Martin Storsjö wrote: > If the output frame size is smaller than the input sample rate, > and the input stream time base corresponds exactly to the input > frame size (getting input packet timestamps like 0, 1, 2, 3, 4 etc), > the output timestamps from the fil

[libav-devel] [PATCH 2/2] af_resample: fix request_frame() behavior.

2012-07-04 Thread Anton Khirnov
Make sure that an output frame has really been produced before returning 0. --- libavfilter/af_resample.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_resample.c b/libavfilter/af_resample.c index 8a02cfe..6a3a224 100644 --- a/libavfilter/af_r

[libav-devel] [PATCH 1/2] af_asyncts: fix request_frame() behavior.

2012-07-04 Thread Anton Khirnov
Make sure that an output frame has really been produced before returning 0. --- libavfilter/af_asyncts.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_asyncts.c b/libavfilter/af_asyncts.c index 8402b26..097bc60 100644 --- a/libavfilter/af_asyncts.c

Re: [libav-devel] [PATCH] h264: use templates to avoid excessive inlining

2012-07-04 Thread Luca Barbato
On 07/04/2012 04:56 PM, Kostya Shishkov wrote: > On Tue, Jul 03, 2012 at 11:43:53PM +0100, Mans Rullgard wrote: >> Instead of inlining everything into ff_h264_hl_decode_mb(), use >> explicit templating to create versions of the called functions >> with constant parameters filled in. This greatly s

Re: [libav-devel] [PATCH] lavfi: reclassify showfiltfmts as a TESTPROG

2012-07-04 Thread Luca Barbato
On 07/04/2012 06:18 PM, Mans Rullgard wrote: > This tool uses lavfi internal symbols not accessible in shared > libraries. TESTPROGS are linked statically to allow them use of > library internals not normally exported. > > Signed-off-by: Mans Rullgard > --- > Now with updated .gitignore. > --- >

Re: [libav-devel] [PATCH] tcp: add initial timeout limit for incomming connections

2012-07-04 Thread Luca Barbato
On 07/04/2012 05:48 PM, Jordi Ortiz wrote: > --- > libavformat/tcp.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) Seems fine. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list libav-de

[libav-devel] [PATCH] lavfi: reclassify showfiltfmts as a TESTPROG

2012-07-04 Thread Mans Rullgard
This tool uses lavfi internal symbols not accessible in shared libraries. TESTPROGS are linked statically to allow them use of library internals not normally exported. Signed-off-by: Mans Rullgard --- Now with updated .gitignore. --- .gitignore |1 -

Re: [libav-devel] [PATCH] lavfi: reclassify showfiltfmts as a TESTPROG

2012-07-04 Thread Diego Biurrun
On Wed, Jul 04, 2012 at 04:51:37PM +0100, Mans Rullgard wrote: > This tool uses lavfi internal symbols not accessible in shared > libraries. TESTPROGS are linked statically to allow them use of > library internals not normally exported. > > Signed-off-by: Mans Rullgard > --- > libavfilter/Makef

[libav-devel] [PATCH] lavfi: reclassify showfiltfmts as a TESTPROG

2012-07-04 Thread Mans Rullgard
This tool uses lavfi internal symbols not accessible in shared libraries. TESTPROGS are linked statically to allow them use of library internals not normally exported. Signed-off-by: Mans Rullgard --- libavfilter/Makefile |4 ++-- tools/lavfi-showfiltfmts.c =

[libav-devel] [PATCH] tcp: add initial timeout limit for incomming connections

2012-07-04 Thread Jordi Ortiz
--- libavformat/tcp.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavformat/tcp.c b/libavformat/tcp.c index 6a65860..e5be465 100644 --- a/libavformat/tcp.c +++ b/libavformat/tcp.c @@ -43,7 +43,7 @@ static int tcp_open(URLContext *h, const char *uri, int flag

Re: [libav-devel] [PATCH] graph2dot: fix printf format specifier

2012-07-04 Thread Måns Rullgård
Anton Khirnov writes: > On Wed, 04 Jul 2012 16:02:45 +0100, Måns Rullgård wrote: >> Diego Biurrun writes: >> >> > tools/graph2dot.c:85: warning: format ‘%lld’ expects type ‘long long int’, >> > but argument 4 has type ‘int’ >> > --- >> > tools/graph2dot.c |2 +- >> > 1 files changed, 1 i

Re: [libav-devel] [PATCH 2/2] vp8: loopfilter >=sse2 functions need aligned stack on x86-32.

2012-07-04 Thread Ronald S. Bultje
Hi, On Wed, Jul 4, 2012 at 8:01 AM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >> Hi, >> >> On Tue, Jul 3, 2012 at 9:11 PM, Ronald S. Bultje wrote: >>> +#if ARCH_X86_64 || HAVE_ALIGNED_STACK >> >> The ARCH_X86_64 here is not because that one has aligned stack (it >> does on win64 also;

Re: [libav-devel] [PATCH] graph2dot: fix printf format specifier

2012-07-04 Thread Anton Khirnov
On Wed, 04 Jul 2012 16:02:45 +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > > tools/graph2dot.c:85: warning: format ‘%lld’ expects type ‘long long int’, > > but argument 4 has type ‘int’ > > --- > > tools/graph2dot.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > >

[libav-devel] [PATCH] mxfdec: replace x>>av_log2(sizeof(..)) by x/sizeof(..).

2012-07-04 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Also replace x>>av_log2(sizeof(..)) + 1 by x/sizeof(..). The +1 is probably meant to emulate av_log2_ceil(sizeof(..)) in cases where ".." is not a power of two. --- libavformat/mxfdec.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavf

Re: [libav-devel] [PATCH] graph2dot: fix printf format specifier

2012-07-04 Thread Måns Rullgård
Diego Biurrun writes: > tools/graph2dot.c:85: warning: format ‘%lld’ expects type ‘long long int’, > but argument 4 has type ‘int’ > --- > tools/graph2dot.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/graph2dot.c b/tools/graph2dot.c > index a52416d..6ea2

Re: [libav-devel] [PATCH 2/2] vp8: loopfilter >=sse2 functions need aligned stack on x86-32.

2012-07-04 Thread Måns Rullgård
"Ronald S. Bultje" writes: > Hi, > > On Tue, Jul 3, 2012 at 9:11 PM, Ronald S. Bultje wrote: >> +#if ARCH_X86_64 || HAVE_ALIGNED_STACK > > The ARCH_X86_64 here is not because that one has aligned stack (it > does on win64 also; see e.g. [1]). Aligned or unaligned stack on win64 > (or any 64bit p

[libav-devel] [PATCH] graph2dot: fix printf format specifier

2012-07-04 Thread Diego Biurrun
tools/graph2dot.c:85: warning: format ‘%lld’ expects type ‘long long int’, but argument 4 has type ‘int’ --- tools/graph2dot.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/graph2dot.c b/tools/graph2dot.c index a52416d..6ea2f32 100644 --- a/tools/graph2dot.c +++

Re: [libav-devel] [PATCH] h264: use templates to avoid excessive inlining

2012-07-04 Thread Kostya Shishkov
On Tue, Jul 03, 2012 at 11:43:53PM +0100, Mans Rullgard wrote: > Instead of inlining everything into ff_h264_hl_decode_mb(), use > explicit templating to create versions of the called functions > with constant parameters filled in. This greatly speeds up > compilation of h264.c and reduces the cod

Re: [libav-devel] [PATCH 2/2] vp8: loopfilter >=sse2 functions need aligned stack on x86-32.

2012-07-04 Thread Ronald S. Bultje
Hi, On Tue, Jul 3, 2012 at 9:11 PM, Ronald S. Bultje wrote: > +#if ARCH_X86_64 || HAVE_ALIGNED_STACK The ARCH_X86_64 here is not because that one has aligned stack (it does on win64 also; see e.g. [1]). Aligned or unaligned stack on win64 (or any 64bit platform for that matter) is an implementat

[libav-devel] [PATCH 2/2] x86: h264_intrapred: use newly introduced SPLAT* and PSHUFLW macros

2012-07-04 Thread Diego Biurrun
--- libavcodec/x86/h264_intrapred.asm | 129 ++-- 1 files changed, 22 insertions(+), 107 deletions(-) diff --git a/libavcodec/x86/h264_intrapred.asm b/libavcodec/x86/h264_intrapred.asm index 87d32c4..5984454 100644 --- a/libavcodec/x86/h264_intrapred.asm +++ b/li

[libav-devel] [PATCH 1/2] x86inc: add SPLATB_LOAD, SPLATB_REG, PSHUFLW macros

2012-07-04 Thread Diego Biurrun
From: Loren Merritt Signed-off-by: Diego Biurrun --- libavcodec/x86/vp8dsp.asm | 21 - libavutil/x86/x86util.asm | 41 + 2 files changed, 37 insertions(+), 25 deletions(-) diff --git a/libavcodec/x86/vp8dsp.asm b/libavcodec/x86/vp

[libav-devel] [PATCH] x86: h264_intrapred: port to cpuflag macros

2012-07-04 Thread Diego Biurrun
--- libavcodec/x86/h264_intrapred.asm| 290 ++ libavcodec/x86/h264_intrapred_init.c | 24 ++-- 2 files changed, 168 insertions(+), 146 deletions(-) diff --git a/libavcodec/x86/h264_intrapred.asm b/libavcodec/x86/h264_intrapred.asm index 3beb3b9..87d32c4 100

Re: [libav-devel] [PATCH] Add XTEA encryption support in libavutil

2012-07-04 Thread Måns Rullgård
Luca Barbato writes: > On 07/03/2012 03:53 PM, Samuel Pitoiset wrote: >> +while (count > 0) { >> +if (decrypt) { > > I'd switch the order (first the branch, then the loop), it is consistent > with the rest of the file and might be better overall. Definitely better. GCC can't do that

Re: [libav-devel] [PATCH] Add XTEA encryption support in libavutil

2012-07-04 Thread Måns Rullgård
Samuel Pitoiset writes: [...] > +void av_xtea_crypt(AVXTEA *ctx, uint8_t *dst, const uint8_t *src, int count, > + uint8_t *iv, int decrypt) > +{ > +int i; > + > +while (count > 0) { [...] > +count -= 8; > +} > +} [...] > +/** > + * Encrypt or decrypt a

Re: [libav-devel] [PATCH] Add Blowfish encryption support in libavutil

2012-07-04 Thread Luca Barbato
On 07/03/2012 03:45 PM, Samuel Pitoiset wrote: > +while (count > 0) { > +if (decrypt) { Same as for the XTEA, invert the order. first branch then loop. lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailin

Re: [libav-devel] [PATCH] Add XTEA encryption support in libavutil

2012-07-04 Thread Luca Barbato
On 07/03/2012 03:53 PM, Samuel Pitoiset wrote: > +while (count > 0) { > +if (decrypt) { I'd switch the order (first the branch, then the loop), it is consistent with the rest of the file and might be better overall. lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero __

Re: [libav-devel] [PATCH 1/4] gitignore: Use full path instead of relative path to specify patterns

2012-07-04 Thread Janne Grunau
On 2012-07-03 00:32:46 +0200, Diego Biurrun wrote: > This avoids confusion from patterns meant to only match at the top > level matching files in subdirectories. > --- > .gitignore | 70 > ++-- > 1 files changed, 35 insertions(+), 35 delet

[libav-devel] [PATCH] flvdec: optionally trust the metadata

2012-07-04 Thread Luca Barbato
In certain conditions video or audio frames might appear way later in the stream. --- Again it is partially an rfc libavformat/flvdec.c | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index 09

Re: [libav-devel] [PATCH] Add Blowfish encryption support in libavutil

2012-07-04 Thread Kostya Shishkov
On Tue, Jul 03, 2012 at 11:13:30PM +0300, Martin Storsjö wrote: > On Tue, 3 Jul 2012, Samuel Pitoiset wrote: > > >--- > >libavutil/Makefile |3 + > >libavutil/avutil.h |2 +- > >libavutil/blowfish.c | 566 > >++ > >libavutil/blowfi

Re: [libav-devel] [PATCH] Add XTEA encryption support in libavutil

2012-07-04 Thread Kostya Shishkov
On Tue, Jul 03, 2012 at 11:14:34PM +0300, Martin Storsjö wrote: > On Tue, 3 Jul 2012, Samuel Pitoiset wrote: > > >--- > >libavutil/Makefile |3 + > >libavutil/avutil.h |2 +- > >libavutil/xtea.c | 165 > >++ > >libavutil/xtea.h

Re: [libav-devel] [PATCH 1/2] x86: h264_intrapred: fix

2012-07-04 Thread Måns Rullgård
Loren Merritt writes: > On Wed, 4 Jul 2012, Måns Rullgård wrote: > >> Loren Merritt writes: >> >> > --- >> >> The commit message needs A LOT of improvement. > > Obviously I intended it to be sqaushed into DonDiego's patch, not an > actual commit message. It wasn't obvious to me. -- Måns Rullg

Re: [libav-devel] [PATCH 1/2] x86: h264_intrapred: fix

2012-07-04 Thread Loren Merritt
On Wed, 4 Jul 2012, Måns Rullgård wrote: > Loren Merritt writes: > > > --- > > The commit message needs A LOT of improvement. Obviously I intended it to be sqaushed into DonDiego's patch, not an actual commit message. --Loren Merritt___ libav-devel ma

Re: [libav-devel] [PATCH] mpegvideo: remove VLAs

2012-07-04 Thread Martin Storsjö
On Wed, 4 Jul 2012, Måns Rullgård wrote: Martin Storsjö writes: diff --git a/libavcodec/mpegvideo.h b/libavcodec/mpegvideo.h index b73da41..4c811bb 100644 --- a/libavcodec/mpegvideo.h +++ b/libavcodec/mpegvideo.h @@ -696,6 +696,12 @@ typedef struct MpegEncContext { int mpv_flags; /

Re: [libav-devel] [PATCH 1/2] x86: h264_intrapred: fix

2012-07-04 Thread Måns Rullgård
Loren Merritt writes: > --- The commit message needs A LOT of improvement. -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] mxfdec: replace x>>av_log2(sizeof(..)) by x/sizeof(..).

2012-07-04 Thread Måns Rullgård
Kostya Shishkov writes: > On Wed, Jul 04, 2012 at 11:09:57AM +0100, Måns Rullgård wrote: >> "Ronald S. Bultje" writes: >> >> > From: "Ronald S. Bultje" >> > >> > --- >> > libavformat/mxfdec.c |8 >> > 1 file changed, 4 insertions(+), 4 deletions(-) >> > >> > diff --git a/libavfor

Re: [libav-devel] [PATCH] mpegvideo: remove VLAs

2012-07-04 Thread Måns Rullgård
Martin Storsjö writes: > diff --git a/libavcodec/mpegvideo.h b/libavcodec/mpegvideo.h > index b73da41..4c811bb 100644 > --- a/libavcodec/mpegvideo.h > +++ b/libavcodec/mpegvideo.h > @@ -696,6 +696,12 @@ typedef struct MpegEncContext { > > int mpv_flags; ///< flags set by private options

[libav-devel] [PATCH 2/2] x86: h264_intrapred: cosmetics

2012-07-04 Thread Loren Merritt
--- libavcodec/x86/h264_intrapred.asm | 129 ++-- libavcodec/x86/vp8dsp.asm | 21 -- libavutil/x86/x86util.asm | 41 +++- 3 files changed, 59 insertions(+), 132 deletions(-) diff --git a/libavcodec/x86/h264_intrapred.asm b/libavcod

[libav-devel] [PATCH 1/2] x86: h264_intrapred: fix

2012-07-04 Thread Loren Merritt
--- libavcodec/x86/h264_intrapred.asm | 54 ++-- 1 files changed, 27 insertions(+), 27 deletions(-) diff --git a/libavcodec/x86/h264_intrapred.asm b/libavcodec/x86/h264_intrapred.asm index 9b2c1cd..87d32c4 100644 --- a/libavcodec/x86/h264_intrapred.asm +++ b/lib

Re: [libav-devel] [PATCH 2/2] vp8: loopfilter >=sse2 functions need aligned stack on x86-32.

2012-07-04 Thread Måns Rullgård
"Ronald S. Bultje" writes: > From: "Ronald S. Bultje" > > --- > libavcodec/x86/vp8dsp-init.c |6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavcodec/x86/vp8dsp-init.c b/libavcodec/x86/vp8dsp-init.c > index d3f1456..a0e8f9b 100644 > --- a/libavcodec/x86/vp8dsp-init.c > +++ b

Re: [libav-devel] [PATCH 1/2] swscale: yuv2planeX 8bit >=sse2 functions need aligned stack on x86-32.

2012-07-04 Thread Måns Rullgård
"Ronald S. Bultje" writes: > From: "Ronald S. Bultje" > > --- > libswscale/x86/swscale_mmx.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/libswscale/x86/swscale_mmx.c b/libswscale/x86/swscale_mmx.c > index 99b3262..37d786a 100644 > --- a/libswscale/

Re: [libav-devel] [PATCH] mov: use forward declaration of a function instead of a table.

2012-07-04 Thread Måns Rullgård
"Ronald S. Bultje" writes: > From: "Ronald S. Bultje" > > MSVC gives a compile error on the forward declaration of the table. It's not a forward declaration (no such term is even defined in the C standard), it is a tentative definition. Please try to use accurate terminology. > --- > libavfo

Re: [libav-devel] [PATCH] lavu: use intrinsic for emms on systems lacking inline asm support.

2012-07-04 Thread Måns Rullgård
"Ronald S. Bultje" writes: > From: "Ronald S. Bultje" > > --- > configure|5 + > libavutil/internal.h |5 - > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index a0c37e2..0ec348e 100755 > --- a/configure > +++ b/configure >

Re: [libav-devel] [PATCH] amr: remove shift out of the AMR_BIT() macro.

2012-07-04 Thread Måns Rullgård
"Ronald S. Bultje" writes: > From: "Ronald S. Bultje" > > MSVC doesn't like the offsetof(..) >> 1 construct, it interprets it as > a non-literal, thus causing use of this in static tables to fail > compilation. This is a blatant violation of the C spec. offsetof() is required to be an integer

Re: [libav-devel] [PATCH] mxfdec: replace x>>av_log2(sizeof(..)) by x/sizeof(..).

2012-07-04 Thread Kostya Shishkov
On Wed, Jul 04, 2012 at 11:09:57AM +0100, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > > > From: "Ronald S. Bultje" > > > > --- > > libavformat/mxfdec.c |8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c >

Re: [libav-devel] [PATCH] mxfdec: replace x>>av_log2(sizeof(..)) by x/sizeof(..).

2012-07-04 Thread Måns Rullgård
"Ronald S. Bultje" writes: > From: "Ronald S. Bultje" > > --- > libavformat/mxfdec.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > index dd10240..a7c1890 100644 > --- a/libavformat/mxfdec.c > +++ b/libavformat/m

Re: [libav-devel] [PATCH] mpegvideo: remove VLAs

2012-07-04 Thread Kostya Shishkov
On Wed, Jul 04, 2012 at 12:43:39PM +0300, Martin Storsjö wrote: > From: "Ronald S. Bultje" > > --- > libavcodec/error_resilience.c |2 +- > libavcodec/mpegvideo.c| 10 ++ > libavcodec/mpegvideo.h|6 ++ > libavcodec/ratecontrol.c |4 ++-- > 4 files c

[libav-devel] [PATCH] mpegvideo: remove VLAs

2012-07-04 Thread Martin Storsjö
From: "Ronald S. Bultje" --- libavcodec/error_resilience.c |2 +- libavcodec/mpegvideo.c| 10 ++ libavcodec/mpegvideo.h|6 ++ libavcodec/ratecontrol.c |4 ++-- 4 files changed, 19 insertions(+), 3 deletions(-) diff --git a/libavcodec/error_resilien

Re: [libav-devel] [PATCH] avplay: update input filter pointer when the filtergraph is reset.

2012-07-04 Thread Kostya Shishkov
On Wed, Jul 04, 2012 at 11:37:03AM +0200, Anton Khirnov wrote: > Fixes an invalid read on size change. > --- > avplay.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/avplay.c b/avplay.c > index e050169..4136b2e 100644 > --- a/avplay.c > +++ b/avplay.c > @@ -1643,6 +1643,7 @@ static

[libav-devel] [PATCH] avplay: update input filter pointer when the filtergraph is reset.

2012-07-04 Thread Anton Khirnov
Fixes an invalid read on size change. --- avplay.c |1 + 1 file changed, 1 insertion(+) diff --git a/avplay.c b/avplay.c index e050169..4136b2e 100644 --- a/avplay.c +++ b/avplay.c @@ -1643,6 +1643,7 @@ static int video_thread(void *arg) graph = avfilter_graph_alloc();

Re: [libav-devel] [PATCH] eval: Add the isinf() function and tests for it

2012-07-04 Thread Anton Khirnov
On Wed, 4 Jul 2012 11:41:12 +0300, Martin Storsjö wrote: > --- > doc/eval.texi |2 ++ > libavutil/avutil.h |2 +- > libavutil/eval.c|9 - > tests/ref/fate/eval | 12 > 4 files changed, 23 insertions(+), 2 deletions(-) > LGTM -- Anton Khirnov ___

[libav-devel] [PATCH] eval: Add the isinf() function and tests for it

2012-07-04 Thread Martin Storsjö
--- doc/eval.texi |2 ++ libavutil/avutil.h |2 +- libavutil/eval.c|9 - tests/ref/fate/eval | 12 4 files changed, 23 insertions(+), 2 deletions(-) diff --git a/doc/eval.texi b/doc/eval.texi index 7f8f365..e1fd7ee 100644 --- a/doc/eval.texi +++ b/doc

Re: [libav-devel] [PATCH] dsputilenc: group yasm and inline asm function pointer assignment.

2012-07-04 Thread Janne Grunau
On 2012-07-03 21:00:13 -0700, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > --- > libavcodec/x86/dsputilenc_mmx.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/x86/dsputilenc_mmx.c b/libavcodec/x86/dsputilenc_mmx.c > index d8a60e1..47fa5ca 10064