Re: [libav-devel] [PATCH 4/4] rtsp: listen mode

2012-07-09 Thread Martin Storsjö
On Mon, 9 Jul 2012, Luca Barbato wrote: On 07/09/2012 03:53 PM, Martin Storsjö wrote: +av_strlcatf(message, sizeof(message), "Server: LibAVFormat %d\r\n", While at it Libavformat instead of LibAVFormat If he switches to LIBAVFORMAT_IDENT, that (actually "Lavf") will be a part of it aut

Re: [libav-devel] [PATCH 4/4] rtsp: listen mode

2012-07-09 Thread Martin Storsjö
On Wed, 4 Jul 2012, Jordi Ortiz wrote: +static int rtsp_read_setup(AVFormatContext *s, char* host, char *controlurl) +{ +RTSPState *rt = s->priv_data; +RTSPMessageHeader request = { 0 }; +int ret = 0; +char url[1024]; +RTSPStream *rtsp_st; +c

[libav-devel] [PATCH] mem: introduce av_calloc and av_malloc_array

2012-07-09 Thread Luca Barbato
Both function ease allocating large arrays implementing the overflow check inside it Since pointless memsetting a potential large array is a waste of time the av_malloc_array is provided along with the av_calloc version. --- libavutil/mem.h | 38 -- 1 files c

Re: [libav-devel] [PATCH 4/4] rtsp: listen mode

2012-07-09 Thread Luca Barbato
On 07/09/2012 03:53 PM, Martin Storsjö wrote: > +av_strlcatf(message, sizeof(message), "Server: LibAVFormat %d\r\n", While at it Libavformat instead of LibAVFormat lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel ma

Re: [libav-devel] [PATCH 4/4] rtsp: listen mode

2012-07-09 Thread Martin Storsjö
On Wed, 4 Jul 2012, Jordi Ortiz wrote: diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 6226f41..b603792 100644 --- a/libavformat/rtspdec.c +++ b/libavformat/rtspdec.c @@ -22,6 +22,7 @@ #include "libavutil/avstring.h" #include "libavutil/intreadwrite.h" #include "libavutil/mathem

[libav-devel] [PATCH] mem: introduce av_calloc and av_malloc_array

2012-07-09 Thread Luca Barbato
Both function ease allocating large arrays implementing the overflow check inside it Since pointless memsetting a potential large array is a waste of time the av_malloc_array is provided along as the av_calloc version. --- Hopefully this will make everybody happy. libavutil/mem.h | 36 +++

Re: [libav-devel] [PATCH 3/4] rtsp listen mode: make rtsp_open_transport_ctx visible out of rtsp.c (remove static)

2012-07-09 Thread Martin Storsjö
On Wed, 4 Jul 2012, Jordi Ortiz wrote: --- libavformat/rtsp.c |6 +++--- libavformat/rtsp.h |5 + 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 551884b..d4206a1 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -5

Re: [libav-devel] [PATCH 2/4] rtsp: move rtsp_read_close

2012-07-09 Thread Martin Storsjö
On Wed, 4 Jul 2012, Jordi Ortiz wrote: --- libavformat/rtspdec.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 063e825..6226f41 100644 --- a/libavformat/rtspdec.c +++ b/libavformat/rtspdec.c

Re: [libav-devel] [PATCH 1/4] rtsp: add mode=receive/record header parse code

2012-07-09 Thread Martin Storsjö
On Wed, 4 Jul 2012, Jordi Ortiz wrote: --- libavformat/rtsp.c |8 libavformat/rtsp.h |3 +++ 2 files changed, 11 insertions(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 76b5df8..551884b 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -749,6 +749,14 @@

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Luca Barbato
On 07/09/2012 02:53 PM, Tomas Härdin wrote: >> What about something along the lines of >> >> #define av_malloc_array(nmemb, size) \ >> av_malloc((size <= 0 || nmemb >= INT_MAX / size) ? 0 : nmemb * size); > > > Wouldn't a static inline be better, should someone do something like > av_malloc_a

Re: [libav-devel] [PATCH] mem: Don't abort on av_malloc(0) in debug mode

2012-07-09 Thread Luca Barbato
On 04/11/2012 09:34 AM, Martin Storsjö wrote: > This makes the behaviour consistent between debug and release mode. > --- > libavutil/mem.c |2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavutil/mem.c b/libavutil/mem.c > index bf1a542..43fe3f6 100644 > --- a/libavutil/mem.c > +++

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Luca Barbato
On 07/09/2012 02:49 PM, Måns Rullgård wrote: > Luca Barbato writes: > >> On 07/09/2012 02:28 PM, Luca Barbato wrote: >>> On 07/09/2012 12:18 PM, Måns Rullgård wrote: Tomas Härdin writes: > On Sun, 2012-07-08 at 21:12 +0100, Måns Rullgård wrote: >> Tomas Härdin writes: >>>

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Tomas Härdin
On Mon, 2012-07-09 at 14:28 +0200, Luca Barbato wrote: > On 07/09/2012 12:18 PM, Måns Rullgård wrote: > > Tomas Härdin writes: > > > >> On Sun, 2012-07-08 at 21:12 +0100, Måns Rullgård wrote: > >>> Tomas Härdin writes: > +void *av_calloc(size_t nmemb, size_t size) > +{ > +if (

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Måns Rullgård
Luca Barbato writes: > On 07/09/2012 02:28 PM, Luca Barbato wrote: >> On 07/09/2012 12:18 PM, Måns Rullgård wrote: >>> Tomas Härdin writes: >>> On Sun, 2012-07-08 at 21:12 +0100, Måns Rullgård wrote: > Tomas Härdin writes: >> +void *av_calloc(size_t nmemb, size_t size) >> +{ >>

Re: [libav-devel] [PATCH] fate: Fix running fate without zlib

2012-07-09 Thread Måns Rullgård
Martin Storsjö writes: > This conditionally enables the tests that depend on having zlib > present. > --- > configure |2 ++ > tests/Makefile|3 ++- > tests/fate/lossless-video.mak |4 ++-- > tests/fate/qt.mak |2 +- > tests/fate/sc

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Luca Barbato
On 07/09/2012 02:28 PM, Luca Barbato wrote: > On 07/09/2012 12:18 PM, Måns Rullgård wrote: >> Tomas Härdin writes: >> >>> On Sun, 2012-07-08 at 21:12 +0100, Måns Rullgård wrote: Tomas Härdin writes: > +void *av_calloc(size_t nmemb, size_t size) > +{ > +if (size <= 0 || nmemb

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Luca Barbato
On 07/09/2012 12:18 PM, Måns Rullgård wrote: > Tomas Härdin writes: > >> On Sun, 2012-07-08 at 21:12 +0100, Måns Rullgård wrote: >>> Tomas Härdin writes: +void *av_calloc(size_t nmemb, size_t size) +{ +if (size <= 0 || nmemb >= INT_MAX / size) +return NULL; +

Re: [libav-devel] [PATCH] mss3: use standard zigzag table

2012-07-09 Thread Luca Barbato
On 07/09/2012 02:10 PM, Kostya Shishkov wrote: > On Mon, Jul 09, 2012 at 02:03:26PM +0200, Kostya Shishkov wrote: >> On Mon, Jul 09, 2012 at 02:01:40PM +0200, Luca Barbato wrote: >>> On 07/09/2012 01:42 PM, Kostya Shishkov wrote: --- libavcodec/mss3.c | 14 ++ 1 files

Re: [libav-devel] [PATCH] mss3: use standard zigzag table

2012-07-09 Thread Kostya Shishkov
On Mon, Jul 09, 2012 at 02:03:26PM +0200, Kostya Shishkov wrote: > On Mon, Jul 09, 2012 at 02:01:40PM +0200, Luca Barbato wrote: > > On 07/09/2012 01:42 PM, Kostya Shishkov wrote: > > > --- > > > libavcodec/mss3.c | 14 ++ > > > 1 files changed, 2 insertions(+), 12 deletions(-) > > >

Re: [libav-devel] [PATCH] mss3: use standard zigzag table

2012-07-09 Thread Kostya Shishkov
On Mon, Jul 09, 2012 at 02:01:40PM +0200, Luca Barbato wrote: > On 07/09/2012 01:42 PM, Kostya Shishkov wrote: > > --- > > libavcodec/mss3.c | 14 ++ > > 1 files changed, 2 insertions(+), 12 deletions(-) > > > > seems fine, is the table always defined? Otherwise add the proper deps

Re: [libav-devel] [PATCH] mss3: use standard zigzag table

2012-07-09 Thread Luca Barbato
On 07/09/2012 01:42 PM, Kostya Shishkov wrote: > --- > libavcodec/mss3.c | 14 ++ > 1 files changed, 2 insertions(+), 12 deletions(-) > seems fine, is the table always defined? Otherwise add the proper deps. lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero __

[libav-devel] [PATCH] mss3: use standard zigzag table

2012-07-09 Thread Kostya Shishkov
--- libavcodec/mss3.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/libavcodec/mss3.c b/libavcodec/mss3.c index 25163c6..50a8268 100644 --- a/libavcodec/mss3.c +++ b/libavcodec/mss3.c @@ -26,6 +26,7 @@ #include "avcodec.h" #include "bytestream.h" +#incl

[libav-devel] [PATCH] fate: Fix running fate without zlib

2012-07-09 Thread Martin Storsjö
This conditionally enables the tests that depend on having zlib present. --- configure |2 ++ tests/Makefile|3 ++- tests/fate/lossless-video.mak |4 ++-- tests/fate/qt.mak |2 +- tests/fate/screen.mak |4 ++-- tests/fate/

Re: [libav-devel] [PATCH 1/5] configure: Change the rdtsc check to a linker check

2012-07-09 Thread Måns Rullgård
Diego Biurrun writes: > A compile-only test could succeed with an implicit function declaration. > Also move the check to the x86 section; rdtsc is x86-only. > --- > configure |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 0b0d532..

Re: [libav-devel] [PATCH 2/5] lavu: use intrinsics for emms on systems lacking inline asm support

2012-07-09 Thread Måns Rullgård
Diego Biurrun writes: > From: Ronald S. Bultje > > Signed-off-by: Diego Biurrun > --- > configure|3 +++ > libavutil/internal.h |7 +-- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 3c82eaa..7ef1025 100755 > --- a/conf

Re: [libav-devel] [PATCH 1/2] configure: Support filtering ldflags just as normal cflags

2012-07-09 Thread Måns Rullgård
Martin Storsjö writes: > --- > I'm not sure I managed to add it to all the necessary places, > but msvc builds with this seem to work as intended. > > configure |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index e8af4b4..9409524 100755

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Måns Rullgård
Tomas Härdin writes: > On Sun, 2012-07-08 at 21:12 +0100, Måns Rullgård wrote: >> Tomas Härdin writes: >> > +void *av_calloc(size_t nmemb, size_t size) >> > +{ >> > +if (size <= 0 || nmemb >= INT_MAX / size) >> > +return NULL; >> > +return av_mallocz(nmemb * size); >> > +} >> >>

Re: [libav-devel] [PATCH 1/4] fft-test: don't use getopt().

2012-07-09 Thread Måns Rullgård
Anton Khirnov writes: > It's not available on all systems and using argc/argv directly does not > complicate the code much. > --- > libavcodec/fft-test.c | 25 ++--- > 1 file changed, 14 insertions(+), 11 deletions(-) > > diff --git a/libavcodec/fft-test.c b/libavcodec/fft-

Re: [libav-devel] [PATCH 3/4] motion-test: don't use getopt().

2012-07-09 Thread Måns Rullgård
Anton Khirnov writes: > It's not available on all systems and using argc/argv directly actually > makes the code simpler. > --- > libavcodec/motion-test.c | 12 +++- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/libavcodec/motion-test.c b/libavcodec/motion-test.c >

Re: [libav-devel] [PATCH] MS Expression Encoder Screen decoder

2012-07-09 Thread Diego Biurrun
On Sat, Jul 07, 2012 at 02:35:23PM +0200, Kostya Shishkov wrote: > > --- a/Changelog > +++ b/Changelog > @@ -31,6 +31,7 @@ version : > - Microsoft ATC Screen decoder > +- Microsoft Expression Encoder Screen decoder > > --- a/doc/general.texi > +++ b/doc/general.texi > @@ -533,6 +533,8 @@ follow

[libav-devel] [RFC PATCH 2/2] msvc: Map -l to .lib

2012-07-09 Thread Martin Storsjö
--- This isn't intended for main git at the moment, but is included to illustrate how filter_ldflags could be used for translating -lfoo to foo.lib. With this in place, no faux -lm is added to the command line. configure |9 + 1 file changed, 9 insertions(+) diff --git a/configure b/

[libav-devel] [PATCH 1/2] configure: Support filtering ldflags just as normal cflags

2012-07-09 Thread Martin Storsjö
--- I'm not sure I managed to add it to all the necessary places, but msvc builds with this seem to work as intended. configure |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index e8af4b4..9409524 100755 --- a/configure +++ b/configure @@ -601,7

Re: [libav-devel] [PATCH] configure: check for math functions without linking to -lm also.

2012-07-09 Thread Martin Storsjö
On Sun, 8 Jul 2012, Ronald S. Bultje wrote: Hi, On Sun, Jul 8, 2012 at 12:48 PM, Måns Rullgård wrote: "Ronald S. Bultje" writes: Hi, On Sat, Jul 7, 2012 at 3:57 PM, Derek Buitenhuis wrote: On 07/07/2012 6:09 PM, Diego Biurrun wrote: And this is required - why? Libm / math is not A Th

Re: [libav-devel] MSVC intrinsics patchset

2012-07-09 Thread Martin Storsjö
On Mon, 9 Jul 2012, Diego Biurrun wrote: These are the intrinsics patches for MSVC, cleaned up to account for review comments. Note that I do not have MSVC, so testing is welcome. Except for patches 3 and 4 which needed double underscores, the rest of this seems to work fine in practice. /

Re: [libav-devel] [PATCH] mss3: split DSP functions that are used in MTS2(MSS4) into separate file

2012-07-09 Thread Diego Biurrun
On Mon, Jul 09, 2012 at 11:13:47AM +0200, Kostya Shishkov wrote: > On Mon, Jul 09, 2012 at 11:05:19AM +0200, Diego Biurrun wrote: > > On Mon, Jul 09, 2012 at 07:57:22AM +0200, Kostya Shishkov wrote: > > > --- > > > I also took the liberty to get rid of floats in matrix generation. > > > > Shouldn'

[libav-devel] [PATCH 4/5] x86/cpu: implement support for cpuid through intrinsics

2012-07-09 Thread Martin Storsjö
From: "Ronald S. Bultje" --- This one needs double underscores as well. configure |2 ++ libavutil/x86/cpu.c | 14 ++ 2 files changed, 16 insertions(+) diff --git a/configure b/configure index 76ad4c7..0f51523 100755 --- a/configure +++ b/configure @@ -1061,6 +1061,

[libav-devel] [PATCH 3/5] x86/cpu: implement support for xgetbv through intrinsics

2012-07-09 Thread Martin Storsjö
From: "Ronald S. Bultje" --- This one needs double underscores. configure |2 ++ libavutil/x86/cpu.c | 11 +++ 2 files changed, 13 insertions(+) diff --git a/configure b/configure index a1506c9..76ad4c7 100755 --- a/configure +++ b/configure @@ -1169,6 +1169,7 @@ HAVE_L

Re: [libav-devel] [PATCH] TechSmith Screen Codec 2 decoder

2012-07-09 Thread Diego Biurrun
On Mon, Jul 09, 2012 at 06:42:36AM +0200, Kostya Shishkov wrote: > --- > Changelog |1 + > doc/general.texi |2 + > libavcodec/Makefile|1 + > libavcodec/allcodecs.c |1 + > libavcodec/avcodec.h |1 + > libavcodec/tscc2.c | 382 +++

Re: [libav-devel] [PATCH] mss3: split DSP functions that are used in MTS2(MSS4) into separate file

2012-07-09 Thread Kostya Shishkov
On Mon, Jul 09, 2012 at 11:05:19AM +0200, Diego Biurrun wrote: > On Mon, Jul 09, 2012 at 07:57:22AM +0200, Kostya Shishkov wrote: > > --- > > I also took the liberty to get rid of floats in matrix generation. > > Shouldn't that go in a separate patch? It was mostly a matter of interface change. _

Re: [libav-devel] [PATCH] mss3: split DSP functions that are used in MTS2(MSS4) into separate file

2012-07-09 Thread Diego Biurrun
On Mon, Jul 09, 2012 at 07:57:22AM +0200, Kostya Shishkov wrote: > --- > I also took the liberty to get rid of floats in matrix generation. Shouldn't that go in a separate patch? > --- /dev/null > +++ b/libavcodec/mss34dsp.c > @@ -0,0 +1,113 @@ > + > +#include "avcodec.h" > +#include "mss34dsp.h"

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Tomas Härdin
On Sun, 2012-07-08 at 18:44 +0200, Luca Barbato wrote: > I thought you were making it an inline. Normal function -> smaller binaries. Also, this patch already existed -> less work. /Tomas ___ libav-devel mailing list libav-devel@libav.org https://lists

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Tomas Härdin
On Sun, 2012-07-08 at 21:12 +0100, Måns Rullgård wrote: > Tomas Härdin writes: > > +void *av_calloc(size_t nmemb, size_t size) > > +{ > > +if (size <= 0 || nmemb >= INT_MAX / size) > > +return NULL; > > +return av_mallocz(nmemb * size); > > +} > > The places where this would be us

<    1   2