On Sat, Jul 28, 2012 at 06:17:48PM -0400, Derek Buitenhuis wrote:
> At the moment it only does BGR24, but I plan to add the rest after.
>
> Signed-off-by: Derek Buitenhuis
> ---
> Changelog |1 +
> doc/general.texi |1 +
> libavcodec/Makefile|1 +
> libavcodec/
Il 28/07/2012 21:45, Ronald S. Bultje ha scritto:
> From: "Ronald S. Bultje"
LGTM.
--
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/
On Sun, 29 Jul 2012 05:27:57 +0200, Luca Barbato wrote:
> On 07/29/2012 05:10 AM, Ronald S. Bultje wrote:
> > From: "Ronald S. Bultje"
> >
> > This way, the code looks less like spaghetti, and is easier to parse
> > for external preprocessors.
>
> Maybe something along the lines
>
> avconv: c
From: "Ronald S. Bultje"
---
libavcodec/h264_ps.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c
index 3f53af8..7d9d596 100644
--- a/libavcodec/h264_ps.c
+++ b/libavcodec/h264_ps.c
@@ -431,6 +431,7 @@ int ff_h264_decode_seq_pa
On 07/29/2012 05:10 AM, Ronald S. Bultje wrote:
> From: "Ronald S. Bultje"
>
> This way, the code looks less like spaghetti, and is easier to parse
> for external preprocessors.
> ---
As for the previous patches.
--
Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero
__
On 07/29/2012 05:10 AM, Ronald S. Bultje wrote:
> From: "Ronald S. Bultje"
>
> This way, the code looks less like spaghetti, and is easier to parse
> for external preprocessors.
As the previous patch, ok but reword the commit message.
lu
--
Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu
On 07/29/2012 05:10 AM, Ronald S. Bultje wrote:
> From: "Ronald S. Bultje"
>
> This way, the code looks less like spaghetti, and is easier to parse
> for external preprocessors.
Maybe something along the lines
avconv: convert ternary statements to normal conditional blocks
The resulting code i
On 07/28/2012 09:07 PM, Jordi Ortiz wrote:
> Enhanced doxygen
> ---
> libavformat/rtmppkt.c | 45 +
> libavformat/rtmppkt.h | 39 +++
> 2 files changed, 84 insertions(+)
>
Looks fine.
--
Luca Barbato
Gentoo/
On 07/28/2012 09:12 PM, Jordi Ortiz wrote:
> ---
> doc/protocols.texi |5 +
> libavformat/rtmp.h |1 +
> libavformat/rtmpproto.c | 532
> +--
> 3 files changed, 517 insertions(+), 21 deletions(-)
>
> diff --git a/doc/protocols.texi b
From: "Ronald S. Bultje"
This way, the code looks less like spaghetti, and is easier to parse
for external preprocessors.
---
libavfilter/avfilter.c | 10 +++---
libavfilter/vsrc_testsrc.c |7 +--
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/libavfilter/avfil
From: "Ronald S. Bultje"
This way, the code looks less like spaghetti, and is easier to parse
for external preprocessors.
---
libavformat/utils.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/libavformat/utils.c b/libavformat/utils.c
index 4ec70b7..a78b9e7 10064
From: "Ronald S. Bultje"
This way, the code looks less like spaghetti, and is easier to parse
for external preprocessors.
---
avconv.c | 44
1 file changed, 28 insertions(+), 16 deletions(-)
diff --git a/avconv.c b/avconv.c
index 439672a..fcf2b69 1
On 28/07/2012 8:32 PM, Måns Rullgård wrote:
> The vlc reader in get_bits.h exists precisely to avoid duplicating code
> like this all over the place. Just use it. It is faster too.
I will try it locally, and see. Reading the code it does NOT look like
it will be faster whatsoever, with the added
"Ronald S. Bultje" writes:
> Hi,
>
> On Sat, Jul 28, 2012 at 3:17 PM, Derek Buitenhuis
> wrote:
>> +/* Simultaniously read and restore the line */
>> +for (i = 0; i < ctx->avctx->width; i++) {
>> +pred += code_table[2 * show_bits(gb, 14)];
>> +skip = code_table[2 * show_
Hi,
On Sat, Jul 28, 2012 at 4:57 PM, Justin Ruggles
wrote:
> ---
> libavresample/x86/audio_convert.asm| 49
>
> libavresample/x86/audio_convert_init.c |9 ++
> 2 files changed, 58 insertions(+), 0 deletions(-)
OK.
Ronald
_
Hi,
On Sat, Jul 28, 2012 at 3:17 PM, Derek Buitenhuis
wrote:
> +/* Simultaniously read and restore the line */
> +for (i = 0; i < ctx->avctx->width; i++) {
> +pred += code_table[2 * show_bits(gb, 14)];
> +skip = code_table[2 * show_bits(gb, 14) + 1];
> +
> +skip_b
---
libavresample/x86/audio_convert.asm| 49
libavresample/x86/audio_convert_init.c |9 ++
2 files changed, 58 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/libavresample/x86/audio_convert.asm
index ee05efc..c3cc76
---
libavresample/x86/audio_convert.asm| 123
libavresample/x86/audio_convert_init.c | 14
2 files changed, 137 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/libavresample/x86/audio_convert.asm
index 4a92952..ee05efc
At the moment it only does BGR24, but I plan to add the rest after.
Signed-off-by: Derek Buitenhuis
---
Changelog |1 +
doc/general.texi |1 +
libavcodec/Makefile|1 +
libavcodec/allcodecs.c |1 +
libavcodec/avcodec.h |1 +
libavcodec/cllc.c | 2
On Thu, 26 Jul 2012 22:51:17 +, Loren Merritt
wrote:
> ---
> libavfilter/vf_hqdn3d.c | 70
> +++
> 1 files changed, 46 insertions(+), 24 deletions(-)
>
> diff --git a/libavfilter/vf_hqdn3d.c b/libavfilter/vf_hqdn3d.c
> index 02f0cd1..521fef8 1
On 28/07/2012 5:25 PM, Måns Rullgård wrote:
>> It looks to me like that struct has a straight-up wrongly named
>> > func param. Why hasn't this been changed?
> Patches welcome.
Will do.
>> > Also, basically every codec I see go in uses data_size, so why
>> > have none of these been changed?
> Pat
Derek Buitenhuis writes:
> On 28/07/2012 5:16 PM, Måns Rullgård wrote:
>>> Wait, what?
>>> >
>>> > http://libav.org/doxygen/master/avcodec_8h_source.html#l02935
>>> >
>>> > Sure looks like data_size to me!
>> Not all things are what they appear to be.
>
> It looks to me like that struct has a str
On 28/07/2012 5:16 PM, Måns Rullgård wrote:
>> Wait, what?
>> >
>> > http://libav.org/doxygen/master/avcodec_8h_source.html#l02935
>> >
>> > Sure looks like data_size to me!
> Not all things are what they appear to be.
It looks to me like that struct has a straight-up wrongly named
func param. Why
Hi,
On Thu, Jul 26, 2012 at 8:28 PM, Ronald S. Bultje wrote:
> On Thu, Jul 26, 2012 at 6:42 PM, Loren Merritt
> wrote:
>> ---
>> libavfilter/vf_hqdn3d.c | 72
>> ++
>> 1 files changed, 53 insertions(+), 19 deletions(-)
>
> OK.
And pushed.
Ronald
Hi,
On Thu, Jul 26, 2012 at 6:40 PM, Loren Merritt wrote:
> On Thu, 26 Jul 2012, Ronald S. Bultje wrote:
>> On Thu, Jul 26, 2012 at 3:51 PM, Loren Merritt
>> wrote:
>> > 14% faster on penryn, 2% on sandybridge, 9% on bulldozer
>> > ---
>> > libavfilter/vf_hqdn3d.c | 157
>> > +++-
Derek Buitenhuis writes:
> On 28/07/2012 1:13 PM, Derek Buitenhuis wrote:
>> On 28/07/2012 5:24 AM, Anton Khirnov wrote:
> +*data_size = sizeof(AVFrame);
>>> It's not data_size.
>>> It's got_frame_ptr. Write 1 there.
>>
>> OK.
>
> Wait, what?
>
> http://libav.org/doxygen/master/avc
Hi,
On Thu, Jul 26, 2012 at 4:14 PM, Luca Barbato wrote:
> On 07/27/2012 12:51 AM, Loren Merritt wrote:
>> ---
>> libavfilter/vf_delogo.c | 38 +-
>> libavfilter/vf_gradfun.c | 37 +
>> libavfilter/video.c | 36 +
On 28/07/2012 1:13 PM, Derek Buitenhuis wrote:
> On 28/07/2012 5:24 AM, Anton Khirnov wrote:
+*data_size = sizeof(AVFrame);
>> It's not data_size.
>> It's got_frame_ptr. Write 1 there.
>
> OK.
Wait, what?
http://libav.org/doxygen/master/avcodec_8h_source.html#l02935
Sure looks li
Hi,
On Sat, Jul 28, 2012 at 12:27 PM, Diego Biurrun wrote:
> On Thu, Jul 26, 2012 at 10:51:13PM +, Loren Merritt wrote:
>> Change code style to match the rest of libav.
>> ---
>> libavfilter/vf_hqdn3d.c | 308
>> +++
>> 1 files changed, 152 inser
13% faster on penryn, 16% on sandybridge, 15% on bulldozer
Not simd; a compiler should have generated this, but gcc didn't.
---
libavfilter/vf_hqdn3d.c| 27 ++--
libavfilter/x86/Makefile |1 +
libavfilter/x86/hqdn3d.asm | 106
libav
On 07/28/2012 08:53 PM, Måns Rullgård wrote:
> "Ronald S. Bultje " writes:
>
>> Module: libav
>> Branch: master
>> Commit: dcb7ef5483f26a7f20eee048821916f051216d62
>>
>> Author:Ronald S. Bultje
>> Committer: Ronald S. Bultje
>> Date: Thu Jul 26 04:23:23 2012 +
>>
>> avprobe/avconv:
On Thu, Jul 26, 2012 at 10:51:13PM +, Loren Merritt wrote:
> Change code style to match the rest of libav.
> ---
> libavfilter/vf_hqdn3d.c | 308
> +++
> 1 files changed, 152 insertions(+), 156 deletions(-)
There is some room for improvement still
---
doc/protocols.texi |5 +
libavformat/rtmp.h |1 +
libavformat/rtmpproto.c | 532 +--
3 files changed, 517 insertions(+), 21 deletions(-)
diff --git a/doc/protocols.texi b/doc/protocols.texi
index ff872fc..cf15b36 100644
--- a/doc/
Enhanced doxygen
---
libavformat/rtmppkt.c | 45 +
libavformat/rtmppkt.h | 39 +++
2 files changed, 84 insertions(+)
diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c
index 4ce238d..3c13709 100644
--- a/l
Hi,
On Sat, Jul 28, 2012 at 11:48 AM, Justin Ruggles
wrote:
> On 07/24/2012 11:51 PM, Ronald S. Bultje wrote:
>> On Sat, Jul 14, 2012 at 9:29 PM, Justin Ruggles
>> wrote:
>>> ---
>>> libavresample/x86/audio_convert.asm| 62
>>>
>>> libavresample/x86/audio
"Ronald S. Bultje " writes:
> Module: libav
> Branch: master
> Commit: dcb7ef5483f26a7f20eee048821916f051216d62
>
> Author:Ronald S. Bultje
> Committer: Ronald S. Bultje
> Date: Thu Jul 26 04:23:23 2012 +
>
> avprobe/avconv: fix tentative declaration compile errors on MSVS.
>
> ---
On 07/24/2012 11:51 PM, Ronald S. Bultje wrote:
> Hi,
>
> On Sat, Jul 14, 2012 at 9:29 PM, Justin Ruggles
> wrote:
>> ---
>> libavresample/x86/audio_convert.asm| 62
>>
>> libavresample/x86/audio_convert_init.c |9 +
>> 2 files changed, 71 insertio
Hi,
On Sat, Jul 28, 2012 at 11:30 AM, Justin Ruggles
wrote:
> ---
> libavresample/x86/audio_convert.asm| 37
>
> libavresample/x86/audio_convert_init.c | 13 +++
> 2 files changed, 50 insertions(+), 0 deletions(-)
LGTM.
Ronald
_
---
libavresample/x86/audio_convert.asm| 37
libavresample/x86/audio_convert_init.c | 13 +++
2 files changed, 50 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/libavresample/x86/audio_convert.asm
index 244c4d1..4
Hi,
On Sat, Jul 28, 2012 at 10:52 AM, Luca Barbato wrote:
> On 07/28/2012 05:05 PM, Ronald S. Bultje wrote:
>> On Fri, Jul 27, 2012 at 5:48 PM, Ronald S. Bultje wrote:
>>> On Fri, Jul 27, 2012 at 2:43 PM, Måns Rullgård wrote:
However, the question still remains why it is in generic code.
>
On 28/07/2012 1:53 PM, Kostya Shishkov wrote:
>>> In theory you could collect (symbol, i+1, prefix) values and use them to
>>> initialise our VLC structure instead of making LUT yourself (exactly like
>>> binary does ;)
>>
>> If you think it's worth the time, I could try, but those functions look
>
Diego Biurrun writes:
> ---
> configure |7 ++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index d645165..53fe2c6 100755
> --- a/configure
> +++ b/configure
> @@ -116,6 +116,8 @@ Component options:
>--enable-x11grab enable X11
Kostya Shishkov writes:
> On Sat, Jul 28, 2012 at 01:31:33PM -0400, Derek Buitenhuis wrote:
>> On 28/07/2012 3:44 AM, Kostya Shishkov wrote:
>> >> +ctx->swapped_buf = av_malloc(avctx->width * avctx->height * 3);
>> >
>> > Are you sure it's always enough? Max code length is 14 bits and
>> > s
Diego Biurrun writes:
> On Fri, Jul 27, 2012 at 11:57:40AM +0100, Måns Rullgård wrote:
>> Diego Biurrun writes:
>> > --- a/Makefile
>> > +++ b/Makefile
>> > @@ -46,7 +46,7 @@ COMPILE_S = $(call COMPILE,AS)
>> >
>> > %.ho: %.h
>> > - $(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ -x c $<
>> > + $(CC)
On 07/28/2012 01:19 PM, Diego Biurrun wrote:
> From: Anton Khirnov
>
> ---
> libavformat/wv.c | 175 +
> 1 files changed, 96 insertions(+), 79 deletions(-)
>
Ok.
--
Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero
__
On Sat, Jul 28, 2012 at 01:31:33PM -0400, Derek Buitenhuis wrote:
> On 28/07/2012 3:44 AM, Kostya Shishkov wrote:
> >> +for (k = prefix << sym_shift; k < prefix + 1 << sym_shift;
> >> k++) {
> >> > +code_table[2 * k] = symbol;
> >> > +code_table[2 *
On 07/28/2012 05:05 PM, Ronald S. Bultje wrote:
> Hi,
>
> On Fri, Jul 27, 2012 at 5:48 PM, Ronald S. Bultje wrote:
>> On Fri, Jul 27, 2012 at 2:43 PM, Måns Rullgård wrote:
>>> However, the question still remains why it is in generic code.
>>
>> That's hard to say in hindsight, but it seems it wa
On 28/07/2012 7:30 AM, Måns Rullgård wrote:
>> Is there any particular reason for the t -> s change? (They're both
>> > extremely descriptive, I know.)
> When replacing two variables with one, one of them must be renamed.
Well, yes. I was just wondering which caused the least amount of changes.
>
On 07/28/2012 07:13 PM, Justin Ruggles wrote:
> ---
> libavfilter/af_asyncts.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Ok.
--
Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero
___
libav-devel mailing list
libav-devel@li
On 07/28/2012 07:13 PM, Justin Ruggles wrote:
> This allows for padding/trimming at the start of stream. By default, no
> assumption is made about the first frame's expected pts, so no padding or
> trimming is done.
> ---
> doc/filters.texi |7 +++
> libavfilter/af_asyncts.c |3
On 07/28/2012 07:16 PM, Mans Rullgard wrote:
> MMX-enabled systems by default use some dsputil functions differing
> from the C versions. Adding these flags ensures accurate ones are
> used everywhere.
>
> Signed-off-by: Mans Rullgard
> ---
> tests/fate/filter.mak | 4 +-
> tests/
On 28/07/2012 3:44 AM, Kostya Shishkov wrote:
>> +for (k = prefix << sym_shift; k < prefix + 1 << sym_shift; k++)
>> {
>> > +code_table[2 * k] = symbol;
>> > +code_table[2 * k + 1] = i + 1;
>> > +}
> In theory you could collect (symbol, i
MMX-enabled systems by default use some dsputil functions differing
from the C versions. Adding these flags ensures accurate ones are
used everywhere.
Signed-off-by: Mans Rullgard
---
tests/fate/filter.mak | 4 +-
tests/ref/fate/filter-yadif-mode0 | 62 +--
tests/
On 28/07/2012 1:01 PM, Måns Rullgård wrote:
>>> +info_tag= AV_RL32(src);
>>> +if (info_tag == MKTAG('I', 'N', 'F', 'O')) {
>>> +info_offset = AV_RL32(src + 4) + 8;
>
> The value read from the bitstream needs to be validated before adding 8,
> or it could overflow.
Will do.
>>
---
libavfilter/af_asyncts.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libavfilter/af_asyncts.c b/libavfilter/af_asyncts.c
index 5a12a6f..21850dd 100644
--- a/libavfilter/af_asyncts.c
+++ b/libavfilter/af_asyncts.c
@@ -186,7 +186,7 @@ static int filter_samples(AVFil
This allows for padding/trimming at the start of stream. By default, no
assumption is made about the first frame's expected pts, so no padding or
trimming is done.
---
doc/filters.texi |7 +++
libavfilter/af_asyncts.c |3 +--
2 files changed, 8 insertions(+), 2 deletions(-)
di
On 28/07/2012 5:24 AM, Anton Khirnov wrote:
>> > +*data_size = sizeof(AVFrame);
> It's not data_size.
> It's got_frame_ptr. Write 1 there.
OK.
- Derek
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/
From: "Ronald S. Bultje"
This completes the conversion of h264dsp to yasm; note that h264 also
uses some dsputil functions, most notably qpel. Performance-wise, the
yasm-version is ~10 cycles faster (182->172) on x86-64, and ~8 cycles
faster (201->193) on x86-32.
---
libavcodec/x86/h264_deblock.
"Ronald S. Bultje" writes:
> Hi,
>
> On Fri, Jul 27, 2012 at 4:21 PM, Derek Buitenhuis
> wrote:
>> +static int cllc_decode_frame(AVCodecContext *avctx, void *data,
>> + int *data_size, AVPacket *avpkt)
> [..]
>> +uint8_t *src = avpkt->data;
> [..]
>> +info_tag
---
libavformat/rtmppkt.c | 45 +
libavformat/rtmppkt.h | 39 +++
2 files changed, 84 insertions(+)
diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c
index 4ce238d..19ac890 100644
--- a/libavformat/rtmppk
On Sat, 28 Jul 2012, Ronald S. Bultje wrote:
> On Fri, Jul 27, 2012 at 1:01 PM, Loren Merritt
> wrote:
>
>> %%.b_idx_loop:
>> Automatically generates a different label for each instantiation of the
>> macro.
>
> My disassembly now looks like this:
>
> 0x0001004c43b4 :jne
>0x1004c44d1
>
> +str[stringlen] = '\0';
>> +*strlen = stringlen;
>>
>
> You could perhaps use the *strlen parameter both for the buffer size as
> both input and output, so you'd need one parameter less.
I dislike this. I feel it is much less intuitive accesing a pointer to
extract the maximum size o
Hi,
On Fri, Jul 27, 2012 at 4:21 PM, Derek Buitenhuis
wrote:
> +static int cllc_decode_frame(AVCodecContext *avctx, void *data,
> + int *data_size, AVPacket *avpkt)
[..]
> +uint8_t *src = avpkt->data;
[..]
> +info_tag= AV_RL32(src);
> +if (info_tag == M
On 07/28/2012 05:53 AM, Anton Khirnov wrote:
> AVPacket.duration is mostly made up and thus completely useless, this is
> especially true for video streams.
> Therefore use dts difference for framerate estimation and
> the max_analyze_duration check.
>
> The asyncts test now needs -analyzeduration
On Sun, Feb 26, 2012 at 05:39:05PM -0800, Ronald S. Bultje wrote:
> ---
> libavcodec/x86/fft_mmx.asm | 14 +++---
> 1 files changed, 7 insertions(+), 7 deletions(-)
LGTM, a more descriptive log msg would be appreciated.
Diego
___
libav-devel
On Sat, Jul 28, 2012 at 08:01:12AM -0700, Ronald S. Bultje wrote:
> From: "Ronald S. Bultje"
>
> ---
> libavcodec/x86/h264_idct_10bit.asm | 254
> ++--
> 1 file changed, 127 insertions(+), 127 deletions(-)
OK
Diego
_
"Ronald S. Bultje" writes:
> Hi,
>
> On Fri, Jul 27, 2012 at 9:29 AM, Ronald S. Bultje wrote:
>> On Thu, Jul 26, 2012 at 6:42 AM, Måns Rullgård wrote:
>>> "Ronald S. Bultje" writes:
On Thu, Jul 26, 2012 at 2:23 AM, Måns Rullgård wrote:
> "Ronald S. Bultje" writes:
>
>> From:
Hi,
On Fri, Jul 27, 2012 at 5:48 PM, Ronald S. Bultje wrote:
> On Fri, Jul 27, 2012 at 2:43 PM, Måns Rullgård wrote:
>> However, the question still remains why it is in generic code.
>
> That's hard to say in hindsight, but it seems it was for simplicity so
> that you don't have to add it to eac
Hi,
On Fri, Jul 27, 2012 at 9:29 AM, Ronald S. Bultje wrote:
> On Thu, Jul 26, 2012 at 6:42 AM, Måns Rullgård wrote:
>> "Ronald S. Bultje" writes:
>>> On Thu, Jul 26, 2012 at 2:23 AM, Måns Rullgård wrote:
"Ronald S. Bultje" writes:
> From: "Ronald S. Bultje"
>
> ---
>>>
Hi,
On Fri, Jul 27, 2012 at 1:01 PM, Loren Merritt wrote:
> On Fri, 27 Jul 2012, Ronald S. Bultje wrote:
>
>> From: "Ronald S. Bultje"
>>
>> This completes the conversion of h264dsp to yasm; note that h264 also
>> uses some dsputil functions, most notably qpel. Performance-wise, the
>> yasm-vers
From: "Ronald S. Bultje"
---
libavcodec/x86/h264_idct_10bit.asm | 254 ++--
1 file changed, 127 insertions(+), 127 deletions(-)
diff --git a/libavcodec/x86/h264_idct_10bit.asm
b/libavcodec/x86/h264_idct_10bit.asm
index 934a7ff..2aab986 100644
--- a/libavcodec/x
---
src/index |6 ++
1 file changed, 6 insertions(+)
diff --git a/src/index b/src/index
index 36ea62d..d780803 100644
--- a/src/index
+++ b/src/index
@@ -33,6 +33,12 @@ with the latest developments by subscribing to both the
News
+July 28, 2012
+
+The libavfilter library is hereby de
On 07/28/2012 12:27 PM, Mashiat Sarker Shakkhar wrote:
> From: Michael Niedermayer
>
> Fixes overread
>
> Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
> Signed-off-by: Michael Niedermayer
> ---
> libavcodec/vc1dec.c |8 ++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
On 07/28/2012 12:03 AM, Jordi Ortiz wrote:
> If you mean converting all the ff_amf_ to av_amf_ and declare them non
> static into the .h I can do that before sending next version with the
> modifications.
We will do later =)
--
Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero
_
On 07/28/2012 09:04 AM, Anton Khirnov wrote:
>
> On Fri, 27 Jul 2012 21:01:49 +0200, Luca Barbato wrote:
>> On 07/27/2012 04:30 PM, Anton Khirnov wrote:
>>> ---
>>> libavformat/utils.c | 18 ++
>>> 1 file changed, 18 insertions(+)
>>>
>>
>> I'm scared about 30fps and 29.7fps mi
From: Michael Niedermayer
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer
---
libavcodec/vc1dec.c |5 +
1 file changed, 5 insertions(+)
diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c
index fd515c7..c6cbfc1 100644
--- a/libavcodec/vc1dec
On Sat, 28 Jul 2012 13:13:37 +0200, Diego Biurrun wrote:
> On Sat, Jul 28, 2012 at 12:42:25PM +0200, Anton Khirnov wrote:
> >
> > --- a/libavformat/wv.c
> > +++ b/libavformat/wv.c
> > @@ -87,27 +87,27 @@ static int wv_read_block_header(AVFormatContext *ctx,
> > AVIOContext *pb, int appen
> >
Derek Buitenhuis writes:
> On 27/07/2012 5:55 PM, Mans Rullgard wrote:
>> There is no sense in pulling in this monster struct just for
>> a handful of fields. The code does not call any functions
>> expecting an MpegEncContext.
>>
>> Signed-off-by: Mans Rullgard
>> ---
>> libavcodec/eamad.c |
On Sat, Jul 28, 2012 at 05:25:58PM +0600, Mashiat Sarker Shakkhar wrote:
> From: Michael Niedermayer
>
> Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
> Signed-off-by: Michael Niedermayer
> ---
> libavcodec/vc1dec.c |5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/liba
From: Michael Niedermayer
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer
---
libavcodec/vc1dec.c |5 +
1 file changed, 5 insertions(+)
diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c
index f49fff8..0c031b7 100644
--- a/libavcodec/vc1dec
On Sat, Jul 28, 2012 at 05:14:49PM +0600, Mashiat Sarker Shakkhar wrote:
>
> --- a/libavcodec/vc1dec.c
> +++ b/libavcodec/vc1dec.c
> @@ -1048,6 +1048,11 @@ static void vc1_mc_4mv_chroma4(VC1Context *v)
> if ((edges&8) && s->mb_y == (s->mb_height - 1))\
> mquant = v->a
From: Anton Khirnov
---
libavformat/wv.c | 175 +
1 files changed, 96 insertions(+), 79 deletions(-)
diff --git a/libavformat/wv.c b/libavformat/wv.c
index b311449..3fd1abc 100644
--- a/libavformat/wv.c
+++ b/libavformat/wv.c
@@ -36,7 +36,7 @
From: Michael Niedermayer
This fixes out of array writes
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer
---
libavcodec/vc1dec.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c
index 0c031b7..0027b
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer
---
libavcodec/vc1dec.c |5 +
1 file changed, 5 insertions(+)
diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c
index f49fff8..0c031b7 100644
--- a/libavcodec/vc1dec.c
+++ b/libavcodec/vc1dec.c
From: Michael Niedermayer
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer
---
libavcodec/vc1dec.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c
index 51124cf..f49fff8 1006
On Sat, Jul 28, 2012 at 12:42:25PM +0200, Anton Khirnov wrote:
>
> --- a/libavformat/wv.c
> +++ b/libavformat/wv.c
> @@ -87,27 +87,27 @@ static int wv_read_block_header(AVFormatContext *ctx,
> AVIOContext *pb, int appen
>
> -if(size < 24 || size > WV_BLOCK_LIMIT){
> +if (size <
On Sat, Jul 28, 2012 at 12:42:24PM +0200, Anton Khirnov wrote:
> ---
> libavformat/wv.c | 45 +++--
> 1 file changed, 23 insertions(+), 22 deletions(-)
OK
Diego
___
libav-devel mailing list
libav-devel@libav.or
On Sat, Jul 28, 2012 at 12:42:23PM +0200, Anton Khirnov wrote:
> ---
> libavformat/wv.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
OK
Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/liba
On Sat, Jul 28, 2012 at 12:42:22PM +0200, Anton Khirnov wrote:
> Don't invent a bogus EIO error.
>
> The code now doesn't check for ret == 0, but that check is redundant,
> av_get_packet() never returns 0.
> ---
> libavformat/mp3dec.c |5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-
On Sat, Jul 28, 2012 at 12:42:21PM +0200, Anton Khirnov wrote:
> ---
> libavformat/mp3dec.c |6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
OK
Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/lis
On Sat, Jul 28, 2012 at 12:42:20PM +0200, Anton Khirnov wrote:
> ---
> libavformat/mp3dec.c |1 -
> 1 file changed, 1 deletion(-)
OK
Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
---
libavformat/wv.c | 145 +-
1 file changed, 68 insertions(+), 77 deletions(-)
diff --git a/libavformat/wv.c b/libavformat/wv.c
index b311449..43790f1 100644
--- a/libavformat/wv.c
+++ b/libavformat/wv.c
@@ -36,7 +36,7 @@
#define WV_END_BLOC
---
libavformat/wv.c | 45 +++--
1 file changed, 23 insertions(+), 22 deletions(-)
diff --git a/libavformat/wv.c b/libavformat/wv.c
index 0b6a406..b311449 100644
--- a/libavformat/wv.c
+++ b/libavformat/wv.c
@@ -90,17 +90,17 @@ static int wv_read_block_he
Don't invent a bogus EIO error.
The code now doesn't check for ret == 0, but that check is redundant,
av_get_packet() never returns 0.
---
libavformat/mp3dec.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c
index 11e684d..a2
---
libavformat/wv.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/wv.c b/libavformat/wv.c
index 49ca486..0b6a406 100644
--- a/libavformat/wv.c
+++ b/libavformat/wv.c
@@ -254,7 +254,7 @@ static int wv_read_packet(AVFormatContext *s,
uint32_t block_samples;
---
libavformat/mp3dec.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c
index 4344e8e..11e684d 100644
--- a/libavformat/mp3dec.c
+++ b/libavformat/mp3dec.c
@@ -185,11 +185,9 @@ static int mp3_read_header(AVFormatContext *s)
---
libavformat/mp3dec.c |1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c
index 3987520..4344e8e 100644
--- a/libavformat/mp3dec.c
+++ b/libavformat/mp3dec.c
@@ -186,7 +186,6 @@ static int mp3_read_header(AVFormatContext *s)
static int mp3_read_pac
On Fri, Jul 27, 2012 at 09:33:41AM -0700, Ronald S. Bultje wrote:
> From: Loren Merritt
>
> This allows us to unconditionally set the cglobal num_args
> parameter to a bigger value, thus making writing yasm code
> even easier than before.
>
> Signed-off-by: Ronald S. Bultje
> ---
> libavutil/x
From: Michael Niedermayer
Fixes overread
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer
---
libavcodec/vc1dec.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c
index 51124cf..3f
On Thu, Jul 26, 2012 at 08:26:17PM -0700, Ronald S. Bultje wrote:
> From: "Ronald S. Bultje"
>
> ---
> libavutil/x86/x86inc.asm | 216
> ++
> 1 file changed, 124 insertions(+), 92 deletions(-)
It does LGTM from my limited perspective. Since I guess
1 - 100 of 113 matches
Mail list logo
