[libav-devel] [PATCH 09/10] idcin: check for EOF before reading video chunk size

2012-08-01 Thread Justin Ruggles
--- libavformat/idcin.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libavformat/idcin.c b/libavformat/idcin.c index 2d506ff..bffa2f4 100644 --- a/libavformat/idcin.c +++ b/libavformat/idcin.c @@ -278,6 +278,8 @@ static int idcin_read_packet(AVFormatContext *s,

[libav-devel] [PATCH 10/10] idcin: return 0 from idcin_read_packet() on success.

2012-08-01 Thread Justin Ruggles
This matches the AVInputFormat.read_packet() API. --- libavformat/idcin.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/idcin.c b/libavformat/idcin.c index bffa2f4..dea4f91 100644 --- a/libavformat/idcin.c +++ b/libavformat/idcin.c @@ -321,7 +321,7 @@

Re: [libav-devel] [PATCH] msvc: check for snprintf

2012-08-01 Thread Ronald S. Bultje
Hi, On Wed, Aug 1, 2012 at 2:31 PM, Uoti Urpala uoti.urp...@pp1.inet.fi wrote: On Wed, 2012-08-01 at 21:55 +0100, Måns Rullgård wrote: Uoti Urpala uoti.urp...@pp1.inet.fi writes: On Wed, 2012-08-01 at 21:34 +0100, Måns Rullgård wrote: It is not possible to get those semantics using the

Re: [libav-devel] [PATCH] msvc: check for snprintf

2012-08-01 Thread Måns Rullgård
Uoti Urpala uoti.urp...@pp1.inet.fi writes: On Wed, 2012-08-01 at 21:49 +0100, Måns Rullgård wrote: Uoti Urpala uoti.urp...@pp1.inet.fi writes: On Wed, 2012-08-01 at 21:22 +0100, Måns Rullgård wrote: +int snprintf(char *buffer, size_t bufsize, const char *fmt, ...) +if

Re: [libav-devel] [PATCH] msvc: check for snprintf

2012-08-01 Thread Uoti Urpala
On Wed, 2012-08-01 at 14:36 -0700, Ronald S. Bultje wrote: On Wed, Aug 1, 2012 at 2:31 PM, Uoti Urpala uoti.urp...@pp1.inet.fi wrote: On Wed, 2012-08-01 at 21:55 +0100, Måns Rullgård wrote: If you insist on arguing, I politely request that you at least be right. If you get to that level

[libav-devel] [PATCH] fate: Only test enabled filters

2012-08-01 Thread Diego Biurrun
This fixes running FATE without --enable-gpl. --- tests/Makefile|3 ++- tests/fate/filter.mak | 18 +- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index 0b11102..2ab529e 100644 --- a/tests/Makefile +++

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-08-01 Thread Diego Biurrun
On Wed, Aug 01, 2012 at 07:41:01AM -0700, Ronald S. Bultje wrote: On Wed, Aug 1, 2012 at 5:30 AM, Diego Biurrun di...@biurrun.de wrote: --- a/libavcodec/x86/fft_mmx.asm +++ b/libavcodec/x86/fft_mmx.asm @@ -105,7 +105,8 @@ SECTION_TEXT pxor %3, [ps_m1p1] ; {t8,t7} mova

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-08-01 Thread Diego Biurrun
On Wed, Aug 01, 2012 at 10:57:47AM -0700, Ronald S. Bultje wrote: On Wed, Aug 1, 2012 at 10:53 AM, Diego Biurrun di...@biurrun.de wrote: +%macro PSWAPD 2 +%if cpuflag(sse) +pshufw %1, %2, 0x4e As Loren said earlier, this is mmx2, not sse. Rebase screwup, I had this fixed at some

[libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-08-01 Thread Diego Biurrun
--- libavcodec/x86/fft_mmx.asm| 16 ++-- libavcodec/x86/fmtconvert.asm | 17 ++--- libavutil/x86/x86util.asm | 12 3 files changed, 16 insertions(+), 29 deletions(-) diff --git a/libavcodec/x86/fft_mmx.asm b/libavcodec/x86/fft_mmx.asm index

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-08-01 Thread Ronald S. Bultje
Hi, On Wed, Aug 1, 2012 at 3:55 PM, Diego Biurrun di...@biurrun.de wrote: +%macro PSWAPD 2 +%if cpuflag(mmxext) +pshufw %1, %2, 0x4e If you change 0x4e to q1032, patch is OK with me. Ronald ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] fate: Only test enabled filters

2012-08-01 Thread Luca Barbato
On 02/08/12 00:39, Diego Biurrun wrote: This fixes running FATE without --enable-gpl. --- tests/Makefile|3 ++- tests/fate/filter.mak | 18 +- 2 files changed, 11 insertions(+), 10 deletions(-) Looks ok. ___

Re: [libav-devel] [PATCH 01/10] idcinvideo: correctly set AVFrame defaults

2012-08-01 Thread Luca Barbato
On 01/08/12 23:36, Justin Ruggles wrote: --- libavcodec/idcinvideo.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/idcinvideo.c b/libavcodec/idcinvideo.c index c936ebb..65414ee 100644 --- a/libavcodec/idcinvideo.c +++ b/libavcodec/idcinvideo.c @@

Re: [libav-devel] [PATCH 04/10] idcin: set channel_layout

2012-08-01 Thread Alex Converse
On Wed, Aug 1, 2012 at 2:36 PM, Justin Ruggles justin.rugg...@gmail.com wrote: --- libavformat/idcin.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/libavformat/idcin.c b/libavformat/idcin.c index 113c66e..c8b8225 100644 --- a/libavformat/idcin.c +++

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-08-01 Thread Loren Merritt
On Thu, 2 Aug 2012, Diego Biurrun wrote: On Wed, Aug 01, 2012 at 07:41:01AM -0700, Ronald S. Bultje wrote: On Wed, Aug 1, 2012 at 5:30 AM, Diego Biurrun di...@biurrun.de wrote: --- a/libavcodec/x86/fft_mmx.asm +++ b/libavcodec/x86/fft_mmx.asm @@ -105,7 +105,8 @@ SECTION_TEXT pxor

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

2012-08-01 Thread Ronald S. Bultje
Hi, On Wed, Aug 1, 2012 at 5:38 PM, Loren Merritt lor...@u.washington.edu wrote: On Thu, 2 Aug 2012, Diego Biurrun wrote: On Wed, Aug 01, 2012 at 07:41:01AM -0700, Ronald S. Bultje wrote: On Wed, Aug 1, 2012 at 5:30 AM, Diego Biurrun di...@biurrun.de wrote: --- a/libavcodec/x86/fft_mmx.asm

Re: [libav-devel] [PATCH] fate: Only test enabled filters

2012-08-01 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: This fixes running FATE without --enable-gpl. --- tests/Makefile|3 ++- tests/fate/filter.mak | 18 +- 2 files changed, 11 insertions(+), 10 deletions(-) Your patch makes me notice that that file needs a rather different

Re: [libav-devel] [PATCH 2/2] rtmp: Prevent handling of an incorrect invoke packet

2012-08-01 Thread Luca Barbato
On 01/08/12 22:44, Luca Barbato wrote: On 01/08/12 12:13, Samuel Pitoiset wrote: --- libavformat/rtmpproto.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 6044425..8c0ecb2 100644 ---

[libav-devel] [PATCH] wmapro: prevent division by zero when sample rate is unspecified

2012-08-01 Thread Sean McGovern
This fixes Bugzilla #327: --- libavcodec/wmaprodec.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/libavcodec/wmaprodec.c b/libavcodec/wmaprodec.c index 30a43c8..88c33c3 100644 --- a/libavcodec/wmaprodec.c +++ b/libavcodec/wmaprodec.c @@ -335,6 +335,11 @@ static

Re: [libav-devel] [PATCH 2/2] h264: convert 8-bit qpel inlined assembly to yasm

2012-08-01 Thread Daniel Kang
On Wed, Aug 1, 2012 at 5:22 AM, Måns Rullgård m...@mansr.com wrote: Daniel Kang daniel.d.k...@gmail.com writes: Can I have access to a setup that doesn't have inlined assembly? --extra-cflags=-D__asm__=error should make it fail nicely. This gives me bizarre errors like:

[libav-devel] [PATCH 1/2] H264: Remove 3dnow qpel code.

2012-08-01 Thread daniel . d . kang
From: Daniel Kang daniel.d.k...@gmail.com The only CPUs that have 3dnow and don't have mmxext are 12 years old. --- libavcodec/x86/dsputil_mmx.c | 11 ++- libavcodec/x86/dsputil_mmx_avg_template.c |8 ++-- libavcodec/x86/h264_qpel_mmx.c|4 3

Re: [libav-devel] [PATCH 2/2] H.264: Convert 8-bit qpel inlined assembly to yasm

2012-08-01 Thread Daniel Kang
On Thu, Aug 2, 2012 at 1:30 AM, daniel.d.k...@gmail.com wrote: From: Daniel Kang daniel.d.k...@gmail.com --- libavcodec/x86/Makefile |3 +- libavcodec/x86/dsputil_mmx.c| 81 +--- libavcodec/x86/dsputil_yasm.asm | 42 ++ libavcodec/x86/h264_qpel.asm| 850

Re: [libav-devel] [PATCH 2/2] h264: convert 8-bit qpel inlined assembly to yasm

2012-08-01 Thread Ronald S. Bultje
Hi, On Wed, Aug 1, 2012 at 10:29 PM, Daniel Kang daniel.d.k...@gmail.com wrote: On Wed, Aug 1, 2012 at 5:22 AM, Måns Rullgård m...@mansr.com wrote: Daniel Kang daniel.d.k...@gmail.com writes: Can I have access to a setup that doesn't have inlined assembly? --extra-cflags=-D__asm__=error

<    1   2