Re: [libav-devel] [PATCH] avcodec: fix memleak in avcodec_encode_audio2()

2012-09-21 Thread Justin Ruggles
On 08/24/2012 04:30 PM, Justin Ruggles wrote: > Ensure that padded_frame is freed before returning when needed. > --- > libavcodec/utils.c |9 ++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index b5b0466..4fffca8 100644

Re: [libav-devel] [PATCH 03/15] avconv: correctly set next_dts for audio and rescale to AV_TIME_BASE

2012-09-21 Thread Justin Ruggles
On 09/19/2012 06:53 PM, Justin Ruggles wrote: > --- > avconv.c |6 +- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/avconv.c b/avconv.c > index e07a2cd..acb4994 100644 > --- a/avconv.c > +++ b/avconv.c > @@ -1084,11 +1084,15 @@ static int decode_audio(InputStream *is

Re: [libav-devel] [PATCH 09/15] vorbisdec: do not discard the first decoded frame

2012-09-21 Thread Justin Ruggles
On 09/20/2012 04:03 AM, Luca Barbato wrote: > On 09/20/2012 12:53 AM, Justin Ruggles wrote: >> Due to seeking, the decoder should not assume anything about the ordering of >> the packets. The first packet received could be in the middle of the stream, >> or the user could seek back to the start of

Re: [libav-devel] [PATCH] swscale: Add support for unscaled Planar RGB -> Packed RGB

2012-09-21 Thread Derek Buitenhuis
On 21/09/2012 10:38 PM, Derek Buitenhuis wrote: >> Signed-off-by: Derek Buitenhuis >> --- >> Shame? I feel no shame. >> --- >> libswscale/swscale_unscaled.c | 151 >> + >> libswscale/utils.c|2 +- >> 2 files changed, 152 insertions(+), 1 d

Re: [libav-devel] [PATCH] swscale: Add support for unscaled Planar RGB -> Packed RGB

2012-09-21 Thread Derek Buitenhuis
On 21/09/2012 10:34 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > Shame? I feel no shame. > --- > libswscale/swscale_unscaled.c | 151 > + > libswscale/utils.c|2 +- > 2 files changed, 152 insertions(+), 1 deletion(

[libav-devel] [PATCH] swscale: Add support for unscaled Planar RGB -> Packed RGB

2012-09-21 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- Shame? I feel no shame. --- libswscale/swscale_unscaled.c | 151 + libswscale/utils.c|2 +- 2 files changed, 152 insertions(+), 1 deletion(-) diff --git a/libswscale/swscale_unscaled.c b/libswscale/swsca

Re: [libav-devel] [PATCH 09/31] iac: use planar sample format

2012-09-21 Thread Benjamin Larsson
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 08/31] dcadec: use float planar sample format

2012-09-21 Thread Benjamin Larsson
LGTM ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 07/31] cook: use planar sample format

2012-09-21 Thread Benjamin Larsson
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 06/31] atrac3: use float planar sample format

2012-09-21 Thread Benjamin Larsson
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/4] ogg: check that the expected number of headers had been parsed

2012-09-21 Thread Justin Ruggles
On 09/20/2012 03:51 AM, Luca Barbato wrote: > diff --git a/libavformat/oggparseflac.c b/libavformat/oggparseflac.c > index 9860a0e..c4928d0 100644 > --- a/libavformat/oggparseflac.c > +++ b/libavformat/oggparseflac.c > @@ -88,11 +88,13 @@ old_flac_header (AVFormatContext * s, int idx) > const stru

Re: [libav-devel] [PATCH 22/31] adpcmdec: set AVCodec.sample_fmts

2012-09-21 Thread Kostya Shishkov
On Fri, Sep 21, 2012 at 11:23:50AM -0400, Justin Ruggles wrote: > --- > libavcodec/adpcm.c | 60 +++ > 1 files changed, 32 insertions(+), 28 deletions(-) looks OK ___ libav-devel mailing list libav-devel

Re: [libav-devel] [PATCH 15/31] ralf: use planar sample format

2012-09-21 Thread Kostya Shishkov
On Fri, Sep 21, 2012 at 11:23:43AM -0400, Justin Ruggles wrote: > --- > libavcodec/ralf.c | 35 --- > 1 files changed, 20 insertions(+), 15 deletions(-) LGTM ___ libav-devel mailing list libav-devel@libav.org https://li

Re: [libav-devel] [PATCH 11/31] mpc7/8: use planar sample format

2012-09-21 Thread Kostya Shishkov
On Fri, Sep 21, 2012 at 11:23:39AM -0400, Justin Ruggles wrote: > --- > libavcodec/mpc.c | 14 +- > libavcodec/mpc.h |2 +- > libavcodec/mpc7.c |6 -- > libavcodec/mpc8.c |7 +-- > 4 files changed, 15 insertions(+), 14 deletions(-) LGTM

Re: [libav-devel] [PATCH 09/31] iac: use planar sample format

2012-09-21 Thread Kostya Shishkov
On Fri, Sep 21, 2012 at 11:23:37AM -0400, Justin Ruggles wrote: > --- > libavcodec/imc.c | 26 +++--- > 1 files changed, 11 insertions(+), 15 deletions(-) mention IMC in the commit message too, otherwise LGTM ___ libav-devel mailin

Re: [libav-devel] [PATCH 08/31] dcadec: use float planar sample format

2012-09-21 Thread Kostya Shishkov
On Fri, Sep 21, 2012 at 11:23:36AM -0400, Justin Ruggles wrote: > --- > libavcodec/dcadec.c | 119 > +-- > 1 files changed, 49 insertions(+), 70 deletions(-) LGTM ___ libav-devel mailing list libav-devel

Re: [libav-devel] [PATCH 04/31] apedec: output in planar sample format

2012-09-21 Thread Kostya Shishkov
On Fri, Sep 21, 2012 at 11:23:32AM -0400, Justin Ruggles wrote: > --- > libavcodec/apedec.c | 39 --- > 1 files changed, 20 insertions(+), 19 deletions(-) LGTM ___ libav-devel mailing list libav-devel@libav.org http

Re: [libav-devel] [PATCH 02/31] 8svx: use planar sample format

2012-09-21 Thread Kostya Shishkov
On Fri, Sep 21, 2012 at 11:23:30AM -0400, Justin Ruggles wrote: > --- > libavcodec/8svx.c | 51 +++ > 1 files changed, 23 insertions(+), 28 deletions(-) LGTM ___ libav-devel mailing list libav-devel@liba

[libav-devel] [PATCH 06/31] atrac3: use float planar sample format

2012-09-21 Thread Justin Ruggles
--- also forgot to remove unused samples_flt in atrac3_decode_frame() libavcodec/atrac3.c | 44 +++- 1 files changed, 7 insertions(+), 37 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index a09007c..94b355a 100644 --- a/libavcodec/a

[libav-devel] [PATCH 06/31] atrac3: use float planar sample format

2012-09-21 Thread Justin Ruggles
--- Forgot to remove unneeded is_float in init_atrac3_transforms() libavcodec/atrac3.c | 45 - 1 files changed, 8 insertions(+), 37 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index a09007c..7f23a15 100644 --- a/libavcodec/atr

[libav-devel] [PATCH 19/31] wmadec: use float planar sample format output

2012-09-21 Thread Justin Ruggles
--- libavcodec/wmadec.c | 65 ++- 1 files changed, 28 insertions(+), 37 deletions(-) diff --git a/libavcodec/wmadec.c b/libavcodec/wmadec.c index 5ee3742..76e5c3c 100644 --- a/libavcodec/wmadec.c +++ b/libavcodec/wmadec.c @@ -48,20 +48,6 @@ stati

[libav-devel] [PATCH 30/31] adpcmdec: use planar sample format for adpcm_thp

2012-09-21 Thread Justin Ruggles
--- libavcodec/adpcm.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index e3b9b24..2226b58 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -144,6 +144,7 @@ static av_cold int adpcm_decode_init(AVCodecContext *

[libav-devel] [PATCH 31/31] adxdec: use planar sample format

2012-09-21 Thread Justin Ruggles
--- libavcodec/adxdec.c | 21 + 1 files changed, 13 insertions(+), 8 deletions(-) diff --git a/libavcodec/adxdec.c b/libavcodec/adxdec.c index 96847c0..4d2892b 100644 --- a/libavcodec/adxdec.c +++ b/libavcodec/adxdec.c @@ -49,7 +49,7 @@ static av_cold int adx_decode_init(AVC

[libav-devel] [PATCH 29/31] adpcmdec: use planar sample format for adpcm_ea_xas

2012-09-21 Thread Justin Ruggles
--- libavcodec/adpcm.c | 28 1 files changed, 16 insertions(+), 12 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 2ef845b..e3b9b24 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -143,6 +143,7 @@ static av_cold int adpcm_decode_i

[libav-devel] [PATCH 28/31] adpcmdec: use planar sample format for adpcm_ea_r1/r2/r3

2012-09-21 Thread Justin Ruggles
--- libavcodec/adpcm.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 8c6252d..2ef845b 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -140,6 +140,9 @@ static av_cold int adpcm_decode_init(AVCo

[libav-devel] [PATCH 27/31] adpcmdec: use planar sample format for adpcm_xa

2012-09-21 Thread Justin Ruggles
--- libavcodec/adpcm.c | 44 1 files changed, 28 insertions(+), 16 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 12bf86f..8c6252d 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -139,6 +139,7 @@ static av_cold in

[libav-devel] [PATCH 26/31] adpcmdec: use planar sample format for adpcm_ima_ws for vqa version 3

2012-09-21 Thread Justin Ruggles
--- libavcodec/adpcm.c | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index b1ce2c5..12bf86f 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -141,6 +141,10 @@ static av_cold int adpcm_decode_init(AVCodec

[libav-devel] [PATCH 25/31] adpcmdec: use planar sample format for adpcm_4xm

2012-09-21 Thread Justin Ruggles
--- libavcodec/adpcm.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index dc055aa..b1ce2c5 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -138,6 +138,7 @@ static av_cold int adpcm_decode_init(AVCodecContext

[libav-devel] [PATCH 24/31] adpcmdec: use planar sample format for adpcm_ima_wav

2012-09-21 Thread Justin Ruggles
--- libavcodec/adpcm.c | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 4a9b1b4..dc055aa 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -137,6 +137,7 @@ static av_cold int adpcm_decode_init(AVCodec

[libav-devel] [PATCH 23/31] adpcmdec: use planar sample format for adpcm_ima_qt

2012-09-21 Thread Justin Ruggles
--- libavcodec/adpcm.c | 25 + 1 files changed, 17 insertions(+), 8 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 2ff961e..4a9b1b4 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -134,7 +134,14 @@ static av_cold int adpcm_decode_init

[libav-devel] [PATCH 22/31] adpcmdec: set AVCodec.sample_fmts

2012-09-21 Thread Justin Ruggles
--- libavcodec/adpcm.c | 60 +++ 1 files changed, 32 insertions(+), 28 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 19772b0..2ff961e 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -1266,7 +1266,10 @@ static

[libav-devel] [PATCH 21/31] wmapro: use planar sample format

2012-09-21 Thread Justin Ruggles
--- libavcodec/wmaprodec.c | 15 +-- 1 files changed, 5 insertions(+), 10 deletions(-) diff --git a/libavcodec/wmaprodec.c b/libavcodec/wmaprodec.c index 60d39be..339a454 100644 --- a/libavcodec/wmaprodec.c +++ b/libavcodec/wmaprodec.c @@ -94,7 +94,6 @@ #include "put_bits.h" #incl

[libav-devel] [PATCH 20/31] wmalossless: output in planar sample format

2012-09-21 Thread Justin Ruggles
--- libavcodec/wmalosslessdec.c | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index 56e9aad..300c66a 100644 --- a/libavcodec/wmalosslessdec.c +++ b/libavcodec/wmalosslessdec.c @@ -184,9 +184,9 @@ s

[libav-devel] [PATCH 18/31] vorbisdec: use float planar sample format

2012-09-21 Thread Justin Ruggles
--- libavcodec/vorbisdec.c | 28 1 files changed, 8 insertions(+), 20 deletions(-) diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c index f5a541a..ab6017b 100644 --- a/libavcodec/vorbisdec.c +++ b/libavcodec/vorbisdec.c @@ -153,7 +153,6 @@ typedef struct

[libav-devel] [PATCH 17/31] twinvq: use planar sample format

2012-09-21 Thread Justin Ruggles
--- libavcodec/twinvq.c | 31 --- 1 files changed, 12 insertions(+), 19 deletions(-) diff --git a/libavcodec/twinvq.c b/libavcodec/twinvq.c index ab22f64..d009196 100644 --- a/libavcodec/twinvq.c +++ b/libavcodec/twinvq.c @@ -666,7 +666,7 @@ static void imdct_and_win

[libav-devel] [PATCH 16/31] shorten: use planar sample format

2012-09-21 Thread Justin Ruggles
--- libavcodec/shorten.c | 23 ++- 1 files changed, 14 insertions(+), 9 deletions(-) diff --git a/libavcodec/shorten.c b/libavcodec/shorten.c index fb48070..1664a90 100644 --- a/libavcodec/shorten.c +++ b/libavcodec/shorten.c @@ -112,7 +112,7 @@ static av_cold int shorten_de

[libav-devel] [PATCH 14/31] pcmdec: use planar sample format for pcm_lxf

2012-09-21 Thread Justin Ruggles
--- libavcodec/pcm.c | 33 +++-- 1 files changed, 15 insertions(+), 18 deletions(-) diff --git a/libavcodec/pcm.c b/libavcodec/pcm.c index 895f72f..9f12614 100644 --- a/libavcodec/pcm.c +++ b/libavcodec/pcm.c @@ -444,26 +444,23 @@ static int pcm_decode_frame(AVCodecC

[libav-devel] [PATCH 15/31] ralf: use planar sample format

2012-09-21 Thread Justin Ruggles
--- libavcodec/ralf.c | 35 --- 1 files changed, 20 insertions(+), 15 deletions(-) diff --git a/libavcodec/ralf.c b/libavcodec/ralf.c index 6866f79..3244424 100644 --- a/libavcodec/ralf.c +++ b/libavcodec/ralf.c @@ -149,7 +149,7 @@ static av_cold int decode_init(

[libav-devel] [PATCH 13/31] pcmdec: use planar sample format for pcm_s16le_planar

2012-09-21 Thread Justin Ruggles
--- libavcodec/pcm.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/libavcodec/pcm.c b/libavcodec/pcm.c index 24272d2..895f72f 100644 --- a/libavcodec/pcm.c +++ b/libavcodec/pcm.c @@ -339,15 +339,16 @@ static int pcm_decode_frame(AVCodecContext *avctx,

[libav-devel] [PATCH 12/31] mpegaudiodec: use planar sample format

2012-09-21 Thread Justin Ruggles
--- libavcodec/mpegaudiodec.c | 67 +- libavcodec/mpegaudiodec_float.c | 10 ++ 2 files changed, 33 insertions(+), 44 deletions(-) diff --git a/libavcodec/mpegaudiodec.c b/libavcodec/mpegaudiodec.c index 03094f6..2fb0e9d 100644 --- a/libavcodec/mp

[libav-devel] [PATCH 11/31] mpc7/8: use planar sample format

2012-09-21 Thread Justin Ruggles
--- libavcodec/mpc.c | 14 +- libavcodec/mpc.h |2 +- libavcodec/mpc7.c |6 -- libavcodec/mpc8.c |7 +-- 4 files changed, 15 insertions(+), 14 deletions(-) diff --git a/libavcodec/mpc.c b/libavcodec/mpc.c index 6b15a33..5a54a9b 100644 --- a/libavcodec/mpc.c +++

[libav-devel] [PATCH 10/31] mace: use planar sample format

2012-09-21 Thread Justin Ruggles
--- libavcodec/mace.c | 32 +++- 1 files changed, 15 insertions(+), 17 deletions(-) diff --git a/libavcodec/mace.c b/libavcodec/mace.c index 9d07180..8fef839 100644 --- a/libavcodec/mace.c +++ b/libavcodec/mace.c @@ -187,9 +187,7 @@ static int16_t read_table(ChannelD

[libav-devel] [PATCH 08/31] dcadec: use float planar sample format

2012-09-21 Thread Justin Ruggles
--- libavcodec/dcadec.c | 119 +-- 1 files changed, 49 insertions(+), 70 deletions(-) diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c index 6b0812c..aecb903 100644 --- a/libavcodec/dcadec.c +++ b/libavcodec/dcadec.c @@ -354,11 +354,9 @@ type

[libav-devel] [PATCH 09/31] iac: use planar sample format

2012-09-21 Thread Justin Ruggles
--- libavcodec/imc.c | 26 +++--- 1 files changed, 11 insertions(+), 15 deletions(-) diff --git a/libavcodec/imc.c b/libavcodec/imc.c index e452baf..73052e8 100644 --- a/libavcodec/imc.c +++ b/libavcodec/imc.c @@ -241,7 +241,7 @@ static av_cold int imc_decode_init(AVCodecCon

[libav-devel] [PATCH 07/31] cook: use planar sample format

2012-09-21 Thread Justin Ruggles
--- libavcodec/cook.c | 40 ++-- 1 files changed, 22 insertions(+), 18 deletions(-) diff --git a/libavcodec/cook.c b/libavcodec/cook.c index 0e7c497..2c4b3bf 100644 --- a/libavcodec/cook.c +++ b/libavcodec/cook.c @@ -119,9 +119,10 @@ typedef struct cook {

[libav-devel] [PATCH 06/31] atrac3: use float planar sample format

2012-09-21 Thread Justin Ruggles
--- libavcodec/atrac3.c | 41 ++--- 1 files changed, 6 insertions(+), 35 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index a09007c..ac510b9 100644 --- a/libavcodec/atrac3.c +++ b/libavcodec/atrac3.c @@ -111,7 +111,6 @@ typedef struct {

[libav-devel] [PATCH 03/31] aacdec: add float planar sample format output

2012-09-21 Thread Justin Ruggles
--- libavcodec/aacdec.c | 36 +--- libavcodec/aacsbr.c |5 ++--- 2 files changed, 15 insertions(+), 26 deletions(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index 1c59ec5..385c8ae 100644 --- a/libavcodec/aacdec.c +++ b/libavcodec/aacdec.c @@ -84

[libav-devel] [PATCH 04/31] apedec: output in planar sample format

2012-09-21 Thread Justin Ruggles
--- libavcodec/apedec.c | 39 --- 1 files changed, 20 insertions(+), 19 deletions(-) diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c index 5917903..9d2941c 100644 --- a/libavcodec/apedec.c +++ b/libavcodec/apedec.c @@ -196,13 +196,13 @@ static av_cold

[libav-devel] [PATCH 05/31] atrac1: use planar sample format

2012-09-21 Thread Justin Ruggles
--- libavcodec/atrac1.c | 29 - 1 files changed, 4 insertions(+), 25 deletions(-) diff --git a/libavcodec/atrac1.c b/libavcodec/atrac1.c index ec4b7c1..7e78c73 100644 --- a/libavcodec/atrac1.c +++ b/libavcodec/atrac1.c @@ -36,7 +36,6 @@ #include "get_bits.h" #inclu

[libav-devel] [PATCH 02/31] 8svx: use planar sample format

2012-09-21 Thread Justin Ruggles
--- libavcodec/8svx.c | 51 +++ 1 files changed, 23 insertions(+), 28 deletions(-) diff --git a/libavcodec/8svx.c b/libavcodec/8svx.c index 328fc65..1839617 100644 --- a/libavcodec/8svx.c +++ b/libavcodec/8svx.c @@ -58,30 +58,25 @@ static const in

[libav-devel] [PATCH 01/31] avconv: improve sample format negotiation for decoder request

2012-09-21 Thread Justin Ruggles
This takes into account planar vs. packed when comparing to find the closest sample format match. --- avconv.c | 33 ++--- 1 files changed, 26 insertions(+), 7 deletions(-) diff --git a/avconv.c b/avconv.c index df09b21..956c1fa 100644 --- a/avconv.c +++ b/avconv.c @

[libav-devel] [PATCH 00/31] planar sample format for decoders

2012-09-21 Thread Justin Ruggles
This set does not include Mans' patches for AC-3, which would complete conversion for all audio decoders which should use planar output. Also, several functions will be able to be removed from dsputil and fmtconvert after these changes, but some should first be ported to libavresample before remov

Re: [libav-devel] [PATCH] sipr: fall back to setting mode based on bit_rate.

2012-09-21 Thread Justin Ruggles
On 09/21/2012 10:31 AM, Reinhard Tartler wrote: > On Tue, Sep 4, 2012 at 7:03 PM, Reinhard Tartler wrote: >> Not all applications (e.g. MPlayer) set block_align, and >> when using a different demuxer it might not even be >> easily available. >> >> Therefore fall back to selecting mode based on bit

Re: [libav-devel] [PATCH] sipr: fall back to setting mode based on bit_rate.

2012-09-21 Thread Reinhard Tartler
On Tue, Sep 4, 2012 at 7:03 PM, Reinhard Tartler wrote: > Not all applications (e.g. MPlayer) set block_align, and > when using a different demuxer it might not even be > easily available. > > Therefore fall back to selecting mode based on bit rate as before if > block_align has not useful value.

Re: [libav-devel] [PATCH] libx264: add forgotten ;

2012-09-21 Thread Luca Barbato
Fine -- Sent from my Android phone with K-9 Mail. Please excuse my brevity.___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 6/6] Use avcodec_free_frame() to free AVFrames.

2012-09-21 Thread Luca Barbato
Ok -- Sent from my Android phone with K-9 Mail. Please excuse my brevity.___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 5/6] lavf: use a malloced AVFrame in try_decode_frame().

2012-09-21 Thread Luca Barbato
Ok if fate-valgring is happy -- Sent from my Android phone with K-9 Mail. Please excuse my brevity.___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 4/6] lavc: add avcodec_free_frame().

2012-09-21 Thread Anton Khirnov
On Fri, 21 Sep 2012 09:44:29 +0200, Luca Barbato wrote: > Do we have examples to update? Yes, see 6/6 -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] libx264: add forgotten ;

2012-09-21 Thread Martin Storsjö
On Fri, 21 Sep 2012, Anton Khirnov wrote: --- libavcodec/libx264.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 62815ce..0db8594 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -69,7 +69,7 @@ typedef struc

Re: [libav-devel] [PATCH 4/6] lavc: add avcodec_free_frame().

2012-09-21 Thread Luca Barbato
Do we have examples to update? -- Sent from my Android phone with K-9 Mail. Please excuse my brevity.___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/6] lavc: ensure extended_data is set properly on decoding

2012-09-21 Thread Luca Barbato
Make it "it is" instead of "it's". The rest looks fine. -- Sent from my Android phone with K-9 Mail. Please excuse my brevity.___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/6] lavc: initialize AVFrame.extended_data in avcodec_get_frame_defaults()

2012-09-21 Thread Luca Barbato
Ok -- Sent from my Android phone with K-9 Mail. Please excuse my brevity.___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/6] lavc: rename the argument of avcodec_alloc_frame/get_frame_defaults

2012-09-21 Thread Luca Barbato
Ok -- Sent from my Android phone with K-9 Mail. Please excuse my brevity.___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] libx264: add forgotten ;

2012-09-21 Thread Anton Khirnov
--- libavcodec/libx264.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 62815ce..0db8594 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -69,7 +69,7 @@ typedef struct X264Context { int direct_pred;

[libav-devel] [PATCH 6/6] Use avcodec_free_frame() to free AVFrames.

2012-09-21 Thread Anton Khirnov
--- avconv.c |4 ++-- avplay.c |4 ++-- libavcodec/api-example.c |8 libavfilter/vsrc_movie.c |2 +- libavformat/output-example.c |1 + 5 files changed, 10 insertions(+), 9 deletions(-) diff --git a/avconv.c b/avconv.c i

[libav-devel] [PATCH 4/6] lavc: add avcodec_free_frame().

2012-09-21 Thread Anton Khirnov
Since an AVFrame now has malloced members (extended_data), it must have a destructor. --- doc/APIchanges |4 libavcodec/avcodec.h | 14 +- libavcodec/utils.c | 15 +++ libavcodec/version.h |2 +- 4 files changed, 33 insertions(+), 2 deletions(-) di

[libav-devel] [PATCH 5/6] lavf: use a malloced AVFrame in try_decode_frame().

2012-09-21 Thread Anton Khirnov
This allows using avcodec_free_frame() to free it properly. --- libavformat/utils.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 64be7c8..f4f491f 100644 --- a/libavformat/utils.c +++ b/libavformat/u

[libav-devel] [PATCH 3/6] lavc: ensure extended_data is set properly on decoding

2012-09-21 Thread Anton Khirnov
--- libavcodec/utils.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 92ac2f8..8f8369b 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -1288,6 +1288,10 @@ int attribute_align_arg avcodec_decode_video2(AVCodecContext

[libav-devel] [PATCH 1/6] lavc: rename the argument of avcodec_alloc_frame/get_frame_defaults

2012-09-21 Thread Anton Khirnov
AVFrame is used for both audio and video, so calling the argument 'pic' is misleading. --- libavcodec/avcodec.h |4 ++-- libavcodec/utils.c | 20 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index c5cdf41.

[libav-devel] [PATCH 2/6] lavc: initialize AVFrame.extended_data in avcodec_get_frame_defaults()

2012-09-21 Thread Anton Khirnov
--- libavcodec/utils.c |4 1 file changed, 4 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index ec3177c..92ac2f8 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -641,6 +641,10 @@ void avcodec_get_frame_defaults(AVFrame *frame) frame->key_frame