Re: [libav-devel] [PATCH 1/6] smoothstreamingenc: Check the output UrlContext before accessing it

2012-10-06 Thread Luca Barbato
The patchset looks fine, push anytime. lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/4] fate: Add tests of the ff_make_absolute_url function

2012-10-06 Thread Diego Biurrun
On Sat, Oct 06, 2012 at 02:44:41AM +0300, Martin Storsjö wrote: On Sat, 6 Oct 2012, Diego Biurrun wrote: On Sat, Oct 06, 2012 at 02:05:21AM +0300, Martin Storsjö wrote: --- /dev/null +++ b/libavformat/url-test.c @@ -0,0 +1,55 @@ +/* + * Copyright (c) 2012 Martin Storsjo No 'ö'? I

[libav-devel] [PATCH] segment: support hls style playlist

2012-10-06 Thread Luca Barbato
--- libavformat/segment.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/libavformat/segment.c b/libavformat/segment.c index 8ac04e2..07bb675 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -37,6 +37,7 @@ typedef struct { AVFormatContext

[libav-devel] [PATCH] parseutils: fix parsing of invalid alpha values

2012-10-06 Thread Mans Rullgard
An alpha specifier outside the valid range results in a conversion from double to long with undefined result. Range-checking the double and only converting it after it passes avoids this. Fixes fate-parseutils errors on some systems. Signed-off-by: Mans Rullgard m...@mansr.com ---

Re: [libav-devel] [PATCH 1/4] fate: Add tests of the ff_make_absolute_url function

2012-10-06 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: On Sat, Oct 06, 2012 at 02:44:41AM +0300, Martin Storsjö wrote: On Sat, 6 Oct 2012, Diego Biurrun wrote: On Sat, Oct 06, 2012 at 02:05:21AM +0300, Martin Storsjö wrote: --- /dev/null +++ b/libavformat/url-test.c @@ -0,0 +1,55 @@ +/* + * Copyright (c)

Re: [libav-devel] [PATCH 1/4] fate: Add tests of the ff_make_absolute_url function

2012-10-06 Thread Diego Biurrun
On Sat, Oct 06, 2012 at 10:39:51AM +0100, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: On Sat, Oct 06, 2012 at 02:44:41AM +0300, Martin Storsjö wrote: On Sat, 6 Oct 2012, Diego Biurrun wrote: On Sat, Oct 06, 2012 at 02:05:21AM +0300, Martin Storsjö wrote: --- /dev/null

Re: [libav-devel] [PATCH] parseutils: fix parsing of invalid alpha values

2012-10-06 Thread Martin Storsjö
On Sat, 6 Oct 2012, Mans Rullgard wrote: An alpha specifier outside the valid range results in a conversion from double to long with undefined result. Range-checking the double and only converting it after it passes avoids this. Fixes fate-parseutils errors on some systems. Signed-off-by:

Re: [libav-devel] [PATCH] segment: support hls style playlist

2012-10-06 Thread Martin Storsjö
On Sat, 6 Oct 2012, Luca Barbato wrote: --- libavformat/segment.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/libavformat/segment.c b/libavformat/segment.c index 8ac04e2..07bb675 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -37,6 +37,7 @@

Re: [libav-devel] [PATCH] segment: support hls style playlist

2012-10-06 Thread Luca Barbato
On 10/06/2012 01:23 PM, Martin Storsjö wrote: This doesn't look right. The #EXT-X-MEDIA-SEQUENCE tag indicates the index in the sequence for the first entry in the list. So as long as you just add more entries to the end of the list, this value should stay unchanged - you should increment it

[libav-devel] [PATCH] fate.sh: add support for build-only FATE instances

2012-10-06 Thread Diego Biurrun
If the build_only variable is set in the configuration file, the FATE client will skip running tests and just compile all targets. --- This is a slightly cleaned-up version of an RFC patch I sent earlier. This comes with documentation, so it should be good to go. doc/fate.texi |1 +

Re: [libav-devel] [PATCH] fate.sh: add support for build-only FATE instances

2012-10-06 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: If the build_only variable is set in the configuration file, the FATE client will skip running tests and just compile all targets. --- This is a slightly cleaned-up version of an RFC patch I sent earlier. This comes with documentation, so it should be

[libav-devel] [PATCH 3/9] pixdesc: add functions for accessing pixel format descriptors.

2012-10-06 Thread Anton Khirnov
Make av_pix_fmt_descriptors table static on next major bump. Making the table public is dangerous, since the caller has no way to know how large it actually is. It also prevents adding new fields to AVPixFmtDescriptor without a major bump. --- libavutil/pixdesc.c | 30

[libav-devel] [PATCH 1/9] pixfmt: add AV_ prefixes to PIX_FMT_*

2012-10-06 Thread Anton Khirnov
--- doc/APIchanges |8 ++ libavutil/Makefile |1 + libavutil/old_pix_fmts.h | 128 libavutil/pixfmt.h | 298 ++ libavutil/version.h |7 +- 5 files changed, 311 insertions(+), 131 deletions(-)

[libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Anton Khirnov
--- avprobe.c |6 +++--- cmdutils.c| 16 +++- tools/graph2dot.c |4 ++-- 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/avprobe.c b/avprobe.c index 16a5d29..3a3ae0f 100644 --- a/avprobe.c +++ b/avprobe.c @@ -584,6 +584,7 @@ static void

[libav-devel] [PATCH 5/9] sws: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Anton Khirnov
--- libswscale/output.c |3 +- libswscale/swscale-test.c | 27 + libswscale/swscale.c |6 +- libswscale/swscale_internal.h | 130 +++-- libswscale/swscale_unscaled.c | 20 --- libswscale/utils.c| 26

[libav-devel] [PATCH 6/9] mpegvideo: fix indentation

2012-10-06 Thread Anton Khirnov
--- libavcodec/mpegvideo.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index f739c2d..995deb8 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@ -1527,20 +1527,20 @@ void

[libav-devel] [PATCH 7/9] lavc: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Anton Khirnov
--- libavcodec/imgconvert.c | 30 ++ libavcodec/libopenjpegdec.c | 34 ++ libavcodec/libopenjpegenc.c | 13 ++--- libavcodec/mpegvideo.c | 10 ++ libavcodec/rawdec.c |3 ++-

[libav-devel] [PATCH 8/9] lavfi: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Anton Khirnov
--- libavfilter/avfilter.c |2 +- libavfilter/buffersrc.c |2 +- libavfilter/drawutils.c |2 +- libavfilter/filtfmts.c |4 ++-- libavfilter/formats.c|6 -- libavfilter/vf_boxblur.c |2 +- libavfilter/vf_crop.c| 10 +-

[libav-devel] [PATCH 9/9] lavu, lavd: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Anton Khirnov
--- libavdevice/fbdev.c |2 +- libavutil/imgutils.c | 24 +++- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/libavdevice/fbdev.c b/libavdevice/fbdev.c index fffe655..7680b29 100644 --- a/libavdevice/fbdev.c +++ b/libavdevice/fbdev.c @@ -171,7 +171,7

[libav-devel] [PATCH 08/11] mpegaudioenc: allow planar or interleaved sample format as input

2012-10-06 Thread Justin Ruggles
--- Supporting either sample format for this particular encoder is trivial and does not require additional processing in either case. libavcodec/mpegaudioenc.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/libavcodec/mpegaudioenc.c

[libav-devel] [PATCH 1/2] avcodec: allow either planar or interleaved sample format when encoding mono

2012-10-06 Thread Justin Ruggles
When there is only 1 channel, the planar and interleaved formats of the same data type should be treated as identical. --- libavcodec/utils.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index a72c434..d1b9d0a 100644 ---

[libav-devel] [PATCH 2/2] af_resample: avoid conversion of identical sample formats for 1 channel

2012-10-06 Thread Justin Ruggles
When there is only 1 channel, the planar and interleaved formats of the same data type should be treated as identical. --- libavfilter/af_resample.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/libavfilter/af_resample.c b/libavfilter/af_resample.c index

Re: [libav-devel] [PATCH 6/9] mpegvideo: fix indentation

2012-10-06 Thread Diego Biurrun
On Sat, Oct 06, 2012 at 06:58:19PM +0200, Anton Khirnov wrote: --- libavcodec/mpegvideo.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) OK Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] fate.sh: add support for build-only FATE instances

2012-10-06 Thread Diego Biurrun
On Sat, Oct 06, 2012 at 05:26:15PM +0100, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: If the build_only variable is set in the configuration file, the FATE client will skip running tests and just compile all targets. --- This is a slightly cleaned-up version of an RFC

Re: [libav-devel] [PATCH 1/2] avcodec: allow either planar or interleaved sample format when encoding mono

2012-10-06 Thread Anton Khirnov
On Sat, 6 Oct 2012 13:30:36 -0400, Justin Ruggles justin.rugg...@gmail.com wrote: When there is only 1 channel, the planar and interleaved formats of the same data type should be treated as identical. --- libavcodec/utils.c |9 - 1 files changed, 8 insertions(+), 1

Re: [libav-devel] [PATCH 2/2] af_resample: avoid conversion of identical sample formats for 1 channel

2012-10-06 Thread Anton Khirnov
On Sat, 6 Oct 2012 13:30:37 -0400, Justin Ruggles justin.rugg...@gmail.com wrote: When there is only 1 channel, the planar and interleaved formats of the same data type should be treated as identical. --- libavfilter/af_resample.c |7 ++- 1 files changed, 6 insertions(+), 1

Re: [libav-devel] [PATCH 2/2] af_resample: avoid conversion of identical sample formats for 1 channel

2012-10-06 Thread Justin Ruggles
On 10/06/2012 02:53 PM, Anton Khirnov wrote: On Sat, 6 Oct 2012 13:30:37 -0400, Justin Ruggles justin.rugg...@gmail.com wrote: When there is only 1 channel, the planar and interleaved formats of the same data type should be treated as identical. --- libavfilter/af_resample.c |7

Re: [libav-devel] [PATCH 2/9] Replace PIX_FMT_* - AV_PIX_FMT_*, PixelFormat - AVPixelFormat

2012-10-06 Thread Ronald S. Bultje
Hi, On Sat, Oct 6, 2012 at 9:58 AM, Anton Khirnov an...@khirnov.net wrote: [..] Yay! OK. (Didn't review at all, a sed replace can't be that hard, plus this is awesome.) Ronald ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Ronald S. Bultje
Hi, On Sat, Oct 6, 2012 at 9:58 AM, Anton Khirnov an...@khirnov.net wrote: --- avprobe.c |6 +++--- cmdutils.c| 16 +++- tools/graph2dot.c |4 ++-- 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/avprobe.c b/avprobe.c index

[libav-devel] [PATCH 0/2] [GSoC] Opus range coder backport

2012-10-06 Thread Nathan Caldwell
This is Andrew's Opus range decoder from his GSoC repo. This only includes the functions required for SILK decoding. There are a few more that are specific to CELT that are not included. I have incldued Andrew's original code as a reference test in opusrac.c. I assume there will be optimizations

[libav-devel] [PATCH 1/2] Native Opus range decoder

2012-10-06 Thread Nathan Caldwell
From: Andrew D'Addesio modchip...@gmail.com Fully functional range decoder, tested against libopus's entdec.c Includes opusrac-test in opusrac.c --- libavcodec/Makefile |1 + libavcodec/opusrac.c | 120 ++ libavcodec/opusrac.h | 90

[libav-devel] [PATCH 2/2] fate: Add Opus RAC test

2012-10-06 Thread Nathan Caldwell
--- tests/fate/libavcodec.mak |5 + 1 file changed, 5 insertions(+) diff --git a/tests/fate/libavcodec.mak b/tests/fate/libavcodec.mak index 2aa9596..71f1430 100644 --- a/tests/fate/libavcodec.mak +++ b/tests/fate/libavcodec.mak @@ -7,4 +7,9 @@ FATE_LIBAVCODEC += fate-iirfilter

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Anton Khirnov
On Sat, 6 Oct 2012 12:35:44 -0700, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Sat, Oct 6, 2012 at 9:58 AM, Anton Khirnov an...@khirnov.net wrote: --- avprobe.c |6 +++--- cmdutils.c| 16 +++- tools/graph2dot.c |4 ++-- 3 files changed,

[libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-10-06 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com Use this in VP8/H264-8bit loopfilter functions so they can be used if there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). --- libavcodec/x86/h264_deblock.asm | 27 ++- libavcodec/x86/h264dsp_init.c | 4 +- libavcodec/x86/vp8dsp.asm |

Re: [libav-devel] [PATCH 3/9] pixdesc: add functions for accessing pixel format descriptors.

2012-10-06 Thread Luca Barbato
On 10/06/2012 06:58 PM, Anton Khirnov wrote: Make av_pix_fmt_descriptors table static on next major bump. Making the table public is dangerous, since the caller has no way to know how large it actually is. It also prevents adding new fields to AVPixFmtDescriptor without a major bump. ---

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Luca Barbato
On 10/06/2012 06:58 PM, Anton Khirnov wrote: --- avprobe.c |6 +++--- cmdutils.c| 16 +++- tools/graph2dot.c |4 ++-- 3 files changed, 16 insertions(+), 10 deletions(-) Seems fine. lu ___ libav-devel

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Luca Barbato
On 10/06/2012 09:35 PM, Ronald S. Bultje wrote: Hi, @@ -629,9 +630,8 @@ static void show_stream(AVFormatContext *fmt_ctx, int stream_idx) rational_string(val_str, sizeof(val_str), :, display_aspect_ratio)); } -

Re: [libav-devel] [PATCH 5/9] sws: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Luca Barbato
On 10/06/2012 06:58 PM, Anton Khirnov wrote: --- libswscale/output.c |3 +- libswscale/swscale-test.c | 27 + libswscale/swscale.c |6 +- libswscale/swscale_internal.h | 130 +++-- libswscale/swscale_unscaled.c

Re: [libav-devel] [PATCH 8/9] lavfi: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Luca Barbato
On 10/06/2012 06:58 PM, Anton Khirnov wrote: --- Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Ronald S. Bultje
Hi, On Sat, Oct 6, 2012 at 1:28 PM, Anton Khirnov an...@khirnov.net wrote: On Sat, 6 Oct 2012 12:35:44 -0700, Ronald S. Bultje rsbul...@gmail.com wrote: On Sat, Oct 6, 2012 at 9:58 AM, Anton Khirnov an...@khirnov.net wrote: --- avprobe.c |6 +++--- cmdutils.c| 16

[libav-devel] [PATCH] adpcmenc: ensure calls to adpcm_ima_compress_sample() are in the right order

2012-10-06 Thread Justin Ruggles
Should fix fate-acodec-adpcm-ima_wav with several compilers. --- libavcodec/adpcmenc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c index 5c95ad7..6816f60 100644 --- a/libavcodec/adpcmenc.c +++ b/libavcodec/adpcmenc.c @@

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Diego Elio Pettenò
On 06/10/2012 17:01, Ronald S. Bultje wrote: It prevents the caller from accessing all the descriptors when he's using a newer library than the one he compiled against. if (compile_ver runtime_ver) error(); on app init. Likely, you want to do that anyway. Actually Anton is referring to

Re: [libav-devel] [PATCH] adpcmenc: ensure calls to adpcm_ima_compress_sample() are in the right order

2012-10-06 Thread Derek Buitenhuis
On 06/10/2012 11:59 PM, Justin Ruggles wrote: Should fix fate-acodec-adpcm-ima_wav with several compilers. --- libavcodec/adpcmenc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) For the record, these are MSVC and PathScale EKOPath. - Derek

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Anton Khirnov
On Sat, 6 Oct 2012 17:01:57 -0700, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Sat, Oct 6, 2012 at 1:28 PM, Anton Khirnov an...@khirnov.net wrote: On Sat, 6 Oct 2012 12:35:44 -0700, Ronald S. Bultje rsbul...@gmail.com wrote: On Sat, Oct 6, 2012 at 9:58 AM, Anton Khirnov

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Ronald S. Bultje
Hi, On Sat, Oct 6, 2012 at 9:19 PM, Anton Khirnov an...@khirnov.net wrote: On Sat, 6 Oct 2012 17:01:57 -0700, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Sat, Oct 6, 2012 at 1:28 PM, Anton Khirnov an...@khirnov.net wrote: On Sat, 6 Oct 2012 12:35:44 -0700, Ronald S. Bultje

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Anton Khirnov
On Sat, 6 Oct 2012 21:44:03 -0700, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Sat, Oct 6, 2012 at 9:19 PM, Anton Khirnov an...@khirnov.net wrote: On Sat, 6 Oct 2012 17:01:57 -0700, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Sat, Oct 6, 2012 at 1:28 PM, Anton

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Ronald S. Bultje
Hi, On Sat, Oct 6, 2012 at 9:47 PM, Anton Khirnov an...@khirnov.net wrote: On Sat, 6 Oct 2012 21:44:03 -0700, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Sat, Oct 6, 2012 at 9:19 PM, Anton Khirnov an...@khirnov.net wrote: On Sat, 6 Oct 2012 17:01:57 -0700, Ronald S. Bultje

Re: [libav-devel] [PATCH 1/9] pixfmt: add AV_ prefixes to PIX_FMT_*

2012-10-06 Thread Ronald S. Bultje
Hi, On Sat, Oct 6, 2012 at 9:58 AM, Anton Khirnov an...@khirnov.net wrote: --- doc/APIchanges |8 ++ libavutil/Makefile |1 + libavutil/old_pix_fmts.h | 128 libavutil/pixfmt.h | 298 ++

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Diego Elio Pettenò
On 06/10/2012 22:11, Ronald S. Bultje wrote: The same way we can never have msvc support? Right. Shall we move on to more practical patches? flamebait Sure, are we going to stop reviewing MSVC fixes? /flamebait As I said this patch makes the ABI more stable, and distributions love ABI