[libav-devel] [PATCH] doc: git-howto: Clarify comment about pushing series of commits

2012-10-26 Thread Diego Biurrun
--- doc/git-howto.texi |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/git-howto.texi b/doc/git-howto.texi index 5114115..68e0061 100644 --- a/doc/git-howto.texi +++ b/doc/git-howto.texi @@ -416,8 +416,8 @@ a panacea. Do not hesitate to perform any other tests

Re: [libav-devel] [PATCH] doc: git-howto: Clarify comment about pushing series of commits

2012-10-26 Thread Luca Barbato
On 10/26/12 12:03 PM, Diego Biurrun wrote: --- doc/git-howto.texi |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/git-howto.texi b/doc/git-howto.texi index 5114115..68e0061 100644 --- a/doc/git-howto.texi +++ b/doc/git-howto.texi @@ -416,8 +416,8 @@ a panacea.

[libav-devel] [PATCH 03/10] cook: Remove senseless maybe_reformat_buffer32() function

2012-10-26 Thread Diego Biurrun
--- libavcodec/cook.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/libavcodec/cook.c b/libavcodec/cook.c index 05efa50..713d0b1 100644 --- a/libavcodec/cook.c +++ b/libavcodec/cook.c @@ -241,17 +241,11 @@ static av_cold int init_cook_mlt(COOKContext *q)

[libav-devel] [PATCH 01/10] cook: cosmetics: Better name for ccpl COOKSubpacket member

2012-10-26 Thread Diego Biurrun
--- libavcodec/cook.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/cook.c b/libavcodec/cook.c index c5b17f9..28ee8ed 100644 --- a/libavcodec/cook.c +++ b/libavcodec/cook.c @@ -79,7 +79,7 @@ typedef struct { int

[libav-devel] [PATCH 02/10] cook: cosmetics: Better names for joint_decode() function parameters

2012-10-26 Thread Diego Biurrun
--- libavcodec/cook.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/libavcodec/cook.c b/libavcodec/cook.c index 28ee8ed..05efa50 100644 --- a/libavcodec/cook.c +++ b/libavcodec/cook.c @@ -809,8 +809,8 @@ static void decouple_float(COOKContext *q, *

[libav-devel] [PATCH 04/10] cook: Remove some silly Doxygen comments

2012-10-26 Thread Diego Biurrun
--- libavcodec/cook.c | 19 ++- 1 files changed, 2 insertions(+), 17 deletions(-) diff --git a/libavcodec/cook.c b/libavcodec/cook.c index 713d0b1..a45bd80 100644 --- a/libavcodec/cook.c +++ b/libavcodec/cook.c @@ -84,11 +84,11 @@ typedef struct { int

[libav-devel] [PATCH 06/10] flashsv: Drop unused size parameter from flashsv2_prime()

2012-10-26 Thread Diego Biurrun
--- libavcodec/flashsv.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/flashsv.c b/libavcodec/flashsv.c index a155bef..1d8cf0c 100644 --- a/libavcodec/flashsv.c +++ b/libavcodec/flashsv.c @@ -121,8 +121,7 @@ static av_cold int

[libav-devel] [PATCH 08/10] aacenc: Drop some unused function arguments

2012-10-26 Thread Diego Biurrun
--- libavcodec/aacenc.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c index f5ab40f..e9f6e2f 100644 --- a/libavcodec/aacenc.c +++ b/libavcodec/aacenc.c @@ -302,7 +302,7 @@ static void encode_ms_info(PutBitContext *pb,

[libav-devel] [PATCH 09/10] avconv: Drop unused function argument from do_video_stats()

2012-10-26 Thread Diego Biurrun
--- avconv.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/avconv.c b/avconv.c index 54a0e2a..d0902a6 100644 --- a/avconv.c +++ b/avconv.c @@ -621,8 +621,7 @@ static double psnr(double d) return -10.0 * log(d) / log(10.0); } -static void

[libav-devel] [PATCH 10/10] avconv_opt, cmdutils: Add missing function parameter Doxygen

2012-10-26 Thread Diego Biurrun
--- avconv_opt.c |1 + cmdutils.h |8 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/avconv_opt.c b/avconv_opt.c index 0eb601b..ffb6c65 100644 --- a/avconv_opt.c +++ b/avconv_opt.c @@ -276,6 +276,7 @@ static int opt_attach(void *optctx, const char *opt, const

[libav-devel] [PATCH 07/10] aacdec: Drop some unused function arguments

2012-10-26 Thread Diego Biurrun
--- libavcodec/aacdec.c | 44 1 files changed, 20 insertions(+), 24 deletions(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index b7caecb..59f39fd 100644 --- a/libavcodec/aacdec.c +++ b/libavcodec/aacdec.c @@ -171,7 +171,7 @@ struct

[libav-devel] function parameter updates

2012-10-26 Thread Diego Biurrun
This is a admittedly somewhat motley collection of small patches I picked from my local Doxygen fixes branch. It contains some refactoring I did while looking through the files doing some Doxygen fixes. The number of Doxygen warnings is still overwhelming, but remember, if our hearts remain

[libav-devel] [PATCH 05/10] ivi_common: Drop unused function parameter from decode_band()

2012-10-26 Thread Diego Biurrun
--- libavcodec/ivi_common.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/ivi_common.c b/libavcodec/ivi_common.c index 149fffe..8566128 100644 --- a/libavcodec/ivi_common.c +++ b/libavcodec/ivi_common.c @@ -644,7 +644,7 @@ void

Re: [libav-devel] function parameter updates

2012-10-26 Thread Benjamin Larsson
Cook patches ok. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 05/10] ivi_common: Drop unused function parameter from decode_band()

2012-10-26 Thread Kostya Shishkov
On Fri, Oct 26, 2012 at 01:15:55PM +0200, Diego Biurrun wrote: --- libavcodec/ivi_common.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/ivi_common.c b/libavcodec/ivi_common.c index 149fffe..8566128 100644 --- a/libavcodec/ivi_common.c +++

Re: [libav-devel] [PATCH v2] build: add rules to generate preprocessed source files

2012-10-26 Thread Diego Biurrun
On Sat, Oct 20, 2012 at 01:51:17AM +0100, Mans Rullgard wrote: This is useful for debugging. Dependencies for these files are not generated due to limitations in many compilers. Signed-off-by: Mans Rullgard m...@mansr.com --- Added the second -test.i rule pointed out by Diego. ---

Re: [libav-devel] [PATCH 2/3] a64multienc: silence bogus gcc warning

2012-10-26 Thread Kostya Shishkov
On Thu, Sep 20, 2012 at 12:05:11PM +0100, Måns Rullgård wrote: Benjamin Larsson benja...@southpole.se writes: libavcodec/a64multienc.c: In function ‘a64multi_encode_frame’: libavcodec/a64multienc.c:342:17: warning: ‘buf’ may be used uninitialized in this function [-Wuninitialized]

Re: [libav-devel] [PATCH 2/3] a64multienc: silence bogus gcc warning

2012-10-26 Thread Måns Rullgård
Kostya Shishkov kostya.shish...@gmail.com writes: On Thu, Sep 20, 2012 at 12:05:11PM +0100, Måns Rullgård wrote: Benjamin Larsson benja...@southpole.se writes: libavcodec/a64multienc.c: In function ‘a64multi_encode_frame’: libavcodec/a64multienc.c:342:17: warning: ‘buf’ may be used

Re: [libav-devel] [PATCH 2/3] a64multienc: silence bogus gcc warning

2012-10-26 Thread Kostya Shishkov
On Fri, Oct 26, 2012 at 12:44:22PM +0100, Måns Rullgård wrote: Kostya Shishkov kostya.shish...@gmail.com writes: On Thu, Sep 20, 2012 at 12:05:11PM +0100, Måns Rullgård wrote: Benjamin Larsson benja...@southpole.se writes: libavcodec/a64multienc.c: In function ‘a64multi_encode_frame’:

Re: [libav-devel] [PATCH 2/3] a64multienc: silence bogus gcc warning

2012-10-26 Thread Måns Rullgård
Kostya Shishkov kostya.shish...@gmail.com writes: On Fri, Oct 26, 2012 at 12:44:22PM +0100, Måns Rullgård wrote: Kostya Shishkov kostya.shish...@gmail.com writes: On Thu, Sep 20, 2012 at 12:05:11PM +0100, Måns Rullgård wrote: Benjamin Larsson benja...@southpole.se writes:

Re: [libav-devel] [PATCH 2/3] a64multienc: silence bogus gcc warning

2012-10-26 Thread Kostya Shishkov
On Fri, Oct 26, 2012 at 12:54:41PM +0100, Måns Rullgård wrote: Kostya Shishkov kostya.shish...@gmail.com writes: On Fri, Oct 26, 2012 at 12:44:22PM +0100, Måns Rullgård wrote: Kostya Shishkov kostya.shish...@gmail.com writes: On Thu, Sep 20, 2012 at 12:05:11PM +0100, Måns Rullgård

[libav-devel] [PATCH] configure: fix tests for 2-arg math functions

2012-10-26 Thread Mans Rullgard
Signed-off-by: Mans Rullgard m...@mansr.com --- configure | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 39649ab..fdd5446 100755 --- a/configure +++ b/configure @@ -785,11 +785,13 @@ EOF check_mathfunc(){ log check_mathfunc $@

Re: [libav-devel] [PATCH] configure: fix tests for 2-arg math functions

2012-10-26 Thread Luca Barbato
On 10/26/2012 03:42 PM, Mans Rullgard wrote: Signed-off-by: Mans Rullgard m...@mansr.com --- configure | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) Looks fine. ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH] av_memcpy_backptr: optimise some special cases

2012-10-26 Thread Mans Rullgard
- Add special cases for offsets of 2, 3, or 4 bytes. This means the offset is always 4 in the generic case, allowing 32-bit copies to be used there. - Don't use memcpy() for sizes less than 16 bytes. Signed-off-by: Mans Rullgard m...@mansr.com --- libavutil/mem.c | 120

Re: [libav-devel] [PATCH] av_memcpy_backptr: optimise some special cases

2012-10-26 Thread Kostya Shishkov
On Fri, Oct 26, 2012 at 02:49:17PM +0100, Mans Rullgard wrote: - Add special cases for offsets of 2, 3, or 4 bytes. This means the offset is always 4 in the generic case, allowing 32-bit copies to be used there. - Don't use memcpy() for sizes less than 16 bytes. Signed-off-by: Mans

Re: [libav-devel] [PATCH 1/2] x86: Require an assembler able to cope with AVX instructions

2012-10-26 Thread Diego Biurrun
On Fri, Oct 19, 2012 at 11:38:53PM +0200, Diego Biurrun wrote: On Fri, Oct 19, 2012 at 10:29:36PM +0100, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: All modern assemblers have this capability. Older ones that do not produce code that crashes at runtime, so it's better

[libav-devel] [PATCH 1/2] pixfmt: support more yuva formats

2012-10-26 Thread Luca Barbato
Signed-off-by: Luca Barbato lu_z...@gentoo.org --- It exposes a bug in swscale. libavcodec/raw.c| 19 + libavformat/nut.c | 28 +++ libavutil/pixdesc.c | 234 libavutil/pixfmt.h | 28 +++ libswscale/utils.c | 18

Re: [libav-devel] [PATCH] doc: git-howto: Leave reviewers time to react before pushing patches

2012-10-26 Thread Diego Biurrun
On Thu, Oct 25, 2012 at 04:42:57PM -0400, Derek Buitenhuis wrote: On 25/10/2012 2:28 PM, Diego Biurrun wrote: +Give other developers a reasonable amount of time to look at and review +patches before you push them. Not everybody is online 24/7, but may wish +to look at and comment on a patch

Re: [libav-devel] [PATCH] doxygen: Drop some pointless entries from PREDEFINED macros list

2012-10-26 Thread Diego Biurrun
On Tue, Oct 23, 2012 at 09:13:34PM +0200, Diego Biurrun wrote: --- doc/Doxyfile |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) OKed by Anton on IRC. Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 4/4] doxygen: Add av_alloc_size to list of predefined macros

2012-10-26 Thread Diego Biurrun
On Mon, Oct 22, 2012 at 04:19:56PM +0200, Diego Biurrun wrote: This avoids Doxygen believing the attribute is the function name. --- doc/Doxyfile |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) OKed by Anton on IRC. Diego ___

[libav-devel] [PATCH 1/1] mxfdec: fix typo in mxf_read_seek()

2012-10-26 Thread Janne Grunau
Check the number of index tables before using byte offset based seeking instead of the index_tables pointer. Found by Måns Rullgård m...@mansr.com. --- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index

Re: [libav-devel] [PATCH 1/1] mxfdec: fix typo in mxf_read_seek()

2012-10-26 Thread Måns Rullgård
Janne Grunau janne-li...@jannau.net writes: Check the number of index tables before using byte offset based seeking instead of the index_tables pointer. Found by Måns Rullgård m...@mansr.com. --- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libav-devel] [PATCH 1/1] remove #defines to prevent use of discouraged external functions

2012-10-26 Thread Måns Rullgård
Janne Grunau janne-li...@jannau.net writes: Preventing the use of discouraged or 'insecure' external functions through defines in an internal header is not a good solution. The header is not guaranteed to be included universally which makes overlooking bad use of said functions during review

Re: [libav-devel] [PATCH 1/1] remove #defines to prevent use of discouraged external functions

2012-10-26 Thread Luca Barbato
On 10/26/2012 08:46 PM, Janne Grunau wrote: Preventing the use of discouraged or 'insecure' external functions through defines in an internal header is not a good solution. The header is not guaranteed to be included universally which makes overlooking bad use of said functions during review

Re: [libav-devel] [PATCH 1/1] remove #defines to prevent use of discouraged external functions

2012-10-26 Thread Diego Elio Pettenò
On 26/10/2012 11:52, Luca Barbato wrote: Fine for me, in case we might add some grep to find functions that could be dangerous. If I'm not mistaken there should be a way to inject the warnings at link time. Although it's easier to just nm/elfgrep the final targets. -- Diego Elio Pettenò —

Re: [libav-devel] [PATCH 1/1] remove #defines to prevent use of discouraged external functions

2012-10-26 Thread Måns Rullgård
Diego Elio Pettenò flamee...@flameeyes.eu writes: On 26/10/2012 11:52, Luca Barbato wrote: Fine for me, in case we might add some grep to find functions that could be dangerous. If I'm not mistaken there should be a way to inject the warnings at link time. Although it's easier to just

Re: [libav-devel] [PATCH 1/1] remove #defines to prevent use of discouraged external functions

2012-10-26 Thread Diego Elio Pettenò
On 26/10/2012 12:07, Måns Rullgård wrote: That would be just as wrong. There are legitimate uses for most of these functions. I'd still prefer that to grepping the sources. For me it's fine to not keep the warnings around at all. -- Diego Elio Pettenò — Flameeyes flamee...@flameeyes.eu —

Re: [libav-devel] [PATCH 1/1] remove #defines to prevent use of discouraged external functions

2012-10-26 Thread Luca Barbato
On 10/26/2012 09:07 PM, Måns Rullgård wrote: Diego Elio Pettenò flamee...@flameeyes.eu writes: On 26/10/2012 11:52, Luca Barbato wrote: Fine for me, in case we might add some grep to find functions that could be dangerous. If I'm not mistaken there should be a way to inject the warnings at

Re: [libav-devel] [PATCH 2/2] swscale: support gray to 9bit and 10bit formats

2012-10-26 Thread Ronald S. Bultje
Hi, On Fri, Oct 26, 2012 at 8:35 AM, Luca Barbato lu_z...@gentoo.org wrote: Signed-off-by: Luca Barbato lu_z...@gentoo.org --- Partially fixes the issue, there is still something wrong somewhere, possibly a buffer overrun or yet some memory not properly set. How do we reproduce? What kind

[libav-devel] [PATCH 1/2] lpc: Add a function for calculating reflection coefficients

2012-10-26 Thread Martin Storsjö
The existing function ff_lpc_calc_coefs does this, but doesn't return the reflection coefficients, only the lpc coefficients. --- libavcodec/lpc.c | 18 ++ libavcodec/lpc.h |3 +++ 2 files changed, 21 insertions(+) diff --git a/libavcodec/lpc.c b/libavcodec/lpc.c index

[libav-devel] [PATCH 2/2] avcodec: Add a RFC 3389 comfort noise codec

2012-10-26 Thread Martin Storsjö
This isn't too useful as a normal codec, but can be used in voip style applications. The decoder updates the noise generator parameters when a packet is given to it for decoding, but if called with an empty packet, it generates more noise according to the last parameters. --- References:

Re: [libav-devel] [PATCH 2/2] avcodec: Add a RFC 3389 comfort noise codec

2012-10-26 Thread Diego Biurrun
On Fri, Oct 26, 2012 at 11:13:49PM +0300, Martin Storsjö wrote: --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -129,6 +129,8 @@ OBJS-$(CONFIG_CLJR_DECODER)+= cljr.o OBJS-$(CONFIG_CLJR_ENCODER)+= cljr.o OBJS-$(CONFIG_CLLC_DECODER)+= cllc.o

Re: [libav-devel] [PATCH 2/2] avcodec: Add a RFC 3389 comfort noise codec

2012-10-26 Thread Martin Storsjö
On Fri, 26 Oct 2012, Diego Biurrun wrote: On Fri, Oct 26, 2012 at 11:13:49PM +0300, Martin Storsjö wrote: --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -129,6 +129,8 @@ OBJS-$(CONFIG_CLJR_DECODER)+= cljr.o OBJS-$(CONFIG_CLJR_ENCODER)+= cljr.o

[libav-devel] [PATCH] yuv4mpeg: reject unsupported codecs

2012-10-26 Thread Luca Barbato
The muxer already rejects unsupported pixel formats, reject also unsupported codecs to prevent dangerous misuses. --- libavformat/yuv4mpeg.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/yuv4mpeg.c b/libavformat/yuv4mpeg.c index bdae17b..a8077a0 100644 ---

Re: [libav-devel] [PATCH 2/2] swscale: support gray to 9bit and 10bit formats

2012-10-26 Thread Luca Barbato
On 10/26/2012 09:47 PM, Ronald S. Bultje wrote: Hi, On Fri, Oct 26, 2012 at 8:35 AM, Luca Barbato lu_z...@gentoo.org wrote: Signed-off-by: Luca Barbato lu_z...@gentoo.org --- Partially fixes the issue, there is still something wrong somewhere, possibly a buffer overrun or yet some memory

Re: [libav-devel] [PATCH 08/10] aacenc: Drop some unused function arguments

2012-10-26 Thread Nathan Caldwell
On Fri, Oct 26, 2012 at 5:15 AM, Diego Biurrun di...@biurrun.de wrote: --- libavcodec/aacenc.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) OK -- -Nathan Caldwell ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH] nutenc: KR formatting cosmetics

2012-10-26 Thread Luca Barbato
--- libavformat/nutenc.c | 769 --- 1 file changed, 427 insertions(+), 342 deletions(-) diff --git a/libavformat/nutenc.c b/libavformat/nutenc.c index 9985cd9..4e35e28 100644 --- a/libavformat/nutenc.c +++ b/libavformat/nutenc.c @@ -28,59 +28,69 @@

Re: [libav-devel] [PATCH] yuv4mpeg: reject unsupported codecs

2012-10-26 Thread Benjamin Larsson
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 03/11] af_channelmap: remove stray enum declaration

2012-10-26 Thread Mans Rullgard
Signed-off-by: Mans Rullgard m...@mansr.com --- libavfilter/af_channelmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/af_channelmap.c b/libavfilter/af_channelmap.c index 8c49d10..f70b481 100644 --- a/libavfilter/af_channelmap.c +++ b/libavfilter/af_channelmap.c @@ -124,7

[libav-devel] [PATCH 01/11] buffersink: remove stray semicolon after function definition

2012-10-26 Thread Mans Rullgard
Signed-off-by: Mans Rullgard m...@mansr.com --- libavfilter/buffersink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c index 73af25d..c68b909 100644 --- a/libavfilter/buffersink.c +++ b/libavfilter/buffersink.c @@ -57,7

[libav-devel] [PATCH 05/11] mov: make enum MovChannelLayoutTag definition standards compliant

2012-10-26 Thread Mans Rullgard
The C99 standard requires that the expression that defines the value of an enumeration constant shall be an integer constant expression that has a value representable as an int. Signed-off-by: Mans Rullgard m...@mansr.com --- libavformat/mov_chan.c | 2 +- 1 file changed, 1 insertion(+), 1

[libav-devel] [PATCH 02/11] assdec: fix qsort() callback signature

2012-10-26 Thread Mans Rullgard
This changes the event_cmp() function to the correct signature, avoiding an ugly cast. Signed-off-by: Mans Rullgard m...@mansr.com --- libavformat/assdec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/assdec.c b/libavformat/assdec.c index 3d39845..0041ca4

[libav-devel] [PATCH 04/11] avio: fix pointer type mismatches in avio_enum_protocols()

2012-10-26 Thread Mans Rullgard
Signed-off-by: Mans Rullgard m...@mansr.com --- libavformat/avio.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index 45ee866..a43b241 100644 --- a/libavformat/avio.c +++ b/libavformat/avio.c @@ -85,11 +85,11 @@ const

[libav-devel] [PATCH 10/11] h264: fix invalid pointer arithmetic

2012-10-26 Thread Mans Rullgard
Subtracting a (positive) value from the address of an array violates C99 section 6.5.6: If both the pointer operand and the result point to elements of the same array object, or one past the last element of the array object, the evaluation shall not produce an overflow; otherwise, the

[libav-devel] [PATCH 06/11] network: use HAVE_THREADS instead of local hack

2012-10-26 Thread Mans Rullgard
HAVE_THREADS is set in config.h if pthreads or w32threads is available, which presumably the proper condition here. Also fixes undefined behaviour in preprocessor directives. Signed-off-by: Mans Rullgard m...@mansr.com --- libavformat/network.c | 14 ++ 1 file changed, 6

[libav-devel] [PATCH 08/11] avserver: use socklen_t where appropriate

2012-10-26 Thread Mans Rullgard
Various socket functions expect a pointer to socklen_t which is not necessarily int. Signed-off-by: Mans Rullgard m...@mansr.com --- avserver.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/avserver.c b/avserver.c index 994edcd..f9d85d8 100644 --- a/avserver.c +++

[libav-devel] [PATCH 11/11] vp8: fix memset() crossing array boundary

2012-10-26 Thread Mans Rullgard
Indexing across array boundaries is not allowed by C99. Signed-off-by: Mans Rullgard m...@mansr.com --- libavcodec/vp8.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index 2766c9e..d9902c4 100644 --- a/libavcodec/vp8.c +++

Re: [libav-devel] [PATCH 11/11] vp8: fix memset() crossing array boundary

2012-10-26 Thread Ronald S. Bultje
Hi, On Fri, Oct 26, 2012 at 5:50 PM, Mans Rullgard m...@mansr.com wrote: Indexing across array boundaries is not allowed by C99. Signed-off-by: Mans Rullgard m...@mansr.com --- libavcodec/vp8.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp8.c

Re: [libav-devel] [PATCH 05/11] mov: make enum MovChannelLayoutTag definition standards compliant

2012-10-26 Thread Diego Elio Pettenò
On 26/10/2012 17:50, Mans Rullgard wrote: +MOV_CH_LAYOUT_UNKNOWN = ( -1 16), MOV_CH_LAYOUT_USE_DESCRIPTIONS = ( 0 16) | 0, Uhm, any reason for the others to use | 0 ? -- Diego Elio Pettenò — Flameeyes flamee...@flameeyes.eu — http://blog.flameeyes.eu/

Re: [libav-devel] [PATCH 05/11] mov: make enum MovChannelLayoutTag definition standards compliant

2012-10-26 Thread Måns Rullgård
Diego Elio Pettenò flamee...@flameeyes.eu writes: On 26/10/2012 17:50, Mans Rullgard wrote: +MOV_CH_LAYOUT_UNKNOWN = ( -1 16), MOV_CH_LAYOUT_USE_DESCRIPTIONS = ( 0 16) | 0, Uhm, any reason for the others to use | 0 ? Only to follow the pattern. -- Måns

Re: [libav-devel] [PATCH 05/11] mov: make enum MovChannelLayoutTag definition standards compliant

2012-10-26 Thread Diego Elio Pettenò
On 26/10/2012 18:18, Måns Rullgård wrote: Only to follow the pattern. Should yours do the same then, or should one Diego at random send a patch to remove the rest? -- Diego Elio Pettenò — Flameeyes flamee...@flameeyes.eu — http://blog.flameeyes.eu/

Re: [libav-devel] [PATCH 01/11] buffersink: remove stray semicolon after function definition

2012-10-26 Thread Luca Barbato
On 10/27/12 2:50 AM, Mans Rullgard wrote: Signed-off-by: Mans Rullgard m...@mansr.com --- libavfilter/buffersink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c index 73af25d..c68b909 100644 ---

Re: [libav-devel] [PATCH 02/11] assdec: fix qsort() callback signature

2012-10-26 Thread Luca Barbato
On 10/27/12 2:50 AM, Mans Rullgard wrote: This changes the event_cmp() function to the correct signature, avoiding an ugly cast. Signed-off-by: Mans Rullgard m...@mansr.com --- libavformat/assdec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/assdec.c

[libav-devel] [PATCH 1/8] flacenc: use a separate buffer for byte-swapping for MD5 checksum on big-endian

2012-10-26 Thread Justin Ruggles
This is much faster than calculating the MD5 one sample at a time. --- libavcodec/flacenc.c | 37 - 1 files changed, 28 insertions(+), 9 deletions(-) diff --git a/libavcodec/flacenc.c b/libavcodec/flacenc.c index b135e4a..db6e776 100644 ---

[libav-devel] [PATCH 2/8] lavu: add av_ctz() for trailing zero bit count

2012-10-26 Thread Justin Ruggles
--- doc/APIchanges |3 +++ libavutil/common.h |4 libavutil/intmath.h | 41 + libavutil/version.h |2 +- 4 files changed, 49 insertions(+), 1 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 24defe4..c8b8fbf 100644

[libav-devel] [PATCH 3/8] flacenc: remove wasted trailing 0 bits

2012-10-26 Thread Justin Ruggles
--- libavcodec/flacenc.c | 39 +-- 1 files changed, 37 insertions(+), 2 deletions(-) diff --git a/libavcodec/flacenc.c b/libavcodec/flacenc.c index db6e776..a7e604b 100644 --- a/libavcodec/flacenc.c +++ b/libavcodec/flacenc.c @@ -20,6 +20,7 @@ */

[libav-devel] [PATCH 4/8] flacenc: use uint64_t for bit counts

2012-10-26 Thread Justin Ruggles
Needed to avoid integer overflows for 24-bit encoding. --- libavcodec/flacenc.c | 58 - 1 files changed, 33 insertions(+), 25 deletions(-) diff --git a/libavcodec/flacenc.c b/libavcodec/flacenc.c index a7e604b..cbfbe9f 100644 ---

[libav-devel] [PATCH 5/8] flacdsp: move lpc encoding from FLAC encoder to FLACDSPContext

2012-10-26 Thread Justin Ruggles
Also, templatize the functions for 16-bit and 32-bit sample range. This will be used for 24-bit FLAC encoding. --- libavcodec/flacdsp.c |9 ++- libavcodec/flacdsp.h |2 + libavcodec/flacdsp_lpc_template.c | 141 +

[libav-devel] [PATCH 6/8] flacenc: add 24-bit encoding

2012-10-26 Thread Justin Ruggles
--- libavcodec/flacenc.c | 88 +++-- 1 files changed, 63 insertions(+), 25 deletions(-) diff --git a/libavcodec/flacenc.c b/libavcodec/flacenc.c index 0ba9176..19413b3 100644 --- a/libavcodec/flacenc.c +++ b/libavcodec/flacenc.c @@ -92,6 +92,7 @@

[libav-devel] [PATCH 7/8] flacenc: use RICE2 entropy coding mode for 24-bit

2012-10-26 Thread Justin Ruggles
--- libavcodec/flacenc.c | 55 +++-- 1 files changed, 39 insertions(+), 16 deletions(-) diff --git a/libavcodec/flacenc.c b/libavcodec/flacenc.c index 19413b3..2648d8e 100644 --- a/libavcodec/flacenc.c +++ b/libavcodec/flacenc.c @@ -43,7 +43,11 @@

[libav-devel] [PATCH 8/8] FATE: add a 24-bit FLAC encoding test

2012-10-26 Thread Justin Ruggles
The existing tests are renamed to fate-flac-16-* to allow different rules for 16-bit and 24-bit tests. --- This will require upload of the 24-bit reference wav file to fate-suite. tests/fate/flac.mak | 31 +++ 1 files changed, 19 insertions(+), 12 deletions(-) diff