Re: [libav-devel] [PATCH] pcm: fix decoding of pcm_s16le_planar on big-endian

On 19/11/2012 21:59, Justin Ruggles wrote: > The sample count is decremented by the DECODE() macro and needs to be reset > in each loop iteration. Also, DECODE() increments the src pointer so that does > not need to be done separately. LGTM. -- Diego Elio Pettenò — Flameeyes flamee...@flameeyes.

[libav-devel] [PATCH] pcm: fix decoding of pcm_s16le_planar on big-endian

The sample count is decremented by the DECODE() macro and needs to be reset in each loop iteration. Also, DECODE() increments the src pointer so that does not need to be done separately. --- libavcodec/pcm.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/p

Re: [libav-devel] [PATCH 2/4] mpegaudiodec: use planar sample format

On Mon, Nov 19, 2012 at 11:29:56PM -0500, Justin Ruggles wrote: > On 11/07/2012 04:00 PM, Justin Ruggles wrote: > > On 10/14/2012 05:44 PM, Justin Ruggles wrote: > >> --- > >> Fix sample format for mp3on4. > >> > >> libavcodec/mpegaudiodec.c | 95 > >> +++--

Re: [libav-devel] [PATCH 2/4] mpegaudiodec: use planar sample format

On 11/07/2012 04:00 PM, Justin Ruggles wrote: > On 10/14/2012 05:44 PM, Justin Ruggles wrote: >> --- >> Fix sample format for mp3on4. >> >> libavcodec/mpegaudiodec.c | 95 >> +++ >> libavcodec/mpegaudiodec_float.c | 14 ++ >> 2 files changed, 61 i

Re: [libav-devel] doc: avtools-common-opts: Fix terminology concerning metric prefixes

Am 19.11.2012 22:26, schrieb Diego Biurrun: On Mon, Nov 19, 2012 at 09:39:20PM +0100, sto@web.de wrote: 'k', 'M', and 'G' are SI (unit) prefixes or metric prefixes, not 'number postfixes'. Also, the statement regarding binary prefixes ("powers of 2 are used instead of powers of 10") might be

Re: [libav-devel] doc: avtools-common-opts: Fix terminology concerning metric prefixes

On Mon, Nov 19, 2012 at 09:39:20PM +0100, sto@web.de wrote: > 'k', 'M', and 'G' are SI (unit) prefixes or metric prefixes, > not 'number postfixes'. Also, the statement regarding binary > prefixes ("powers of 2 are used instead of powers of 10") > might be misinterpreted (1 kB = 10^3 B, but 1 K

Re: [libav-devel] doc: avtools-common-opts: Fix terminology concerning metric prefixes

On 11/19/12 9:39 PM, sto@web.de wrote: 'k', 'M', and 'G' are SI (unit) prefixes or metric prefixes, not 'number postfixes'. Also, the statement regarding binary prefixes ("powers of 2 are used instead of powers of 10") might be misinterpreted (1 kB = 10^3 B, but 1 KiB != 2^3 B). Sounds ok

[libav-devel] doc: avtools-common-opts: Fix terminology concerning metric prefixes

'k', 'M', and 'G' are SI (unit) prefixes or metric prefixes, not 'number postfixes'. Also, the statement regarding binary prefixes ("powers of 2 are used instead of powers of 10") might be misinterpreted (1 kB = 10^3 B, but 1 KiB != 2^3 B). -- diff --git a/doc/avtool

Re: [libav-devel] unused YASM macros

On 11/19/2012 12:30 PM, Måns Rullgård wrote: > Diego Biurrun writes: > >> Justin suggested I should drop PSIGNW instead of porting it to cpuflags; >> it is unused, so I made a list of all unused YASM macros in x86util.asm: >> >> PSIGNW >> ABSB >> ABSB2 >> ABS4 >> SUMSUB2_AB (only used in DCT4_1D,

Re: [libav-devel] unused YASM macros

Diego Biurrun writes: > Justin suggested I should drop PSIGNW instead of porting it to cpuflags; > it is unused, so I made a list of all unused YASM macros in x86util.asm: > > PSIGNW > ABSB > ABSB2 > ABS4 > SUMSUB2_AB (only used in DCT4_1D, see below) > SUMSUB2_BA > DCT4_1D > LOAD_DIFF (only used

Re: [libav-devel] Cleanup imgconvert

On 11/19/2012 03:42 PM, Kostya Shishkov wrote: > On Mon, Nov 19, 2012 at 03:37:47PM +0100, Luca Barbato wrote: >> Here the first set of patches to reduce and cleanup imgconvert. >> >> I'm wondering if we should keep the deinterlace, crop and pad functions. > > Since they duplicate avfilter functio

Re: [libav-devel] [PATCH 2/3] avcodec: split avpicture from imgconvert

On 11/19/2012 04:11 PM, Diego Biurrun wrote: > On Mon, Nov 19, 2012 at 03:37:49PM +0100, Luca Barbato wrote: >> All the non deprecated functions are in avpicture.c now. >> --- >> libavcodec/Makefile | 1 + >> libavcodec/avpicture.c | 123 >>

[libav-devel] unused YASM macros

Justin suggested I should drop PSIGNW instead of porting it to cpuflags; it is unused, so I made a list of all unused YASM macros in x86util.asm: PSIGNW ABSB ABSB2 ABS4 SUMSUB2_AB (only used in DCT4_1D, see below) SUMSUB2_BA DCT4_1D LOAD_DIFF (only used in LOAD_DIFF_8x4P, see below) LOAD_DIFF_8x4P

[libav-devel] [PATCH] x86: PSIGNW: port to cpuflags

--- Now with error case if XMM registers are used w/o SSE2. libavutil/x86/x86util.asm | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/libavutil/x86/x86util.asm b/libavutil/x86/x86util.asm index d3c0d86..5b76338 100644 --- a/libavutil/x86/x86util.asm +++ b/libav

Re: [libav-devel] [PATCH 2/3] avcodec: split avpicture from imgconvert

On Mon, Nov 19, 2012 at 03:37:49PM +0100, Luca Barbato wrote: > All the non deprecated functions are in avpicture.c now. > --- > libavcodec/Makefile | 1 + > libavcodec/avpicture.c | 123 > > libavcodec/imgconvert.c | 85 ---

Re: [libav-devel] [PATCH 3/3] imgconvert: remove PixFmtInfo

On Mon, Nov 19, 2012 at 03:37:50PM +0100, Luca Barbato wrote: > It is pleonastic and was used in stale functions pending replacement. > --- > libavcodec/imgconvert.c | 496 > > 1 file changed, 35 insertions(+), 461 deletions(-) LGTM __

Re: [libav-devel] [PATCH 2/3] avcodec: split avpicture from imgconvert

On Mon, Nov 19, 2012 at 03:37:49PM +0100, Luca Barbato wrote: > All the non deprecated functions are in avpicture.c now. > --- > libavcodec/Makefile | 1 + > libavcodec/avpicture.c | 123 > > libavcodec/imgconvert.c | 85 ---

Re: [libav-devel] [PATCH 1/3] pixdesc: add PIX_FMT_ALPHA flag

On Mon, Nov 19, 2012 at 03:37:48PM +0100, Luca Barbato wrote: > --- > libavutil/pixdesc.c | 49 + > libavutil/pixdesc.h | 3 +++ > 2 files changed, 28 insertions(+), 24 deletions(-) looks OK ___ libav-dev

Re: [libav-devel] Cleanup imgconvert

On Mon, Nov 19, 2012 at 03:37:47PM +0100, Luca Barbato wrote: > Here the first set of patches to reduce and cleanup imgconvert. > > I'm wondering if we should keep the deinterlace, crop and pad functions. Since they duplicate avfilter functionality - maybe only as some internal fallback functions

[libav-devel] [PATCH 3/3] imgconvert: remove PixFmtInfo

It is pleonastic and was used in stale functions pending replacement. --- libavcodec/imgconvert.c | 496 1 file changed, 35 insertions(+), 461 deletions(-) diff --git a/libavcodec/imgconvert.c b/libavcodec/imgconvert.c index f730bef..ff4236e 100644

[libav-devel] [PATCH 2/3] avcodec: split avpicture from imgconvert

All the non deprecated functions are in avpicture.c now. --- libavcodec/Makefile | 1 + libavcodec/avpicture.c | 123 libavcodec/imgconvert.c | 85 - 3 files changed, 124 insertions(+), 85 deletions(-) create

[libav-devel] [PATCH 1/3] pixdesc: add PIX_FMT_ALPHA flag

--- libavutil/pixdesc.c | 49 + libavutil/pixdesc.h | 3 +++ 2 files changed, 28 insertions(+), 24 deletions(-) diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c index d0889b4..439c550 100644 --- a/libavutil/pixdesc.c +++ b/libavutil/pixdesc.c

[libav-devel] Cleanup imgconvert

Here the first set of patches to reduce and cleanup imgconvert. I'm wondering if we should keep the deinterlace, crop and pad functions. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/4] aacdec: use float planar sample format for output

This looks fine On Wed, Nov 7, 2012 at 12:59 PM, Justin Ruggles wrote: > On 10/29/2012 03:15 PM, Justin Ruggles wrote: > > --- > > libavcodec/aac.h|7 ++- > > libavcodec/aacdec.c | 102 > ++ > > libavcodec/aacsbr.c |6 +-- > > 3 files