On 2012-11-28 20:04:08 +0100, Diego Biurrun wrote:
---
tests/fate/cover-art.mak | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/tests/fate/cover-art.mak b/tests/fate/cover-art.mak
index dadfcd8..e0452f4 100644
--- a/tests/fate/cover-art.mak
+++
On 2012-11-28 20:04:09 +0100, Diego Biurrun wrote:
---
tests/fate/image.mak | 24 +++-
1 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/tests/fate/image.mak b/tests/fate/image.mak
index a6768a0..1e4bc56 100644
--- a/tests/fate/image.mak
+++
On 2012-11-28 20:04:10 +0100, Diego Biurrun wrote:
---
tests/fate/dpcm.mak | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/fate/dpcm.mak b/tests/fate/dpcm.mak
index 14e77a2..abc25ed 100644
--- a/tests/fate/dpcm.mak
+++ b/tests/fate/dpcm.mak
@@
On 2012-11-28 20:04:11 +0100, Diego Biurrun wrote:
---
tests/fate/pcm.mak | 27 +++
1 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/tests/fate/pcm.mak b/tests/fate/pcm.mak
index c84de9e..ca586e2 100644
--- a/tests/fate/pcm.mak
+++
On 2012-11-28 20:04:12 +0100, Diego Biurrun wrote:
---
tests/fate/voice.mak | 32 ++--
1 files changed, 18 insertions(+), 14 deletions(-)
diff --git a/tests/fate/voice.mak b/tests/fate/voice.mak
index 8fe445a..e6569a3 100644
--- a/tests/fate/voice.mak
+++
On 2012-11-26 00:04:00 +0100, Janne Grunau wrote:
Fixes an assert in fuzzed sample sample.mp4_s265930.
---
libavformat/mov.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 8dbcc41..149b48e 100644
--- a/libavformat/mov.c
On 2012-11-27 12:24:51 +0100, Janne Grunau wrote:
Avoids a 2G memory allocation and parsing of random data in
mov_read_dref(). The fuzzed sample sample.mp4_s224424 triggers this.
---
err, now the correct patch. git send-email only works after
git commit --amend as intended.
On 2012-11-27 12:56:56 +0100, Janne Grunau wrote:
caeemt2n3my5kdpilyqhmlfcyoh8s4cokppn4birycolo-f9...@mail.gmail.com
On 2012-11-26 07:04:16 -0800, Ronald S. Bultje wrote:
Hi,
On Mon, Nov 26, 2012 at 4:27 AM, Janne Grunau janne-li...@jannau.net
wrote:
On 2012-11-26 13:22:51 +0100,
On 2012-11-30 19:56:14 +0100, Janne Grunau wrote:
This prevents undefined behaviour of signed left shift if the coded
value is larger than 2^31. Large values are most likely invalid and
caused errors or by feeding random.
Validate every use of svq3_get_ue_golomb() and changed the place there
---
libavutil/x86/float_dsp.asm |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/libavutil/x86/float_dsp.asm b/libavutil/x86/float_dsp.asm
index 4a1742f..4113fd9 100644
--- a/libavutil/x86/float_dsp.asm
+++ b/libavutil/x86/float_dsp.asm
@@ -121,7 +121,10 @@
Reusing MpegEncContext's obmc_scratchpad for this becomes a mess with
adaptive frame-mt.
Fixes CVPA1_TOSHIBA_B.264_s6838.
---
There is probably no problem with that file and the current decoder.
It crashes only the adaptive-mt decoder. I'll test before pushing and
remove the reference if it
Janne Grunau janne-li...@jannau.net writes:
On 2012-11-28 20:04:12 +0100, Diego Biurrun wrote:
---
tests/fate/voice.mak | 32 ++--
1 files changed, 18 insertions(+), 14 deletions(-)
diff --git a/tests/fate/voice.mak b/tests/fate/voice.mak
index
On 12/06/2012 12:27 PM, Janne Grunau wrote:
On 2012-11-26 00:04:00 +0100, Janne Grunau wrote:
Fixes an assert in fuzzed sample sample.mp4_s265930.
---
libavformat/mov.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index
On 11/27/2012 06:24 AM, Janne Grunau wrote:
Avoids a 2G memory allocation and parsing of random data in
mov_read_dref(). The fuzzed sample sample.mp4_s224424 triggers this.
---
err, now the correct patch. git send-email only works after
git commit --amend as intended.
libavformat/mov.c
On 12/03/2012 12:26 PM, Kostya Shishkov wrote:
+static int get_code(GetBitContext *gb, int nbits)
+{
+if (nbits == 1) {
+skip_bits1(gb);
looks like very effective coding
+return 0;
+} else {
+return get_sbits(gb, nbits);
+}
+}
The only way
On 12/06/2012 01:48 PM, Justin Ruggles wrote:
On 12/03/2012 12:26 PM, Kostya Shishkov wrote:
+static int get_code(GetBitContext *gb, int nbits)
+{
+if (nbits == 1) {
+skip_bits1(gb);
looks like very effective coding
+return 0;
+} else {
+return
On 12/6/12 6:39 PM, Janne Grunau wrote:
Reusing MpegEncContext's obmc_scratchpad for this becomes a mess with
adaptive frame-mt.
Fixes CVPA1_TOSHIBA_B.264_s6838.
---
There is probably no problem with that file and the current decoder.
It crashes only the adaptive-mt decoder. I'll test before
I was more worried about the 'overflow' in get_ue_golomb() since I saw
that already. Checking before the the addition for an overflow works
too, updated patch attached.
Fine for me.
lu
___
libav-devel mailing list
libav-devel@libav.org
On 12/06/2012 02:03 PM, Justin Ruggles wrote:
On 12/06/2012 01:48 PM, Justin Ruggles wrote:
On 12/03/2012 12:26 PM, Kostya Shishkov wrote:
+static int get_code(GetBitContext *gb, int nbits)
+{
+if (nbits == 1) {
+skip_bits1(gb);
looks like very effective coding
+return
When called from the v4l2 input device, pix_fmt can be
AV_PIX_FMT_NONE (for jpeg formats). Before 50ba57e0, this wasn't
an issue for avpicture_get_size, but after that commit, this
lead to crashes.
---
libavcodec/avpicture.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Michael Niedermayer michae...@gmx.at
Signed-off-by: Michael Niedermayer michae...@gmx.at
Signed-off-by: Justin Ruggles justin.rugg...@gmail.com
---
libavcodec/parser.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/libavcodec/parser.c b/libavcodec/parser.c
On 2012-12-06 23:51:03 +0200, Martin Storsjö wrote:
When called from the v4l2 input device, pix_fmt can be
AV_PIX_FMT_NONE (for jpeg formats). Before 50ba57e0, this wasn't
an issue for avpicture_get_size, but after that commit, this
lead to crashes.
---
libavcodec/avpicture.c |2 +-
1
When initialising an FFTContext for a plain FFT, mdct_bits is not set
and can contain a garbage value. Since nbits is always valid and for
MDCT operation is mdct_bits - 2 checking this instead avoids using an
uninitialised value while having the same effect.
Signed-off-by: Mans Rullgard
On 2012-12-06 23:53:24 +, Måns Rullgård wrote:
When initialising an FFTContext for a plain FFT, mdct_bits is not set
and can contain a garbage value. Since nbits is always valid and for
MDCT operation is mdct_bits - 2 checking this instead avoids using an
uninitialised value while having
Avoids reads of uninitialized memory in ff_lpc_calc_coefs() during
fate-flac-16-lpc-cholesky.
---
libavcodec/flacenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/flacenc.c b/libavcodec/flacenc.c
index 54bc64c..7808e20 100644
--- a/libavcodec/flacenc.c
+++
Janne Grunau janne-li...@jannau.net writes:
Avoids reads of uninitialized memory in ff_lpc_calc_coefs() during
fate-flac-16-lpc-cholesky.
A bit more of an explanation would be nice.
--
Måns Rullgård
m...@mansr.com
___
libav-devel mailing list
On 12/06/2012 07:25 PM, Janne Grunau wrote:
Avoids reads of uninitialized memory in ff_lpc_calc_coefs() during
fate-flac-16-lpc-cholesky.
---
libavcodec/flacenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/flacenc.c b/libavcodec/flacenc.c
index
2012/12/6 Justin Ruggles justin.rugg...@gmail.com:
+static int decode_subframe(TAKDecContext *s, int32_t *decoded,
+ int subframe_size, int prev_subframe_size)
+{
[...]
+emms_c();
[...]
+static int decorrelate(TAKDecContext *s, int c1, int c2, int length)
[...]
2012/12/2 Christophe Gisquet christophe.gisq...@gmail.com:
Implemented that because that seemed the obvious thing to do in retrospect.
Also moved some of the movh loads to mova followed by proper unpacks.
Ping?
--
Christophe
___
libav-devel mailing
2012/12/1 Christophe Gisquet christophe.gisq...@gmail.com:
2012/11/30 Loren Merritt lor...@u.washington.edu:
LGTM.
Corrected 2 vs 4-spaces tabs.
The patch was ok'ed, is there a need for another review?
--
Christophe
___
libav-devel mailing list
2012/12/1 Christophe Gisquet christophe.gisq...@gmail.com:
2012/11/30 Christophe Gisquet christophe.gisq...@gmail.com:
4 space tabs.
Done.
Given the results for the parts where a change was investigated, is
there a need for another review?
--
Christophe
2012/12/1 Christophe Gisquet christophe.gisq...@gmail.com:
Corrected 2 vs 4-spaces tabs and base4 constants.
Ping
--
Christophe
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
2012/12/1 Christophe Gisquet christophe.gisq...@gmail.com:
Corrected 2 vs 4-spaces tabs and base4 constants.
Ping.
--
Christophe
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
2012/12/1 Christophe Gisquet christophe.gisq...@gmail.com:
The improvement is really minor, but as the LC AAC decoder already
requires it, it seems obvious to use it there too.
Ping
--
Christophe
___
libav-devel mailing list
libav-devel@libav.org
2012/12/1 Christophe Gisquet christophe.gisq...@gmail.com:
2012/12/1 Jason Garrett-Glaser ja...@x264.com:
Maybe save this mask value in a register instead of loading it repeatedly?
Sorry, then I worded my commit message incorrectly. As strange as it
is, it worsen things (I don't remember how
2012/12/2 Christophe Gisquet christophe.gisq...@gmail.com:
movh generates a SSE2 movq instruction, so explicitly use movlps.
Ping.
--
Christophe
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
2012/12/2 Christophe Gisquet christophe.gisq...@gmail.com:
movh generates a SSE2 movq instruction, so explicitly use movlps.
Is there a need for another review?
--
Christophe
___
libav-devel mailing list
libav-devel@libav.org
2012/11/27 Justin Ruggles justin.rugg...@gmail.com:
The patch itself looks good. Only the neon version would need to be
modified. The altivec version already handles multiples of 8.
The (yet to be ported) tak decoder could also use this.
This tak decoder seems to require down to multiples of
38 matches
Mail list logo
