Re: [libav-devel] [PATCH] avcodec: Fix a typo in an option description

2012-12-08 Thread Anton Khirnov
On Fri, 07 Dec 2012 16:01:40 +0100, Diego Biurrun di...@biurrun.de wrote: On Fri, Dec 07, 2012 at 03:50:49PM +0200, Martin Storsjö wrote: --- libavcodec/options_table.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I suggest to hold off on this spelling fix and collect more

Re: [libav-devel] [PATCH 3/4] hls: improve options description

2012-12-08 Thread Diego Biurrun
On Sat, Dec 08, 2012 at 06:17:04AM +0100, Luca Barbato wrote: --- doc/muxers.texi | 12 1 file changed, 8 insertions(+), 4 deletions(-) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 2/4] hls: use a meaningful long name

2012-12-08 Thread Diego Biurrun
On Sat, Dec 08, 2012 at 06:17:03AM +0100, Luca Barbato wrote: --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Should be OK. Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] avcodec: Fix a typo in an option description

2012-12-08 Thread Diego Biurrun
On Sat, Dec 08, 2012 at 10:08:14AM +0100, Anton Khirnov wrote: On Fri, 07 Dec 2012 16:01:40 +0100, Diego Biurrun di...@biurrun.de wrote: On Fri, Dec 07, 2012 at 03:50:49PM +0200, Martin Storsjö wrote: --- libavcodec/options_table.h |2 +- 1 file changed, 1 insertion(+), 1

[libav-devel] [PATCH 1/1] mjpeg: initialize input padding after unescaped buffer to zero

2012-12-08 Thread Janne Grunau
Fixes valgrind --undef-value-errors=yes warnings caused by valid overreads in the fate vsynth jpegls, cover-art-ape and cover-art-wv tests. --- libavcodec/mjpegdec.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index 104a63d..0b22bca 100644

Re: [libav-devel] [PATCH 1/1] mjpeg: initialize input padding after unescaped buffer to zero

2012-12-08 Thread Luca Barbato
On 12/8/12 4:24 PM, Janne Grunau wrote: Fixes valgrind --undef-value-errors=yes warnings caused by valid overreads in the fate vsynth jpegls, cover-art-ape and cover-art-wv tests. --- Ok. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 1/3] lavu: add av_lfg_get_flt() to get a random float

2012-12-08 Thread Diego Biurrun
On Fri, Dec 07, 2012 at 04:01:29PM -0500, Justin Ruggles wrote: --- a/libavutil/lfg.h +++ b/libavutil/lfg.h @@ -41,6 +43,14 @@ static inline unsigned int av_lfg_get(AVLFG *c){ /** + * Get the next random float, in the range -0.5 to 0.5, using an ALFG. + */ +static inline float

Re: [libav-devel] [PATCH] h264: KR formatting cosmetics

2012-12-08 Thread Janne Grunau
On 2012-12-08 03:16:18 +0100, Luca Barbato wrote: On 12/8/12 2:51 AM, Luca Barbato wrote: On 12/8/12 2:45 AM, Clément Bœsch wrote: On Sat, Dec 08, 2012 at 02:17:04AM +0100, Luca Barbato wrote: Review in form of patches mostly welcome for this one It is an uncrustify pass with some of

Re: [libav-devel] [PATCH 4/4] img2: document the options available

2012-12-08 Thread Janne Grunau
On 2012-12-08 06:17:05 +0100, Luca Barbato wrote: --- doc/demuxers.texi | 13 + doc/muxers.texi | 5 + 2 files changed, 18 insertions(+) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index c3049dd..2d5c425 100644 --- a/doc/demuxers.texi +++ b/doc/demuxers.texi

[libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-08 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com Use this in VP8/H264-8bit loopfilter functions so they can be used if there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). --- libavcodec/x86/h264_deblock.asm | 27 ++ libavcodec/x86/h264dsp_init.c | 4 +- libavcodec/x86/vp8dsp.asm |

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-08 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: From: Ronald S. Bultje rsbul...@gmail.com Use this in VP8/H264-8bit loopfilter functions so they can be used if there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). --- libavcodec/x86/h264_deblock.asm | 27 ++

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-08 Thread Ronald S. Bultje
Hi, On Sat, Dec 8, 2012 at 8:41 AM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje rsbul...@gmail.com writes: From: Ronald S. Bultje rsbul...@gmail.com Use this in VP8/H264-8bit loopfilter functions so they can be used if there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). ---

Re: [libav-devel] [PATCH] lavf: fix arithmetic overflows in avformat_seek_file()

2012-12-08 Thread Janne Grunau
On 2012-12-07 13:54:02 +, Måns Rullgård wrote: The values compared here can be more than INT64_MAX apart. Since the difference is always positive, converting to uint64_t before subtracting gives the correct result without overflows. s/(without)/\1 undefined/ it still relies on defined

Re: [libav-devel] [PATCH] lavf: fix arithmetic overflows in avformat_seek_file()

2012-12-08 Thread Måns Rullgård
Janne Grunau janne-li...@jannau.net writes: On 2012-12-07 13:54:02 +, Måns Rullgård wrote: The values compared here can be more than INT64_MAX apart. Since the difference is always positive, converting to uint64_t before subtracting gives the correct result without overflows.

Re: [libav-devel] [PATCH 1/4] hls: add start_number option

2012-12-08 Thread Diego Elio Pettenò
On 08/12/2012 06:17, Luca Barbato wrote: +{ start_number, first number in the sequence, OFFSET(number), AV_OPT_TYPE_INT,{.i64 = 0}, 0, INT_MAX, E}, {hls_time, segment length in seconds, OFFSET(time),AV_OPT_TYPE_FLOAT, {.dbl = 2}, 0,

[libav-devel] [PATCH 1/1] svq3: make slice type value unsigned to match svq3_get_ue_golomb return type

2012-12-08 Thread Janne Grunau
--- libavcodec/svq3.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c index 013dee8..0bfc73e 100644 --- a/libavcodec/svq3.c +++ b/libavcodec/svq3.c @@ -750,6 +750,7 @@ static int svq3_decode_slice_header(AVCodecContext *avctx)

Re: [libav-devel] [PATCH 1/1] svq3: make slice type value unsigned to match svq3_get_ue_golomb return type

2012-12-08 Thread Luca Barbato
On 12/8/12 10:37 PM, Janne Grunau wrote: --- libavcodec/svq3.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Ok, I guess. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-08 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com Use this in VP8/H264-8bit loopfilter functions so they can be used if there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). --- libavcodec/x86/h264_deblock.asm | 27 ++ libavcodec/x86/h264dsp_init.c | 4 +- libavcodec/x86/vp8dsp.asm |

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-08 Thread Ronald S. Bultje
Hi, On Sat, Dec 8, 2012 at 4:12 PM, Ronald S. Bultje rsbul...@gmail.com wrote: From: Ronald S. Bultje rsbul...@gmail.com Use this in VP8/H264-8bit loopfilter functions so they can be used if there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). --- libavcodec/x86/h264_deblock.asm | 27

[libav-devel] [RFC PATCH 0/2] Separate h264 qpel from dsputil

2012-12-08 Thread Mans Rullgard
This is a rough stab at splitting off h264 qpel from dsputil. It is ugly in places and incomplete (arm and ppc not updated), but it builds and passes tests. Comments welcome. Mans Rullgard (2): dsputil: drop non-compliant fast qpel mc functions Separate h264 qpel from dsptuil

[libav-devel] [PATCH 1/2] dsputil: drop non-compliant fast qpel mc functions

2012-12-08 Thread Mans Rullgard
--- libavcodec/dsputil.c | 16 - libavcodec/dsputil.h | 3 -- libavcodec/h263dec.c | 5 +-- libavcodec/h264.c | 11 ++- libavcodec/x86/dsputil_avg_template.c | 51 -

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-08 Thread Luca Barbato
On 12/9/12 1:14 AM, Ronald S. Bultje wrote: Hi, On Sat, Dec 8, 2012 at 4:12 PM, Ronald S. Bultje rsbul...@gmail.com wrote: From: Ronald S. Bultje rsbul...@gmail.com Use this in VP8/H264-8bit loopfilter functions so they can be used if there is no aligned stack (e.g. MSVC 32bit or ICC 10.x).

Re: [libav-devel] [PATCH 1/2] dsputil: drop non-compliant fast qpel mc functions

2012-12-08 Thread Luca Barbato
On 12/9/12 1:32 AM, Mans Rullgard wrote: --- libavcodec/dsputil.c | 16 - libavcodec/dsputil.h | 3 -- libavcodec/h263dec.c | 5 +-- libavcodec/h264.c | 11 ++- libavcodec/x86/dsputil_avg_template.c | 51

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-08 Thread Luca Barbato
On 12/09/2012 02:05 AM, Luca Barbato wrote: I was waiting for the local x86 experts to chip in, did you test it on win64 and mac I take, I can try it on linux if nobody did already. on amd64 seems fine as well. I guess can be pushed tomorrow. lu

[libav-devel] [PATCH] avio: KR cosmetic formatting

2012-12-08 Thread Luca Barbato
--- libavformat/aviobuf.c | 121 -- 1 file changed, 67 insertions(+), 54 deletions(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index 15d132d..b762d10 100644 --- a/libavformat/aviobuf.c +++ b/libavformat/aviobuf.c @@ -76,27 +76,31

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-08 Thread Diego Biurrun
On Sat, Dec 08, 2012 at 08:42:36AM -0800, Ronald S. Bultje wrote: On Sat, Dec 8, 2012 at 8:41 AM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje rsbul...@gmail.com writes: Use this in VP8/H264-8bit loopfilter functions so they can be used if there is no aligned stack (e.g. MSVC 32bit

[libav-devel] [RFC] avio checksum functionality

2012-12-08 Thread Luca Barbato
Hi, I'm wondering if we could completely hide the avio checksum fields from the public structure by moving it to an internal field or extend it to be able to use any hash function from avutil and fully expose it to our users. The current situation is less than optimal. lu