[libav-devel] fix CVE-2012-2783 properly

2012-12-14 Thread Luca Barbato
I was mislead by the strange convention used by vp5 and vp6 parse_header, here a fix for it and following the, hopefully, proper fix for the double free. ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH 1/2] vp56: make parse_header return standard error codes

2012-12-14 Thread Luca Barbato
Returning 0 for failure is misleading. CC: libav-sta...@libav.org --- libavcodec/vp5.c | 12 ++-- libavcodec/vp56.c | 8 libavcodec/vp56.h | 2 ++ libavcodec/vp6.c | 12 ++-- 4 files changed, 18 insertions(+), 16 deletions(-) diff --git a/libavcodec/vp5.c

[libav-devel] [PATCH 2/2] vp56: release frames on error

2012-12-14 Thread Luca Barbato
Fixes CVE-2012-2783 CC: libav-sta...@libav.org --- libavcodec/vp56.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp56.c b/libavcodec/vp56.c index 6779ffb..5bd0a1a 100644 --- a/libavcodec/vp56.c +++ b/libavcodec/vp56.c @@ -514,8 +514,14 @@ int

Re: [libav-devel] [PATCH 2/2] vp56: release frames on error

2012-12-14 Thread Anton Khirnov
On Fri, 14 Dec 2012 09:59:15 +0100, Luca Barbato lu_z...@gentoo.org wrote: Fixes CVE-2012-2783 CC: libav-sta...@libav.org --- libavcodec/vp56.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp56.c b/libavcodec/vp56.c index 6779ffb..5bd0a1a 100644

[libav-devel] [PATCH 1/1] x86inc: remove wrong assert in X86_32 PROLOGUE macro

2012-12-14 Thread Janne Grunau
Arguments on the stack are handled properly and functions can use more than arguments than the 7 registers available on x86_32. Fixes nasm build, yasm would fail too if it would error out on %error instead of just emitting a warning. --- libavutil/x86/x86inc.asm | 1 - 1 file changed, 1

Re: [libav-devel] [PATCH 2/2] vp56: release frames on error

2012-12-14 Thread Luca Barbato
On 12/14/2012 10:52 AM, Anton Khirnov wrote: On Fri, 14 Dec 2012 09:59:15 +0100, Luca Barbato lu_z...@gentoo.org wrote: Fixes CVE-2012-2783 CC: libav-sta...@libav.org --- libavcodec/vp56.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp56.c

Re: [libav-devel] [PATCH 1/2] vp56: make parse_header return standard error codes

2012-12-14 Thread Diego Biurrun
On Fri, Dec 14, 2012 at 09:59:14AM +0100, Luca Barbato wrote: --- a/libavcodec/vp5.c +++ b/libavcodec/vp5.c @@ -49,18 +49,18 @@ static int vp5_parse_header(VP56Context *s, const uint8_t *buf, int buf_size, if (vp56_rac_get(c)) { av_log(s-avctx, AV_LOG_ERROR,

Re: [libav-devel] [PATCH 1/1] x86inc: remove wrong assert in X86_32 PROLOGUE macro

2012-12-14 Thread Diego Biurrun
On Fri, Dec 14, 2012 at 12:30:27PM +0100, Janne Grunau wrote: Arguments on the stack are handled properly and functions can use more than arguments than the 7 registers available on x86_32. more arguments than The patch is probably OK, but wait for more opinions just in case. Diego

Re: [libav-devel] [PATCH 1/2] vp56: make parse_header return standard error codes

2012-12-14 Thread Luca Barbato
On 12/14/2012 02:44 PM, Diego Biurrun wrote: On Fri, Dec 14, 2012 at 09:59:14AM +0100, Luca Barbato wrote: --- a/libavcodec/vp5.c +++ b/libavcodec/vp5.c @@ -49,18 +49,18 @@ static int vp5_parse_header(VP56Context *s, const uint8_t *buf, int buf_size, if (vp56_rac_get(c)) {

Re: [libav-devel] Request for a raspberry pi hardware accelerated scaling function

2012-12-14 Thread towi
Attila Kinali attila@... writes: Yes3: People around here seem to think that openmax is an overly clumsy, developed behind closed doors standard. Where the develpopers of said standard didn't even think about asking those who will be using their standard until it was too late. The last words

[libav-devel] [PATCH 1/1] h264: handle complementary field pairs in await_references()

2012-12-14 Thread Janne Grunau
On 2012-12-12 16:16:21 -0800, Ronald S. Bultje wrote: On Wed, Dec 12, 2012 at 3:22 PM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-12 14:39:34 -0800, Ronald S. Bultje wrote: Hi, On Wed, Dec 12, 2012 at 12:30 PM, Janne Grunau janne-li...@jannau.net wrote: Fixes hang in

Re: [libav-devel] [PATCH 1/1] x86inc: remove wrong assert in X86_32 PROLOGUE macro

2012-12-14 Thread Ronald S. Bultje
Hi, On Dec 14, 2012 3:30 AM, Janne Grunau janne-li...@jannau.net wrote: Arguments on the stack are handled properly and functions can use more than arguments than the 7 registers available on x86_32. Fixes nasm build, yasm would fail too if it would error out on %error instead of just

Re: [libav-devel] [PATCH 2/2] vp56: release frames on error

2012-12-14 Thread Ronald S. Bultje
Hi, On Dec 14, 2012 12:59 AM, Luca Barbato lu_z...@gentoo.org wrote: Fixes CVE-2012-2783 CC: libav-sta...@libav.org --- libavcodec/vp56.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp56.c b/libavcodec/vp56.c index 6779ffb..5bd0a1a 100644 ---

Re: [libav-devel] [PATCH 1/1] x86inc: remove wrong assert in X86_32 PROLOGUE macro

2012-12-14 Thread Janne Grunau
On 2012-12-14 08:32:14 -0800, Ronald S. Bultje wrote: Hi, On Dec 14, 2012 3:30 AM, Janne Grunau janne-li...@jannau.net wrote: Arguments on the stack are handled properly and functions can use more than arguments than the 7 registers available on x86_32. Fixes nasm build, yasm would

Re: [libav-devel] [PATCH 2/2] vp56: release frames on error

2012-12-14 Thread Luca Barbato
On 12/14/12 5:33 PM, Ronald S. Bultje wrote: Hi, On Dec 14, 2012 12:59 AM, Luca Barbato lu_z...@gentoo.org wrote: Fixes CVE-2012-2783 CC: libav-sta...@libav.org --- libavcodec/vp56.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp56.c

[libav-devel] [PATCH 1/1] h264: fix memleak on error during SPS parsing

2012-12-14 Thread Janne Grunau
Introduced in d7d6efe42b0d. --- libavcodec/h264_ps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c index 0166ad2..7eb8726 100644 --- a/libavcodec/h264_ps.c +++ b/libavcodec/h264_ps.c @@ -357,7 +357,7 @@ int

[libav-devel] [PATCH 1/1] h264-mt: handle NAL_DPAs before calling ff_thread_finish_setup

2012-12-14 Thread Janne Grunau
Hi, On 2012-12-12 16:20:50 -0800, Ronald S. Bultje wrote: Hi, On Wed, Dec 12, 2012 at 12:30 PM, Janne Grunau janne-li...@jannau.net wrote: --- libavcodec/h264.c | 13 - libavcodec/h264.h | 1 + 2 files changed, 13 insertions(+), 1 deletion(-) In what situation does

Re: [libav-devel] [PATCH 1/1] x86inc: remove wrong assert in X86_32 PROLOGUE macro

2012-12-14 Thread Ronald S. Bultje
Hi, On Fri, Dec 14, 2012 at 8:56 AM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-14 08:32:14 -0800, Ronald S. Bultje wrote: Hi, On Dec 14, 2012 3:30 AM, Janne Grunau janne-li...@jannau.net wrote: Arguments on the stack are handled properly and functions can use more than

Re: [libav-devel] [PATCH 1/1] h264-mt: handle NAL_DPAs before calling ff_thread_finish_setup

2012-12-14 Thread Ronald S. Bultje
Hi, On Fri, Dec 14, 2012 at 2:33 PM, Janne Grunau janne-li...@jannau.net wrote: Hi, On 2012-12-12 16:20:50 -0800, Ronald S. Bultje wrote: Hi, On Wed, Dec 12, 2012 at 12:30 PM, Janne Grunau janne-li...@jannau.net wrote: --- libavcodec/h264.c | 13 - libavcodec/h264.h | 1

Re: [libav-devel] [PATCH 1/1] h264: fix memleak on error during SPS parsing

2012-12-14 Thread Ronald S. Bultje
Hi, On Fri, Dec 14, 2012 at 12:09 PM, Janne Grunau janne-li...@jannau.net wrote: Introduced in d7d6efe42b0d. --- libavcodec/h264_ps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) OK. Ronald ___ libav-devel mailing list

Re: [libav-devel] [PATCH 1/1] h264: handle complementary field pairs in await_references()

2012-12-14 Thread Ronald S. Bultje
Hi, On Fri, Dec 14, 2012 at 7:02 AM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-12 16:16:21 -0800, Ronald S. Bultje wrote: On Wed, Dec 12, 2012 at 3:22 PM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-12 14:39:34 -0800, Ronald S. Bultje wrote: Hi, On Wed, Dec 12,