I think there are still a bug. please consider.
-邮件原件-
发件人: libav-devel-boun...@libav.org [mailto:libav-devel-boun...@libav.org]
代表 Martin Storsj?
发送时间: 2012年12月29日 23:20
收件人: libav development
主题: Re: [libav-devel] [PATCH 7/9] hlsenc: do not add timestamps in
different timebases
On Sat,
>Consider the corner case with a list size larger than the wrap
>number.
>I'm not sure if merge it with the checks Kanglin proposed or keep it
separated
If keep it separated, Please give examples of application scenarios.
___
libav-devel mailing list
As long as we can guarantee that the memory is properly released, I was
still acceptable. Because the server or embedded development resources less
environment, and to do so may be better.
-邮件原件-
发件人: libav-devel-boun...@libav.org [mailto:libav-devel-boun...@libav.org]
代表 Martin Storsj?
发
Ok. If he replies, shared with me.
-邮件原件-
发件人: libav-devel-boun...@libav.org [mailto:libav-devel-boun...@libav.org]
代表 Luca Barbato
发送时间: 2012年12月29日 23:05
收件人: libav-devel@libav.org
主题: [libav-devel] [PATCH 8/9] hlsenc: make EXT-X-MEDIA-SEQUENCE
alwaysincrease
From: Kanglin
---
I assu
On 12/29/2012 07:34 PM, Tim W. wrote:
> On Dec 29, 2012, at 5:40 PM, Justin Ruggles wrote:
>
>> On 12/29/2012 11:00 AM, Tim W. wrote:
>>> On Dec 29, 2012, at 3:57 PM, Justin Ruggles
>>> wrote:
>>>
On 12/28/2012 08:05 PM, Tim Walker wrote:
> ---
> libavcodec/mlp_parser.c |9
On 12/29/2012 07:32 PM, Tim W. wrote:
>
> On Dec 29, 2012, at 5:35 PM, Justin Ruggles wrote:
>
>> On 12/29/2012 11:07 AM, Tim W. wrote:
>>> As a side note, I don't think there is any facility to let the user know
>>> which layout(s) the decoder can output without external (avresample) help?
>>
> + FFMAX(hls->sequence - hls->nb_entries, 0));
>why nb_entries? hls->size should do as well.
I think with nb_entries better, because it is the actual counter.
> static int hls_write_header(AVFormatContext *s)
> hls->number = 0;
> - hls->recording_time = hls->time * 100;
> + hls->recording_
On Sat, Dec 29, 2012 at 08:23:03AM +0100, Anton Khirnov wrote:
> On Fri, 28 Dec 2012 23:09:02 +0100, Diego Biurrun wrote:
> > On Fri, Dec 28, 2012 at 01:31:13PM -0800, Ronald S. Bultje wrote:
> > > On Fri, Dec 28, 2012 at 12:21 PM, Luca Barbato wrote:
> > > > On 28/12/12 19:15, Diego Biurrun wrot
On Sat, Dec 29, 2012 at 06:07:51PM +0100, Luca Barbato wrote:
> It was left over from the initial conversion.
> ---
> libavcodec/snow.c | 3 ++-
> libavcodec/snow.h | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
I had this locally already, but it does not fix FATE (completely)
when Snow
On Dec 29, 2012, at 5:40 PM, Justin Ruggles wrote:
> On 12/29/2012 11:00 AM, Tim W. wrote:
>> On Dec 29, 2012, at 3:57 PM, Justin Ruggles wrote:
>>
>>> On 12/28/2012 08:05 PM, Tim Walker wrote:
---
libavcodec/mlp_parser.c |9 +
libavcodec/mlpdec.c |2 ++
2
On Dec 29, 2012, at 5:35 PM, Justin Ruggles wrote:
> On 12/29/2012 11:07 AM, Tim W. wrote:
>> As a side note, I don't think there is any facility to let the user know
>> which layout(s) the decoder can output without external (avresample) help?
>
> AVCodec.channel_layouts could be used for tha
On 2012-12-29 02:06:40 +0100, Rafaël Carré wrote:
> Le 26/12/2012 01:41, Janne Grunau a écrit :
>
> > Before the
> > commit it was only probed once? When does it get probed? in the
> > get_format callback?
>
> It was probed only once, and you're right, it's done in the get_format
> callback:
>
---
libavresample/audio_mix.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavresample/audio_mix.c b/libavresample/audio_mix.c
index 8df8a02..12f5d24 100644
--- a/libavresample/audio_mix.c
+++ b/libavresample/audio_mix.c
@@ -87,11 +87,12 @@ void ff_audio_mix_set_f
If the matrix results in an output channel not getting a contribution
from any input channel and the corresponding input channel does not
contribute to any outputs, we can skip the channel during mixing and
silence it after mixing.
If the matrix results in an input channel not contributing to any
Hi,
On Sat, Dec 29, 2012 at 9:07 AM, Luca Barbato wrote:
> It was left over from the initial conversion.
> ---
> libavcodec/snow.c | 3 ++-
> libavcodec/snow.h | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
OK.
Ronald
___
libav-devel mailin
It was left over from the initial conversion.
---
libavcodec/snow.c | 3 ++-
libavcodec/snow.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavcodec/snow.c b/libavcodec/snow.c
index b9dab45..153e5b2 100644
--- a/libavcodec/snow.c
+++ b/libavcodec/snow.c
@@ -349,7 +349,7 @
On Sat, 29 Dec 2012, Luca Barbato wrote:
Avoid calling av_get_frame_filename twice, once to generate the
segment filename and once to generate the playlist.
---
libavformat/hlsenc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
Avoid calling av_get_frame_filename twice, once to generate the
segment filename and once to generate the playlist.
---
libavformat/hlsenc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index e039687..7abb46d 100644
--- a/libavf
On 29/12/12 17:43, Justin Ruggles wrote:
> On 12/29/2012 11:42 AM, Justin Ruggles wrote:
>> On 12/29/2012 11:07 AM, Luca Barbato wrote:
>>> Thread safe version of the common basename and dirname.
>>> ---
>>> Changelog| 3 +++
>>> doc/APIchanges | 3 +++
>>> libavutil/avstring.c
On 12/29/2012 11:42 AM, Justin Ruggles wrote:
> On 12/29/2012 11:07 AM, Luca Barbato wrote:
>> Thread safe version of the common basename and dirname.
>> ---
>> Changelog| 3 +++
>> doc/APIchanges | 3 +++
>> libavutil/avstring.c | 41 +
>
On 12/29/2012 11:07 AM, Luca Barbato wrote:
> Thread safe version of the common basename and dirname.
> ---
> Changelog| 3 +++
> doc/APIchanges | 3 +++
> libavutil/avstring.c | 41 +
> libavutil/avstring.h | 16
> libav
On 12/29/2012 11:00 AM, Tim W. wrote:
> On Dec 29, 2012, at 3:57 PM, Justin Ruggles wrote:
>
>> On 12/28/2012 08:05 PM, Tim Walker wrote:
>>> ---
>>> libavcodec/mlp_parser.c |9 +
>>> libavcodec/mlpdec.c |2 ++
>>> 2 files changed, 11 insertions(+)
>>
>> The point of deprecating
On 12/29/2012 11:07 AM, Tim W. wrote:
> As a side note, I don't think there is any facility to let the user know
> which layout(s) the decoder can output without external (avresample) help?
AVCodec.channel_layouts could be used for that.
Typically such a list would be very long though and not re
On 12/29/2012 11:05 AM, Tim W. wrote:
> On Dec 29, 2012, at 4:07 PM, Justin Ruggles wrote:
>
>> On 12/28/2012 08:05 PM, Tim Walker wrote:
>>> Allows users (e.g. avconv) to configure the output based on what will
>>> actually be decoded.
>>>
>>> Fixes the rest of bug 401.
>>> ---
>>> libavcodec/m
On Sat, 29 Dec 2012, Luca Barbato wrote:
Thread safe version of the common basename and dirname.
---
Changelog| 3 +++
doc/APIchanges | 3 +++
libavutil/avstring.c | 41 +
libavutil/avstring.h | 16
libavutil/version.h |
As a side note, I don't think there is any facility to let the user know which
layout(s) the decoder can output without external (avresample) help?
Tim
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-dev
Thread safe version of the common basename and dirname.
---
Changelog| 3 +++
doc/APIchanges | 3 +++
libavutil/avstring.c | 41 +
libavutil/avstring.h | 16
libavutil/version.h | 2 +-
5 files changed, 64 insertions(+)
On Dec 29, 2012, at 4:07 PM, Justin Ruggles wrote:
> On 12/28/2012 08:05 PM, Tim Walker wrote:
>> Allows users (e.g. avconv) to configure the output based on what will
>> actually be decoded.
>>
>> Fixes the rest of bug 401.
>> ---
>> libavcodec/mlp_parser.c | 18 +++---
>> 1 file
On Dec 29, 2012, at 3:57 PM, Justin Ruggles wrote:
> On 12/28/2012 08:05 PM, Tim Walker wrote:
>> ---
>> libavcodec/mlp_parser.c |9 +
>> libavcodec/mlpdec.c |2 ++
>> 2 files changed, 11 insertions(+)
>
> The point of deprecating request_channels is not to remove the
> functio
On Dec 29, 2012, at 3:49 PM, Justin Ruggles wrote:
> On 12/28/2012 08:05 PM, Tim Walker wrote:
>> ---
>> libavcodec/mlpdec.c | 17 +
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/libavcodec/mlpdec.c b/libavcodec/mlpdec.c
>> index 3852f6e..6af3a71 100644
>> --- a/libavco
On Sat, 29 Dec 2012, Luca Barbato wrote:
It will overflow if somebody keeps streaming for a time long enough.
---
As unlikely as it is...
libavformat/hlsenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 918ab23..1433f75 1
On Sat, 29 Dec 2012, Luca Barbato wrote:
From: Kanglin
---
I assume 64bit is enough for now, I sent an email asking for clarification
on what we should do once we wrap to the rfc authors.
libavformat/hlsenc.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavformat/
On Sat, 29 Dec 2012, Luca Barbato wrote:
start_time is in stream timebase units while end_time is
in AV_TIME_BASE ones.
---
libavformat/hlsenc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 276bd1d..14b7040 100644
--- a/
On 29/12/12 16:13, Martin Storsjö wrote:
> On Sat, 29 Dec 2012, Luca Barbato wrote:
>
>> Avoid calling av_get_frame_filename twice, once to generate the
>> segment filename and once to generate the playlist.
>> ---
>>
>> Again no changes
>
> Why didn't you do any changes, when I specifically aske
On Sat, 29 Dec 2012, Luca Barbato wrote:
From: Kanglin
recording_time is in AV_TIME_BASE units.
---
libavformat/hlsenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 6dc31d5..276bd1d 100644
--- a/libavformat/hlsenc.c
+++ b
On Sat, 29 Dec 2012, Luca Barbato wrote:
Consider the corner case with a list size larger than the wrap
number.
---
I'm not sure if merge it with the checks Kanglin proposed or keep it separated
libavformat/hlsenc.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libav
On Sat, 29 Dec 2012, Luca Barbato wrote:
Avoid calling av_get_frame_filename twice, once to generate the
segment filename and once to generate the playlist.
---
Again no changes
Why didn't you do any changes, when I specifically asked you to? See
http://patches.libav.org/patch/32437/ and
ht
On Sat, 29 Dec 2012, Luca Barbato wrote:
---
No changes here
libavformat/hlsenc.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
Still ok
// Martin
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/l
On Sat, 29 Dec 2012, Luca Barbato wrote:
The segment path is desumed from the playlist path, recording a
relative path in the playlist while serving the file could lead
to misleading results.
---
"to desume" is proper English and used at least in ietf, yet if you want
some different wording ple
On 29/12/12 16:07, Martin Storsjö wrote:
> This still isn't a char*, so I'd still want you to change the function
> to return const char*.
Looks like it slipped among rebases, changing it now. Sorry.
___
libav-devel mailing list
libav-devel@libav.org
ht
On Sat, 29 Dec 2012, Luca Barbato wrote:
Thread safe version of the common basename and dirname.
---
No changes to the code, the note for dirname still has "may".
Changelog| 3 +++
doc/APIchanges | 3 +++
libavutil/avstring.c | 41 +
lib
On 12/28/2012 08:05 PM, Tim Walker wrote:
> ---
> libavcodec/mlpdec.c |8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/libavcodec/mlpdec.c b/libavcodec/mlpdec.c
> index 27d2c98..e6a610a 100644
> --- a/libavcodec/mlpdec.c
> +++ b/libavcodec/mlpdec.c
> @@ -441,11
On 12/28/2012 08:05 PM, Tim Walker wrote:
> Allows users (e.g. avconv) to configure the output based on what will
> actually be decoded.
>
> Fixes the rest of bug 401.
> ---
> libavcodec/mlp_parser.c | 18 +++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/
It will overflow if somebody keeps streaming for a time long enough.
---
As unlikely as it is...
libavformat/hlsenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 918ab23..1433f75 100644
--- a/libavformat/hlsenc.c
+++ b/lib
From: Kanglin
---
I assume 64bit is enough for now, I sent an email asking for clarification
on what we should do once we wrap to the rfc authors.
libavformat/hlsenc.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 14b7
start_time is in stream timebase units while end_time is
in AV_TIME_BASE ones.
---
libavformat/hlsenc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 276bd1d..14b7040 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat/hls
From: Kanglin
recording_time is in AV_TIME_BASE units.
---
libavformat/hlsenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 6dc31d5..276bd1d 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat/hlsenc.c
@@ -193,7 +193,7 @@
Consider the corner case with a list size larger than the wrap
number.
---
I'm not sure if merge it with the checks Kanglin proposed or keep it separated
libavformat/hlsenc.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
ind
Avoid calling av_get_frame_filename twice, once to generate the
segment filename and once to generate the playlist.
---
Again no changes
libavformat/hlsenc.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index e039687
---
No changes here
libavformat/hlsenc.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 418c87d..e039687 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat/hlsenc.c
@@ -259,9 +259,12 @@ static int hls_write_packet(A
The segment path is desumed from the playlist path, recording a
relative path in the playlist while serving the file could lead
to misleading results.
---
"to desume" is proper English and used at least in ietf, yet if you want
some different wording please tell.
libavformat/hlsenc.c | 3 ++-
1
Thread safe version of the common basename and dirname.
---
No changes to the code, the note for dirname still has "may".
Changelog| 3 +++
doc/APIchanges | 3 +++
libavutil/avstring.c | 41 +
libavutil/avstring.h | 16
On 12/28/2012 08:05 PM, Tim Walker wrote:
> Fixes part of bug 401.
> ---
> libavcodec/mlpdec.c |6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/mlpdec.c b/libavcodec/mlpdec.c
> index 6f0a2c6..cb5192c 100644
> --- a/libavcodec/mlpdec.c
> +++ b/libavcodec
On 12/28/2012 08:05 PM, Tim Walker wrote:
> Fixes bug 208.
> ---
> libavcodec/mlpdec.c | 35 +++
> 1 file changed, 35 insertions(+)
LGTM
-Justin
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.o
On 12/28/2012 08:05 PM, Tim Walker wrote:
> ---
> libavcodec/mlp_parser.c |9 +
> libavcodec/mlpdec.c |2 ++
> 2 files changed, 11 insertions(+)
The point of deprecating request_channels is not to remove the
functionality completely, but to replace it with request_channel_layo
On 12/28/2012 08:05 PM, Tim Walker wrote:
> ---
> libavcodec/mlpdec.c | 17 +
> 1 file changed, 17 insertions(+)
>
> diff --git a/libavcodec/mlpdec.c b/libavcodec/mlpdec.c
> index 3852f6e..6af3a71 100644
> --- a/libavcodec/mlpdec.c
> +++ b/libavcodec/mlpdec.c
> @@ -28,6 +28,7 @@
On 12/28/2012 08:05 PM, Tim Walker wrote:
> ---
> libavcodec/mlp_parser.h | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
LGTM
-Justin
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/
On 12/28/2012 08:05 PM, Tim Walker wrote:
> Also stop storing the channel arrangement, as it's unused outside of
> ff_mlp_read_major_sync.
> ---
> libavcodec/mlp_parser.c | 26 --
> libavcodec/mlp_parser.h |9 ++---
> 2 files changed, 22 insertions(+), 13 deletio
On 29/12/12 08:30, kanglin wrote:
> There are four cases:
You are mixing up a number of issues and they should be split.
> + FFMAX(hls->sequence - hls->nb_entries, 0));
why nb_entries? hls->size should do as well.
> static int hls_write_header(AVFormatContext *s)
> hls->number = 0;
> - hls-
59 matches
Mail list logo
