Re: [libav-devel] [PATCH] oggenc: add a page_duration option and deprecate the pagesize option

2012-12-30 Thread Luca Barbato
On 31/12/12 01:41, Justin Ruggles wrote: > This uses page duration instead of byte size to determine when to buffer > the page. Also, it tries to avoid continued pages by buffering the current > page if there are already packets in the page and adding the next packet > would require it to be contin

[libav-devel] [PATCH] oggenc: add a page_duration option and deprecate the pagesize option

2012-12-30 Thread Justin Ruggles
This uses page duration instead of byte size to determine when to buffer the page. Also, it tries to avoid continued pages by buffering the current page if there are already packets in the page and adding the next packet would require it to be continued on a new page. This can improve seeking perfo

Re: [libav-devel] [PATCH 4/4] rtmp: Add support for limelight authentication

2012-12-30 Thread Luca Barbato
On 30/12/12 23:58, Martin Storsjö wrote: > - av_md5_init(md5); > - av_md5_update(md5, user, strlen(user)); > - av_md5_update(md5, salt, strlen(salt)); > - av_md5_update(md5, rt->password, strlen(rt->password)); > - av_md5_final(md5, hash); > - av_base64_encode(hashstr, sizeof(hashstr), hash, > - si

Re: [libav-devel] [PATCH 3/4] rtmp: Add support for adobe authentication

2012-12-30 Thread Luca Barbato
On 30/12/12 23:58, Martin Storsjö wrote: > This is mostly used to authenticate the client when publishing. > Tested with wowza and akamai. > > Some but not all servers support resending a new connect invoke > within the same connection, so always reconnect for sending a new > connection attempt. T

Re: [libav-devel] [PATCH 2/4] rtmp: Add a function for writing AMF strings based on two substrings

2012-12-30 Thread Luca Barbato
On 30/12/12 23:58, Martin Storsjö wrote: > This avoids having to concatenate them into one buffer before writing > them as AMF. > --- > libavformat/rtmppkt.c | 13 + > libavformat/rtmppkt.h |9 + > 2 files changed, 22 insertions(+) > Ok. ___

Re: [libav-devel] [PATCH 1/4] rtmp: Return a proper error code in handle_invoke_error

2012-12-30 Thread Luca Barbato
On 30/12/12 23:58, Martin Storsjö wrote: > --- > libavformat/rtmpproto.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Ok ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] configure: suppress -fPIC in msvc builds

2012-12-30 Thread Diego Biurrun
On Mon, Dec 31, 2012 at 01:45:43AM +0200, Martin Storsjö wrote: > From: Hendrik Leppkes > > MSVC doesn't understand the option, and emits a warning on every > call to cl.exe. > --- > configure |1 + > 1 file changed, 1 insertion(+) OK Diego ___ l

Re: [libav-devel] [PATCH 1/4] rtmp: Return a proper error code in handle_invoke_error

2012-12-30 Thread Diego Biurrun
On Mon, Dec 31, 2012 at 12:58:09AM +0200, Martin Storsjö wrote: > --- > libavformat/rtmpproto.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) probably OK Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mail

Re: [libav-devel] [PATCH] oggenc: add a page_duration option and deprecate the pagesize option

2012-12-30 Thread Luca Barbato
On 30/12/12 23:45, Justin Ruggles wrote: > On 12/30/2012 05:42 PM, Justin Ruggles wrote: >> -OGGPageList *l = av_mallocz(sizeof(*l)); >> +OGGPageList *l; >> >> +l = av_mallocz(sizeof(*l)); > > Sorry, that unrelated change is a WIP leftover I forgot to change back. > Fixed locally. O

Re: [libav-devel] [PATCH] configure: suppress -fPIC in msvc builds

2012-12-30 Thread Derek Buitenhuis
On 30/12/2012 6:45 PM, Martin Storsjö wrote: > From: Hendrik Leppkes > > MSVC doesn't understand the option, and emits a warning on every > call to cl.exe. > --- > configure |1 + > 1 file changed, 1 insertion(+) LGTM. - Derek ___ libav-devel mai

Re: [libav-devel] [PATCH] Drop unnecessary 'l' length modifier when printfing double values.

2012-12-30 Thread Martin Storsjö
On Mon, 31 Dec 2012, Diego Biurrun wrote: %f denotes a double argument and 'l' does nothing in this case according to the C spec. --- libavfilter/vf_frei0r.c |2 +- libavfilter/vf_hqdn3d.c |2 +- libavfilter/vsrc_movie.c |2 +- libavutil/opt.c |2 +- 4 files changed, 4 ins

[libav-devel] [PATCH] configure: suppress -fPIC in msvc builds

2012-12-30 Thread Martin Storsjö
From: Hendrik Leppkes MSVC doesn't understand the option, and emits a warning on every call to cl.exe. --- configure |1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 0ede1d5..e87a326 100755 --- a/configure +++ b/configure @@ -2187,6 +2187,7 @@ msvc_flags(){

[libav-devel] [PATCH] Drop unnecessary 'l' length modifier when printfing double values.

2012-12-30 Thread Diego Biurrun
%f denotes a double argument and 'l' does nothing in this case according to the C spec. --- libavfilter/vf_frei0r.c |2 +- libavfilter/vf_hqdn3d.c |2 +- libavfilter/vsrc_movie.c |2 +- libavutil/opt.c |2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a

[libav-devel] [PATCH 4/4] rtmp: Add support for limelight authentication

2012-12-30 Thread Martin Storsjö
Limelight is a not too uncommon CDN. The authentication scheme is pretty similar to the adobe authentication, but is even closer to normal http digest authentication (but not close enough to warrant sharing code) than the adobe version. --- libavformat/rtmpproto.c | 107 ++

[libav-devel] [PATCH 3/4] rtmp: Add support for adobe authentication

2012-12-30 Thread Martin Storsjö
This is mostly used to authenticate the client when publishing. Tested with wowza and akamai. Some but not all servers support resending a new connect invoke within the same connection, so always reconnect for sending a new connection attempt. This matches what other applications do as well. The

[libav-devel] [PATCH 2/4] rtmp: Add a function for writing AMF strings based on two substrings

2012-12-30 Thread Martin Storsjö
This avoids having to concatenate them into one buffer before writing them as AMF. --- libavformat/rtmppkt.c | 13 + libavformat/rtmppkt.h |9 + 2 files changed, 22 insertions(+) diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c index f69ce82..aed188d 100644 ---

[libav-devel] [PATCH 1/4] rtmp: Return a proper error code in handle_invoke_error

2012-12-30 Thread Martin Storsjö
--- libavformat/rtmpproto.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 8924fb3..4e059d6 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -1533,7 +1533,7 @@ static int handle_invoke_error(URLCon

Re: [libav-devel] [PATCH] oggenc: add a page_duration option and deprecate the pagesize option

2012-12-30 Thread Justin Ruggles
On 12/30/2012 05:42 PM, Justin Ruggles wrote: > -OGGPageList *l = av_mallocz(sizeof(*l)); > +OGGPageList *l; > > +l = av_mallocz(sizeof(*l)); Sorry, that unrelated change is a WIP leftover I forgot to change back. Fixed locally. -Justin _

[libav-devel] [PATCH] oggenc: add a page_duration option and deprecate the pagesize option

2012-12-30 Thread Justin Ruggles
This uses page duration instead of byte size to determine when to buffer the page. Also, it tries to avoid continued pages by buffering the current page if there are already packets in the page and adding the next packet would require it to be continued on a new page. This can improve seeking perfo

Re: [libav-devel] [PATCH] truemotion2: Sanitize tm2_read_header()

2012-12-30 Thread Justin Ruggles
On 12/30/2012 04:12 PM, Diego Biurrun wrote: > Also give a variable a more sensible name. > --- > > And now with missing parentheses ... > > libavcodec/truemotion2.c | 44 +--- > 1 files changed, 21 insertions(+), 23 deletions(-) LGTM -Justin

[libav-devel] [PATCH] truemotion2: Sanitize tm2_read_header()

2012-12-30 Thread Diego Biurrun
Also give a variable a more sensible name. --- And now with missing parentheses ... libavcodec/truemotion2.c | 44 +--- 1 files changed, 21 insertions(+), 23 deletions(-) diff --git a/libavcodec/truemotion2.c b/libavcodec/truemotion2.c index 5b441e1..2d

Re: [libav-devel] [PATCH] truemotion2: Sanitize tm2_read_header()

2012-12-30 Thread Justin Ruggles
On 12/30/2012 11:44 AM, Diego Biurrun wrote: > +if (ret = tm2_read_header(l, swbuf) < 0) { Doesn't that have to be wrapped in another set of parentheses? -Justin ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/lis

[libav-devel] [PATCH] truemotion2: Sanitize tm2_read_header()

2012-12-30 Thread Diego Biurrun
Also give a variable a more sensible name. --- Now passing on the error return value from tm2_read_header(). libavcodec/truemotion2.c | 44 +--- 1 files changed, 21 insertions(+), 23 deletions(-) diff --git a/libavcodec/truemotion2.c b/libavcodec/truemo

Re: [libav-devel] [PATCH] truemotion2: Sanitize tm2_read_header()

2012-12-30 Thread Justin Ruggles
On 12/30/2012 08:46 AM, Diego Biurrun wrote: > Also give a variable a more sensible name. > --- > > Squashed the two patches together according to Justin's preference. > > libavcodec/truemotion2.c | 42 -- > 1 files changed, 20 insertions(+), 22 deletion

Re: [libav-devel] [PATCH 4/5] fate: pcm: Add dependencies

2012-12-30 Thread Diego Biurrun
On Thu, Dec 06, 2012 at 06:10:12PM +0100, Janne Grunau wrote: > On 2012-11-28 20:04:11 +0100, Diego Biurrun wrote: > > --- a/tests/fate/pcm.mak > > +++ b/tests/fate/pcm.mak > > @@ -1,32 +1,35 @@ > > -FATE_SAMPLES_PCM += fate-iff-pcm > > +FATE_SAMPLES_PCM-$(call DEMDEC, WAV, PCM_U8) += fate-iff-pcm

Re: [libav-devel] [PATCH] fate: cover-art: Add dependencies

2012-12-30 Thread Diego Biurrun
On Fri, Dec 07, 2012 at 01:03:24PM +0100, Janne Grunau wrote: > On 2012-12-07 11:32:18 +0100, Diego Biurrun wrote: > > --- > > Add missing dependency on MJPEG decoder for the actual cover images. > > --- a/tests/fate/cover-art.mak > > +++ b/tests/fate/cover-art.mak > > @@ -1,23 +1,23 @@ > > -FATE_C

[libav-devel] [PATCH 2/3] fate: cosmetics: Order some test entries

2012-12-30 Thread Diego Biurrun
--- tests/fate/cdxl.mak |6 +++--- tests/fate/lossless-video.mak | 12 ++-- tests/fate/microsoft.mak | 12 ++-- tests/fate/seek.mak | 16 tests/fate/utvideo.mak| 30 +++--- tests/fate/vcodec.mak

[libav-devel] [PATCH 3/3] fate: vp3: Fix fate-vp3-coeff-level64 test dependencies

2012-12-30 Thread Diego Biurrun
Also rename the test to reflect that the video track is Theora, not VP3. --- tests/fate/vpx.mak |8 .../{vp3-coeff-level64 => theora-coeff-level64}|0 2 files changed, 4 insertions(+), 4 deletions(-) rename tests/ref/fate/{vp3-coeff-level64 =>

[libav-devel] [PATCH 1/3] fate: Fix fate-siff dependencies and move to a more appropriate file

2012-12-30 Thread Diego Biurrun
The test is not a pure demuxer test, it also tests VB video decoding. --- tests/fate/demux.mak |3 --- tests/fate/video.mak |3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/fate/demux.mak b/tests/fate/demux.mak index d917cca..c245a13 100644 --- a/tests/fate/demu

[libav-devel] [PATCH] truemotion2: Sanitize tm2_read_header()

2012-12-30 Thread Diego Biurrun
Also give a variable a more sensible name. --- Squashed the two patches together according to Justin's preference. libavcodec/truemotion2.c | 42 -- 1 files changed, 20 insertions(+), 22 deletions(-) diff --git a/libavcodec/truemotion2.c b/libavcodec/tr

Re: [libav-devel] [PATCH] libavcodec/utils: Add braces to shut up gcc warnings

2012-12-30 Thread Luca Barbato
On 30/12/12 12:27, Diego Biurrun wrote: > Feel free to do that. In the meantime I see no point in not applying > this patch, we have more instances of '{ { 0 } }' throughout and they > hardly hurt. I thought I told you to go for it before, by all means, apply anytime =) lu _

Re: [libav-devel] [PATCH] libavcodec/utils: Add braces to shut up gcc warnings

2012-12-30 Thread Diego Biurrun
On Sun, Dec 30, 2012 at 11:05:35AM +0100, Luca Barbato wrote: > On 30/12/12 02:09, Diego Biurrun wrote: > > On Sat, Dec 29, 2012 at 08:23:03AM +0100, Anton Khirnov wrote: > >> On Fri, 28 Dec 2012 23:09:02 +0100, Diego Biurrun wrote: > >>> On Fri, Dec 28, 2012 at 01:31:13PM -0800, Ronald S. Bultje

Re: [libav-devel] [PATCH] snow: use VideoDSPContext

2012-12-30 Thread Luca Barbato
On 30/12/12 02:06, Diego Biurrun wrote: > On Sat, Dec 29, 2012 at 06:07:51PM +0100, Luca Barbato wrote: >> It was left over from the initial conversion. >> --- >> libavcodec/snow.c | 3 ++- >> libavcodec/snow.h | 1 + >> 2 files changed, 3 insertions(+), 1 deletion(-) > > I had this locally alrea

Re: [libav-devel] [PATCH] libavcodec/utils: Add braces to shut up gcc warnings

2012-12-30 Thread Luca Barbato
On 30/12/12 02:09, Diego Biurrun wrote: > On Sat, Dec 29, 2012 at 08:23:03AM +0100, Anton Khirnov wrote: >> On Fri, 28 Dec 2012 23:09:02 +0100, Diego Biurrun wrote: >>> On Fri, Dec 28, 2012 at 01:31:13PM -0800, Ronald S. Bultje wrote: On Fri, Dec 28, 2012 at 12:21 PM, Luca Barbato wrote: >>>

Re: [libav-devel] hlsenc:Fixed #EXT-X-MEDIA-SEQUENCE calculation error, when setting to the hls_wrap

2012-12-30 Thread Luca Barbato
On 30/12/12 02:10, kanglin wrote: > >> + FFMAX(hls->sequence - hls->nb_entries, 0)); > >> why nb_entries? hls->size should do as well. > > I think with nb_entries better, because it is the actual counter. I kept the size, hopefully I'll get an answer from the rfc authors on the wrap around. >>