Re: [libav-devel] [PATCH] compat: Add DLL import function pointers for MSVC

2013-05-01 Thread Martin Storsjö
On Wed, 1 May 2013, Derek Buitenhuis wrote: On 2013-05-01 6:17 PM, Martin Storsjö wrote: The symbol naming trickery has been tested on x86, x86_64 and arm. And yes, this is ugly as hell. Suggestions on a cleaner way of doing it are welcome, but this is less intrusive than most other solutions.

Re: [libav-devel] [PATCH] compat: Add DLL import function pointers for MSVC

2013-05-01 Thread Derek Buitenhuis
On 2013-05-01 6:17 PM, Martin Storsjö wrote: > The symbol naming trickery has been tested on x86, x86_64 and arm. > > And yes, this is ugly as hell. Suggestions on a cleaner way of doing it > are welcome, but this is less intrusive than most other solutions. Having hit this problem myself, and th

[libav-devel] [PATCH] configure: Check for getenv

2013-05-01 Thread Martin Storsjö
When targeting the "windows store application" (metro) API subset (or the windows phone API subset), the getenv function isn't available. If it is unavailable, just define getenv to NULL. The check uses check_func_headers, since the function actually might exist in the libraries, but is hidden in

[libav-devel] [PATCH] configure: Check for getenv on msvc

2013-05-01 Thread Martin Storsjö
When targeting the "windows store application" (metro) API subset (or the windows phone API subset), the getenv function isn't available. If it is unavailable, just define getenv to NULL. The check uses check_func_headers, since the function actually might exist in the libraries, but is hidden in

[libav-devel] [PATCH] compat: Add DLL import function pointers for MSVC

2013-05-01 Thread Martin Storsjö
If building libav with -MD in the cflags (for making the msvc compiler generate code for using a dynamically linked libc), the system headers that declare strtod, snprintf and vsnprintf declare the functions as imported from a DLL. To hook up wrappers of our own for these functions, the function na

Re: [libav-devel] [PATCH] wav: chunks start always at even length

2013-05-01 Thread Kostya Shishkov
On Wed, May 01, 2013 at 07:45:52PM +0200, Luca Barbato wrote: > On 05/01/2013 07:29 PM, Luca Barbato wrote: > > From: Kostya Shishkov > > > > CC:libav-sta...@libav.org > > Bug-id: 500 > > Signed-off-by: Luca Barbato > > Seems correct to me obviously I'd say that it applies to all RIFF chunks.

Re: [libav-devel] [PATCH] wav: chunks start always at even length

2013-05-01 Thread Luca Barbato
On 05/01/2013 07:29 PM, Luca Barbato wrote: > From: Kostya Shishkov > > CC:libav-sta...@libav.org > Bug-id: 500 > Signed-off-by: Luca Barbato Seems correct to me obviously lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/

[libav-devel] [PATCH] wav: chunks start always at even length

2013-05-01 Thread Luca Barbato
From: Kostya Shishkov CC:libav-sta...@libav.org Bug-id: 500 Signed-off-by: Luca Barbato --- libavformat/wavdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index c9f7abb..84f6ce5 100644 --- a/libavformat/wavdec.c +++ b/libavfo

[libav-devel] [PATCH 2/2] id3v2: check for end of file while unescaping tags

2013-05-01 Thread Luca Barbato
Prevent a serious out of buffer bound write. Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC:libav-sta...@libav.org --- libavformat/id3v2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c index a6a483c..e625f5a 100644

[libav-devel] [PATCH 1/2] id3v2: K&R formatting cosmetics

2013-05-01 Thread Luca Barbato
--- libavformat/id3v2.c | 127 +++- 1 file changed, 76 insertions(+), 51 deletions(-) diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c index 7bcea21..a6a483c 100644 --- a/libavformat/id3v2.c +++ b/libavformat/id3v2.c @@ -259,7 +259,8 @@ static

[libav-devel] [PATCH] id3v2: check for end of file while unescaping tags

2013-05-01 Thread Luca Barbato
Prevent a serious out of buffer bound write. Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC:libav-sta...@libav.org --- libavformat/id3v2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c index a6a483c..e625f5a 100644

[libav-devel] [PATCH] id3v2: K&R formatting cosmetics

2013-05-01 Thread Luca Barbato
--- libavformat/id3v2.c | 127 +++- 1 file changed, 76 insertions(+), 51 deletions(-) diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c index 7bcea21..a6a483c 100644 --- a/libavformat/id3v2.c +++ b/libavformat/id3v2.c @@ -259,7 +259,8 @@ static

Re: [libav-devel] [PATCH] Fix reading wav files with odd-length chunks.

2013-05-01 Thread Luca Barbato
On 05/01/2013 04:37 PM, Kostya Shishkov wrote: > next_tag_ofs = avio_tell(pb) + size + (size & 1); Looks better indeed. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/3 v2] avcodec: doxy: Clarify what get_buffer2 must fill in buf[]

2013-05-01 Thread Diego Biurrun
On Tue, Apr 30, 2013 at 01:36:52PM -0400, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > Diego: I've not used @see, since it inserts a "See Also" header of > sorts at the end of teh section, and I'd rather keep thee function > references in the description of buf[], since it's w

Re: [libav-devel] [PATCH] Fix reading wav files with odd-length chunks.

2013-05-01 Thread Kostya Shishkov
On Wed, May 01, 2013 at 11:43:09AM +0200, Jan Gerber wrote: > forward patch from ffmpeg, > fixes http://bugzilla.libav.org/show_bug.cgi?id=500 > >From 68755a1adefd0e3f2356c85e4d3bd435a01118ae Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Mon, 8 Apr 2013 19:36:01 +0200 > Subject: [PATC

[libav-devel] [PATCH] Fix reading wav files with odd-length chunks.

2013-05-01 Thread Jan Gerber
forward patch from ffmpeg, fixes http://bugzilla.libav.org/show_bug.cgi?id=500 >From 68755a1adefd0e3f2356c85e4d3bd435a01118ae Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 8 Apr 2013 19:36:01 +0200 Subject: [PATCH] Fix reading wav files with odd-length chunks. Fixes ticket #2417. ---