On Tue, 23 Jul 2013, Diego Biurrun wrote:
On Tue, Jul 23, 2013 at 10:28:25PM +0300, Martin Storsjö wrote:
On Tue, 23 Jul 2013, Luca Barbato wrote:
Diego Biurrun wrote:
On Tue, Jul 23, 2013 at 02:51:23PM +0200, Hendrik Leppkes wrote:
On Tue, Jul 23, 2013 at 2:49 PM, Luca Barbato
wrote:
O
On Jul 23, 2013 11:37 PM, "Diego Biurrun" wrote:
>
> ---
>
> Now with Vitor's comments addressed.
One last comment.
= (bit_size + 13) / 14;
>
> -rounded_up = (bit_size + tctx->n_div[i] - 1)/tctx->n_div[i];
> -rounded_down = (bit_size )/tctx->n_div[i];
> -num_r
From: Rainer Hochecker
VDPAU expects the bitstream value (0, 2 or 3).
libavcodec uses a enum (0, 1 or 2).
Signed-off-by: Rémi Denis-Courmont
---
libavcodec/vdpau_vc1.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/vdpau_vc1.c b/libavcodec/vdpau_vc1.c
index 8
On 07/22/2013 10:08 PM, Rémi Denis-Courmont wrote:
> Or should I reuse the same version number for both?
Probably we could squash the whole thing in a single commit in the end,
thanks for splitting and making easier to review.
lu
___
libav-devel maili
Le lundi 22 juillet 2013 23:07:14 Rémi Denis-Courmont a écrit :
> The bitstream buffers are now private and freed by libavcodec. For
> backward compatibility, the hold bitstream buffer pointer is left NULL
> (applications were supposed to av_freep() it).
> ---
> doc/APIchanges | 3 +++
---
configure | 11 --
libavcodec/allcodecs.c| 6 -
libavcodec/error_resilience.c | 1 -
libavcodec/h263dec.c | 7 -
libavcodec/h264.c | 48 +-
libavcodec/mpeg12.c | 1 -
libavcodec/mpeg12dec.c| 55 +--
libavcode
This sanitizes frame threading sane and hides libavcodec<->libvdpau
internal buffers from the application.
---
libavcodec/Makefile | 2 +-
libavcodec/vdpau.c | 33 ++---
libavcodec/vdpau_h264.c | 31 ++-
libavcodec/vdpa
On 07/22/2013 06:08 PM, Martin Storsjo wrote:
> ---
> gas-preprocessor.pl |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
> index a560921..c02e0b6 100755
> --- a/gas-preprocessor.pl
> +++ b/gas-preprocessor.pl
> @@ -224,7 +224,
Slice threading does not work with hardware acceleration, as decoding
is per-picture.
This fixes https://bugzilla.libav.org/show_bug.cgi?id=542
---
libavcodec/mpeg12dec.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.
Screw that. A few more zombie bits to be removed.
--
Rémi Denis-Courmont
http://www.remlab.net/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
---
doc/APIchanges | 3 +++
libavutil/old_pix_fmts.h | 4
libavutil/pixdesc.c | 2 ++
libavutil/pixfmt.h | 4
libavutil/version.h | 5 -
5 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/doc/APIchanges b/doc/APIchanges
index cdfcc09..52672f5 100
---
doc/APIchanges | 3 +++
libavcodec/avcodec.h | 2 ++
libavcodec/vdpau.h | 3 ++-
libavcodec/version.h | 5 -
4 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/doc/APIchanges b/doc/APIchanges
index 52672f5..0d87f04 100644
--- a/doc/APIchanges
+++ b/doc/APIchanges
@@ -1
Hello,
This is basically the same as previous, with vdpau_render_state also
marked for removal.
configure | 11 -
doc/APIchanges|6
libavcodec/allcodecs.c|6
libavcodec/avcodec.h |2
libavcodec/error_resilience.c |
On Mon, 22 Jul 2013, Luca Barbato wrote:
On 07/22/2013 11:35 AM, Martin Storsjo wrote:
When the .unreq is part of a .rept, both of them need to go along
with each other so that they end up at the right place in the repeated
output.
Both patches sound ok, we should start collecting small testc
On Mon, 22 Jul 2013, Luca Barbato wrote:
Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-sta...@libav.org
---
libavcodec/4xm.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavcodec/4xm.c b/libavcodec/4xm.c
index a4e6965..2c63eb1 100644
--- a/libavcodec/4xm.c
+++
Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-sta...@libav.org
---
libavcodec/4xm.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavcodec/4xm.c b/libavcodec/4xm.c
index a4e6965..2c63eb1 100644
--- a/libavcodec/4xm.c
+++ b/libavcodec/4xm.c
@@ -807,6 +807,11 @@ st
output_picture_number tells us the output or presentation order and shall
be unique within a sequence.
This corresponds to H.264/H.265 PicOrderCnt and Dirac picture number.
Attached patches support parsing H.264 PicOrderCnt.
0001-avcodec-Add-output-picture-number-to-AVCodecParserCo.patch
Descrip
On Mon, Jul 22, 2013 at 12:33:22PM +0300, Martin Storsjö wrote:
> ---
> libavcodec/arm/dcadsp_vfp.S |2 +-
> libavcodec/arm/mdct_vfp.S |4 ++--
> libavcodec/arm/synth_filter_vfp.S |2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
looks OK
When the .unreq is part of a .rept, both of them need to go along
with each other so that they end up at the right place in the repeated
output.
---
gas-preprocessor.pl |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
index 755d9fd..b
---
IMO more readable. The '0.' (and friends) notation keeps confusing me.
libavcodec/aac_tablegen.h |2 +-
libavcodec/aacdec.c |4 ++--
libavcodec/aacps_tablegen.h |2 +-
libavcodec/acelp_vectors.c |4 ++--
libavcodec/qcelpdec.c |6 +++---
libavcodec/ra288.
On Tue, Jul 23, 2013 at 08:00:42PM +0200, Vitor Sessak wrote:
> On Tue, Jul 23, 2013 at 2:28 PM, Diego Biurrun wrote:
> >
> > Now taking the comments from Vitor and Luca into account.
> >
> > libavcodec/twinvq.c | 584
> > --
> > libavcodec/twinvq
On 07/21/2013 11:34 PM, Diego Biurrun wrote:
> On Sat, Jul 20, 2013 at 05:45:50PM +0200, Vitor Sessak wrote:
>> On Jul 20, 2013 12:26 AM, "Diego Biurrun" wrote:
>>>
>>> ---
>>>
>>> I removed parts of the changes to twinvq_data.h, as adding 4 spaces of
>>> indentation to all those tables makes for
On Sat, Jul 20, 2013 at 05:45:50PM +0200, Vitor Sessak wrote:
> On Jul 20, 2013 12:26 AM, "Diego Biurrun" wrote:
> >
> > ---
> >
> > I removed parts of the changes to twinvq_data.h, as adding 4 spaces of
> > indentation to all those tables makes for a 1.5MB patch. I kid you not ..
>
> If what yo
On Sat, Jul 20, 2013 at 01:34:16PM +0300, Rémi Denis-Courmont wrote:
> --- a/libavcodec/version.h
> +++ b/libavcodec/version.h
> @@ -27,7 +27,7 @@
> */
>
> #define LIBAVCODEC_VERSION_MAJOR 55
> -#define LIBAVCODEC_VERSION_MINOR 10
> +#define LIBAVCODEC_VERSION_MINOR 11
> #define LIBAVCODEC_VE
On Mon, Jul 22, 2013 at 11:26:51PM +0200, Luca Barbato wrote:
> Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
> CC: libav-sta...@libav.org
> ---
> libavcodec/8bps.c | 10 +++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/8bps.c b/libavcodec/8bps.
On Tue, Jul 23, 2013 at 06:26:36PM +0300, Rémi Denis-Courmont wrote:
> Le mardi 23 juillet 2013 17:18:25 Martin Storsjö a écrit :
> > --- a/libavformat/wtv.c
> > +++ b/libavformat/wtv.c
> > @@ -155,7 +155,7 @@ static AVIOContext * wtvfile_open_sector(int
> > first_sector, uint64_t length, int WtvFi
On Tue, Jul 23, 2013 at 10:28:25PM +0300, Martin Storsjö wrote:
> On Tue, 23 Jul 2013, Luca Barbato wrote:
>
> >Diego Biurrun wrote:
> >>On Tue, Jul 23, 2013 at 02:51:23PM +0200, Hendrik Leppkes wrote:
> >>>On Tue, Jul 23, 2013 at 2:49 PM, Luca Barbato
> >>wrote:
> On 07/23/2013 02:39 PM, Di
On 07/22/2013 10:40 PM, Rémi Denis-Courmont wrote:
> From: Rainer Hochecker
>
> VDPAU expects the bitstream value (0, 2 or 3).
> libavcodec uses a enum (0, 1 or 2).
>
Ok.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mail
On 07/12/2013 05:54 PM, Luca Barbato wrote:
> if (ht_size > INT32_MAX)
> -return -1;
> +return AVERROR_INVALIDDATA;
This condition isn't technically invalid data (although it would be
extremely odd). It's just that our bitstream reader uses int for bit
counts. So this is more
On 07/12/2013 05:10 PM, Luca Barbato wrote:
> mcc_weightings is only 32 elements.
>
> Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
> CC: libav-sta...@libav.org
LGTM. Although it might also be nice to log a warning in addition to the
clipping. The spec doesn't mention how to handle ou
The bitstream buffers are now private and freed by libavcodec. For
backward compatibility, the hold bitstream buffer pointer is left NULL
(applications were supposed to av_freep() it).
---
doc/APIchanges | 3 +++
libavcodec/vdpau.h | 8
libavcodec/vdpau_internal.h |
Le lundi 22 juillet 2013 22:00:48 Luca Barbato a écrit :
> On 07/22/2013 09:48 PM, Rémi Denis-Courmont wrote:
> > Slice threading does not work with hardware acceleration, as decoding
> > is per-picture.
> >
> > This fixes https://bugzilla.libav.org/show_bug.cgi?id=542
> > ---
> >
> > libavcodec
On 07/22/2013 10:05 PM, Rémi Denis-Courmont wrote:
> ---
> configure | 11 --
> libavcodec/allcodecs.c| 6 -
> libavcodec/error_resilience.c | 1 -
> libavcodec/h263dec.c | 7 -
> libavcodec/h264.c | 48 +-
> libavcodec/mpeg12.c
On 07/22/2013 09:48 PM, Rémi Denis-Courmont wrote:
> Slice threading does not work with hardware acceleration, as decoding
> is per-picture.
>
> This fixes https://bugzilla.libav.org/show_bug.cgi?id=542
> ---
> libavcodec/mpeg12dec.c |9 ++---
> 1 file changed, 6 insertions(+), 3 deletion
On 07/12/2013 11:10 PM, Luca Barbato wrote:
> mcc_weightings is only 32 elements.
>
> Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
> CC: libav-sta...@libav.org
> ---
>
> Not related to the theoretically negative block_lenght that I'm tracking
> back to parse_bs_info.
>
> I do not ha
---
configure | 11 --
libavcodec/allcodecs.c| 6 -
libavcodec/error_resilience.c | 1 -
libavcodec/h263dec.c | 6 -
libavcodec/h264.c | 47 +-
libavcodec/mpeg12dec.c| 54 +--
libavcodec/mpeg4videodec.c| 18 ---
libavco
---
gas-preprocessor.pl |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
index a560921..c02e0b6 100755
--- a/gas-preprocessor.pl
+++ b/gas-preprocessor.pl
@@ -224,7 +224,7 @@ sub parse_line {
$current_macro = '';
---
libavformat/asfenc.c |6 +++---
libavformat/avidec.c |2 +-
libavformat/avienc.c |4 ++--
libavformat/aviobuf.c|4 ++--
libavformat/bmv.c|5 ++---
libavformat/concat.c |7 +++
libavformat/cu
On 07/22/2013 12:19 PM, Yusuke Nakamura wrote:
> output_picture_number tells us the output or presentation order and shall
> be unique within a sequence.
> This corresponds to H.264/H.265 PicOrderCnt and Dirac picture number.
>
> Attached patches support parsing H.264 PicOrderCnt.
>
>
Probably
On 07/21/2013 06:56 PM, Justin Ruggles wrote:
> On 07/12/2013 05:10 PM, Luca Barbato wrote:
>> mcc_weightings is only 32 elements.
>>
>> Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
>> CC: libav-sta...@libav.org
>
> LGTM. Although it might also be nice to log a warning in addition to
On 07/22/2013 01:13 PM, Martin Storsjö wrote:
> On Mon, 22 Jul 2013, Luca Barbato wrote:
>
>> Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
>> CC: libav-sta...@libav.org
>> ---
>> libavcodec/4xm.c | 5 +
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/libavcodec/4xm.c b/libavc
On 07/22/2013 11:35 AM, Martin Storsjo wrote:
> When the .unreq is part of a .rept, both of them need to go along
> with each other so that they end up at the right place in the repeated
> output.
Both patches sound ok, we should start collecting small testcases =/
lu
___
---
gas-preprocessor.pl |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
index 27155d0..755d9fd 100755
--- a/gas-preprocessor.pl
+++ b/gas-preprocessor.pl
@@ -401,8 +401,6 @@ my @irp_args;
my $irp_param;
# pass 2: parse .rept a
---
libavcodec/arm/dcadsp_vfp.S |2 +-
libavcodec/arm/mdct_vfp.S |4 ++--
libavcodec/arm/synth_filter_vfp.S |2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavcodec/arm/dcadsp_vfp.S b/libavcodec/arm/dcadsp_vfp.S
index 6039e87..5892a84 100644
--- a/
On Mon, 22 Jul 2013, Martin Storsjö wrote:
Module: libav
Branch: master
Commit: b63bb251ea6d6ba23295294e37a92625c0192206
Author:Martin Storsjö
Committer: Martin Storsjö
Date: Fri Jul 19 10:59:17 2013 +0300
arm: Add VFP-accelerated version of imdct_half
Before
On 07/21/2013 07:47 PM, Martin Storsjö wrote:
> I'd declare this patchset good enough for now and push it soon, unless
> there's more comments.
You tested a lot and looks fine for me as well.
___
libav-devel mailing list
libav-devel@libav.org
https://lis
On Fri, 19 Jul 2013, Martin Storsjö wrote:
From: Ben Avison
Before After
MeanStdDev MeanStdDev Change
This function 1323.0 98.0 746.2 60.6 +77.3%
Overall15400.0 336.414147.5 288.4+8.9%
---
libavcodec/arm/dcadsp_init_ar
On 07/20/2013 02:50 PM, Derek Buitenhuis wrote:
> On 7/19/2013 3:20 PM, Luca Barbato wrote:
>> Adding a -DX264_API_IMPORTS=1 would probably make them calmer?
>
> I'm not terribly fond of spamming this libx264-specific define in our
> CPPFLAGS... it seems like a rather messy alternative to a nicely
The following changes since commit 6756d98cec7dbeab6d407abc656d06d7ba97fdda:
lavfi: filtfmts: use newer avfilter APIs (2013-07-19 12:22:30 +0300)
are not available in the git repository at:
git://git.libav.org/libav.git
up to:
vdpau: deprecate VDPAU codec capability (2013-07-20 13:22:51
---
doc/APIchanges | 3 +++
libavcodec/avcodec.h | 2 ++
libavcodec/version.h | 5 -
3 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/doc/APIchanges b/doc/APIchanges
index 52672f5..0d87f04 100644
--- a/doc/APIchanges
+++ b/doc/APIchanges
@@ -13,6 +13,9 @@ libavutil: 2012
---
doc/APIchanges | 3 +++
libavutil/old_pix_fmts.h | 4
libavutil/pixdesc.c | 2 ++
libavutil/pixfmt.h | 4
libavutil/version.h | 5 -
5 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/doc/APIchanges b/doc/APIchanges
index cdfcc09..52672f5 100
On Fri, Jul 19, 2013 at 09:29:12PM +0200, Vitor Sessak wrote:
> Hello!
>
> On Fri, Jul 19, 2013 at 9:22 AM, Kostya Shishkov
> wrote:
>
> > ---
> > It's good enough for the only file I care about but maybe it's useful for
> > the
> > others too.
> >
> > The source can benefit from heavy diegoing (
On Sat, Jul 20, 2013 at 12:17:18AM +0200, Diego Biurrun wrote:
> On Fri, Jul 19, 2013 at 09:22:46AM +0200, Kostya Shishkov wrote:
> > ---
> > It's good enough for the only file I care about but maybe it's useful for
> > the
> > others too.
>
> That wouldn't chance to be a movie with vampires, pri
On Tue, 23 Jul 2013, Luca Barbato wrote:
Diego Biurrun wrote:
On Tue, Jul 23, 2013 at 02:51:23PM +0200, Hendrik Leppkes wrote:
On Tue, Jul 23, 2013 at 2:49 PM, Luca Barbato
wrote:
On 07/23/2013 02:39 PM, Diego Biurrun wrote:
This allows excluding the sync-fate-samples target from conditio
---
libavcodec/avpacket.c |3 +--
libavcodec/binkaudio.c|5 ++---
libavcodec/bitstream.c|2 +-
libavcodec/flashsv.c | 11 +++
libavcodec/g2meet.c |6 ++
libavcodec/h264_mp4toannexb_bsf.c | 15 ---
2013/7/22 Luca Barbato
> On 07/22/2013 12:19 PM, Yusuke Nakamura wrote:
> > output_picture_number tells us the output or presentation order and shall
> > be unique within a sequence.
> > This corresponds to H.264/H.265 PicOrderCnt and Dirac picture number.
> >
> > Attached patches support parsing
On Tue, Jul 23, 2013 at 2:28 PM, Diego Biurrun wrote:
> ---
>
> Now taking the comments from Vitor and Luca into account.
>
> libavcodec/twinvq.c | 584
> --
> libavcodec/twinvq_data.h | 325 +-
> 2 files changed, 474 ins
On Tue, Jul 23, 2013 at 02:19:31PM +0200, Luca Barbato wrote:
> ---
> libavcodec/8bps.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/8bps.c b/libavcodec/8bps.c
> index dbe1f22..ad1266f 100644
> --- a/libavcodec/8bps.c
> +++ b/libavcodec/8bps.c
> @@ -105,
---
libavcodec/avpacket.c |3 +--
libavcodec/binkaudio.c|5 ++---
libavcodec/bitstream.c|2 +-
libavcodec/flashsv.c | 11 +++
libavcodec/g2meet.c | 12
libavcodec/h264_mp4toannexb_bsf.c | 15 -
On Tue, Jul 23, 2013 at 02:19:30PM +0200, Luca Barbato wrote:
> Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
> CC: libav-sta...@libav.org
> ---
> libavcodec/8bps.c | 10 +++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/8bps.c b/libavcodec/8bps.
On Tue, 23 Jul 2013, Rémi Denis-Courmont wrote:
Le mardi 23 juillet 2013 17:18:25 Martin Storsjö a écrit :
From: Peter Ross
---
libavformat/wtv.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/wtv.c b/libavformat/wtv.c
index 8b92746..494af3b 100644
---
On Tue, 23 Jul 2013, Diego Biurrun wrote:
On Tue, Jul 23, 2013 at 05:18:25PM +0300, Martin Storsjö wrote:
--- a/libavformat/wtv.c
+++ b/libavformat/wtv.c
@@ -155,7 +155,7 @@ static AVIOContext * wtvfile_open_sector(int first_sector,
uint64_t length, int
-if (avio_seek(s->pb, first_sector
---
libavformat/asfenc.c |6 +++---
libavformat/avidec.c |2 +-
libavformat/avienc.c |4 ++--
libavformat/aviobuf.c|4 ++--
libavformat/bmv.c|5 ++---
libavformat/concat.c |7 +++
libavformat/cu
---
libavformat/cutils.c |7 +--
libavformat/internal.h |8 +---
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/libavformat/cutils.c b/libavformat/cutils.c
index b6f4303..ebcc751 100644
--- a/libavformat/cutils.c
+++ b/libavformat/cutils.c
@@ -22,7 +22,7 @@
#inc
Le mardi 23 juillet 2013 17:18:25 Martin Storsjö a écrit :
> From: Peter Ross
>
> ---
> libavformat/wtv.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/wtv.c b/libavformat/wtv.c
> index 8b92746..494af3b 100644
> --- a/libavformat/wtv.c
> +++ b/libav
On Tue, Jul 23, 2013 at 05:18:25PM +0300, Martin Storsjö wrote:
> --- a/libavformat/wtv.c
> +++ b/libavformat/wtv.c
> @@ -155,7 +155,7 @@ static AVIOContext * wtvfile_open_sector(int
> first_sector, uint64_t length, int
>
> -if (avio_seek(s->pb, first_sector << WTV_SECTOR_BITS, SEEK_SET) < 0
Diego Biurrun wrote:
>On Tue, Jul 23, 2013 at 02:51:23PM +0200, Hendrik Leppkes wrote:
>> On Tue, Jul 23, 2013 at 2:49 PM, Luca Barbato
>wrote:
>> > On 07/23/2013 02:39 PM, Diego Biurrun wrote:
>> >> This allows excluding the sync-fate-samples target from conditions
>that
>> >> match all other fa
From: Peter Ross
---
libavformat/wtv.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/wtv.c b/libavformat/wtv.c
index 8b92746..494af3b 100644
--- a/libavformat/wtv.c
+++ b/libavformat/wtv.c
@@ -155,7 +155,7 @@ static AVIOContext * wtvfile_open_sector(int f
On Tue, Jul 23, 2013 at 02:51:23PM +0200, Hendrik Leppkes wrote:
> On Tue, Jul 23, 2013 at 2:49 PM, Luca Barbato wrote:
> > On 07/23/2013 02:39 PM, Diego Biurrun wrote:
> >> This allows excluding the sync-fate-samples target from conditions that
> >> match all other fate-related targets.
> >> ---
On Tue, Jul 23, 2013 at 2:49 PM, Luca Barbato wrote:
> On 07/23/2013 02:39 PM, Diego Biurrun wrote:
>> This allows excluding the sync-fate-samples target from conditions that
>> match all other fate-related targets.
>> ---
>>
>> Now with a name that is really better than its predecessor.
>>
>
> No
On 07/23/2013 02:39 PM, Diego Biurrun wrote:
> This allows excluding the sync-fate-samples target from conditions that
> match all other fate-related targets.
> ---
>
> Now with a name that is really better than its predecessor.
>
No, it is longer, easier to mistype.
Just filter out fate-rsync
On 7/23/2013 8:21 AM, Martin Storsjö wrote:
> Hmm, nifty. Do you prefer this over the other solution (where hex literals
> are converted into decimals numbers) when I've corrected it like this?
This one seems less ugly to me, but that's just my opinion. :)
- Derek
___
This allows excluding the sync-fate-samples target from conditions that
match all other fate-related targets.
---
Now with a name that is really better than its predecessor.
doc/fate.texi |4 ++--
doc/git-howto.texi |2 +-
tests/Makefile |9 ++---
3 files changed, 9 inse
On 07/23/2013 02:28 PM, Diego Biurrun wrote:
> ---
>
> Now taking the comments from Vitor and Luca into account.
>
> libavcodec/twinvq.c | 584
> --
> libavcodec/twinvq_data.h | 325 +-
> 2 files changed, 474 insertions(
On Tue, 23 Jul 2013, Derek Buitenhuis wrote:
On 7/23/2013 6:32 AM, Martin Storsjö wrote:
Yes, which I also mentioned in the annotation "This is pretty ugly, and
can only match one single symbol per line.". Any suggestions on a better
way of doing it?
I'm pretty sure Perl can do something like
On Tue, Jul 23, 2013 at 2:15 PM, Diego Biurrun wrote:
> On Tue, Jul 23, 2013 at 01:54:25PM +0200, Hendrik Leppkes wrote:
>> On Tue, Jul 23, 2013 at 1:52 PM, Diego Biurrun wrote:
>> > On Sat, Jul 20, 2013 at 12:50:05AM +0200, Diego Biurrun wrote:
>> >> This allows excluding the samples-rsync targe
Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-sta...@libav.org
---
libavcodec/8bps.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/libavcodec/8bps.c b/libavcodec/8bps.c
index fcb7b2b..dbe1f22 100644
--- a/libavcodec/8bps.c
+++ b/libavcodec/8bp
---
libavcodec/8bps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/8bps.c b/libavcodec/8bps.c
index dbe1f22..ad1266f 100644
--- a/libavcodec/8bps.c
+++ b/libavcodec/8bps.c
@@ -105,7 +105,7 @@ static int decode_frame(AVCodecContext *avctx, void *data,
On Tue, Jul 23, 2013 at 01:54:25PM +0200, Hendrik Leppkes wrote:
> On Tue, Jul 23, 2013 at 1:52 PM, Diego Biurrun wrote:
> > On Sat, Jul 20, 2013 at 12:50:05AM +0200, Diego Biurrun wrote:
> >> This allows excluding the samples-rsync target from conditions that
> >> atch all other fate-related targ
On 07/23/2013 01:54 PM, Hendrik Leppkes wrote:
> On Tue, Jul 23, 2013 at 1:52 PM, Diego Biurrun wrote:
>> On Sat, Jul 20, 2013 at 12:50:05AM +0200, Diego Biurrun wrote:
>>> This allows excluding the samples-rsync target from conditions that
>>> atch all other fate-related targets.
>>> ---
>>>
>>>
On Tue, Jul 23, 2013 at 1:52 PM, Diego Biurrun wrote:
> On Sat, Jul 20, 2013 at 12:50:05AM +0200, Diego Biurrun wrote:
>> This allows excluding the samples-rsync target from conditions that
>> atch all other fate-related targets.
>> ---
>>
>> This now deprecates the target instead of dropping it.
On Sat, Jul 20, 2013 at 12:50:05AM +0200, Diego Biurrun wrote:
> This allows excluding the samples-rsync target from conditions that
> atch all other fate-related targets.
> ---
>
> This now deprecates the target instead of dropping it. The second patch
> remains simple and fate-rsync stays in pl
On 7/23/2013 4:31 AM, Martin Storsjo wrote:
> ---
> gas-preprocessor.pl |3 +++
> 1 file changed, 3 insertions(+)
OK.
- Derek
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
On 7/23/2013 4:31 AM, Martin Storsjo wrote:
> +my $line = @_[0];
Should be $_[0].
Otherwise, LGTM.
- Derek
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
On 7/23/2013 4:31 AM, Martin Storsjo wrote:
> ---
> gas-preprocessor.pl |6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>From the patch context, it looks reasonable.
- Derek
___
libav-devel mailing list
libav-devel@libav.org
https://li
On 7/23/2013 4:31 AM, Martin Storsjo wrote:
> This avoids the hidden assumption that the parameter passed is
> also available in $_.
> ---
> gas-preprocessor.pl |5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Less implicitness is good. LGTM.
- Derek
__
On 7/23/2013 6:32 AM, Martin Storsjö wrote:
> Yes, which I also mentioned in the annotation "This is pretty ugly, and
> can only match one single symbol per line.". Any suggestions on a better
> way of doing it?
I'm pretty sure Perl can do something like:
while ($expr =~ /([A-Za-z._][A-Za-z
On 7/23/2013 6:33 AM, Martin Storsjö wrote:
> We don't do this on all the asm source, only on certain subexpressions
> that we need to evaluate (for parameters to .set, .if, .rept). So I think
> it should be pretty safe.
OK.
- Derek
___
libav-devel ma
On Tue, 23 Jul 2013, Derek Buitenhuis wrote:
On 7/23/2013 4:38 AM, Martin Storsjo wrote:
+while ($expr =~ /(0x[A-Fa-f0-9]*)/) {
Is it wise it wise to match '0x'? Thogh, I guess that would be invalid
code anyway.
We don't do this on all the asm source, only on certain subexpressions
tha
On Tue, 23 Jul 2013, Derek Buitenhuis wrote:
On 7/23/2013 4:38 AM, Martin Storsjo wrote:
-$expr =~ s/([A-Za-z._][A-Za-z0-9._]*)/$symbols{$1}/g;
+if ($expr =~ /([A-Za-z._][A-Za-z0-9._]*)/) {
+my $sym = $1;
+$expr =~ s/$sym/$symbols{$sym}/ if defined $symbols{$sym};
I th
On 7/23/2013 4:38 AM, Martin Storsjo wrote:
> -$expr =~ s/([A-Za-z._][A-Za-z0-9._]*)/$symbols{$1}/g;
> +if ($expr =~ /([A-Za-z._][A-Za-z0-9._]*)/) {
> +my $sym = $1;
> +$expr =~ s/$sym/$symbols{$sym}/ if defined $symbols{$sym};
I think you lost the function of /g?
- Derek
On 7/23/2013 4:38 AM, Martin Storsjo wrote:
> +while ($expr =~ /(0x[A-Fa-f0-9]*)/) {
Is it wise it wise to match '0x'? Thogh, I guess that would be invalid
code anyway.
- Derek
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.o
This avoids replacing a substring like x0123 in hex constants with
an empty string.
---
This is pretty ugly, and can only match one single symbol per line.
Better solutions are welcome. This is an alternative to first matching
and replacing all hex constants.
---
gas-preprocessor.pl |5 -
Otherwise the substring x0123 will be matched as a symbol name
and replaced with the value of that symbol.
---
This fixes evaluating expressions like "0x80808080 >> 16",
where x80808080 is interpreted as a symbol (with no value).
This is encountered when building e.g. vp8dsp_armv6.o. (This has
norm
---
gas-preprocessor.pl |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
index 7da7c33..8e1c13f 100755
--- a/gas-preprocessor.pl
+++ b/gas-preprocessor.pl
@@ -224,7 +224,7 @@ sub parse_line {
$current_macro = '';
This avoids the hidden assumption that the parameter passed is
also available in $_.
---
gas-preprocessor.pl |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
index a560921..7da7c33 100755
--- a/gas-preprocessor.pl
+++ b/gas-prepr
---
gas-preprocessor.pl | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
index 8e1c13f..2602383 100755
--- a/gas-preprocessor.pl
+++ b/gas-preprocessor.pl
@@ -260,6 +260,13 @@ sub parse_line {
}
}
+sub handle_set {
---
gas-preprocessor.pl |3 +++
1 file changed, 3 insertions(+)
diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
index 2602383..98b9360 100755
--- a/gas-preprocessor.pl
+++ b/gas-preprocessor.pl
@@ -519,6 +519,7 @@ foreach my $line (@pass1_lines) {
$line =~ s/\\$irp
98 matches
Mail list logo
