Re: [libav-devel] [libav-commits] avcodec: Consistently name encoder init functions foo_encode_init

2014-02-21 Thread Martin Storsjö
On Thu, 20 Feb 2014, Diego Biurrun wrote: Module: libav Branch: master Commit: 984e3398662d460e15904f9e4a6df9ef759070cb Author:Diego Biurrun di...@biurrun.de Committer: Diego Biurrun di...@biurrun.de Date: Thu Feb 6 18:29:51 2014 +0100 avcodec: Consistently name encoder init

[libav-devel] [PATCH] configure: Add missing dependency of Snow decoder on videodsp

2014-02-21 Thread Diego Biurrun
--- This applies to the 9 branch only. Done for completeness, not that anybody cares... configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 6ab04ae..d2b4122 100755 --- a/configure +++ b/configure @@ -1562,7 +1562,7 @@

Re: [libav-devel] [PATCH] configure: Add missing dependency of Snow decoder on videodsp

2014-02-21 Thread Luca Barbato
On 21/02/14 10:32, Diego Biurrun wrote: --- This applies to the 9 branch only. Done for completeness, not that anybody cares... Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] libvorbis: Give consistent names to all functions, structs, and defines

2014-02-21 Thread Diego Biurrun
--- libavcodec/libvorbis.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/libavcodec/libvorbis.c b/libavcodec/libvorbis.c index 545aa72..4b4caaa 100644 --- a/libavcodec/libvorbis.c +++ b/libavcodec/libvorbis.c @@ -43,11 +43,11 @@ *

Re: [libav-devel] [PATCH] libvorbis: Give consistent names to all functions, structs, and defines

2014-02-21 Thread Luca Barbato
On 21/02/14 11:08, Diego Biurrun wrote: --- libavcodec/libvorbis.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) Assuming you tested it seems ok. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] libvorbis: Give consistent names to all functions, structs, and defines

2014-02-21 Thread Martin Storsjö
On Fri, 21 Feb 2014, Diego Biurrun wrote: --- libavcodec/libvorbis.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) Why does this commit message not state the most important fact of all, that it fixes compilation? // Martin

Re: [libav-devel] [PATCH 7/7] hevc: Do not left shift a negative value

2014-02-21 Thread Janne Grunau
On 2014-02-21 00:10:05 +0100, Luca Barbato wrote: On 20/02/14 23:58, Janne Grunau wrote: Also after a cursory glance x can only be smaller than 0 if x0 is smaller than 0. There are some right shifts of x0 i the same function which are implementation defined. IIRC x0 should be at least

Re: [libav-devel] [PATCH] libvorbis: Give consistent names to all functions, structs, and defines

2014-02-21 Thread Diego Biurrun
On Fri, Feb 21, 2014 at 12:34:41PM +0200, Martin Storsjö wrote: On Fri, 21 Feb 2014, Diego Biurrun wrote: --- libavcodec/libvorbis.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) Why does this commit message not state the most important fact

Re: [libav-devel] [PATCH] configure: Add missing dependency of Snow decoder on videodsp

2014-02-21 Thread Tim Walker
On 21 Feb 2014, at 10:32, Diego Biurrun di...@biurrun.de wrote: --- This applies to the 9 branch only. Done for completeness, not that anybody cares... configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) :-) ___ libav-devel

[libav-devel] [PATCH 2/4] libx265: Support 4:4:4

2014-02-21 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavcodec/libx265.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 0577400..1546853 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -109,6 +109,17

[libav-devel] [PATCH 1/4] libx265: Update API usage

2014-02-21 Thread Derek Buitenhuis
Framerate is now a sane rational instead of an integer, and inputDepth is changed to what it actually is. Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- configure| 4 ++-- libavcodec/libx265.c | 9 +++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git

[libav-devel] [PATCH 0/4] libx265 stuff

2014-02-21 Thread Derek Buitenhuis
Derek Buitenhuis (4): libx265: Update API usage libx265: Support 4:4:4 libx265: Support SAR libx265: Properly handled dynamic linking with MSVC configure| 4 ++-- libavcodec/libx265.c | 36 ++-- 2 files changed, 36 insertions(+), 4

[libav-devel] [PATCH 3/4] libx265: Support SAR

2014-02-21 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavcodec/libx265.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 1546853..7fdccc7 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -77,6 +77,7 @@ static

Re: [libav-devel] [PATCH 0/4] libx265 stuff

2014-02-21 Thread Luca Barbato
On 21/02/14 18:16, Derek Buitenhuis wrote: Derek Buitenhuis (4): libx265: Update API usage libx265: Support 4:4:4 libx265: Support SAR libx265: Properly handled dynamic linking with MSVC The set looks fine. lu ___ libav-devel mailing

[libav-devel] [PATCH 1/4 v2] libx265: Update API usage

2014-02-21 Thread Derek Buitenhuis
Framerate is now a sane rational instead of an integer, and inputDepth is changed to what it actually is. Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- configure| 4 ++-- libavcodec/libx265.c | 12 +--- 2 files changed, 11 insertions(+), 5 deletions(-) diff

Re: [libav-devel] [PATCH] h264: lower bound check for slice offsets

2014-02-21 Thread Hendrik Leppkes
On Thu, Feb 20, 2014 at 2:38 AM, Vittorio Giovara vittorio.giov...@gmail.com wrote: And use the value from the specification. Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind --- libavcodec/h264.c| 18 ++ libavcodec/h264_loopfilter.c | 8 2 files

[libav-devel] [RFC] avconv: Use the input codec timebase for encoding

2014-02-21 Thread Luca Barbato
The codec time_base is used as hint for some rate control algorithms and usually the filter time base matches poorly for such usage. --- Spun from the x265 patchset and the libmfx encoder patchset I'm working on. avconv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [libav-devel] [PATCH] h264: lower bound check for slice offsets

2014-02-21 Thread Luca Barbato
On 21/02/14 18:46, Hendrik Leppkes wrote: On Thu, Feb 20, 2014 at 2:38 AM, Vittorio Giovara vittorio.giov...@gmail.com wrote: And use the value from the specification. Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind --- libavcodec/h264.c| 18 ++

[libav-devel] [PATCH 3/4 v2] libx265: Support SAR

2014-02-21 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavcodec/libx265.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 079a5b7..b71b49a 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -77,6 +77,7 @@

Re: [libav-devel] [PATCH 3/4 v2] libx265: Support SAR

2014-02-21 Thread Anton Khirnov
On Fri, 21 Feb 2014 19:10:34 +, Derek Buitenhuis derek.buitenh...@gmail.com wrote: Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavcodec/libx265.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index

Re: [libav-devel] [PATCH 3/4 v2] libx265: Support SAR

2014-02-21 Thread Derek Buitenhuis
On 2/21/2014 8:08 PM, Anton Khirnov wrote: Patch still looks fine, assuming you tested it. I did, but there might be a bug in x265 that doesn't properly reject impossible SARs. I've stabbed Steve elsewhere over it. Holding off until then. - Derek ___

Re: [libav-devel] [PATCH 1/4 v2] libx265: Update API usage

2014-02-21 Thread Anton Khirnov
On Fri, 21 Feb 2014 17:38:53 +, Derek Buitenhuis derek.buitenh...@gmail.com wrote: Framerate is now a sane rational instead of an integer, and inputDepth is changed to what it actually is. Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- configure| 4 ++--

Re: [libav-devel] [PATCH 1/4 v2] libx265: Update API usage

2014-02-21 Thread Derek Buitenhuis
On 2/21/2014 8:11 PM, Anton Khirnov wrote: This doesn't look very pretty, especially since it's pointless called for each frame. Might be better to store it in the context. Indeed, we could save all of one function all per frame. I'm sure this makes a big difference while encoding HEVC. MiNi

Re: [libav-devel] [RFC] avconv: Use the input codec timebase for encoding

2014-02-21 Thread Anton Khirnov
On Fri, 21 Feb 2014 18:52:09 +0100, Luca Barbato lu_z...@gentoo.org wrote: The codec time_base is used as hint for some rate control algorithms and usually the filter time base matches poorly for such usage. --- No, this will break more stuff than it fixes. Input codec timebase is just a

Re: [libav-devel] [RFC] avconv: Use the input codec timebase for encoding

2014-02-21 Thread Luca Barbato
On 21/02/14 21:16, Anton Khirnov wrote: On Fri, 21 Feb 2014 18:52:09 +0100, Luca Barbato lu_z...@gentoo.org wrote: The codec time_base is used as hint for some rate control algorithms and usually the filter time base matches poorly for such usage. --- No, this will break more stuff than

Re: [libav-devel] [PATCH 2/9] lavf: add an AVStream field for exporting stream-global side data

2014-02-21 Thread Anton Khirnov
On Thu, 20 Feb 2014 10:57:45 +0200 (EET), Martin Storsjö mar...@martin.st wrote: On Wed, 19 Feb 2014, Anton Khirnov wrote: --- doc/APIchanges |4 libavformat/avformat.h | 15 +++ libavformat/utils.c|8 +++- libavformat/version.h |2 +- 4

Re: [libav-devel] [PATCH 2/9] lavf: add an AVStream field for exporting stream-global side data

2014-02-21 Thread Anton Khirnov
On Thu, 20 Feb 2014 09:45:09 +0100, wm4 nfx...@googlemail.com wrote: On Wed, 19 Feb 2014 21:16:45 +0100 Anton Khirnov an...@khirnov.net wrote: +/** + * An array of side data that applies to the whole stream (i.e. the + * container does not allow it to change between

Re: [libav-devel] [PATCH 3/9] Add replaygain side data type and code for parsing replaygain tags.

2014-02-21 Thread Anton Khirnov
On Wed, 19 Feb 2014 18:26:38 -0500, Justin Ruggles justin.rugg...@gmail.com wrote: On 02/19/2014 03:16 PM, Anton Khirnov wrote: --- doc/APIchanges |6 ++ libavcodec/avcodec.h | 16 + libavcodec/version.h |2 +- libavformat/replaygain.c | 155

Re: [libav-devel] [PATCH 6/9] avconv: add stream-global side data to the first demuxed packet

2014-02-21 Thread Anton Khirnov
On Thu, 20 Feb 2014 23:19:19 +0100, Tim Walker tdskywal...@gmail.com wrote: On 19 Feb 2014, at 21:16, Anton Khirnov an...@khirnov.net wrote: --- avconv.c | 17 + avconv.h |3 +++ 2 files changed, 20 insertions(+) diff --git a/avconv.c b/avconv.c index

Re: [libav-devel] [RFC] avconv: Use the input codec timebase for encoding

2014-02-21 Thread Anton Khirnov
On Fri, 21 Feb 2014 21:18:54 +0100, Luca Barbato lu_z...@gentoo.org wrote: On 21/02/14 21:16, Anton Khirnov wrote: On Fri, 21 Feb 2014 18:52:09 +0100, Luca Barbato lu_z...@gentoo.org wrote: The codec time_base is used as hint for some rate control algorithms and usually the filter time

Re: [libav-devel] [PATCH 1/4 v2] libx265: Update API usage

2014-02-21 Thread Anton Khirnov
On Fri, 21 Feb 2014 20:13:15 +, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 2/21/2014 8:11 PM, Anton Khirnov wrote: This doesn't look very pretty, especially since it's pointless called for each frame. Might be better to store it in the context. Indeed, we could

Re: [libav-devel] [PATCH 2/4] libx265: Support 4:4:4

2014-02-21 Thread Derek Buitenhuis
On 2/21/2014 5:16 PM, Derek Buitenhuis wrote: Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavcodec/libx265.c | 14 ++ 1 file changed, 14 insertions(+) FYI, I've changed this to be marked as experimental locally, since Jan has informed me 4:4:4 HEVC is still

Re: [libav-devel] [PATCH 2/9] lavf: add an AVStream field for exporting stream-global side data

2014-02-21 Thread wm4
On Fri, 21 Feb 2014 21:28:27 +0100 Anton Khirnov an...@khirnov.net wrote: Maybe there should be clear rules when and how often side data appears in AVStream and AVPackets. For example, for that files that allow parameter changes you could do one of the following: A) have no side data

Re: [libav-devel] [RFC] avconv: Use the input codec timebase for encoding

2014-02-21 Thread Tim Walker
On 21 Feb 2014, at 21:18, Luca Barbato lu_z...@gentoo.org wrote: On 21/02/14 21:16, Anton Khirnov wrote: On Fri, 21 Feb 2014 18:52:09 +0100, Luca Barbato lu_z...@gentoo.org wrote: The codec time_base is used as hint for some rate control algorithms and usually the filter time base matches

Re: [libav-devel] [RFC] avconv: Use the input codec timebase for encoding

2014-02-21 Thread Luca Barbato
On 22/02/14 02:20, Tim Walker wrote: On 21 Feb 2014, at 21:18, Luca Barbato lu_z...@gentoo.org wrote: Can you elaborate? currently avconv passes as codec timebase the filter timebase and it is usually 1/90k or such value. mfx rejects it. lu ___

[libav-devel] [PATCH 1/3] x86: add missing XOP checks and macros

2014-02-21 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- configure | 5 + libavutil/x86/cpu.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/configure b/configure index 72cf831..96cbe5d 100755 --- a/configure +++ b/configure @@ -270,6 +270,7 @@ Optimization options (experts only):

[libav-devel] [PATCH 3/3] x86: add detection for Bit Manipulation Instruction sets

2014-02-21 Thread James Almer
Based on x264 code Signed-off-by: James Almer jamr...@gmail.com --- libavutil/cpu.c | 6 ++ libavutil/cpu.h | 2 ++ libavutil/x86/cpu.c | 16 +++- 3 files changed, 19 insertions(+), 5 deletions(-) diff --git a/libavutil/cpu.c b/libavutil/cpu.c index 972e4eb..d651eb2

[libav-devel] [PATCH 2/3] x86: add detection for FMA3 instruction set

2014-02-21 Thread James Almer
Based on x264 code Signed-off-by: James Almer jamr...@gmail.com --- configure | 5 + libavutil/cpu.c | 3 +++ libavutil/cpu.h | 1 + libavutil/x86/cpu.c | 5 - libavutil/x86/cpu.h | 3 +++ 5 files changed, 16 insertions(+), 1 deletion(-) diff --git a/configure

[libav-devel] [PATCH 0/3] support for FMA3 and BMI intruction sets

2014-02-21 Thread James Almer
These are the missing instruction sets introduced with Haswell/Piledriver CPUs. Last two patches are based on x264 detection code. James Almer (3): x86: add missing XOP checks and macros x86: add detection for FMA3 instruction set x86: add detection for Bit Manipulation Instruction sets