Re: [libav-devel] [PATCH 12/16] doc: decoders: Add documentation for libopencore-amrwb

2014-03-31 Thread Martin Storsjö
On Sun, 30 Mar 2014, Luca Barbato wrote: On 30/03/14 23:10, Timothy Gu wrote: On Mar 30, 2014 11:19 AM, Luca Barbato lu_z...@gentoo.org wrote: You need to +explicitly configure the build with @code{--enable-libopencore-amrwb}. + +A Libav native decoder for AMR-WB exists, so users can decode

Re: [libav-devel] [PATCH] Add gen-rc tool for generating Windows resource files

2014-03-31 Thread James Almer
On 30/03/14 10:49 AM, Vittorio Giovara wrote: From: Timothy Gu timothyg...@gmail.com --- Anyone willing to test this on Windows would be welcome. Vittorio tools/gen-rc | 122 +++ 1 file changed, 122 insertions(+) create mode

[libav-devel] FYI: avconv-lua wrapper git repo.

2014-03-31 Thread Enrique Arizón Benito
https://code.google.com/p/avconv-lua-frontend/source/browse/ (This is a works for me version) Regards, Enrique ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] On2 VP7 decoder

2014-03-31 Thread Kostya Shishkov
On Sun, Mar 30, 2014 at 02:01:36PM +0200, Luca Barbato wrote: From: Peter Ross pr...@xvid.org Further performance improvements and security fixes by Vittorio Giovara and Luca Barbato. Signed-off-by: Vittorio Giovara vittorio.giov...@gmail.com Signed-off-by: Luca Barbato lu_z...@gentoo.org

[libav-devel] [PATCH v3 1/5] replaygain: correctly parse peak values

2014-03-31 Thread Alessandro Ghedini
According to the ReplayGain spec, the peak amplitude may overflow and may result in peak amplitude values greater than 1.0 with psychoacoustically coded audio, such as MP3. Fully compliant decoders must allow peak overflows. Additionally, having peak values in the 0-UINT32_MAX scale makes it more

Re: [libav-devel] [PATCH] On2 VP7 decoder

2014-03-31 Thread Vittorio Giovara
On Mon, Mar 31, 2014 at 11:08 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Sun, Mar 30, 2014 at 02:01:36PM +0200, Luca Barbato wrote: From: Peter Ross pr...@xvid.org Further performance improvements and security fixes by Vittorio Giovara and Luca Barbato. Signed-off-by: Vittorio

Re: [libav-devel] [PATCH] On2 VP7 decoder

2014-03-31 Thread Luca Barbato
On 31/03/14 14:01, Vittorio Giovara wrote: On Mon, Mar 31, 2014 at 11:08 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Sun, Mar 30, 2014 at 02:01:36PM +0200, Luca Barbato wrote: From: Peter Ross pr...@xvid.org Further performance improvements and security fixes by Vittorio Giovara

[libav-devel] Patch: Checking for Allocated Memory Fixing Return Value in libavcodec/vp56.c

2014-03-31 Thread Sayanti Bandyopadhyay
Respected Sir, I am sending patch for checking allocated memory fixing return Value in libavcodec/vp56.c I am seding the link and attching the code. http://codetidy.com/8681/ Thanking You. Sayanti Bandyopadhyay IIIT Hyderabad, Hyderabad. /* *

Re: [libav-devel] [PATCH] OpenEXR decoder

2014-03-31 Thread Vittorio Giovara
On Wed, Mar 26, 2014 at 4:39 AM, Vittorio Giovara vittorio.giov...@gmail.com wrote: On Sun, Mar 23, 2014 at 4:07 PM, Vittorio Giovara vittorio.giov...@gmail.com wrote: From: Jimmy Christensen ji...@ghost.dk Additional fixes and enhancements by Vittorio Giovara, Gonzalo Garramuno, Nicolas

Re: [libav-devel] [PATCH 087/132] x86: Drop some unnecessary YASM ifdefs

2014-03-31 Thread Vittorio Giovara
On Wed, Mar 26, 2014 at 12:41 PM, Diego Biurrun di...@biurrun.de wrote: Dead code elimination is enough to avoid undefined references in these cases. --- libavcodec/x86/dsputilenc_mmx.c| 2 -- libavcodec/x86/h264chroma_init.c | 2 -- libavcodec/x86/vorbisdsp_init.c| 2 --

Re: [libav-devel] [PATCH] Add gen-rc tool for generating Windows resource files

2014-03-31 Thread Vittorio Giovara
On Mon, Mar 31, 2014 at 9:02 AM, James Almer jamr...@gmail.com wrote: On 30/03/14 10:49 AM, Vittorio Giovara wrote: From: Timothy Gu timothyg...@gmail.com --- Anyone willing to test this on Windows would be welcome. Vittorio tools/gen-rc | 122

Re: [libav-devel] Patch: Checking for Allocated Memory Fixing Return Value in libavcodec/vp56.c

2014-03-31 Thread Vittorio Giovara
On Mon, Mar 31, 2014 at 3:28 PM, Sayanti Bandyopadhyay bandyopadhyay.saya...@gmail.com wrote: Respected Sir, I am sending patch for checking allocated memory fixing return Value in libavcodec/vp56.c I am seding the link and attching the code.

Re: [libav-devel] [PATCH 1/2] dxva2_h264: set the correct ref frame index in the long slice struct

2014-03-31 Thread Vittorio Giovara
On Tue, Mar 18, 2014 at 5:53 PM, Vittorio Giovara vittorio.giov...@gmail.com wrote: On Fri, Mar 7, 2014 at 2:05 PM, Felix Abecassis felix.abecas...@gmail.com wrote: From: Hendrik Leppkes h.lepp...@gmail.com The latest H.264 DXVA specification states that the index in this structure should

Re: [libav-devel] [PATCH] [RFC] asettb: setting timebases for audio files

2014-03-31 Thread Katerina Barone-Adesi
On Mon, Mar 31, 2014 at 6:01 AM, Timothy Gu timothyg...@gmail.com wrote: Thanks for doing this. Some comments and possible improvements: * Add support for sr as a variable name as in http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=ba856c0be5599f21f241162e1f5f3f2506f3132c * Add

Re: [libav-devel] [PATCH] [RFC] asettb: setting timebases for audio files

2014-03-31 Thread Vittorio Giovara
On Mon, Mar 31, 2014 at 4:37 PM, Katerina Barone-Adesi kateri...@gmail.com wrote: On Mon, Mar 31, 2014 at 6:01 AM, Timothy Gu timothyg...@gmail.com wrote: Thanks for doing this. Some comments and possible improvements: * Add support for sr as a variable name as in

Re: [libav-devel] [PATCH] [RFC] asettb: setting timebases for audio files

2014-03-31 Thread Tim Walker
On 31 Mar 2014, at 16:37, Katerina Barone-Adesi kateri...@gmail.com wrote: 0001-Added-asettb-support-setting-timebases-for-audio.patch0002-Renamed-vf_settb.c-to-f_settb.c.patch Hi, your patches are correctly formatted, but your emails aren't - please try and use git send-email to send them.

[libav-devel] [PATCH] dxva2: don't assume Picture and H264Picture are the same

2014-03-31 Thread Hendrik Leppkes
From: Michael Niedermayer michae...@gmx.at This resolves compilation warnings and protects against future breakage as Picture and H264Picture drift apart. Signed-off-by: Hendrik Leppkes h.lepp...@gmail.com --- libavcodec/dxva2.c | 12 ++-- libavcodec/dxva2_h264.c | 8

Re: [libav-devel] [PATCH] [RFC] asettb: setting timebases for audio files

2014-03-31 Thread Derek Buitenhuis
On 3/31/2014 4:12 PM, Vittorio Giovara wrote: Please do not do this, defining macros in this way hides bugs and make the code harder to read. Please write down the full AVClass block. There's really no chance of it in this case, though. It is super simple. - Derek

Re: [libav-devel] [PATCH] [RFC] asettb: setting timebases for audio files

2014-03-31 Thread Vittorio Giovara
On Mon, Mar 31, 2014 at 5:29 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 3/31/2014 4:12 PM, Vittorio Giovara wrote: Please do not do this, defining macros in this way hides bugs and make the code harder to read. Please write down the full AVClass block. There's really no chance

Re: [libav-devel] [PATCH] [RFC] asettb: setting timebases for audio files

2014-03-31 Thread Derek Buitenhuis
On 3/31/2014 4:37 PM, Vittorio Giovara wrote: Even if this macro hides only something like 4 lines, it makes the code harder to read for no particular gain, especially for first time contributors that have to go and look it up. I can really only disagree in this instance. - Derek

Re: [libav-devel] [PATCH] [RFC] asettb: setting timebases for audio files

2014-03-31 Thread Vittorio Giovara
On Mon, Mar 31, 2014 at 5:42 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 3/31/2014 4:37 PM, Vittorio Giovara wrote: Even if this macro hides only something like 4 lines, it makes the code harder to read for no particular gain, especially for first time contributors that have to

Re: [libav-devel] [PATCH] [RFC] asettb: setting timebases for audio files

2014-03-31 Thread Katerina Barone-Adesi
I agree with Vittorio that it's suboptimal for this patch set, at the least. I was erring on the side of porting changes from FFmpeg, but will leave it out. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] Add gen-rc tool for generating Windows resource files

2014-03-31 Thread Luca Barbato
On 31/03/14 15:52, Vittorio Giovara wrote: Thanks for catching this, do you think you could also pick and the patch that adds that too? it is just a line in configure... ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] Patch: Checking for Allocated Memory Fixing Return Value in libavcodec/vp56.c

2014-03-31 Thread Diego Biurrun
On Mon, Mar 31, 2014 at 06:58:25PM +0530, Sayanti Bandyopadhyay wrote: I am sending patch for checking allocated memory fixing return Value in libavcodec/vp56.c I am seding the link and attching the code. http://codetidy.com/8681/ Actually, you sent a complete file,

[libav-devel] [PATCH v3 1/2] Renamed vf_settb.c to settb.c.

2014-03-31 Thread Katerina Barone-Adesi
--- libavfilter/Makefile | 2 +- libavfilter/settb.c| 161 + libavfilter/vf_settb.c | 161 - 3 files changed, 162 insertions(+), 162 deletions(-) create mode 100644 libavfilter/settb.c delete

[libav-devel] [PATCH v3 2/2] Added asettb support - setting timebases for audio

2014-03-31 Thread Katerina Barone-Adesi
Ported asettb (including the sr option for audio sample rate), and documentation from ffmpeg. --- doc/filters.texi | 43 +- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/settb.c | 68

[libav-devel] [PATCH 0/2] Modified the asettb patch wrt comments

2014-03-31 Thread Katerina Barone-Adesi
* The rename patch is first. * The contentious macro has been removed and is not in this patch set. * The file is named settb.c rather than f_settb.c, in accordance with libav rather than FFmpeg naming conventions. * The documentation is duplicated (like showinfo/ashowinfo are), rather than

[libav-devel] [PATCH 2/2] svq1enc: initialize MpegEncContext

2014-03-31 Thread wm4
ff_MPV_common_init initializes Picture.f, so call it. s-m.mb_type must be set to NULL before ff_MPV_common_end, because it attempts to free it. --- Fixes a crash. Probably should be squashed with the previous commit, or moved before it. --- libavcodec/svq1enc.c | 8 1 file changed, 8

Re: [libav-devel] [PATCH] dxva2: don't assume Picture and H264Picture are the same

2014-03-31 Thread Luca Barbato
On 31/03/14 17:24, Hendrik Leppkes wrote: From: Michael Niedermayer michae...@gmx.at This resolves compilation warnings and protects against future breakage as Picture and H264Picture drift apart. Looks fine to me. I'd push it with the message amended: dxva2: Directly use AVFrames The

Re: [libav-devel] [PATCH] dxva2: don't assume Picture and H264Picture are the same

2014-03-31 Thread Vittorio Giovara
On Mon, Mar 31, 2014 at 5:24 PM, Hendrik Leppkes h.lepp...@gmail.com wrote: From: Michael Niedermayer michae...@gmx.at This resolves compilation warnings and protects against future breakage as Picture and H264Picture drift apart. Signed-off-by: Hendrik Leppkes h.lepp...@gmail.com ---

[libav-devel] [PATCH] vc1dec: fix a possible unitialized variable warning

2014-03-31 Thread Vittorio Giovara
--- This mimics the case above, fate is happy. Silences a long warning like ~/src/libav/libavcodec/vc1dec.c:1868:28: warning: variable 'px' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] } else if (c_valid) {

Re: [libav-devel] [PATCH 1/2] mpegvideo: operate with pointers to AVFrames instead of whole structs

2014-03-31 Thread Vittorio Giovara
On Mon, Mar 31, 2014 at 8:46 PM, wm4 nfx...@googlemail.com wrote: The only interesting parts are initialization in ff_MPV_common_init and uninitialization in ff_MPV_common_end. ff_mpeg_unref_picture and ff_thread_release_buffer have additional NULL checks for Picture.f, because these

Re: [libav-devel] [PATCH v3 1/2] Renamed vf_settb.c to settb.c.

2014-03-31 Thread Vittorio Giovara
On Mon, Mar 31, 2014 at 8:28 PM, Katerina Barone-Adesi kateri...@gmail.com wrote: --- libavfilter/Makefile | 2 +- libavfilter/settb.c| 161 + libavfilter/vf_settb.c | 161 - 3 files

Re: [libav-devel] [PATCH v3 2/2] Added asettb support - setting timebases for audio

2014-03-31 Thread Timothy Gu
On Mar 31, 2014 11:28 AM, Katerina Barone-Adesi kateri...@gmail.com wrote: Subject: Added asettb support - setting timebases for audio Use this as title: libavfilter: Add asettb filter for setting timebase for audio Ported asettb (including the sr option for audio sample rate), and

Re: [libav-devel] [PATCH v3 2/2] Added asettb support - setting timebases for audio

2014-03-31 Thread Vittorio Giovara
On Mon, Mar 31, 2014 at 8:28 PM, Katerina Barone-Adesi kateri...@gmail.com wrote: Ported asettb (including the sr option for audio sample rate), and documentation from ffmpeg. --- doc/filters.texi | 43 +- libavfilter/Makefile | 1 +

[libav-devel] [PATCH] rdt: check malloc() calls

2014-03-31 Thread Nidhi Makhijani
--- libavformat/rdt.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/rdt.c b/libavformat/rdt.c index a90c168..98ca129 100644 --- a/libavformat/rdt.c +++ b/libavformat/rdt.c @@ -399,6 +399,8 @@ rdt_parse_b64buf (unsigned int *target_len, const char *p) }

Re: [libav-devel] [PATCH] rdt: check malloc() calls

2014-03-31 Thread Timothy Gu
On Mar 31, 2014 9:56 PM, Nidhi Makhijani nidhim...@gmail.com wrote: --- libavformat/rdt.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/rdt.c b/libavformat/rdt.c index a90c168..98ca129 100644 --- a/libavformat/rdt.c +++ b/libavformat/rdt.c @@ -399,6

[libav-devel] [PATCH] nutdec: Check malloc() calls

2014-03-31 Thread Nidhi Makhijani
--- libavformat/nutdec.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c index 6328549..3d92ecb 100644 --- a/libavformat/nutdec.c +++ b/libavformat/nutdec.c @@ -230,7 +230,8 @@ static int decode_main_header(NUTContext *nut)

Re: [libav-devel] [PATCH] vc1dec: fix a possible unitialized variable warning

2014-03-31 Thread Kostya Shishkov
On Tue, Apr 01, 2014 at 01:55:12AM +0200, Vittorio Giovara wrote: --- This mimics the case above, fate is happy. Silences a long warning like ~/src/libav/libavcodec/vc1dec.c:1868:28: warning: variable 'px' is used uninitialized whenever 'if' condition is false

Re: [libav-devel] [PATCH] On2 VP7 decoder

2014-03-31 Thread Kostya Shishkov
On Tue, Apr 01, 2014 at 04:08:02AM +0200, Vittorio Giovara wrote: From: Peter Ross pr...@xvid.org Further performance improvements and security fixes by Vittorio Giovara and Luca Barbato. Signed-off-by: Vittorio Giovara vittorio.giov...@gmail.com Signed-off-by: Luca Barbato