Re: [libav-devel] [PATCH 6/6] http: enable icy metadata by default.

2014-06-04 Thread Vittorio Giovara
On Wed, Jun 4, 2014 at 2:33 PM, Andrew Stone wrote: > It won't hurt servers that don't care about the header, > and those that do will include it by default. > --- > doc/protocols.texi | 2 +- > libavformat/http.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) This is very nice, I wo

Re: [libav-devel] [PATCH 4/6] Add av_metadata_updated to check for any metadata updates on the stream.

2014-06-04 Thread wm4
On Wed, 4 Jun 2014 14:33:03 -0400 Andrew Stone wrote: > av_metadata_updated checks all metadata dictionaries and checks to see > if any option named "metadata" was set inside the context; if it was, > the value is merged into current context metadata. > > Rather than maintaining a list of metad

Re: [libav-devel] [PATCH 3/6] http: export icecast metadata as an option with name "metadata".

2014-06-04 Thread wm4
On Wed, 4 Jun 2014 14:33:02 -0400 Andrew Stone wrote: > --- > libavformat/http.c | 29 + > 1 file changed, 29 insertions(+) > > diff --git a/libavformat/http.c b/libavformat/http.c > index 948930a..f269675 100644 > --- a/libavformat/http.c > +++ b/libavformat/http.c

Re: [libav-devel] [PATCH 1/6] Add av_dict_version() to make it quick to check if a dictionary has changed.

2014-06-04 Thread James Almer
On 04/06/14 3:33 PM, Andrew Stone wrote: > By comparing versions of dictionaries, it's possible to detect if metadata > has changed. > --- > libavutil/dict.c | 8 > libavutil/dict.h | 10 ++ > 2 files changed, 18 insertions(+) Maybe revision is a better name to avoid confusion w

Re: [libav-devel] [PATCH 4/6] Add av_metadata_updated to check for any metadata updates on the stream.

2014-06-04 Thread Vittorio Giovara
On Wed, Jun 4, 2014 at 2:33 PM, Andrew Stone wrote: > av_metadata_updated checks all metadata dictionaries and checks to see > if any option named "metadata" was set inside the context; if it was, > the value is merged into current context metadata. > > Rather than maintaining a list of metadata c

Re: [libav-devel] [PATCH 2/6] AVOption: add support for dictionary types.

2014-06-04 Thread Vittorio Giovara
On Wed, Jun 4, 2014 at 2:33 PM, Andrew Stone wrote: > In order to support metadata being set as an option, it's necessary to be able > to set dictionaries as values. > > Relies on Diego Biurrun's change: > https://lists.libav.org/pipermail/libav-devel/2014-June/060148.html No need for mentioning

Re: [libav-devel] [PATCH 1/6] Add av_dict_version() to make it quick to check if a dictionary has changed.

2014-06-04 Thread Vittorio Giovara
On Wed, Jun 4, 2014 at 2:33 PM, Andrew Stone wrote: > By comparing versions of dictionaries, it's possible to detect if metadata > has changed. > --- > libavutil/dict.c | 8 > libavutil/dict.h | 10 ++ > 2 files changed, 18 insertions(+) dict.h is a public header, adding a func

[libav-devel] [PATCH 4/6] Add av_metadata_updated to check for any metadata updates on the stream.

2014-06-04 Thread Andrew Stone
av_metadata_updated checks all metadata dictionaries and checks to see if any option named "metadata" was set inside the context; if it was, the value is merged into current context metadata. Rather than maintaining a list of metadata changes and presenting them to applications, applications must

[libav-devel] [PATCH 6/6] http: enable icy metadata by default.

2014-06-04 Thread Andrew Stone
It won't hurt servers that don't care about the header, and those that do will include it by default. --- doc/protocols.texi | 2 +- libavformat/http.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 1501dab..c7afd5a 100644 --- a

[libav-devel] [PATCH 2/6] AVOption: add support for dictionary types.

2014-06-04 Thread Andrew Stone
In order to support metadata being set as an option, it's necessary to be able to set dictionaries as values. Relies on Diego Biurrun's change: https://lists.libav.org/pipermail/libav-devel/2014-June/060148.html --- libavutil/opt.c | 54 +++--- lib

[libav-devel] [PATCH 1/6] Add av_dict_version() to make it quick to check if a dictionary has changed.

2014-06-04 Thread Andrew Stone
By comparing versions of dictionaries, it's possible to detect if metadata has changed. --- libavutil/dict.c | 8 libavutil/dict.h | 10 ++ 2 files changed, 18 insertions(+) diff --git a/libavutil/dict.c b/libavutil/dict.c index 7b4dbf2..113afe4 100644 --- a/libavutil/dict.c +++

[libav-devel] [PATCH 5/6] Expose metadata found in onCuePoint events in .flv files.

2014-06-04 Thread Andrew Stone
Currently, only onMetadata is used, but some providers (wrongly) put metadata into onCuePoint events, and it's still nice to be able to use that data. --- libavformat/flvdec.c | 82 +++- 1 file changed, 42 insertions(+), 40 deletions(-) diff --git a

[libav-devel] [PATCH 3/6] http: export icecast metadata as an option with name "metadata".

2014-06-04 Thread Andrew Stone
--- libavformat/http.c | 29 + 1 file changed, 29 insertions(+) diff --git a/libavformat/http.c b/libavformat/http.c index 948930a..f269675 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -78,6 +78,7 @@ typedef struct { int icy_metaint; char *icy_

[libav-devel] [PATCH 0/6] Live Metadata

2014-06-04 Thread Andrew Stone
Round 2 of Live Metadata patches after feedback. Andrew Stone (6): Add av_dict_version() to make it quick to check if a dictionary has changed. AVOption: add support for dictionary types. http: export icecast metadata as an option with name "metadata". Add av_metadata_updated to check

[libav-devel] [PATCH] ogg: check malloc calls

2014-06-04 Thread Nidhi Makhijani
--- libavformat/oggparsespeex.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/oggparsespeex.c b/libavformat/oggparsespeex.c index 6d70e99..927b2cb 100644 --- a/libavformat/oggparsespeex.c +++ b/libavformat/oggparsespeex.c @@ -47,6 +47,8 @@ static int speex_header(AVFormatCo

[libav-devel] [PATCH v5] nut: check memory allocations

2014-06-04 Thread Nidhi Makhijani
--- corrected cosmetic errors libavformat/nutdec.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c index 838c181..7119f95 100644 --- a/libavformat/nutdec.c +++ b/libavformat/nutdec.c @@ -231,6 +231,8 @@ s

Re: [libav-devel] [PATCH] libfdk-aac: Relicense the library wrappers to the ISC license

2014-06-04 Thread Justin Ruggles
On 06/04/2014 12:23 PM, Martin Storsjö wrote: This reduces the number of different licenses used within libav, and is preferrable since it has less ambiguous wordings than the BSD license with respect to the duties of the user of the code. Fraunhofer have now indicated that they're allowed to co

Re: [libav-devel] [PATCH] libfdk-aac: Relicense the library wrappers to the ISC license

2014-06-04 Thread Diego Biurrun
On Wed, Jun 04, 2014 at 07:23:32PM +0300, Martin Storsjö wrote: > This reduces the number of different licenses used within libav, > and is preferrable since it has less ambiguous wordings than > the BSD license with respect to the duties of the user of the code. > > Fraunhofer have now indicated

Re: [libav-devel] [PATCH] libfdk-aac: Relicense the library wrappers to the ISC license

2014-06-04 Thread Luca Barbato
On 04/06/14 18:23, Martin Storsjö wrote: > This reduces the number of different licenses used within libav, > and is preferrable since it has less ambiguous wordings than > the BSD license with respect to the duties of the user of the code. > > Fraunhofer have now indicated that they're allowed to

[libav-devel] [PATCH] libfdk-aac: Relicense the library wrappers to the ISC license

2014-06-04 Thread Martin Storsjö
This reduces the number of different licenses used within libav, and is preferrable since it has less ambiguous wordings than the BSD license with respect to the duties of the user of the code. Fraunhofer have now indicated that they're allowed to contribute code under this license as well. --- Th

Re: [libav-devel] [PATCH 2/4] Exporting icecast metadata as an option with name "metadata"

2014-06-04 Thread Luca Barbato
On 04/06/14 17:36, Andrew Stone wrote: > On Tue, Jun 3, 2014 at 3:12 PM, Luca Barbato wrote: >> This patch should be split in 3: >> >> - icy part. >> >> - dict api variation. >> >> - opt api extension. > > I've split up all my commits in this series into separate ones that > each address smaller

Re: [libav-devel] [PATCH] dict: const correctness for av_dict_get() and av_dict_copy()

2014-06-04 Thread Vittorio Giovara
On Wed, Jun 4, 2014 at 11:29 AM, Andrew Stone wrote: > On Wed, Jun 4, 2014 at 11:17 AM, Vittorio Giovara > wrote: >> On Wed, Jun 4, 2014 at 7:59 AM, Diego Biurrun wrote: >>> --- >>> libavutil/dict.c | 4 ++-- >>> libavutil/dict.h | 6 +++--- >>> 2 files changed, 5 insertions(+), 5 deletions(-)

Re: [libav-devel] [PATCH 2/4] Exporting icecast metadata as an option with name "metadata"

2014-06-04 Thread Andrew Stone
On Tue, Jun 3, 2014 at 3:12 PM, Luca Barbato wrote: > This patch should be split in 3: > > - icy part. > > - dict api variation. > > - opt api extension. I've split up all my commits in this series into separate ones that each address smaller portions (it's refreshing to see a project that puts t

Re: [libav-devel] [PATCH] dict: const correctness for av_dict_get() and av_dict_copy()

2014-06-04 Thread Andrew Stone
On Wed, Jun 4, 2014 at 11:17 AM, Vittorio Giovara wrote: > On Wed, Jun 4, 2014 at 7:59 AM, Diego Biurrun wrote: >> --- >> libavutil/dict.c | 4 ++-- >> libavutil/dict.h | 6 +++--- >> 2 files changed, 5 insertions(+), 5 deletions(-) > > Maybe I am wrong, but I think to remember that adding const

Re: [libav-devel] [PATCH 3/4] avcodec options: adding enum option for colorspace

2014-06-04 Thread Vittorio Giovara
On Wed, Jun 4, 2014 at 8:29 AM, Derek Buitenhuis wrote: > On 6/3/2014 10:52 AM, Marc-Antoine ARNAUD wrote: >> --- >> libavcodec/options_table.h | 12 +++- >> 1 files changed, 11 insertions(+), 1 deletions(-) > > Reasonable as well IMO. > > - Derek Anyone committing this set please reme

Re: [libav-devel] [PATCH] dict: const correctness for av_dict_get() and av_dict_copy()

2014-06-04 Thread Vittorio Giovara
On Wed, Jun 4, 2014 at 7:59 AM, Diego Biurrun wrote: > --- > libavutil/dict.c | 4 ++-- > libavutil/dict.h | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) Maybe I am wrong, but I think to remember that adding const to a public functions is an API break and therefore should be mask

Re: [libav-devel] [PATCH] mpeg2: add sequence display extension information

2014-06-04 Thread Vittorio Giovara
On Wed, Jun 4, 2014 at 4:34 AM, Luca Barbato wrote: > On 04/06/14 10:26, Marc-Antoine ARNAUD wrote: >> From: Marc-Antoine Arnaud >> > > Seems ok. Thank you > Ok, thanks! -- Vittorio ___ libav-devel mailing list libav-devel@libav.org https://lists.liba

[libav-devel] [PATCH v5] nut: check memory allocations

2014-06-04 Thread Nidhi Makhijani
--- corrected return error value and corrected cosmetic mistakes libavformat/nutdec.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c index 838c181..8ef788f 100644 --- a/libavformat/nutdec.c +++ b/libavfo

Re: [libav-devel] [PATCH 3/4] avcodec options: adding enum option for colorspace

2014-06-04 Thread Derek Buitenhuis
On 6/3/2014 10:52 AM, Marc-Antoine ARNAUD wrote: > --- > libavcodec/options_table.h | 12 +++- > 1 files changed, 11 insertions(+), 1 deletions(-) Reasonable as well IMO. - Derek ___ libav-devel mailing list libav-devel@libav.org https://list

Re: [libav-devel] [PATCH 1/4] avcodec options: adding enum option for color_primaries

2014-06-04 Thread Luca Barbato
On 04/06/14 14:27, Derek Buitenhuis wrote: > On 6/3/2014 10:51 AM, Marc-Antoine ARNAUD wrote: >> --- >> libavcodec/options_table.h | 10 +- >> 1 files changed, 9 insertions(+), 1 deletions(-) > > Seems reasonable to me. > +1 ___ libav-devel

Re: [libav-devel] [PATCH 2/4] avcodec options: adding enum option for color_trc

2014-06-04 Thread Derek Buitenhuis
On 6/3/2014 10:53 AM, Marc-Antoine ARNAUD wrote: > --- > libavcodec/options_table.h | 16 +++- > 1 files changed, 15 insertions(+), 1 deletions(-) Also seems reasonable. - Derek ___ libav-devel mailing list libav-devel@libav.org https://l

Re: [libav-devel] [PATCH] dict: const correctness for av_dict_get() and av_dict_copy()

2014-06-04 Thread Luca Barbato
On 04/06/14 13:59, Diego Biurrun wrote: > --- > libavutil/dict.c | 4 ++-- > libavutil/dict.h | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > Should be fine. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/m

Re: [libav-devel] [PATCH 1/4] avcodec options: adding enum option for color_primaries

2014-06-04 Thread Derek Buitenhuis
On 6/3/2014 10:51 AM, Marc-Antoine ARNAUD wrote: > --- > libavcodec/options_table.h | 10 +- > 1 files changed, 9 insertions(+), 1 deletions(-) Seems reasonable to me. - Derek ___ libav-devel mailing list libav-devel@libav.org https://lists.l

Re: [libav-devel] [PATCH 2/4] Exporting icecast metadata as an option with name "metadata"

2014-06-04 Thread Diego Biurrun
On Tue, Jun 03, 2014 at 03:56:09PM -0400, Andrew Stone wrote: > On Tue, Jun 3, 2014 at 3:21 PM, Diego Biurrun wrote: > >> --- a/libavutil/dict.c > >> +++ b/libavutil/dict.c > >> @@ -186,7 +186,7 @@ void av_dict_free(AVDictionary **pm) > >> > >> -void av_dict_copy(AVDictionary **dst, AVDictionary *

[libav-devel] [PATCH] dict: const correctness for av_dict_get() and av_dict_copy()

2014-06-04 Thread Diego Biurrun
--- libavutil/dict.c | 4 ++-- libavutil/dict.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libavutil/dict.c b/libavutil/dict.c index 3b95aba..7b4dbf2 100644 --- a/libavutil/dict.c +++ b/libavutil/dict.c @@ -35,7 +35,7 @@ int av_dict_count(const AVDictionary *m)

Re: [libav-devel] [PATCH v4] nut: check memory allocations

2014-06-04 Thread Diego Biurrun
On Wed, Jun 04, 2014 at 04:56:15PM +0530, Nidhi Makhijani wrote: > --- a/libavformat/nutdec.c > +++ b/libavformat/nutdec.c > @@ -230,7 +230,8 @@ static int decode_main_header(NUTContext *nut) > > GET_V(nut->time_base_count, tmp > 0 && tmp < INT_MAX / > sizeof(AVRational)); > nut->time_

[libav-devel] [PATCH v4] nut: check memory allocations

2014-06-04 Thread Nidhi Makhijani
--- corrected av_freep error, used goto fail. libavformat/nutdec.c | 27 +++ 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c index 838c181..fb1b407 100644 --- a/libavformat/nutdec.c +++ b/libavformat/nutdec.c @@ -

Re: [libav-devel] [PATCH 4/4] avcodec options: adding enum option for color_range

2014-06-04 Thread Diego Biurrun
Please don't top-post. On Wed, Jun 04, 2014 at 08:51:46AM +0200, Marc-Antoine ARNAUD wrote: > > 2014-06-03 16:05 GMT+02:00 Timothy Gu : > > > On Jun 3, 2014 2:53 AM, "Marc-Antoine ARNAUD" < > > arnaud.marcanto...@gmail.com> > > wrote: > > > > > > --- > > > libavcodec/options_table.h |5

Re: [libav-devel] [PATCH] mpeg2: add sequence display extension information

2014-06-04 Thread Luca Barbato
On 04/06/14 10:26, Marc-Antoine ARNAUD wrote: > From: Marc-Antoine Arnaud > Seems ok. Thank you ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 4/4] avcodec options: adding enum option for color_range

2014-06-04 Thread Marc-Antoine ARNAUD
--- libavcodec/options_table.h |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h index 7cf45b8..e580f6d 100644 --- a/libavcodec/options_table.h +++ b/libavcodec/options_table.h @@ -402,7 +402,10 @@ static const AVOp

[libav-devel] [PATCH] mpeg2: add sequence display extension information

2014-06-04 Thread Marc-Antoine ARNAUD
From: Marc-Antoine Arnaud --- libavcodec/mpeg12enc.c | 12 +++ tests/ref/lavf/gxf |4 +- tests/ref/lavf/mxf |2 +- tests/ref/lavf/mxf_d10 |2 +- tests/ref/lavf/ts |