Re: [libav-devel] [PATCH] mxf: Detect Vanc/Vbi SMPTE-436M mxf track

2014-07-23 Thread Kieran Kunhya
On 23 July 2014 15:22, Luca Barbato wrote: > From: Marc-Antoine Arnaud > > Signed-off-by: Luca Barbato Is there any point to this since libav does not support analogue VBI, nor does it support VANC? Kieran ___ libav-devel mailing list libav-devel@lib

[libav-devel] [PATCH] mpeg4videodec: Initialize just idctdsp to enable optimized Xvid IDCT

2014-07-23 Thread Diego Biurrun
--- So here it is, just implementing the more lightweight init call. libavcodec/mpeg4videodec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index 97dbcf6..2269123 100644 --- a/libavcodec/mpeg4videodec.c +++ b/libavco

Re: [libav-devel] [PATCH] http: K&R formatting cosmetics

2014-07-23 Thread Diego Biurrun
On Wed, Jul 23, 2014 at 03:15:12PM +0200, Luca Barbato wrote: > On 23/07/14 12:59, Diego Biurrun wrote: > > On Wed, Jul 23, 2014 at 12:52:37PM +0200, Luca Barbato wrote: > >> On 23/07/14 12:44, Diego Biurrun wrote: > >>> On Tue, Jul 22, 2014 at 08:53:56PM +0200, Luca Barbato wrote: > On 22/07/

Re: [libav-devel] [PATCH 3/5] mpeg4video: Drop unnecessary MMX ifdefs around DCT init call

2014-07-23 Thread Diego Biurrun
On Wed, Jul 23, 2014 at 03:51:10PM +0200, Diego Biurrun wrote: > On Mon, Jul 21, 2014 at 11:58:26PM +0200, Janne Grunau wrote: > > On 2014-07-21 14:21:08 -0700, Diego Biurrun wrote: > > > The DCT init code takes care of MMX and other arch details on its own. > > > > yes and no > > > > > --- a/lib

[libav-devel] [PATCH] fft-test: Pass the right struct members instead of casting

2014-07-23 Thread Diego Biurrun
--- .. and I do wonder why people just have to paper over everything with casts .. libavcodec/fft-test.c | 28 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/libavcodec/fft-test.c b/libavcodec/fft-test.c index 063f8b1..f62cf0d 100644 --- a/libavcodec

Re: [libav-devel] [PATCH 6/8] fft-test: Check memory allocations

2014-07-23 Thread Diego Biurrun
On Mon, Jul 21, 2014 at 09:12:40AM -0700, Diego Biurrun wrote: > --- > libavcodec/fft-test.c | 17 + > 1 file changed, 13 insertions(+), 4 deletions(-) OKed by Anton on IRC. Diego ___ libav-devel mailing list libav-devel@libav.org https

Re: [libav-devel] [PATCH] hevc: Special case square hls_prediction_unit

2014-07-23 Thread Luca Barbato
On 23/07/14 21:43, Anton Khirnov wrote: > > On Mon, 14 Jul 2014 12:55:36 +0200, Luca Barbato wrote: >> Square prediction units are the most common. >> About 0.7% faster on 4k videos. >> --- >> libavcodec/hevc.c | 64 >> +-- >> libavcodec/hevcd

Re: [libav-devel] [PATCH] hevc: Special case square hls_prediction_unit

2014-07-23 Thread Anton Khirnov
On Mon, 14 Jul 2014 12:55:36 +0200, Luca Barbato wrote: > Square prediction units are the most common. > About 0.7% faster on 4k videos. > --- > libavcodec/hevc.c | 64 > +-- > libavcodec/hevcdsp.c | 6 > libavcodec/hevcdsp.h

Re: [libav-devel] [PATCH] extract origin information from material and source track

2014-07-23 Thread Luca Barbato
On 23/07/14 17:14, Marc-Antoine ARNAUD wrote: > Actually I don't have free-royalties samples > I'll try to generate and send one. > > Do you any requirements about video/audio contents ? > Or I can generate a colorwheel on 3 frames with 1kHz of sound ? > it is perfectly fine anything we can

Re: [libav-devel] [PATCH] set top_field_first and use it to write gop header

2014-07-23 Thread Hendrik Leppkes
Am 23.07.2014 17:16 schrieb "Marc-Antoine Arnaud" < arnaud.marcanto...@gmail.com>: > > --- > libavcodec/mpeg12enc.c | 2 +- > libavcodec/mpegvideo_enc.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c > index f87286a..84

[libav-devel] [PATCH] libavformat/icecast: Add Icecast protocol

2014-07-23 Thread epirat07
From: Marvin Scholz Fixes: Grouped fields set by AVOptions Use just s[0] instead of s[0] != '\0' s->headers removed from context free headers and options --- Icecast is basically a convenience wrapper around the HTTP protocol. --- Changelog| 1 + configur

[libav-devel] [PATCH] set top_field_first and use it to write gop header

2014-07-23 Thread Marc-Antoine Arnaud
--- libavcodec/mpeg12enc.c | 2 +- libavcodec/mpegvideo_enc.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index f87286a..84d9508 100644 --- a/libavcodec/mpeg12enc.c +++ b/libavcodec/mpeg12enc.c @@ -424,7 +424,7 @@ void ff

Re: [libav-devel] [PATCH] extract origin information from material and source track

2014-07-23 Thread Marc-Antoine ARNAUD
Actually I don't have free-royalties samples I'll try to generate and send one. Do you any requirements about video/audio contents ? Or I can generate a colorwheel on 3 frames with 1kHz of sound ? 2014-07-23 16:49 GMT+02:00 Luca Barbato : > On 22/07/14 18:08, Marc-Antoine Arnaud wrote: >> --

Re: [libav-devel] [PATCH] fft-test: Pass correct struct members to (i)dct functions

2014-07-23 Thread Luca Barbato
On 23/07/14 16:41, Diego Biurrun wrote: > This fixes a number of incompatible pointer type warnings. > --- > libavcodec/fft-test.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/fft-test.c b/libavcodec/fft-test.c > index 9a7b3cb..02d252d 100644 > --- a/l

Re: [libav-devel] [PATCH] extract origin information from material and source track

2014-07-23 Thread Luca Barbato
On 22/07/14 18:08, Marc-Antoine Arnaud wrote: > --- > libavformat/mxfdec.c | 14 ++ > 1 file changed, 14 insertions(+) > Looks fine to me. Do you have samples I can use to test? lu ___ libav-devel mailing list libav-devel@libav.org https:

[libav-devel] [PATCH] fft-test: Pass correct struct members to (i)dct functions

2014-07-23 Thread Diego Biurrun
This fixes a number of incompatible pointer type warnings. --- libavcodec/fft-test.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/fft-test.c b/libavcodec/fft-test.c index 9a7b3cb..02d252d 100644 --- a/libavcodec/fft-test.c +++ b/libavcodec/fft-test.c @@ -420

[libav-devel] [PATCH] mxf: Detect Vanc/Vbi SMPTE-436M mxf track

2014-07-23 Thread Luca Barbato
From: Marc-Antoine Arnaud Signed-off-by: Luca Barbato --- Last minute review in patch form: FF_ARRAY_ELEMS should make the code simpler, this file has overly long lines might be nicer make at least some of them shorter. libavformat/mxfdec.c | 18 ++ 1 file changed, 18 insert

Re: [libav-devel] [PATCH 1/2] fft: Expose both fixed and float variant of FFTSample in public header

2014-07-23 Thread Luca Barbato
On 23/07/14 00:55, Diego Biurrun wrote: > This allows unconditionally including the public header and cleaning up > some duplicated declarations. It also allows cleanly eliminating > redefined typedefs for fft-related context structs. > --- > > This is the cleanest solution to the redefined typede

Re: [libav-devel] [PATCH] fft-test: Reduce variable scope where sensibly possible

2014-07-23 Thread Katerina Barone-Adesi
LGTM. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/5] mpeg4video: Drop unnecessary MMX ifdefs around DCT init call

2014-07-23 Thread Diego Biurrun
On Mon, Jul 21, 2014 at 11:58:26PM +0200, Janne Grunau wrote: > On 2014-07-21 14:21:08 -0700, Diego Biurrun wrote: > > The DCT init code takes care of MMX and other arch details on its own. > > yes and no > > > --- a/libavcodec/mpeg4videodec.c > > +++ b/libavcodec/mpeg4videodec.c > > @@ -2066,14

Re: [libav-devel] [PATCH 1/2] fft: Expose both fixed and float variant of FFTSample in public header

2014-07-23 Thread Luca Barbato
On 23/07/14 00:55, Diego Biurrun wrote: > This allows unconditionally including the public header and cleaning up > some duplicated declarations. It also allows cleanly eliminating > redefined typedefs for fft-related context structs. > --- > > This is the cleanest solution to the redefined typede

Re: [libav-devel] [PATCH] http: K&R formatting cosmetics

2014-07-23 Thread Luca Barbato
On 23/07/14 12:59, Diego Biurrun wrote: > On Wed, Jul 23, 2014 at 12:52:37PM +0200, Luca Barbato wrote: >> On 23/07/14 12:44, Diego Biurrun wrote: >>> On Tue, Jul 22, 2014 at 08:53:56PM +0200, Luca Barbato wrote: On 22/07/14 20:44, Diego Biurrun wrote: > --- a/libavformat/http.c > +++

Re: [libav-devel] [PATCH] http: K&R formatting cosmetics

2014-07-23 Thread Vittorio Giovara
On Wed, Jul 23, 2014 at 11:59 AM, Diego Biurrun wrote: > On Wed, Jul 23, 2014 at 12:52:37PM +0200, Luca Barbato wrote: >> On 23/07/14 12:44, Diego Biurrun wrote: >> > On Tue, Jul 22, 2014 at 08:53:56PM +0200, Luca Barbato wrote: >> >> On 22/07/14 20:44, Diego Biurrun wrote: >> >>> --- a/libavforma

Re: [libav-devel] [PATCH] mpegenccontext: remove extra dct_unquantize_h261 function pointers

2014-07-23 Thread Diego Biurrun
On Wed, Jul 23, 2014 at 05:27:01PM +0530, Nidhi Makhijani wrote: > --- > libavcodec/mpegvideo.h | 4 > 1 file changed, 4 deletions(-) LGTM, queued. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/l

[libav-devel] [PATCH] mpegenccontext: remove extra dct_unquantize_h261 function pointers

2014-07-23 Thread Nidhi Makhijani
--- libavcodec/mpegvideo.h | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/mpegvideo.h b/libavcodec/mpegvideo.h index 1a7c1b1..5ddb4f3 100644 --- a/libavcodec/mpegvideo.h +++ b/libavcodec/mpegvideo.h @@ -628,10 +628,6 @@ typedef struct MpegEncContext {

Re: [libav-devel] [PATCH 1/2] fft: Expose both fixed and float variant of FFTSample in public header

2014-07-23 Thread Anton Khirnov
On Wed, 23 Jul 2014 13:20:22 +0200, Diego Biurrun wrote: > On Wed, Jul 23, 2014 at 12:56:54PM +0200, Anton Khirnov wrote: > > > > On Tue, 22 Jul 2014 15:55:24 -0700, Diego Biurrun wrote: > > > This allows unconditionally including the public header and cleaning up > > > some duplicated declarat

Re: [libav-devel] [PATCH 1/2] fft: Expose both fixed and float variant of FFTSample in public header

2014-07-23 Thread Diego Biurrun
On Wed, Jul 23, 2014 at 12:56:54PM +0200, Anton Khirnov wrote: > > On Tue, 22 Jul 2014 15:55:24 -0700, Diego Biurrun wrote: > > This allows unconditionally including the public header and cleaning up > > some duplicated declarations. It also allows cleanly eliminating > > redefined typedefs for f

Re: [libav-devel] [PATCH] matroskaenc: Don't set language to empty string, use "und"

2014-07-23 Thread Anton Khirnov
On Tue, 22 Jul 2014 09:38:42 +0200, j...@v2v.cc wrote: > On 07/21/2014 09:35 PM, Anton Khirnov wrote: > > > > On Sun, 20 Jul 2014 15:28:36 +0200, j...@v2v.cc wrote: > >> On 07/20/2014 03:13 PM, Anton Khirnov wrote: > >>> Could you share the sample? > >>> This really sounds like a bug elsewhere th

Re: [libav-devel] [PATCH] http: K&R formatting cosmetics

2014-07-23 Thread Diego Biurrun
On Wed, Jul 23, 2014 at 12:52:37PM +0200, Luca Barbato wrote: > On 23/07/14 12:44, Diego Biurrun wrote: > > On Tue, Jul 22, 2014 at 08:53:56PM +0200, Luca Barbato wrote: > >> On 22/07/14 20:44, Diego Biurrun wrote: > >>> --- a/libavformat/http.c > >>> +++ b/libavformat/http.c > >>> @@ -121,10 +124,

Re: [libav-devel] [PATCH 1/2] fft: Expose both fixed and float variant of FFTSample in public header

2014-07-23 Thread Anton Khirnov
On Tue, 22 Jul 2014 15:55:24 -0700, Diego Biurrun wrote: > This allows unconditionally including the public header and cleaning up > some duplicated declarations. It also allows cleanly eliminating > redefined typedefs for fft-related context structs. > --- > > This is the cleanest solution to t

Re: [libav-devel] [PATCH] http: K&R formatting cosmetics

2014-07-23 Thread Luca Barbato
On 23/07/14 12:44, Diego Biurrun wrote: > On Tue, Jul 22, 2014 at 08:53:56PM +0200, Luca Barbato wrote: >> On 22/07/14 20:44, Diego Biurrun wrote: >>> --- a/libavformat/http.c >>> +++ b/libavformat/http.c >>> @@ -82,37 +84,38 @@ typedef struct { >>> >>> -#define OFFSET(x) offsetof(HTTPContext, x)

Re: [libav-devel] [PATCH] libavformat/icecast: Add Icecast protocol

2014-07-23 Thread Anton Khirnov
On Wed, 23 Jul 2014 09:45:31 +0200, epira...@gmail.com wrote: > From: ePirat > > Fixes: Possible leak in cat_header >Unused #define D AV_OPT_FLAG_DECODING_PARAM >use av_freep() instead of av_free() >make byte compare arrays static const > > --- > > Icecast is basically

Re: [libav-devel] [PATCH] http: K&R formatting cosmetics

2014-07-23 Thread Diego Biurrun
On Tue, Jul 22, 2014 at 08:53:56PM +0200, Luca Barbato wrote: > On 22/07/14 20:44, Diego Biurrun wrote: > > --- a/libavformat/http.c > > +++ b/libavformat/http.c > > @@ -82,37 +84,38 @@ typedef struct { > > > > -#define OFFSET(x) offsetof(HTTPContext, x) > > -#define D AV_OPT_FLAG_DECODING_PARAM

Re: [libav-devel] [PATCH 1/5] avutil: rename AV_PIX_FMT_Y400A to AV_PIX_FMT_GRAY8A

2014-07-23 Thread Kostya Shishkov
On Wed, Jul 23, 2014 at 10:05:28AM +0100, Vittorio Giovara wrote: > On Wed, Jul 23, 2014 at 8:52 AM, Kostya Shishkov > wrote: > > On Wed, Jul 23, 2014 at 08:47:59AM +0100, Vittorio Giovara wrote: > >> On Mon, Jul 21, 2014 at 8:43 PM, Anton Khirnov wrote: > >> > > >> > On Sun, 20 Jul 2014 23:59:17

Re: [libav-devel] [PATCH 1/5] avutil: rename AV_PIX_FMT_Y400A to AV_PIX_FMT_GRAY8A

2014-07-23 Thread Vittorio Giovara
On Wed, Jul 23, 2014 at 8:52 AM, Kostya Shishkov wrote: > On Wed, Jul 23, 2014 at 08:47:59AM +0100, Vittorio Giovara wrote: >> On Mon, Jul 21, 2014 at 8:43 PM, Anton Khirnov wrote: >> > >> > On Sun, 20 Jul 2014 23:59:17 +0100, Vittorio Giovara >> > wrote: >> >> @@ -256,6 +256,7 @@ enum AVPixelF

Re: [libav-devel] [PATCH 1/5] avutil: rename AV_PIX_FMT_Y400A to AV_PIX_FMT_GRAY8A

2014-07-23 Thread Kostya Shishkov
On Wed, Jul 23, 2014 at 08:47:59AM +0100, Vittorio Giovara wrote: > On Mon, Jul 21, 2014 at 8:43 PM, Anton Khirnov wrote: > > > > On Sun, 20 Jul 2014 23:59:17 +0100, Vittorio Giovara > > wrote: > >> @@ -256,6 +256,7 @@ enum AVPixelFormat { > >> #define AV_PIX_FMT_XYZ12 AV_PIX_FMT_NE(XYZ12B

Re: [libav-devel] [PATCH 1/5] avutil: rename AV_PIX_FMT_Y400A to AV_PIX_FMT_GRAY8A

2014-07-23 Thread Vittorio Giovara
On Mon, Jul 21, 2014 at 8:43 PM, Anton Khirnov wrote: > > On Sun, 20 Jul 2014 23:59:17 +0100, Vittorio Giovara > wrote: >> @@ -256,6 +256,7 @@ enum AVPixelFormat { >> #define AV_PIX_FMT_XYZ12 AV_PIX_FMT_NE(XYZ12BE, XYZ12LE) >> #define AV_PIX_FMT_NV20 AV_PIX_FMT_NE(NV20BE, NV20LE) >

[libav-devel] [PATCH] libavformat/icecast: Add Icecast protocol

2014-07-23 Thread epirat07
From: ePirat Fixes: Possible leak in cat_header Unused #define D AV_OPT_FLAG_DECODING_PARAM use av_freep() instead of av_free() make byte compare arrays static const --- Icecast is basically a convenience wrapper around the HTTP protocol. --- Changelog|

Re: [libav-devel] [PATCH 4/5] msmpeg$: Drop inline assembly from ff_msmpeg4_pred_dc

2014-07-23 Thread Vittorio Giovara
On Mon, Jul 21, 2014 at 10:21 PM, Diego Biurrun wrote: > Inline assembly has no place in the general C code and the utility > of this microoptimization is doubtful. > --- this might be ok, a very small benchmark would be appreciated anyway. also typo in commit, it should be m$mpeg4 ;) -- Vittorio

Re: [libav-devel] [PATCH] mpegvideo: Move QUANT_BIAS_SHIFT define to the only place it is used

2014-07-23 Thread Vittorio Giovara
On Tue, Jul 22, 2014 at 7:45 PM, Diego Biurrun wrote: > --- > libavcodec/mpegvideo.h | 2 +- > libavcodec/mpegvideo_enc.c | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > ok -- Vittorio ___ libav-devel mailing list libav-devel@libav.org